)]}'
{"ironic_python_agent/cmd/agent.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7e7116f8c550406db7dc84370c062408c05055ae","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    # Debug option comes from oslo.log, allow overriding it via kernel cmdline"},{"line_number":126,"context_line":"    new_debug \u003d APARAMS.get(\u0027ipa-debug\u0027)"},{"line_number":127,"context_line":"    if new_debug is not None:"},{"line_number":128,"context_line":"        new_debug \u003d new_debug.lower() in (\u00271\u0027, \u0027true\u0027)"},{"line_number":129,"context_line":"        CONF.set_override(\u0027debug\u0027, new_debug, enforce_type\u003dTrue)"},{"line_number":130,"context_line":"    log.setup(CONF, \u0027ironic-python-agent\u0027)"},{"line_number":131,"context_line":"    agent.IronicPythonAgent(CONF.api_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_cc1a5717","line":128,"updated":"2016-02-25 16:31:28.000000000","message":"What about using oslo.utils bool_from_string() here?\n\nhttps://github.com/openstack/oslo.utils/blob/84ecd5cf6b13980af6242084e749103c6739ed63/oslo_utils/strutils.py#L109","commit_id":"e7acc3da7b17c33631f123602263d379e8250a80"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"fb39814d58259a436f02fed204bc05ee05469f49","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    # Debug option comes from oslo.log, allow overriding it via kernel cmdline"},{"line_number":126,"context_line":"    new_debug \u003d APARAMS.get(\u0027ipa-debug\u0027)"},{"line_number":127,"context_line":"    if new_debug is not None:"},{"line_number":128,"context_line":"        new_debug \u003d new_debug.lower() in (\u00271\u0027, \u0027true\u0027)"},{"line_number":129,"context_line":"        CONF.set_override(\u0027debug\u0027, new_debug, enforce_type\u003dTrue)"},{"line_number":130,"context_line":"    log.setup(CONF, \u0027ironic-python-agent\u0027)"},{"line_number":131,"context_line":"    agent.IronicPythonAgent(CONF.api_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c76cf09e","line":128,"in_reply_to":"bae84128_cc1a5717","updated":"2016-02-25 16:47:11.000000000","message":"+1","commit_id":"e7acc3da7b17c33631f123602263d379e8250a80"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"46e59a81bb4475c1d2ceedb083f140a04bfbaac4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    new_debug \u003d APARAMS.get(\u0027ipa-debug\u0027)"},{"line_number":127,"context_line":"    if new_debug is not None:"},{"line_number":128,"context_line":"        new_debug \u003d new_debug.lower() in (\u00271\u0027, \u0027true\u0027)"},{"line_number":129,"context_line":"        CONF.set_override(\u0027debug\u0027, new_debug, enforce_type\u003dTrue)"},{"line_number":130,"context_line":"    log.setup(CONF, \u0027ironic-python-agent\u0027)"},{"line_number":131,"context_line":"    agent.IronicPythonAgent(CONF.api_url,"},{"line_number":132,"context_line":"                            (CONF.advertise_host, CONF.advertise_port),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_9ea87579","line":129,"updated":"2016-02-25 16:04:55.000000000","message":"NIT: I would prefer new_debug was called ipa_debug or similar","commit_id":"e7acc3da7b17c33631f123602263d379e8250a80"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8072577667cee8c571308529a12a60bd368d9668","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    new_debug \u003d APARAMS.get(\u0027ipa-debug\u0027)"},{"line_number":127,"context_line":"    if new_debug is not None:"},{"line_number":128,"context_line":"        new_debug \u003d new_debug.lower() in (\u00271\u0027, \u0027true\u0027)"},{"line_number":129,"context_line":"        CONF.set_override(\u0027debug\u0027, new_debug, enforce_type\u003dTrue)"},{"line_number":130,"context_line":"    log.setup(CONF, \u0027ironic-python-agent\u0027)"},{"line_number":131,"context_line":"    agent.IronicPythonAgent(CONF.api_url,"},{"line_number":132,"context_line":"                            (CONF.advertise_host, CONF.advertise_port),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_7eb0118c","line":129,"in_reply_to":"bae84128_9ea87579","updated":"2016-02-25 16:08:29.000000000","message":"Not sure why we need to enforce_type here, we know it is boolean.","commit_id":"e7acc3da7b17c33631f123602263d379e8250a80"}],"releasenotes/notes/ipa-debug-68c86101b1fdc3d9.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"2208b6a1e03825b51fd4b59b81ef1720877df8d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Debug logging can no be enabled by setting \"ipa-debug\" kernel parameter."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bae84128_c8b891e8","line":3,"updated":"2016-02-25 13:13:40.000000000","message":"Nit: s/no/now/","commit_id":"e364d2b20387b2b9da66ce8ad30ec7daa5401260"}]}