)]}'
{"ironic_python_agent/shell/shutdown.sh":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7dbe4336a5777c3b1b6845553b5b6e33b45df04c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [[ $1 \u003d \u0027-h\u0027 ]]; then"},{"line_number":20,"context_line":"    shutdown --poweroff"},{"line_number":21,"context_line":"elif [[ $1 \u003d \u0027-r\u0027 ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_cc90c4ef","line":18,"updated":"2016-03-15 17:55:51.000000000","message":"echo s \u003e /proc/sysrq-trigger forced a sync; I wonder if it\u0027s prudent to keep this behavior, either by calling the new sync script explicitly (that\u0027s added in the other PR) or adding the \"sync\" command here","commit_id":"087138c25899bc8ce58ba03e2c9c52ca61863596"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a468ba1c4a027e6f392c2f63b4d9cebc5fa0817d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [[ $1 \u003d \u0027-h\u0027 ]]; then"},{"line_number":20,"context_line":"    shutdown --poweroff"},{"line_number":21,"context_line":"elif [[ $1 \u003d \u0027-r\u0027 ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1af94dfe_af13aa5b","line":18,"in_reply_to":"1af94dfe_cc90c4ef","updated":"2016-03-15 17:59:27.000000000","message":"I removed that because since we do a soft shutdown we will change the run level to 0 (halt) or 6 (reboot) and it should umount all filesystems etc... So the sync happens implicitly.\n\nBut that said, I\u0027ve no problems adding a explicit one here. I will update the patch","commit_id":"087138c25899bc8ce58ba03e2c9c52ca61863596"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"03b65a2d0f1e2af01a7bea94c7af1d97d51e7a45","unresolved":false,"context_lines":[{"line_number":20,"context_line":"sync"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if [[ $1 \u003d \u0027-h\u0027 ]]; then"},{"line_number":23,"context_line":"    poweroff -f"},{"line_number":24,"context_line":"elif [[ $1 \u003d \u0027-r\u0027 ]]; then"},{"line_number":25,"context_line":"    reboot -f"},{"line_number":26,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1af94dfe_104dd699","line":23,"updated":"2016-03-18 23:52:00.000000000","message":"-f, --force\n    Force immediate halt, power-off, reboot. Do not contact the init system.\n\nSo, I must ask. What\u0027s the difference here?","commit_id":"2ece9927909fd6839adaae593e6c4a698c1e0923"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d5f83efd493402b1de619f4bc690a2249ef2eb23","unresolved":false,"context_lines":[{"line_number":20,"context_line":"sync"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if [[ $1 \u003d \u0027-h\u0027 ]]; then"},{"line_number":23,"context_line":"    poweroff -f"},{"line_number":24,"context_line":"elif [[ $1 \u003d \u0027-r\u0027 ]]; then"},{"line_number":25,"context_line":"    reboot -f"},{"line_number":26,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa0719c6_51b6088b","line":23,"in_reply_to":"1af94dfe_104dd699","updated":"2016-03-21 09:47:28.000000000","message":"Oh I think you are correct! We shouldn\u0027t force it and go through the init system. Good catch, I will put up a new patch set removing the --force parameter because I believe both sysrq and --force will be a soft ACPI reboot/power off","commit_id":"2ece9927909fd6839adaae593e6c4a698c1e0923"}]}