)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"072b58b2a58af34da24b4ea5f39be35e3fe5d141","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Shell script to create config drive being replaced with python"},{"line_number":10,"context_line":"code in ironic-lib."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I9a0775a147d5bac711b58b4b6cf0135ec68509f7"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1493328"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa7ab95a_1855164f","line":12,"updated":"2016-09-02 10:47:35.000000000","message":"Why do you need this dependency? seems not directly related...","commit_id":"76b19ce1188fa7e7c422fb85c78fa8e176c4df64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"03709e1fdd9708082528647f797c606b10b93b68","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Shell script to create config drive being replaced with python"},{"line_number":10,"context_line":"code in ironic-lib."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I9a0775a147d5bac711b58b4b6cf0135ec68509f7"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1493328"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_8d562dcc","line":12,"in_reply_to":"fa7ab95a_1855164f","updated":"2016-09-13 14:59:25.000000000","message":"Done","commit_id":"76b19ce1188fa7e7c422fb85c78fa8e176c4df64"}],"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d6ccebcd8980b674639e603e22e71be0541a0137","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        # work_on_disk()."},{"line_number":465,"context_line":"        if image_info.get(\u0027image_type\u0027) !\u003d \u0027partition\u0027:"},{"line_number":466,"context_line":"            if configdrive is not None:"},{"line_number":467,"context_line":"                node_uuid \u003d image_info.get(\u0027node_uuid\u0027)"},{"line_number":468,"context_line":"                try:"},{"line_number":469,"context_line":"                    starttime \u003d time.time()"},{"line_number":470,"context_line":"                    disk_utils.create_config_drive_partition(node_uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_fbca2e4e","line":467,"range":{"start_line":467,"start_character":28,"end_line":467,"end_character":55},"updated":"2016-07-25 18:41:14.000000000","message":"So, compatibility wise, this would break if a user updated their IPA image to work on an older Ironic, which does tend to happen with users building IPA images from source.   It _looks_ like it is used just for logging though, perhaps maybe.... a default value if the get fails?\n\n(I feel bad for even suggesting it, but I only suggest it because I\u0027ve seen it happen more than a few times)","commit_id":"ad7eba12f52fba8e8771383f38c09ec78e7a8c76"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f4e80bba2d772b6838f6ae71e1fe15487536026e","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        # work_on_disk()."},{"line_number":465,"context_line":"        if image_info.get(\u0027image_type\u0027) !\u003d \u0027partition\u0027:"},{"line_number":466,"context_line":"            if configdrive is not None:"},{"line_number":467,"context_line":"                node_uuid \u003d image_info.get(\u0027node_uuid\u0027)"},{"line_number":468,"context_line":"                try:"},{"line_number":469,"context_line":"                    starttime \u003d time.time()"},{"line_number":470,"context_line":"                    disk_utils.create_config_drive_partition(node_uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_18e6c343","line":467,"range":{"start_line":467,"start_character":28,"end_line":467,"end_character":55},"in_reply_to":"dada55a8_b5cb50a3","updated":"2016-07-27 11:48:06.000000000","message":"I think unknown should work just fine, or maybe \"local\".","commit_id":"ad7eba12f52fba8e8771383f38c09ec78e7a8c76"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"be502b62863bd5f7370571abeaa459d0c19e3efb","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        # work_on_disk()."},{"line_number":465,"context_line":"        if image_info.get(\u0027image_type\u0027) !\u003d \u0027partition\u0027:"},{"line_number":466,"context_line":"            if configdrive is not None:"},{"line_number":467,"context_line":"                node_uuid \u003d image_info.get(\u0027node_uuid\u0027)"},{"line_number":468,"context_line":"                try:"},{"line_number":469,"context_line":"                    starttime \u003d time.time()"},{"line_number":470,"context_line":"                    disk_utils.create_config_drive_partition(node_uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_b5cb50a3","line":467,"range":{"start_line":467,"start_character":28,"end_line":467,"end_character":55},"in_reply_to":"dada55a8_fbca2e4e","updated":"2016-07-27 05:31:39.000000000","message":"Using node_uuid from image_info is not a new change. It is being there in IPA for a while. Just it being used in this method now.\nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/standby.py#L76\n\nI can check and pass value as \u0027Unknown\u0027 if the node_uuid is missing in image_info. Would that help?","commit_id":"ad7eba12f52fba8e8771383f38c09ec78e7a8c76"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"072b58b2a58af34da24b4ea5f39be35e3fe5d141","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                    totaltime \u003d time.time() - starttime"},{"line_number":477,"context_line":"                    LOG.info(\u0027configdrive copied to {0} in {1} \u0027"},{"line_number":478,"context_line":"                             \u0027seconds.\u0027.format(device, totaltime))"},{"line_number":479,"context_line":"                except processutils.ProcessExecutionError as e:"},{"line_number":480,"context_line":"                    raise errors.ConfigDriveWriteError(device,"},{"line_number":481,"context_line":"                                                       e.exit_code,"},{"line_number":482,"context_line":"                                                       e.stdout,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_3852da67","line":479,"updated":"2016-09-02 10:47:35.000000000","message":"this exception cannot be raised, see the source: https://github.com/openstack/ironic-lib/blob/master/ironic_lib/disk_utils.py#L754-L760","commit_id":"76b19ce1188fa7e7c422fb85c78fa8e176c4df64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"03709e1fdd9708082528647f797c606b10b93b68","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                    totaltime \u003d time.time() - starttime"},{"line_number":477,"context_line":"                    LOG.info(\u0027configdrive copied to {0} in {1} \u0027"},{"line_number":478,"context_line":"                             \u0027seconds.\u0027.format(device, totaltime))"},{"line_number":479,"context_line":"                except processutils.ProcessExecutionError as e:"},{"line_number":480,"context_line":"                    raise errors.ConfigDriveWriteError(device,"},{"line_number":481,"context_line":"                                                       e.exit_code,"},{"line_number":482,"context_line":"                                                       e.stdout,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_0a80438a","line":479,"in_reply_to":"fa7ab95a_3852da67","updated":"2016-09-13 14:59:25.000000000","message":"Done","commit_id":"76b19ce1188fa7e7c422fb85c78fa8e176c4df64"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"072b58b2a58af34da24b4ea5f39be35e3fe5d141","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                                                       e.exit_code,"},{"line_number":482,"context_line":"                                                       e.stdout,"},{"line_number":483,"context_line":"                                                       e.stderr)"},{"line_number":484,"context_line":"                except Exception as e:"},{"line_number":485,"context_line":"                    raise errors.ConfigDriveWriteError(device,"},{"line_number":486,"context_line":"                                                       \u0027unknown\u0027,"},{"line_number":487,"context_line":"                                                       \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_584b1eb1","line":484,"updated":"2016-09-02 10:47:35.000000000","message":"please don\u0027t catch generic exceptions. the only exception we can get is InstanceDeployFailure and we should just let it through","commit_id":"76b19ce1188fa7e7c422fb85c78fa8e176c4df64"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"03709e1fdd9708082528647f797c606b10b93b68","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                                                       e.exit_code,"},{"line_number":482,"context_line":"                                                       e.stdout,"},{"line_number":483,"context_line":"                                                       e.stderr)"},{"line_number":484,"context_line":"                except Exception as e:"},{"line_number":485,"context_line":"                    raise errors.ConfigDriveWriteError(device,"},{"line_number":486,"context_line":"                                                       \u0027unknown\u0027,"},{"line_number":487,"context_line":"                                                       \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_ea74ffcf","line":484,"in_reply_to":"fa7ab95a_584b1eb1","updated":"2016-09-13 14:59:25.000000000","message":"Done","commit_id":"76b19ce1188fa7e7c422fb85c78fa8e176c4df64"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d04a43b72bc5496118658f34de0423b5a2df8aec","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                                                         configdrive)"},{"line_number":479,"context_line":"                totaltime \u003d time.time() - starttime"},{"line_number":480,"context_line":"                LOG.info(\u0027configdrive copied to {0} in {1} \u0027"},{"line_number":481,"context_line":"                         \u0027seconds.\u0027.format(device, totaltime))"},{"line_number":482,"context_line":"        msg \u003d \u0027image ({}) written to device {} \u0027"},{"line_number":483,"context_line":"        result_msg \u003d _message_format(msg, image_info, device,"},{"line_number":484,"context_line":"                                     self.partition_uuids)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6895a0_0109bc95","line":481,"updated":"2016-10-21 08:56:04.000000000","message":"this duplicates already existing logging in ironic-lib","commit_id":"3665306dfbf9afadf06fc669b75a74e1c08b6b01"}]}
