)]}'
{"id":"openstack%2Fironic-python-agent~296539","triplet_id":"openstack%2Fironic-python-agent~master~If3a44cb813b565ea47dea310f59f28479fc326f4","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1561137","hashtags":[],"change_id":"If3a44cb813b565ea47dea310f59f28479fc326f4","subject":"Get root device hints from the node object","status":"ABANDONED","created":"2016-03-23 15:28:18.000000000","updated":"2016-05-23 11:11:55.000000000","total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"52fa4a53eacccdd3d1c6e617f666d1ff6c8905a6","_number":296539,"virtual_id_number":296539,"owner":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-05-18 18:28:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-28 10:31:02.000000000","updated_by":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"reviewer":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"state":"REVIEWER"},{"updated":"2016-05-17 10:30:53.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-05-17 16:29:26.000000000","updated_by":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"reviewer":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"state":"REVIEWER"},{"updated":"2016-05-17 19:07:07.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2016-05-18 13:51:59.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2016-05-18 18:28:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"83765a8603913c989c333b6024fa2becf432c056","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-23 15:28:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e0846b7dce71c5c26808318f86d0e48c41d3e25","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-23 15:28:40.000000000","message":"Patch Set 1: Workflow-1\n\nTesting at the moment","accounts_in_message":[],"_revision_number":1},{"id":"db5676174c89af3e2d9878d547de73da9f4528d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-23 17:12:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/1/check/gate-ironic-python-agent-docs/bc5b3eb//doc/build/html/ : SUCCESS in 3m 59s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/1/check/gate-ironic-python-agent-pep8/ebdb68a/ : SUCCESS in 3m 02s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/1/check/gate-ironic-python-agent-python27/f9259bf/ : SUCCESS in 4m 57s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/1/check/gate-ironic-python-agent-python34/45fc423/ : SUCCESS in 3m 58s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/996c7bc/ : SUCCESS in 46m 24s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/b3bc88d/ : SUCCESS in 1h 01m 26s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/1/check/gate-ironic-inspector-dsvm-ipa-src-nv/e5da20a/ : SUCCESS in 37m 12s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/39/296539/1/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/359d775/ : SUCCESS in 35m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f12ee654e4156c513d77f3699edd0c6b6b17ee1d","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-23 17:54:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ec226a2eb12e33ccd89064bafca9fa6641834db5","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-03-23 17:54:46.000000000","message":"Patch Set 2: Code-Review-2\n\nTested locally, works. Waiting for RFE approval","accounts_in_message":[],"_revision_number":2},{"id":"72182b5f191a39c67887a621b10abd6e8e78989f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-23 19:40:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/2/check/gate-ironic-python-agent-docs/ecf77b0//doc/build/html/ : SUCCESS in 2m 35s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/2/check/gate-ironic-python-agent-pep8/801e25a/ : SUCCESS in 15m 35s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/2/check/gate-ironic-python-agent-python27/d2da35e/ : SUCCESS in 2m 20s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/2/check/gate-ironic-python-agent-python34/dfcaf01/ : SUCCESS in 2m 39s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/2/check/gate-tempest-dsvm-ironic-agent_ssh-src/c5e5210/ : SUCCESS in 25m 31s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/2/check/gate-tempest-dsvm-ironic-pxe_ipa-src/1816cd4/ : SUCCESS in 48m 44s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/2/check/gate-ironic-inspector-dsvm-ipa-src-nv/4fbb819/ : SUCCESS in 47m 12s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv http://logs.openstack.org/39/296539/2/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-nv/e613190/ : SUCCESS in 27m 06s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9a5ddaea6601ac76508fa5582cf10451c374e4e8","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-03-30 18:50:36.000000000","message":"Patch Set 2: Code-Review+1\n\nHonestly, I like this fix even if we don\u0027t enhance syntax for root_device_hints. If you want to file a separate RFE bug just targeted to this feature, I\u0027ll approve it and +2 here. It solves a major problem for deployers who need to support this but are running with their own DHCP setup -- this is directly related to the work I\u0027ve been doing around manage_ramdisk_boot in Ironic.","accounts_in_message":[],"_revision_number":2},{"id":"de722d251b6747ff4bac549f628ed00bebb797fe","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-03-31 12:41:50.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nI\u0027d also fix it independently of the RFE. One concern inline.","accounts_in_message":[],"_revision_number":2},{"id":"ed0f690cae86b12c2e588b828421b4bd7fe6af98","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-04-12 07:23:46.000000000","message":"Patch Set 2: -Code-Review Workflow-1\n\n(1 comment)\n\nAlright, fair enough. Thanks for the comment","accounts_in_message":[],"_revision_number":2},{"id":"33afc62ac4568b4a4ccf73b1f443af624797358c","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-04-12 08:03:17.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e6f5e8a15088629b9e87045987f1fd74ca7ee591","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-12 08:42:41.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/3/check/gate-ironic-python-agent-docs/faa22a9//doc/build/html/ : SUCCESS in 1m 35s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/3/check/gate-ironic-python-agent-pep8/e14a36a/ : SUCCESS in 1m 28s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/3/check/gate-ironic-python-agent-python27/064cb0e/ : SUCCESS in 2m 11s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/3/check/gate-ironic-python-agent-python34/4603a74/ : SUCCESS in 3m 25s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/3/check/gate-tempest-dsvm-ironic-agent_ssh-src/8ee26ac/ : FAILURE in 20m 54s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/3/check/gate-tempest-dsvm-ironic-pxe_ipa-src/5076867/ : SUCCESS in 36m 29s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/3/check/gate-ironic-inspector-dsvm-ipa-src-nv/b62acd1/ : SUCCESS in 38m 19s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/3/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/5e49823/ : SUCCESS in 35m 13s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"7b7768bdf31797db955aebdb5e15a737592c3dfc","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-04-12 10:07:55.000000000","message":"Patch Set 3:\n\nrecheck\n\n2016-04-12 08:24:37.490 | \u001b[91mE\u001b[0m\u001b[91m: Failed to fetch http://httpredir.debian.org/debian/pool/main/g/gdisk/gdisk_0.8.10-2_amd64.deb  Error reading from server. Remote end closed connection [IP: 128.31.0.66 80]","accounts_in_message":[],"_revision_number":3},{"id":"092a4303c3a23682aee6785849e0a0536a684ada","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-12 10:52:08.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/3/check/gate-ironic-python-agent-docs/66b8e7e//doc/build/html/ : SUCCESS in 3m 47s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/3/check/gate-ironic-python-agent-pep8/7fc7ccd/ : SUCCESS in 4m 08s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/3/check/gate-ironic-python-agent-python27/fa181c7/ : SUCCESS in 4m 02s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/3/check/gate-ironic-python-agent-python34/3367723/ : SUCCESS in 4m 23s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/3/check/gate-tempest-dsvm-ironic-agent_ssh-src/7840625/ : SUCCESS in 41m 51s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/3/check/gate-tempest-dsvm-ironic-pxe_ipa-src/d922f77/ : SUCCESS in 38m 37s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/3/check/gate-ironic-inspector-dsvm-ipa-src-nv/2a8dc99/ : SUCCESS in 40m 50s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/3/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/8427838/ : SUCCESS in 35m 24s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"70bbee71a58bca17d5c940d2a7ce1e4e491a4331","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-04-18 13:00:01.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"50c83b36842afabfca8afaa89dd152cb3f319e83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-18 18:57:26.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/4/check/gate-ironic-python-agent-docs/a08bd48//doc/build/html/ : SUCCESS in 1m 30s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/4/check/gate-ironic-python-agent-pep8/21452e4/ : SUCCESS in 1m 51s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/4/check/gate-ironic-python-agent-python27/97fc368/ : SUCCESS in 2m 00s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/4/check/gate-ironic-python-agent-python34/cb4294e/ : SUCCESS in 2m 35s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/4/check/gate-tempest-dsvm-ironic-agent_ssh-src/e975603/ : SUCCESS in 35m 28s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/4/check/gate-tempest-dsvm-ironic-pxe_ipa-src/36f70e3/ : FAILURE in 40m 19s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/4/check/gate-ironic-inspector-dsvm-ipa-src-nv/294178f/ : SUCCESS in 34m 01s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/4/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/bbaf051/ : FAILURE in 45m 37s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"5e7b5a802f29436c855efdfda513142f556663e9","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-04-22 08:59:58.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"bd53713da3ef0abfa5eb206d3ea93a23ca4f805c","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2016-04-23 22:26:20.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)\n\nNeed to add back line to retrieve root device hint from kernel command line parameters if node object is not passed.","accounts_in_message":[],"_revision_number":4},{"id":"54df68f0e75ac07f4dfe7fc859f46af7b649cdd4","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-04-28 10:31:02.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)\n\nLucas thanks for the patch.\nIronic bash ramdisk is deprecated. And going to be removed in Newton release right? \nhttps://review.openstack.org/#/q/topic:bp/deprecate-bash-ramdisk","accounts_in_message":[],"_revision_number":4},{"id":"1d4261a52502a6d683b2a58a84e7320922efcabe","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-04-28 12:39:59.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"07d710d2b6768fc3621d69a0a9867180d68a2082","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-04-28 12:40:48.000000000","message":"Patch Set 4:\n\nrecheck\n\nNot sure what folks mean. This patch still LGTM modulo wrong comment (please fix at your convenience).","accounts_in_message":[],"_revision_number":4},{"id":"6e3a3c592e90ce2a335fce416fb0c5d4c297ff56","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2016-04-28 12:49:44.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)\n\nThank you Dmitry, Vasyl.\nSince this fix will not support the bash ramdisk, it is fine. The comment needs to be corrected.","accounts_in_message":[],"_revision_number":4},{"id":"2a4a82f36119d883bb59c6a0d67b9d55428e6986","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2016-04-28 12:57:23.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f799ddca8d9e3b338e91e5e7349ac5158915560b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-28 13:24:56.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/4/check/gate-ironic-python-agent-docs/dd29af4//doc/build/html/ : SUCCESS in 2m 30s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/4/check/gate-ironic-python-agent-pep8/ad4ee5c/ : SUCCESS in 2m 01s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/4/check/gate-ironic-python-agent-python27/425b145/ : SUCCESS in 2m 16s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/4/check/gate-ironic-python-agent-python34/f846a36/ : SUCCESS in 1m 52s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/4/check/gate-tempest-dsvm-ironic-agent_ssh-src/7b636ab/ : SUCCESS in 37m 48s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/4/check/gate-tempest-dsvm-ironic-pxe_ipa-src/746a9f1/ : SUCCESS in 36m 56s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/4/check/gate-ironic-inspector-dsvm-ipa-src-nv/6b8334e/ : SUCCESS in 42m 43s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/4/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/1804638/ : SUCCESS in 36m 10s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"e53b7df581a41848e98bc00ed669deea384b2870","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-17 10:25:18.000000000","message":"Patch Set 4: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"adcdd69e0a2f042ada67aaafc524c6fe9c3f6528","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-05-17 10:26:15.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"08d39c061c438d2ccaf0556f430afbbf9f6d29b9","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-17 10:28:56.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"dd65e3ce3cc137c440cc62edbc7f0850729f0716","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-05-17 10:30:53.000000000","message":"Patch Set 5: Code-Review-1\n\nAs discussed above, we don\u0027t need a fallback to kernel arguments, as node always contains the root device hints","accounts_in_message":[],"_revision_number":5},{"id":"398ce096e35eb32608752785e6f09dd856e58889","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-17 10:38:25.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"897e49f4a800b99f4bf593d69d9b456bafb41557","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-05-17 10:39:59.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f6bbfbc9fa1fe213721e5a94862695c50be41acb","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-17 10:40:22.000000000","message":"Patch Set 5:\n\nRight, the problem is when the node is not passed as parameter to the get_os_install_device() (3rd party hardware managers will not pass it unless they update the code), e.g https://github.com/rackerlabs/onmetal-ironic-hardware-manager/blob/master/onmetal_ironic_hardware_manager/__init__.py#L167\n\nIn that situation, if root device hints were used before via the kernel cmdline the get_os_install_device() may return a different device after this update if we do not fallback to the kernel cmdline.","accounts_in_message":[],"_revision_number":5},{"id":"cce98b3b595313fcfda0411dd1c1cc0bb3cba0bf","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-05-17 10:41:29.000000000","message":"Patch Set 5:\n\nI get it, but then lets avoid breaking them completely. E.g. passing the node via self. It\u0027s strange to avoid only one way of breakages.","accounts_in_message":[],"_revision_number":5},{"id":"f6565b6e86b99e087bb3a5d4dc1968230722f17a","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-17 10:41:33.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1baa6158e09276f58b5958df022ca94cd754f519","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-17 10:43:31.000000000","message":"Patch Set 5: Workflow-1\n\nYeah, we have to rethink it :-/ there are potential breakages on both sides","accounts_in_message":[],"_revision_number":5},{"id":"9f72868320baa4bce9bc3ad8ed71828e2d0e7e44","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-17 12:23:13.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/5/check/gate-ironic-python-agent-docs/4b1856d//doc/build/html/ : SUCCESS in 3m 44s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/5/check/gate-ironic-python-agent-pep8/c20a2f2/ : SUCCESS in 2m 22s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/5/check/gate-ironic-python-agent-python27/3b60626/ : SUCCESS in 2m 28s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/5/check/gate-ironic-python-agent-python34/7e9bd0e/ : SUCCESS in 2m 51s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/5/check/gate-tempest-dsvm-ironic-agent_ssh-src/d3a3eaf/ : SUCCESS in 34m 25s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/5/check/gate-tempest-dsvm-ironic-pxe_ipa-src/27fdd2f/ : SUCCESS in 49m 07s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/5/check/gate-ironic-inspector-dsvm-ipa-src-nv/ab0a09d/ : SUCCESS in 41m 22s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/5/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/dd34922/ : SUCCESS in 41m 06s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"c8703590d3da5d1f44fcd1dd5137bfe8eb3f2369","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-17 15:05:57.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"72e906c2236269efe975a1579a26a7d1b5da8e1f","author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"date":"2016-05-17 16:29:26.000000000","message":"Patch Set 6: Code-Review+1\n\n(3 comments)\n\nLooks fine to me; I\u0027ve left a few trivial nits on the commit message which you could fix if you do another version.","accounts_in_message":[],"_revision_number":6},{"id":"32ba2a2a2a36a99496dce388d0a6223ac31cbd90","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-05-17 19:07:07.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"23f3deade10fc64909f03ed5c18f655d0028138d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-17 19:19:52.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/6/check/gate-ironic-python-agent-docs/a3f8a06//doc/build/html/ : SUCCESS in 3m 29s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/6/check/gate-ironic-python-agent-pep8/7f87777/ : SUCCESS in 2m 17s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/6/check/gate-ironic-python-agent-python27/7edeac5/ : SUCCESS in 5m 26s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/6/check/gate-ironic-python-agent-python34/e7155d8/ : SUCCESS in 2m 51s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/6/check/gate-tempest-dsvm-ironic-agent_ssh-src/74b3743/ : SUCCESS in 47m 06s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/6/check/gate-tempest-dsvm-ironic-pxe_ipa-src/a5d7199/ : SUCCESS in 52m 26s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/6/check/gate-ironic-inspector-dsvm-ipa-src-nv/85b859a/ : SUCCESS in 34m 59s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/6/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/4f0e675/ : SUCCESS in 33m 24s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"e2e6cf899af312bfa27e6e07797f33d543037304","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-18 10:18:46.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"d4e55db988fb30ebfc1e41cfdceac8feab58ab3d","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-18 10:19:48.000000000","message":"Patch Set 7:\n\n@Miles, \n\nThanks for the comment on the previous patch, this new patch-set was just a rebase on top of the dependent one. I will fix the nits if I happen to need to submit a new patch-set for this.","accounts_in_message":[],"_revision_number":7},{"id":"eb945f4002f32da11f583059c72eef8f3d3c8a26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-18 11:38:25.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/7/check/gate-ironic-python-agent-docs/8fadb45//doc/build/html/ : SUCCESS in 2m 29s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/7/check/gate-ironic-python-agent-pep8/d054210/ : SUCCESS in 4m 23s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/7/check/gate-ironic-python-agent-python27/d863f6d/ : SUCCESS in 2m 51s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/7/check/gate-ironic-python-agent-python34/a5777de/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/7/check/gate-tempest-dsvm-ironic-agent_ssh-src/3574ce5/ : SUCCESS in 38m 47s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/7/check/gate-tempest-dsvm-ironic-pxe_ipa-src/3bf85df/ : SUCCESS in 51m 12s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/7/check/gate-ironic-inspector-dsvm-ipa-src-nv/99b7708/ : SUCCESS in 42m 58s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/7/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/d56bc5d/ : SUCCESS in 41m 48s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"9738c06a7cf900961eef25d5e0926486104f3b13","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2016-05-18 13:51:59.000000000","message":"Patch Set 7: Code-Review+1\n\nThank you. LGTM.","accounts_in_message":[],"_revision_number":7},{"id":"67d4eab560e48268dd3320f15031db4edf847040","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-18 15:23:47.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"17e095c7413d2f842df56b096d24eedecf441cb1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-18 18:28:15.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/39/296539/8/check/gate-ironic-python-agent-docs/2e1a234//doc/build/html/ : SUCCESS in 4m 11s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/39/296539/8/check/gate-ironic-python-agent-pep8/aa72caf/ : SUCCESS in 2m 33s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/39/296539/8/check/gate-ironic-python-agent-python27/a86e913/ : SUCCESS in 2m 43s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/39/296539/8/check/gate-ironic-python-agent-python34/cd51eca/ : SUCCESS in 1m 54s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/39/296539/8/check/gate-tempest-dsvm-ironic-agent_ssh-src/38bc966/ : SUCCESS in 32m 10s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/39/296539/8/check/gate-tempest-dsvm-ironic-pxe_ipa-src/b3465c0/ : SUCCESS in 55m 55s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/39/296539/8/check/gate-ironic-inspector-dsvm-ipa-src-nv/473b646/ : SUCCESS in 38m 30s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/39/296539/8/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/6e2bbf2/ : SUCCESS in 34m 10s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"4d69b156713bcf963ec6ed327f38ab120148b548","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-23 11:11:55.000000000","message":"Abandoned\n\nSuperseded by https://review.openstack.org/#/c/318538/","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"9cc806d426bf452bd870981cac509d3583664a95","revisions":{"3e9b1ee1fcf19c09fb20f0fdb7d91e8eeefe3a11":{"kind":"REWORK","_number":1,"created":"2016-03-23 15:28:18.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/1"}}},"commit":{"parents":[{"commit":"858c6437778fad0d94652d1032d22689c99b4890","subject":"Merge \"Add disk_label support for partition images\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/858c6437778fad0d94652d1032d22689c99b4890"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-23 15:20:06.000000000","tz":0},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-23 15:25:44.000000000","tz":0},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop to rely\non the kernel command line for passing the root device hints. Since IPA\ndoes have access to a representation of the Ironic\u0027s node object (the\nlookup method at the startup of IPA will populate it) we can use it and\nget the root device hints directly from the node\u0027s properties, if\npresent.\n\nThis patch is extending the get_os_install_device() method from the\nHardwareManager class to accept a node representation as a parameter.\nThis parameter has a default value of None because making this parameter\nmandatory may break other out-of-tree hardware managers that inherit\nfrom that class.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk, since we\u0027ve used the same [i]PXE template for both\nramdisks we needed a generic way to pass the hints for both deploy\nramdisks.\n\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3e9b1ee1fcf19c09fb20f0fdb7d91e8eeefe3a11"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3e9b1ee1fcf19c09fb20f0fdb7d91e8eeefe3a11"}]},"branch":"refs/heads/master"},"d9cc33ac0d68769fc5feb51254b06299d9a7847a":{"kind":"REWORK","_number":2,"created":"2016-03-23 17:54:06.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/2"}}},"commit":{"parents":[{"commit":"858c6437778fad0d94652d1032d22689c99b4890","subject":"Merge \"Add disk_label support for partition images\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/858c6437778fad0d94652d1032d22689c99b4890"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-23 15:20:06.000000000","tz":0},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-23 17:53:50.000000000","tz":0},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop to rely\non the kernel command line for passing the root device hints. Since IPA\ndoes have access to a representation of the Ironic\u0027s node object (the\nlookup method at the startup of IPA will populate it) we can use it and\nget the root device hints directly from the node\u0027s properties, if\npresent.\n\nThis patch is extending the get_os_install_device() method from the\nHardwareManager class to accept a node representation as a parameter.\nThis parameter has a default value of None because making this parameter\nmandatory may break other out-of-tree hardware managers that inherit\nfrom that class.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk, since we\u0027ve used the same [i]PXE template for both\nramdisks we needed a generic way to pass the hints for both deploy\nramdisks.\n\nPartial-Bug: #1561137\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d9cc33ac0d68769fc5feb51254b06299d9a7847a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d9cc33ac0d68769fc5feb51254b06299d9a7847a"}]},"branch":"refs/heads/master"},"ac8d77b301ab2b3563963bcdef5dfa34c5d3315b":{"kind":"REWORK","_number":3,"created":"2016-04-12 08:03:17.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/3"}}},"commit":{"parents":[{"commit":"819b79da87c01b2af49ef4d1871065ce7aa768ee","subject":"Merge \"Add script to install missing tinyipa dependencies\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/819b79da87c01b2af49ef4d1871065ce7aa768ee"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-23 15:20:06.000000000","tz":0},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-04-12 08:03:05.000000000","tz":60},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop to rely\non the kernel command line for passing the root device hints. Since IPA\ndoes have access to a representation of the Ironic\u0027s node object (the\nlookup method at the startup of IPA will populate it) we can use it and\nget the root device hints directly from the node\u0027s properties, if\npresent.\n\nThis patch is extending the get_os_install_device() method from the\nHardwareManager class to accept a node representation as a parameter.\nThis parameter has a default value of None because making this parameter\nmandatory may break other out-of-tree hardware managers that inherit\nfrom that class.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk, since we\u0027ve used the same [i]PXE template for both\nramdisks we needed a generic way to pass the hints for both deploy\nramdisks.\n\nPartial-Bug: #1561137\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ac8d77b301ab2b3563963bcdef5dfa34c5d3315b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ac8d77b301ab2b3563963bcdef5dfa34c5d3315b"}]},"branch":"refs/heads/master"},"b6fbd36a531fd146e977aa6d894fcf23efcb756d":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2016-04-18 13:00:01.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/4"}}},"commit":{"parents":[{"commit":"8ce07c88bef9826a00187b555a9406b4febe276d","subject":"Merge \"Install qemu-image from backports repo\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8ce07c88bef9826a00187b555a9406b4febe276d"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-23 15:20:06.000000000","tz":0},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-04-18 13:00:01.000000000","tz":0},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop to rely\non the kernel command line for passing the root device hints. Since IPA\ndoes have access to a representation of the Ironic\u0027s node object (the\nlookup method at the startup of IPA will populate it) we can use it and\nget the root device hints directly from the node\u0027s properties, if\npresent.\n\nThis patch is extending the get_os_install_device() method from the\nHardwareManager class to accept a node representation as a parameter.\nThis parameter has a default value of None because making this parameter\nmandatory may break other out-of-tree hardware managers that inherit\nfrom that class.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk, since we\u0027ve used the same [i]PXE template for both\nramdisks we needed a generic way to pass the hints for both deploy\nramdisks.\n\nPartial-Bug: #1561137\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b6fbd36a531fd146e977aa6d894fcf23efcb756d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b6fbd36a531fd146e977aa6d894fcf23efcb756d"}]},"branch":"refs/heads/master"},"eba11721c696e4b83cf9d5021cf5b74e04c18c67":{"kind":"REWORK","_number":5,"created":"2016-05-17 10:28:56.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/5"}}},"commit":{"parents":[{"commit":"83ab1bc7dd475d72cc9a98c92257f6f4398bee29","subject":"Make sure tinyipa du takes into account branch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/83ab1bc7dd475d72cc9a98c92257f6f4398bee29"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-03-23 15:20:06.000000000","tz":0},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-05-17 10:26:48.000000000","tz":60},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop to rely\non the kernel command line for passing the root device hints. Since IPA\ndoes have access to a representation of the Ironic\u0027s node object (the\nlookup method at the startup of IPA will populate it) we can use it and\nget the root device hints directly from the node\u0027s properties, if\npresent.\n\nThis patch is extending the get_os_install_device() method from the\nHardwareManager class to accept a node representation as a parameter.\nThis parameter has a default value of None because making this parameter\nmandatory may break other out-of-tree hardware managers that inherit\nfrom that class.\n\nThe kernel command line still available as a fallback, but the patch\nis printing a warning message about deprecation and it\u0027s expected that\nout-of-tree hardware managers update their code accordingly soon.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk, since we\u0027ve used the same [i]PXE template for both\nramdisks we needed a generic way to pass the hints for both deploy\nramdisks.\n\nPartial-Bug: #1561137\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/eba11721c696e4b83cf9d5021cf5b74e04c18c67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/eba11721c696e4b83cf9d5021cf5b74e04c18c67"}]},"branch":"refs/heads/master"},"2ebb81f851441f02f597c1c13eea8ae3fbf21341":{"kind":"REWORK","_number":6,"created":"2016-05-17 15:05:57.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/6"}}},"commit":{"parents":[{"commit":"7c2998596e295aad4372d413195e7098461a655e","subject":"Cache node object inside hw manager instances","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7c2998596e295aad4372d413195e7098461a655e"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-05-17 15:02:23.000000000","tz":60},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-05-17 15:02:23.000000000","tz":60},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop to rely\non the kernel command line for passing the root device hints. Since the\nhardware managers already have a representation of the Ironic\u0027s node\nobject we should use it and get the root device hints directly from its\nproperties.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk, since we\u0027ve used the same [i]PXE template for both\nramdisks we needed a generic way to pass the hints for both deploy\nramdisks.\n\nPartial-Bug: #1561137\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2ebb81f851441f02f597c1c13eea8ae3fbf21341"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2ebb81f851441f02f597c1c13eea8ae3fbf21341"}]},"branch":"refs/heads/master"},"ef1fd208a8fe03cf9979b627adbabdb1eab2ef92":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2016-05-18 10:18:46.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/7"}}},"commit":{"parents":[{"commit":"3bd06c90594761bf3bd8077fa79adf7569205794","subject":"Cache node object inside hw manager instances","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/3bd06c90594761bf3bd8077fa79adf7569205794"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-05-17 15:02:23.000000000","tz":60},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-05-18 10:17:24.000000000","tz":60},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop to rely\non the kernel command line for passing the root device hints. Since the\nhardware managers already have a representation of the Ironic\u0027s node\nobject we should use it and get the root device hints directly from its\nproperties.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk, since we\u0027ve used the same [i]PXE template for both\nramdisks we needed a generic way to pass the hints for both deploy\nramdisks.\n\nPartial-Bug: #1561137\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ef1fd208a8fe03cf9979b627adbabdb1eab2ef92"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ef1fd208a8fe03cf9979b627adbabdb1eab2ef92"}]},"branch":"refs/heads/master"},"9cc806d426bf452bd870981cac509d3583664a95":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":8,"created":"2016-05-18 15:23:47.000000000","uploader":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"ref":"refs/changes/39/296539/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/39/296539/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/39/296539/8"}}},"commit":{"parents":[{"commit":"2fe15dc9e80d48f9ffdd31a09cbfb8d4e0fecb0b","subject":"Cache node object inside hw manager instances","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2fe15dc9e80d48f9ffdd31a09cbfb8d4e0fecb0b"}]}],"author":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-05-17 15:02:23.000000000","tz":60},"committer":{"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","date":"2016-05-18 15:22:28.000000000","tz":60},"subject":"Get root device hints from the node object","message":"Get root device hints from the node object\n\nIn order to support a more complex syntax for root device hints (e.g\noperators: greater than, less than, in, etc...) we need to stop relying\non the kernel command line for passing the root device hints. Since the\nhardware managers already have a representation of the ironic node\u0027s\nobject we should use it and get the root device hints directly from its\nproperties.\n\nFor context, the kernel command line was used in the past because of the\nold bash ramdisk. Since we used the same [i]PXE template for both ramdisks\nwe needed a generic way to pass the hints for both deploy ramdisks.\n\nPartial-Bug: #1561137\nChange-Id: If3a44cb813b565ea47dea310f59f28479fc326f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9cc806d426bf452bd870981cac509d3583664a95"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9cc806d426bf452bd870981cac509d3583664a95"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}