)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"62dce61bddc934a0f801596d6d14f8aa2d2fdc82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vmud213 \u003cvinay50muddu@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-24 11:12:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for all interfaces to be up before node lookup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During node look up sometimes IPA sends hardware inventory information before"},{"line_number":10,"context_line":"the interfaces are up, resulting in empty interfaces information being sent"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9abb7d3a_72baf2c1","line":7,"updated":"2016-05-30 16:56:43.000000000","message":"it waits for at least one interface, right?, not All.","commit_id":"d2b09602aae166f3a0986d0b65204c44ebf4a223"}],"ironic_python_agent/agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72399ec217a2fce86e31448d73034e822901f520","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            # lookup will fail due to unknown MAC."},{"line_number":296,"context_line":"            uuid \u003d inspector.inspect()"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            WAIT_INTERVEL \u003d 60"},{"line_number":299,"context_line":"            RETRY_INTERVEL \u003d 5"},{"line_number":300,"context_line":"            wait_till \u003d time.time() + WAIT_INTERVEL"},{"line_number":301,"context_line":"            while time.time() \u003c wait_till:"},{"line_number":302,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_d37bc626","line":299,"range":{"start_line":298,"start_character":0,"end_line":299,"end_character":30},"updated":"2016-04-14 09:42:18.000000000","message":"please move this to the top level (with an appropriate name).\n\nalso typos in \"interval\". e.g. WAIT_INTERVAL should probably be NETWORK_WAIT_TIMEOUT","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"94232a0faa4533328a5f89822aa3b3ba364fb8bf","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            # lookup will fail due to unknown MAC."},{"line_number":296,"context_line":"            uuid \u003d inspector.inspect()"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            WAIT_INTERVEL \u003d 60"},{"line_number":299,"context_line":"            RETRY_INTERVEL \u003d 5"},{"line_number":300,"context_line":"            wait_till \u003d time.time() + WAIT_INTERVEL"},{"line_number":301,"context_line":"            while time.time() \u003c wait_till:"},{"line_number":302,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_965adc28","line":299,"range":{"start_line":298,"start_character":0,"end_line":299,"end_character":30},"in_reply_to":"5a18252c_d37bc626","updated":"2016-04-15 09:55:17.000000000","message":"Done","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72399ec217a2fce86e31448d73034e822901f520","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            while time.time() \u003c wait_till:"},{"line_number":302,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":303,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":304,"context_line":"                if not interfaces:"},{"line_number":305,"context_line":"                    LOG.debug(\u0027Could not retrieve interfaces.Retrying...\u0027)"},{"line_number":306,"context_line":"                    time.sleep(RETRY_INTERVEL)"},{"line_number":307,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_738ab21c","line":304,"range":{"start_line":304,"start_character":16,"end_line":304,"end_character":34},"updated":"2016-04-14 09:42:18.000000000","message":"Lets even check for MAC\u0027s\n\n if not any(iface.mac_addr for iface in interfaces):","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"94232a0faa4533328a5f89822aa3b3ba364fb8bf","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            while time.time() \u003c wait_till:"},{"line_number":302,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":303,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":304,"context_line":"                if not interfaces:"},{"line_number":305,"context_line":"                    LOG.debug(\u0027Could not retrieve interfaces.Retrying...\u0027)"},{"line_number":306,"context_line":"                    time.sleep(RETRY_INTERVEL)"},{"line_number":307,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_3626f616","line":304,"range":{"start_line":304,"start_character":16,"end_line":304,"end_character":34},"in_reply_to":"5a18252c_738ab21c","updated":"2016-04-15 09:55:17.000000000","message":"Done","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72399ec217a2fce86e31448d73034e822901f520","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":303,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":304,"context_line":"                if not interfaces:"},{"line_number":305,"context_line":"                    LOG.debug(\u0027Could not retrieve interfaces.Retrying...\u0027)"},{"line_number":306,"context_line":"                    time.sleep(RETRY_INTERVEL)"},{"line_number":307,"context_line":"                else:"},{"line_number":308,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_13ed3eef","line":305,"updated":"2016-04-14 09:42:18.000000000","message":"missing space before the dot","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"94232a0faa4533328a5f89822aa3b3ba364fb8bf","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":303,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":304,"context_line":"                if not interfaces:"},{"line_number":305,"context_line":"                    LOG.debug(\u0027Could not retrieve interfaces.Retrying...\u0027)"},{"line_number":306,"context_line":"                    time.sleep(RETRY_INTERVEL)"},{"line_number":307,"context_line":"                else:"},{"line_number":308,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_561d72bc","line":305,"in_reply_to":"5a18252c_13ed3eef","updated":"2016-04-15 09:55:17.000000000","message":"Done","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"72399ec217a2fce86e31448d73034e822901f520","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    time.sleep(RETRY_INTERVEL)"},{"line_number":307,"context_line":"                else:"},{"line_number":308,"context_line":"                    break"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":311,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("},{"line_number":312,"context_line":"                    \u0027list_hardware_info\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_f3fa4274","line":309,"updated":"2016-04-14 09:42:18.000000000","message":"lets have a warning if timeout was reached","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"94232a0faa4533328a5f89822aa3b3ba364fb8bf","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                    time.sleep(RETRY_INTERVEL)"},{"line_number":307,"context_line":"                else:"},{"line_number":308,"context_line":"                    break"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":311,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("},{"line_number":312,"context_line":"                    \u0027list_hardware_info\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f682bec7","line":309,"in_reply_to":"5a18252c_f3fa4274","updated":"2016-04-15 09:55:17.000000000","message":"Done","commit_id":"4437971749e897740073ed0bd88102d6ef9324c4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17107c7ffb3c58d1b29a92471fbcd9d2beec424e","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def run(self):"},{"line_number":285,"context_line":"        \"\"\"Run the Ironic Python Agent.\"\"\""},{"line_number":286,"context_line":"        NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":287,"context_line":"        RETRY_INTERVAL \u003d 5"},{"line_number":288,"context_line":"        found_ifces \u003d False"},{"line_number":289,"context_line":"        # Get the UUID so we can heartbeat to Ironic. Raises LookupNodeError"},{"line_number":290,"context_line":"        # if there is an issue (uncaught, restart agent)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_b4913555","line":287,"range":{"start_line":286,"start_character":0,"end_line":287,"end_character":26},"updated":"2016-04-22 08:50:12.000000000","message":"please move these constants to the beginning of the file","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7f593a01fcf0710ca5b2f05c5ad850d950f3a557","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def run(self):"},{"line_number":285,"context_line":"        \"\"\"Run the Ironic Python Agent.\"\"\""},{"line_number":286,"context_line":"        NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":287,"context_line":"        RETRY_INTERVAL \u003d 5"},{"line_number":288,"context_line":"        found_ifces \u003d False"},{"line_number":289,"context_line":"        # Get the UUID so we can heartbeat to Ironic. Raises LookupNodeError"},{"line_number":290,"context_line":"        # if there is an issue (uncaught, restart agent)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_efa47309","line":287,"range":{"start_line":286,"start_character":0,"end_line":287,"end_character":26},"in_reply_to":"1a122d0e_b4913555","updated":"2016-04-22 10:31:54.000000000","message":"Done","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17107c7ffb3c58d1b29a92471fbcd9d2beec424e","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        \"\"\"Run the Ironic Python Agent.\"\"\""},{"line_number":286,"context_line":"        NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":287,"context_line":"        RETRY_INTERVAL \u003d 5"},{"line_number":288,"context_line":"        found_ifces \u003d False"},{"line_number":289,"context_line":"        # Get the UUID so we can heartbeat to Ironic. Raises LookupNodeError"},{"line_number":290,"context_line":"        # if there is an issue (uncaught, restart agent)"},{"line_number":291,"context_line":"        self.started_at \u003d _time()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_94aa3984","line":288,"range":{"start_line":288,"start_character":14,"end_line":288,"end_character":19},"updated":"2016-04-22 08:50:12.000000000","message":"typo: ifaces is a more common shortening","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7f593a01fcf0710ca5b2f05c5ad850d950f3a557","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        \"\"\"Run the Ironic Python Agent.\"\"\""},{"line_number":286,"context_line":"        NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":287,"context_line":"        RETRY_INTERVAL \u003d 5"},{"line_number":288,"context_line":"        found_ifces \u003d False"},{"line_number":289,"context_line":"        # Get the UUID so we can heartbeat to Ironic. Raises LookupNodeError"},{"line_number":290,"context_line":"        # if there is an issue (uncaught, restart agent)"},{"line_number":291,"context_line":"        self.started_at \u003d _time()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2faf8be4","line":288,"range":{"start_line":288,"start_character":14,"end_line":288,"end_character":19},"in_reply_to":"1a122d0e_94aa3984","updated":"2016-04-22 10:31:54.000000000","message":"Done","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17107c7ffb3c58d1b29a92471fbcd9d2beec424e","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":304,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":305,"context_line":"                if not any(ifc.mac_address for ifc in interfaces):"},{"line_number":306,"context_line":"                    LOG.debug(\u0027Could not retrieve interfaces. Retrying ...\u0027)"},{"line_number":307,"context_line":"                    time.sleep(RETRY_INTERVAL)"},{"line_number":308,"context_line":"                else:"},{"line_number":309,"context_line":"                    found_ifces \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_948199fe","line":306,"range":{"start_line":306,"start_character":31,"end_line":306,"end_character":60},"updated":"2016-04-22 08:50:12.000000000","message":"better: \"Network is not up, no valid interfaces found, retrying\"","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7f593a01fcf0710ca5b2f05c5ad850d950f3a557","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":304,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":305,"context_line":"                if not any(ifc.mac_address for ifc in interfaces):"},{"line_number":306,"context_line":"                    LOG.debug(\u0027Could not retrieve interfaces. Retrying ...\u0027)"},{"line_number":307,"context_line":"                    time.sleep(RETRY_INTERVAL)"},{"line_number":308,"context_line":"                else:"},{"line_number":309,"context_line":"                    found_ifces \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_4fb6473e","line":306,"range":{"start_line":306,"start_character":31,"end_line":306,"end_character":60},"in_reply_to":"1a122d0e_948199fe","updated":"2016-04-22 10:31:54.000000000","message":"Done","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17107c7ffb3c58d1b29a92471fbcd9d2beec424e","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                    break"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            if not found_ifces:"},{"line_number":313,"context_line":"                LOG.warning(\"Could not retrieve network \""},{"line_number":314,"context_line":"                            \"interfaces information.\")"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":317,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_749ddd58","line":314,"range":{"start_line":313,"start_character":29,"end_line":314,"end_character":52},"updated":"2016-04-22 08:50:12.000000000","message":"better: \"No valid network interfaces found, lookup will probably fail\"","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7f593a01fcf0710ca5b2f05c5ad850d950f3a557","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                    break"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            if not found_ifces:"},{"line_number":313,"context_line":"                LOG.warning(\"Could not retrieve network \""},{"line_number":314,"context_line":"                            \"interfaces information.\")"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":317,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_af81db4f","line":314,"range":{"start_line":313,"start_character":29,"end_line":314,"end_character":52},"in_reply_to":"1a122d0e_749ddd58","updated":"2016-04-22 10:31:54.000000000","message":"Done","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36acdd4565e995a564e2eb520194d218fbc8f560","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":305,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":306,"context_line":"                if not any(ifc.mac_address for ifc in interfaces):"},{"line_number":307,"context_line":"                    LOG.debug(\u0027Network is not up yet.\u0027"},{"line_number":308,"context_line":"                              \u0027No valid interfaces found, retrying ...\u0027)"},{"line_number":309,"context_line":"                    time.sleep(RETRY_INTERVAL)"},{"line_number":310,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_7fc90325","line":307,"updated":"2016-05-04 09:45:45.000000000","message":"nit: space after dot","commit_id":"b99385095bdd2d9ba89f50dfd566f0a75ad0c280"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"36acdd4565e995a564e2eb520194d218fbc8f560","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    found_ifaces \u003d True"},{"line_number":312,"context_line":"                    break"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"            if not found_ifaces:"},{"line_number":315,"context_line":"                LOG.warning(\"No valid network interfaces found. \""},{"line_number":316,"context_line":"                            \"Node lookup will probably fail.\")"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_dfe777aa","line":314,"range":{"start_line":314,"start_character":12,"end_line":314,"end_character":32},"updated":"2016-05-04 09:45:45.000000000","message":"this could be replaces with while..else.. syntax","commit_id":"b99385095bdd2d9ba89f50dfd566f0a75ad0c280"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a70fd0f08fc8b8cf8ec3290c69f3ab3bc443410e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":42,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_d14432b8","line":41,"updated":"2016-05-10 20:00:55.000000000","message":"Is this in seconds? Would be good to add a comment or something so that it is clear what the units are.","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"49284fd7be59679db64a017d3ca2f34046fa97a4","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":42,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_98e1a201","line":41,"in_reply_to":"dab17558_d14432b8","updated":"2016-05-13 07:00:57.000000000","message":"Done","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a70fd0f08fc8b8cf8ec3290c69f3ab3bc443410e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":42,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _time():"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_91af4a29","line":42,"updated":"2016-05-10 20:00:55.000000000","message":"this is seconds too, right?\n\nI\u0027d have preferred s/RETRY/NETWORK_WAIT_RETRY/","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"49284fd7be59679db64a017d3ca2f34046fa97a4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":42,"context_line":"RETRY_INTERVAL \u003d 5"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _time():"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_f8e6ee14","line":42,"in_reply_to":"dab17558_91af4a29","updated":"2016-05-13 07:00:57.000000000","message":"Done","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a70fd0f08fc8b8cf8ec3290c69f3ab3bc443410e","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def run(self):"},{"line_number":288,"context_line":"        \"\"\"Run the Ironic Python Agent.\"\"\""},{"line_number":289,"context_line":"        found_ifaces \u003d False"},{"line_number":290,"context_line":"        # Get the UUID so we can heartbeat to Ironic. Raises LookupNodeError"},{"line_number":291,"context_line":"        # if there is an issue (uncaught, restart agent)"},{"line_number":292,"context_line":"        self.started_at \u003d _time()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_5147a276","line":289,"updated":"2016-05-10 20:00:55.000000000","message":"it would have been better to put this closer to line 302, since this has nothing to do with the lines before that.\n\nAlso, given that line 292 seems to be tracking the time for this, it also makes sense not to put any code before that line.","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"49284fd7be59679db64a017d3ca2f34046fa97a4","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def run(self):"},{"line_number":288,"context_line":"        \"\"\"Run the Ironic Python Agent.\"\"\""},{"line_number":289,"context_line":"        found_ifaces \u003d False"},{"line_number":290,"context_line":"        # Get the UUID so we can heartbeat to Ironic. Raises LookupNodeError"},{"line_number":291,"context_line":"        # if there is an issue (uncaught, restart agent)"},{"line_number":292,"context_line":"        self.started_at \u003d _time()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_78b95eec","line":289,"in_reply_to":"dab17558_5147a276","updated":"2016-05-13 07:00:57.000000000","message":"Done","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b4556cb8626d55b700d391b7bde0015a1845f0a4","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":305,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":306,"context_line":"                if not any(ifc.mac_address for ifc in interfaces):"},{"line_number":307,"context_line":"                    LOG.debug(\u0027Network is not up yet.\u0027"},{"line_number":308,"context_line":"                              \u0027No valid interfaces found, retrying ...\u0027)"},{"line_number":309,"context_line":"                    time.sleep(RETRY_INTERVAL)"},{"line_number":310,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_734e5cc2","line":307,"updated":"2016-05-04 11:05:05.000000000","message":"nit: space after the dot","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"49284fd7be59679db64a017d3ca2f34046fa97a4","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                interfaces \u003d hardware.dispatch_to_managers("},{"line_number":305,"context_line":"                    \u0027list_network_interfaces\u0027)"},{"line_number":306,"context_line":"                if not any(ifc.mac_address for ifc in interfaces):"},{"line_number":307,"context_line":"                    LOG.debug(\u0027Network is not up yet.\u0027"},{"line_number":308,"context_line":"                              \u0027No valid interfaces found, retrying ...\u0027)"},{"line_number":309,"context_line":"                    time.sleep(RETRY_INTERVAL)"},{"line_number":310,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_532a7d7f","line":307,"in_reply_to":"1a122d0e_734e5cc2","updated":"2016-05-13 07:00:57.000000000","message":"Done","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b4556cb8626d55b700d391b7bde0015a1845f0a4","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    found_ifaces \u003d True"},{"line_number":312,"context_line":"                    break"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"            if not found_ifaces:"},{"line_number":315,"context_line":"                LOG.warning(\"No valid network interfaces found. \""},{"line_number":316,"context_line":"                            \"Node lookup will probably fail.\")"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_f3d0accb","line":314,"range":{"start_line":314,"start_character":11,"end_line":314,"end_character":32},"updated":"2016-05-04 11:05:05.000000000","message":"nit: while..else.. construction would avoid an unnecessary variable.","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"49284fd7be59679db64a017d3ca2f34046fa97a4","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                    found_ifaces \u003d True"},{"line_number":312,"context_line":"                    break"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"            if not found_ifaces:"},{"line_number":315,"context_line":"                LOG.warning(\"No valid network interfaces found. \""},{"line_number":316,"context_line":"                            \"Node lookup will probably fail.\")"},{"line_number":317,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_13e2b59f","line":314,"range":{"start_line":314,"start_character":11,"end_line":314,"end_character":32},"in_reply_to":"1a122d0e_f3d0accb","updated":"2016-05-13 07:00:57.000000000","message":"Done","commit_id":"d0d811a9971e4f1001efcaf04958e5b370e116bc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4be7d98cf3a644d3f20581dc46255d134ff62788","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            else:"},{"line_number":317,"context_line":"                LOG.warning(\"No valid network interfaces found. \""},{"line_number":318,"context_line":"                            \"Node lookup will probably fail.\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":321,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_f2ba4b22","line":318,"updated":"2016-05-31 08:14:03.000000000","message":"I\u0027d prefer this to be split to a separate function","commit_id":"d20c2f3109593e29f23c5ab63479cbb32a1b4fd6"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"debc8f7c5489b47571ce1aabeca4caa9f396eedf","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            else:"},{"line_number":317,"context_line":"                LOG.warning(\"No valid network interfaces found. \""},{"line_number":318,"context_line":"                            \"Node lookup will probably fail.\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":321,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_390f5c89","line":318,"in_reply_to":"9abb7d3a_90710479","updated":"2016-06-01 07:00:42.000000000","message":"Done","commit_id":"d20c2f3109593e29f23c5ab63479cbb32a1b4fd6"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"debc8f7c5489b47571ce1aabeca4caa9f396eedf","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            else:"},{"line_number":317,"context_line":"                LOG.warning(\"No valid network interfaces found. \""},{"line_number":318,"context_line":"                            \"Node lookup will probably fail.\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":321,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_590a207a","line":318,"in_reply_to":"9abb7d3a_f2ba4b22","updated":"2016-06-01 07:00:42.000000000","message":"Done","commit_id":"d20c2f3109593e29f23c5ab63479cbb32a1b4fd6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1c94bfdebd834f61d61a43656a21810ff5ed5d51","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"            else:"},{"line_number":317,"context_line":"                LOG.warning(\"No valid network interfaces found. \""},{"line_number":318,"context_line":"                            \"Node lookup will probably fail.\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"            content \u003d self.api_client.lookup_node("},{"line_number":321,"context_line":"                hardware_info\u003dhardware.dispatch_to_managers("}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_90710479","line":318,"in_reply_to":"9abb7d3a_f2ba4b22","updated":"2016-05-31 23:45:42.000000000","message":"I agree.","commit_id":"d20c2f3109593e29f23c5ab63479cbb32a1b4fd6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3a11aca60f83421444671821a1671deb63f6887e","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Time(in seconds) to wait for any of the interfaces to be up"},{"line_number":42,"context_line":"# before lookup of the node is attempted"},{"line_number":43,"context_line":"NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Time(in seconds) to wait before reattempt"},{"line_number":46,"context_line":"NETWORK_WAIT_RETRY \u003d 5"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_364c8e9d","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":25},"updated":"2016-06-08 08:37:03.000000000","message":"Would it be useful if this is a config parameter?","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"cc151a958ce0b4ad1971853785b97917ddc4b906","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Time(in seconds) to wait for any of the interfaces to be up"},{"line_number":42,"context_line":"# before lookup of the node is attempted"},{"line_number":43,"context_line":"NETWORK_WAIT_TIMEOUT \u003d 60"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Time(in seconds) to wait before reattempt"},{"line_number":46,"context_line":"NETWORK_WAIT_RETRY \u003d 5"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_d1c194e5","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":25},"in_reply_to":"7aa08908_364c8e9d","updated":"2016-06-09 04:58:59.000000000","message":"IMO it is not required. The reason being \n1. we are not particular about the timeout value and i see no reason why we change it.\n2. Node lookup is reattempted with some delay after this timeout(60 seconds), with exception being thrown on the conductor(which is required). IPA again polls at 5 seconds timeout to see if at least one interface is up until 60 seconds is elapsed. So even if this value is reduced to 30 seconds it still has no impact except that we see exception messages more frequently.","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"}],"ironic_python_agent/tests/unit/test_agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17107c7ffb3c58d1b29a92471fbcd9d2beec424e","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":173,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":174,"context_line":"    @mock.patch.object(hardware, \u0027dispatch_to_managers\u0027)"},{"line_number":175,"context_line":"    @mock.patch(\u0027wsgiref.simple_server.make_server\u0027, autospec\u003dTrue)"},{"line_number":176,"context_line":"    def test_run(self, wsgi_server_cls, mocked_dispatch,"},{"line_number":177,"context_line":"                 mock_sleep, mock_time):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_74b4bdd0","line":174,"updated":"2016-04-22 08:50:12.000000000","message":"autospec\u003dTrue","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7f593a01fcf0710ca5b2f05c5ad850d950f3a557","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":173,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":174,"context_line":"    @mock.patch.object(hardware, \u0027dispatch_to_managers\u0027)"},{"line_number":175,"context_line":"    @mock.patch(\u0027wsgiref.simple_server.make_server\u0027, autospec\u003dTrue)"},{"line_number":176,"context_line":"    def test_run(self, wsgi_server_cls, mocked_dispatch,"},{"line_number":177,"context_line":"                 mock_sleep, mock_time):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ef7bd379","line":174,"in_reply_to":"1a122d0e_74b4bdd0","updated":"2016-04-22 10:31:54.000000000","message":"Done","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"17107c7ffb3c58d1b29a92471fbcd9d2beec424e","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":208,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":209,"context_line":"    @mock.patch.object(hardware, \u0027dispatch_to_managers\u0027)"},{"line_number":210,"context_line":"    @mock.patch(\u0027wsgiref.simple_server.make_server\u0027, autospec\u003dTrue)"},{"line_number":211,"context_line":"    def test_run_wait(self, wsgi_server_cls, mocked_dispatch,"},{"line_number":212,"context_line":"                      mock_sleep, mock_time):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_34e1a5d1","line":209,"updated":"2016-04-22 08:50:12.000000000","message":"autospec\u003dTrue","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7f593a01fcf0710ca5b2f05c5ad850d950f3a557","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":208,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":209,"context_line":"    @mock.patch.object(hardware, \u0027dispatch_to_managers\u0027)"},{"line_number":210,"context_line":"    @mock.patch(\u0027wsgiref.simple_server.make_server\u0027, autospec\u003dTrue)"},{"line_number":211,"context_line":"    def test_run_wait(self, wsgi_server_cls, mocked_dispatch,"},{"line_number":212,"context_line":"                      mock_sleep, mock_time):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_0f93afa4","line":209,"in_reply_to":"1a122d0e_34e1a5d1","updated":"2016-04-22 10:31:54.000000000","message":"Done","commit_id":"14f4811da928d04b137721acdd81e81a5d98b1eb"},{"author":{"_account_id":7933,"name":"Philippe Godin","email":"godp1301@gmail.com","username":"godp1301"},"change_message_id":"fa6797a20f9b6979067d229ee53f4cbca3be4b61","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            make_test_instance([extension.Extension(\u0027fake\u0027, None,"},{"line_number":149,"context_line":"                                                    FakeExtension,"},{"line_number":150,"context_line":"                                                    FakeExtension())])"},{"line_number":151,"context_line":"        self.sample_nw_ifce \u003d hardware.NetworkInterface("},{"line_number":152,"context_line":"            \"eth9\", \"AA:BB:CC:DD:EE:FF\", \"1.2.3.4\", True)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def assertEqualEncoded(self, a, b):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_ce269015","line":151,"range":{"start_line":151,"start_character":23,"end_line":151,"end_character":27},"updated":"2016-04-25 18:00:32.000000000","message":"nit: s/ifce/iface","commit_id":"b99385095bdd2d9ba89f50dfd566f0a75ad0c280"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab2a61867bb888f85f975c5588dca2b7df769673","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            make_test_instance([extension.Extension(\u0027fake\u0027, None,"},{"line_number":149,"context_line":"                                                    FakeExtension,"},{"line_number":150,"context_line":"                                                    FakeExtension())])"},{"line_number":151,"context_line":"        self.sample_nw_ifce \u003d hardware.NetworkInterface("},{"line_number":152,"context_line":"            \"eth9\", \"AA:BB:CC:DD:EE:FF\", \"1.2.3.4\", True)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def assertEqualEncoded(self, a, b):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_5f3c51bf","line":151,"range":{"start_line":151,"start_character":23,"end_line":151,"end_character":27},"in_reply_to":"1a122d0e_ce269015","updated":"2016-05-02 08:25:20.000000000","message":"Thanks. Will update if it happens to submit another patch.","commit_id":"b99385095bdd2d9ba89f50dfd566f0a75ad0c280"},{"author":{"_account_id":7933,"name":"Philippe Godin","email":"godp1301@gmail.com","username":"godp1301"},"change_message_id":"fa6797a20f9b6979067d229ee53f4cbca3be4b61","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        wsgi_server \u003d wsgi_server_cls.return_value"},{"line_number":180,"context_line":"        wsgi_server.start.side_effect \u003d KeyboardInterrupt()"},{"line_number":181,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":182,"context_line":"        mocked_dispatch.side_effect \u003d [[self.sample_nw_ifce], {}]"},{"line_number":183,"context_line":"        expected_dispatch_calls \u003d [mock.call(\"list_network_interfaces\"),"},{"line_number":184,"context_line":"                                   mock.call(\"list_hardware_info\")]"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_ae2194fe","line":182,"range":{"start_line":182,"start_character":55,"end_line":182,"end_character":59},"updated":"2016-04-25 18:00:32.000000000","message":"ditto","commit_id":"b99385095bdd2d9ba89f50dfd566f0a75ad0c280"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"ab2a61867bb888f85f975c5588dca2b7df769673","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        wsgi_server \u003d wsgi_server_cls.return_value"},{"line_number":180,"context_line":"        wsgi_server.start.side_effect \u003d KeyboardInterrupt()"},{"line_number":181,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":182,"context_line":"        mocked_dispatch.side_effect \u003d [[self.sample_nw_ifce], {}]"},{"line_number":183,"context_line":"        expected_dispatch_calls \u003d [mock.call(\"list_network_interfaces\"),"},{"line_number":184,"context_line":"                                   mock.call(\"list_hardware_info\")]"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_9f46e94d","line":182,"range":{"start_line":182,"start_character":55,"end_line":182,"end_character":59},"in_reply_to":"1a122d0e_ae2194fe","updated":"2016-05-02 08:25:20.000000000","message":"Thanks. Will update if it happens to submit another patch.","commit_id":"b99385095bdd2d9ba89f50dfd566f0a75ad0c280"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"053f31d4664e3d28f212ecb8fac67e4bbdd90c52","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":255,"context_line":"        self.agent._wait_for_interface()"},{"line_number":256,"context_line":"        mocked_dispatch.assert_called_once_with(\u0027list_network_interfaces\u0027)"},{"line_number":257,"context_line":"        mocked_sleep.assert_not_called()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":260,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_42188975","line":257,"updated":"2016-06-13 13:44:30.000000000","message":"this only exists in python 3.5 :-(\n\nyou can do something like self.assertFalse(mocked_sleep.called)","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"c595b27f90e123a03557747c0d8b0f850a01d623","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":255,"context_line":"        self.agent._wait_for_interface()"},{"line_number":256,"context_line":"        mocked_dispatch.assert_called_once_with(\u0027list_network_interfaces\u0027)"},{"line_number":257,"context_line":"        mocked_sleep.assert_not_called()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":260,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_aa091133","line":257,"in_reply_to":"7aa08908_1d423cae","updated":"2016-06-14 12:47:09.000000000","message":"Thanks Sam Betts for reviewing it. Yes this passed py27 and py34. However i am making the choice of changing it just to ensure the changes are in consistent with other code parts.","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"03f6daa2499b9a6880534becb56010d11a3ab563","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":255,"context_line":"        self.agent._wait_for_interface()"},{"line_number":256,"context_line":"        mocked_dispatch.assert_called_once_with(\u0027list_network_interfaces\u0027)"},{"line_number":257,"context_line":"        mocked_sleep.assert_not_called()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":260,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_aa3c712f","line":257,"in_reply_to":"7aa08908_42188975","updated":"2016-06-14 12:41:41.000000000","message":"Done","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"56f6ef9c054680a94c1a589dd050f86174f9d0cd","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":255,"context_line":"        self.agent._wait_for_interface()"},{"line_number":256,"context_line":"        mocked_dispatch.assert_called_once_with(\u0027list_network_interfaces\u0027)"},{"line_number":257,"context_line":"        mocked_sleep.assert_not_called()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":260,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_1d423cae","line":257,"in_reply_to":"7aa08908_42188975","updated":"2016-06-14 10:24:03.000000000","message":"The mock library we use for py27 testing has backported versions all the functions from the py3 mock library, so as long as mock is up to date in the gate then this function exists:\n\nhttps://github.com/testing-cabal/mock\nhttps://mock.readthedocs.io/en/latest/index.html\n\nautospec on the mock.patch.object decorator should cause mock to throw an AttributeError if we try to call something that doesn\u0027t exist on mock itself or the mocked object/function. So I\u0027d assume this is working in the gate as the UTs have passed without error on py27 :)","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e890adf9d7507f85fd9758548f2cacc8dcf5f42e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":255,"context_line":"        self.agent._wait_for_interface()"},{"line_number":256,"context_line":"        mocked_dispatch.assert_called_once_with(\u0027list_network_interfaces\u0027)"},{"line_number":257,"context_line":"        mocked_sleep.assert_not_called()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":260,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_6f10c559","line":257,"in_reply_to":"7aa08908_83e4f00c","updated":"2016-06-14 18:03:32.000000000","message":"For anyone still listening to this discussion :), Sam clarified things for me. In test-requirements, we have mock \u003e\u003d 2.0. This is a mock library that contains a rolling backport of the standard library mock code, compatible with py 2.6+, py 3.3+. So yes, it is OK to use .assert_not_called(). Sorry Vinay (but I learned something!)","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"99aefcd202ce3263c6ea5787d46c77f4511515e4","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        mock_time.return_value \u003d 10"},{"line_number":255,"context_line":"        self.agent._wait_for_interface()"},{"line_number":256,"context_line":"        mocked_dispatch.assert_called_once_with(\u0027list_network_interfaces\u0027)"},{"line_number":257,"context_line":"        mocked_sleep.assert_not_called()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @mock.patch.object(time, \u0027time\u0027, autospec\u003dTrue)"},{"line_number":260,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7aa08908_83e4f00c","line":257,"in_reply_to":"7aa08908_aa091133","updated":"2016-06-14 16:48:42.000000000","message":"@Sam. I didn\u0027t know that. I also think (if I understand) that this is dangerous. In the sense that the test has a different behavior in the gate than it does on my dev box. Unless I also backport things from the py3 mock library too. (How did you even know this?)","commit_id":"019c672ac66e98c2f691a59c0c79bf7e0e4fc09d"}],"releasenotes/notes/wait-for-interfaces-before-lookup-9bf38852b2f176a1.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b3854141bbe439b778e08fd22752e3fd644859ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - IPA now waits for atleast one interface to be up before trying for node"},{"line_number":4,"context_line":"    lookup."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dab17558_09e4d8dd","line":3,"updated":"2016-05-16 15:49:41.000000000","message":"typo: at least","commit_id":"2a407b8f581e03893ce0bc3d4bae56960aa50d53"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7f5ec367af896a9429fda44499d9991603a23010","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - IPA now waits for atleast one interface to be up before trying for node"},{"line_number":4,"context_line":"    lookup."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bab6814e_1678ae29","line":4,"updated":"2016-05-19 17:13:31.000000000","message":"It is worth asking yourself, if you see this in the release notes, would it be sufficient?\n\nWhat was the problem that this fixes? That unless an interface is up, IPA will send out no interface information. To ensure that there is information, IPA now waits up to 60 seconds for ...","commit_id":"2a407b8f581e03893ce0bc3d4bae56960aa50d53"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4be7d98cf3a644d3f20581dc46255d134ff62788","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - This change is to ensure that the node look up is attempted with valid"},{"line_number":4,"context_line":"    interfaces information to avoid exception log messages in the conductor"},{"line_number":5,"context_line":"    log. IPA tries to retrieve interfaces information every 5 seconds until"},{"line_number":6,"context_line":"    either at least one of the interfaces is up or 60 seconds is lapsed."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_d2b58731","line":3,"updated":"2016-05-31 08:14:03.000000000","message":"s/This change is to//\n\nit won\u0027t be clear what \"this change\" means on the release notes page","commit_id":"d20c2f3109593e29f23c5ab63479cbb32a1b4fd6"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"debc8f7c5489b47571ce1aabeca4caa9f396eedf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - This change is to ensure that the node look up is attempted with valid"},{"line_number":4,"context_line":"    interfaces information to avoid exception log messages in the conductor"},{"line_number":5,"context_line":"    log. IPA tries to retrieve interfaces information every 5 seconds until"},{"line_number":6,"context_line":"    either at least one of the interfaces is up or 60 seconds is lapsed."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_560aef79","line":3,"in_reply_to":"9abb7d3a_303938a5","updated":"2016-06-01 07:00:42.000000000","message":"Done","commit_id":"d20c2f3109593e29f23c5ab63479cbb32a1b4fd6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1c94bfdebd834f61d61a43656a21810ff5ed5d51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - This change is to ensure that the node look up is attempted with valid"},{"line_number":4,"context_line":"    interfaces information to avoid exception log messages in the conductor"},{"line_number":5,"context_line":"    log. IPA tries to retrieve interfaces information every 5 seconds until"},{"line_number":6,"context_line":"    either at least one of the interfaces is up or 60 seconds is lapsed."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9abb7d3a_303938a5","line":3,"in_reply_to":"9abb7d3a_d2b58731","updated":"2016-05-31 23:45:42.000000000","message":"Lets fix this before landing this patch.","commit_id":"d20c2f3109593e29f23c5ab63479cbb32a1b4fd6"}]}
