)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"983c97a84f8f66853fa5efa783ecc0bd9f30f50c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dmitry Tantsur \u003cdtantsur@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-19 17:12:51 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support capabilities discovery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updated the inventory with the \"capabilities\" field populated from the new"},{"line_number":10,"context_line":"list_capabilities hardware manager call. As an example, provide boot_mode"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bab6814e_c8c29352","line":7,"updated":"2016-05-23 11:52:51.000000000","message":"nit: please mention the cpu flags in the first line. May I suggest:\n\n\"Support multiple cpu flags and node capabilities discovery\"\n\nMaybe even splitting this patch in two, since the changes are not really related with each other.","commit_id":"e1c5d5e1611c7cf17a9b647dc9031c09aacc4a28"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"675a5107ad8dbd94c7213c8cc90f3207aaecf0a1","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class Capability(encoding.SerializableComparable):"},{"line_number":223,"context_line":"    serializable_fields \u003d (\u0027name\u0027, \u0027current\u0027, \u0027supported\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, name, current, supported\u003dNone):"},{"line_number":226,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_c60380bd","line":223,"range":{"start_line":223,"start_character":46,"end_line":223,"end_character":57},"updated":"2016-05-12 09:23:23.000000000","message":"What is the significance of \u0027supported\u0027 field? How would it get used?","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"fc1de633e28723825b720e625194723b57618b76","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class Capability(encoding.SerializableComparable):"},{"line_number":223,"context_line":"    serializable_fields \u003d (\u0027name\u0027, \u0027current\u0027, \u0027supported\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, name, current, supported\u003dNone):"},{"line_number":226,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_bf6119d6","line":223,"range":{"start_line":223,"start_character":46,"end_line":223,"end_character":57},"in_reply_to":"dab17558_1a7b1c7d","updated":"2016-05-12 11:29:22.000000000","message":"Thank you. \n\nI think only Windows 8 support UEFI Class 3 (uefi only)\n\nWould it be safe to fill \u0027supported\u0027 field with \u0027bios and uefi\u0027 if current boot mode is uefi?","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cd0b267f9f1b2d381cb01d475574fb030ab49191","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class Capability(encoding.SerializableComparable):"},{"line_number":223,"context_line":"    serializable_fields \u003d (\u0027name\u0027, \u0027current\u0027, \u0027supported\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, name, current, supported\u003dNone):"},{"line_number":226,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_1fce65b4","line":223,"range":{"start_line":223,"start_character":46,"end_line":223,"end_character":57},"in_reply_to":"dab17558_bf6119d6","updated":"2016-05-12 11:30:53.000000000","message":"Dunno, I\u0027ve heard about folks with Linux and UEFI-only machines. I don\u0027t want to make such assumptions.","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fe6ed648827aa1d7cd71f1d9c70e696001b236d5","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class Capability(encoding.SerializableComparable):"},{"line_number":223,"context_line":"    serializable_fields \u003d (\u0027name\u0027, \u0027current\u0027, \u0027supported\u0027)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, name, current, supported\u003dNone):"},{"line_number":226,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_1a7b1c7d","line":223,"range":{"start_line":223,"start_character":46,"end_line":223,"end_character":57},"in_reply_to":"dab17558_c60380bd","updated":"2016-05-12 09:29:18.000000000","message":"Imagine some hardware manager can figure out both the current value (e.g. the node was booted with boot_mode\u003duefi) and possible values (e.g. this node supports boot_mode bios and uefi; or only uefi).","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eea0bcaf99eadde2d83587257c5a7e84bf8cdddd","unresolved":false,"context_lines":[{"line_number":602,"context_line":"                                serial_number\u003dserial_number,"},{"line_number":603,"context_line":"                                manufacturer\u003dmanufacturer)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    def list_capabilities(self):"},{"line_number":606,"context_line":"        boot_mode \u003d \u0027uefi\u0027 if os.path.isdir(\u0027/sys/firmware/efi\u0027) else \u0027bios\u0027"},{"line_number":607,"context_line":"        LOG.debug(\u0027The current boot mode is %s\u0027, boot_mode)"},{"line_number":608,"context_line":"        return [Capability(name\u003d\u0027boot_mode\u0027, current\u003dboot_mode)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_b0bd7bd9","line":605,"updated":"2016-05-19 12:27:30.000000000","message":"note for myself: try to modprobe efivars first just in case","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"983c97a84f8f66853fa5efa783ecc0bd9f30f50c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def __init__(self, name, current, supported\u003dNone):"},{"line_number":226,"context_line":"        self.name \u003d name"},{"line_number":227,"context_line":"        self.current \u003d current"},{"line_number":228,"context_line":"        self.supported \u003d supported"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_48434313","line":228,"updated":"2016-05-23 11:52:51.000000000","message":"nit: Please add a brief comment explaining each field. I had to read the docs to understand what \"supported\" actually meant. As a developer it would be easier to figure out if it was written in the code.","commit_id":"e1c5d5e1611c7cf17a9b647dc9031c09aacc4a28"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d4095bca4917a9c51b74d03715b231c9d97d41e0","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        out \u003d utils.try_execute(\u0027grep\u0027, \u0027-Em1\u0027, \u0027^flags\u0027, \u0027/proc/cpuinfo\u0027)"},{"line_number":455,"context_line":"        if out:"},{"line_number":456,"context_line":"            try:"},{"line_number":457,"context_line":"                flags \u003d out[0].strip().split(\u0027:\u0027, 1)[1].strip().split()"},{"line_number":458,"context_line":"            except (IndexError, ValueError):"},{"line_number":459,"context_line":"                LOG.warning(\u0027Malformed CPU flags information: %s\u0027, out)"},{"line_number":460,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_848ef376","line":457,"updated":"2016-05-31 19:28:18.000000000","message":"so the output is \n    flags : \u003cspace separated list of flag strings\u003e?\n\nI personally like comments for these things, so that if something goes wrong, I can see what the expected output was meant to be.","commit_id":"a05fd1c8cc03e54f66fbde39065a86b30d90aca2"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":16530,"name":"Wajdi Al-Hawari","email":"w.hawari@gmail.com","username":"wajdi"},"change_message_id":"cfdf98c56d42eac3284485ece38ff92364513b31","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            self.assertEqual(\u0027fake-vendor\u0027, vendor)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027)"},{"line_number":444,"context_line":"    def test_get_cpus(self, mocked_execute):"},{"line_number":445,"context_line":"        mocked_execute.side_effect \u003d ["},{"line_number":446,"context_line":"            (LSCPU_OUTPUT, \u0027\u0027),"},{"line_number":447,"context_line":"            processutils.ProcessExecutionError()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_1e973149","line":444,"updated":"2016-05-19 14:39:11.000000000","message":"Might be a good idea to differentiate the two \"test_get_cpus\" methods more explicitly. e.g. something like \"test_get_cpus_with_no_flags\", \"test_get_cpus_with_flags\"?","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"2930fdc7f7e1126a0207b065dc213abb8fcc66ca","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        self.assertEqual(4, cpus.count)"},{"line_number":455,"context_line":"        self.assertEqual(\u0027x86_64\u0027, cpus.architecture)"},{"line_number":456,"context_line":"        self.assertFalse(cpus.flags)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027)"},{"line_number":459,"context_line":"    def test_get_cpus2(self, mocked_execute):"},{"line_number":460,"context_line":"        mocked_execute.side_effect \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_e807657f","line":457,"updated":"2016-05-12 12:31:55.000000000","message":"possibly add a test case: test_get_cpu_illegal_flags that exercises the try--except block from hardware.py:HardwareManager.get_cpus() lines #469--472","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"beecfed73567e1b9e0d6c94c00730917a680b5b9","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        self.assertEqual(4, cpus.count)"},{"line_number":455,"context_line":"        self.assertEqual(\u0027x86_64\u0027, cpus.architecture)"},{"line_number":456,"context_line":"        self.assertFalse(cpus.flags)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027)"},{"line_number":459,"context_line":"    def test_get_cpus2(self, mocked_execute):"},{"line_number":460,"context_line":"        mocked_execute.side_effect \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_4baf8694","line":457,"in_reply_to":"dab17558_e807657f","updated":"2016-05-12 13:59:27.000000000","message":"+1","commit_id":"abb95a8a8d19e72e9dded728a022bd0b2724c62c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d4095bca4917a9c51b74d03715b231c9d97d41e0","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        self.assertEqual(\u00272400.0000\u0027, cpus.frequency)"},{"line_number":484,"context_line":"        self.assertEqual(4, cpus.count)"},{"line_number":485,"context_line":"        self.assertEqual(\u0027x86_64\u0027, cpus.architecture)"},{"line_number":486,"context_line":"        self.assertFalse(cpus.flags)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027)"},{"line_number":489,"context_line":"    def test_get_cpus_illegal_flags(self, mocked_execute):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_e40b7f22","line":486,"updated":"2016-05-31 19:28:18.000000000","message":"cpus.flags is [], right? not False?","commit_id":"a05fd1c8cc03e54f66fbde39065a86b30d90aca2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d4095bca4917a9c51b74d03715b231c9d97d41e0","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        self.assertEqual(\u00272400.0000\u0027, cpus.frequency)"},{"line_number":499,"context_line":"        self.assertEqual(4, cpus.count)"},{"line_number":500,"context_line":"        self.assertEqual(\u0027x86_64\u0027, cpus.architecture)"},{"line_number":501,"context_line":"        self.assertFalse(cpus.flags)"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    @mock.patch(\u0027psutil.version_info\u0027, (2, 0))"},{"line_number":504,"context_line":"    @mock.patch(\u0027psutil.phymem_usage\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_44152b3e","line":501,"updated":"2016-05-31 19:28:18.000000000","message":"ditto","commit_id":"a05fd1c8cc03e54f66fbde39065a86b30d90aca2"}]}
