)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"5d4ffb950d55290e2ef9a9541eb5ec6dfc1ae352","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TinyIPA: Ensure that kernel modules are loaded at boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Installing packages into a chroot was not something tce-load was ever"},{"line_number":10,"context_line":"designed for, because of this it gets a little confused about loading"},{"line_number":11,"context_line":"kernel modules when we install them. This patch manually calls depmod to"},{"line_number":12,"context_line":"ensure that the kernel modules we install during the build process get"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_b086a8b6","line":9,"updated":"2016-05-17 10:38:45.000000000","message":"How\u0027s it meant to be used? Is TinyCoreLinux designed around the assumption that your OS image will be built on the machine it will be run on?","commit_id":"c36183a23b1fa73ebdf6da375dc37a571bd30fb0"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"fac7990acc95825041b1535164707341ef36effc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TinyIPA: Ensure that kernel modules are loaded at boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Installing packages into a chroot was not something tce-load was ever"},{"line_number":10,"context_line":"designed for, because of this it gets a little confused about loading"},{"line_number":11,"context_line":"kernel modules when we install them. This patch manually calls depmod to"},{"line_number":12,"context_line":"ensure that the kernel modules we install during the build process get"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_5bf4bdef","line":9,"in_reply_to":"dab17558_b086a8b6","updated":"2016-05-17 10:44:57.000000000","message":"Their documented method for building a custom image for tinycore is to manually download the packages you want and drop them into the image, as normally they are loaded at boot time anyway. tce-load their package manager understands what to do if the system is in a booting state or an already running state to load the packages, but I think gets a little confused by being in a chroot.","commit_id":"c36183a23b1fa73ebdf6da375dc37a571bd30fb0"}],"imagebuild/tinyipa/finalise-tinyipa.sh":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9bb1ed9b32c36753e279f3fc3f407a7c8a63a130","unresolved":false,"context_lines":[{"line_number":68,"context_line":"$TC_CHROOT_CMD tce-load -ic /tmp/builtin/optional/qemu-utils.tcz"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Ensure tinyipa picks up installed kernel modules"},{"line_number":71,"context_line":"$CHROOT_CMD depmod -a `$WORKDIR/build_files/fakeuname -r`"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# If flag is set install the python now"},{"line_number":74,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dab17558_cd98f3c2","line":71,"range":{"start_line":71,"start_character":23,"end_line":71,"end_character":31},"updated":"2016-05-17 10:13:35.000000000","message":"It may not work since $WORKDIR points to path that doesn\u0027t exists in chroot environment. Lets wait for tests.","commit_id":"70d035662839a613f6025198d423d66d7a32c7ae"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"86e6dc2033797a6d1116c662b83312c19e4974f7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"$TC_CHROOT_CMD tce-load -ic /tmp/builtin/optional/qemu-utils.tcz"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Ensure tinyipa picks up installed kernel modules"},{"line_number":71,"context_line":"$CHROOT_CMD depmod -a `$WORKDIR/build_files/fakeuname -r`"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# If flag is set install the python now"},{"line_number":74,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dab17558_108fb475","line":71,"range":{"start_line":71,"start_character":23,"end_line":71,"end_character":31},"in_reply_to":"dab17558_cd98f3c2","updated":"2016-05-17 10:29:22.000000000","message":"The `command` is processed by the script before the rest of the command. I\u0027ve tested this locally, a build_files directory will never exist in the chroot so this would fail if it was trying to operate inside the chroot.","commit_id":"70d035662839a613f6025198d423d66d7a32c7ae"}]}
