)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"a284f81b444eb3277b7394d12c0ff847cfd3b6c3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Two new functions: \"cache_node\" and \"get_cached_node\" were added to the"},{"line_number":16,"context_line":"hardware module. The idea is to facilitate the access to a node object"},{"line_number":17,"context_line":"representation from the hardware extension methods without breaking"},{"line_number":18,"context_line":"the compatibility with out-of-tree hardware managers (for not changing"},{"line_number":19,"context_line":"the methods signatures)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the new \"get_cached_node\" is just a guard function to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_4e14eb4b","line":18,"updated":"2016-05-23 12:30:11.000000000","message":"Nit: I\u0027d reword this as \"The idea is to facilitate the access to a node object representation from the hardware extension methods without changing method signatures, which would break compatibility with out-of-tree hardware managers.\"","commit_id":"6fc28bf831cc36584c59513b2f55ad2a642d683e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"eb84106d17812eef91917991bce4a946af1d2296","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Two new functions: \"cache_node\" and \"get_cached_node\" were added to the"},{"line_number":16,"context_line":"hardware module. The idea is to facilitate the access to a node object"},{"line_number":17,"context_line":"representation from the hardware extension methods without breaking"},{"line_number":18,"context_line":"the compatibility with out-of-tree hardware managers (for not changing"},{"line_number":19,"context_line":"the methods signatures)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note that the new \"get_cached_node\" is just a guard function to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_34fd716e","line":18,"in_reply_to":"bab6814e_4e14eb4b","updated":"2016-05-23 13:28:48.000000000","message":"Great +1","commit_id":"6fc28bf831cc36584c59513b2f55ad2a642d683e"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"78eb3892e06996521441d9e53b45480396a7ada5","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        return list_all_block_devices()"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def get_os_install_device(self):"},{"line_number":502,"context_line":"        global NODE"},{"line_number":503,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":504,"context_line":"        if NODE is not None:"},{"line_number":505,"context_line":"            root_device_hints \u003d NODE[\u0027properties\u0027].get(\u0027root_device\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_2dd458ea","line":502,"updated":"2016-05-20 12:11:36.000000000","message":"you don\u0027t need \u0027global\u0027 instruction to read a variable, only to set it","commit_id":"c323088d200d2ef895f6695818e411bfc7e2042d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3b1effa4227c6ef51ada0b358a5849529cf83b9f","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        return list_all_block_devices()"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def get_os_install_device(self):"},{"line_number":502,"context_line":"        global NODE"},{"line_number":503,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":504,"context_line":"        if NODE is not None:"},{"line_number":505,"context_line":"            root_device_hints \u003d NODE[\u0027properties\u0027].get(\u0027root_device\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_fc3832f0","line":502,"in_reply_to":"bab6814e_2dd458ea","updated":"2016-05-20 16:47:32.000000000","message":"Done","commit_id":"c323088d200d2ef895f6695818e411bfc7e2042d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"78eb3892e06996521441d9e53b45480396a7ada5","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        global NODE"},{"line_number":503,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":504,"context_line":"        if NODE is not None:"},{"line_number":505,"context_line":"            root_device_hints \u003d NODE[\u0027properties\u0027].get(\u0027root_device\u0027)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        if not root_device_hints:"},{"line_number":508,"context_line":"            return utils.guess_root_disk(block_devices).name"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0dd194fa","line":505,"updated":"2016-05-20 12:11:36.000000000","message":"else:\n root_device_hints \u003d None\n\notherwise the next check will raise","commit_id":"c323088d200d2ef895f6695818e411bfc7e2042d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3b1effa4227c6ef51ada0b358a5849529cf83b9f","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        global NODE"},{"line_number":503,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":504,"context_line":"        if NODE is not None:"},{"line_number":505,"context_line":"            root_device_hints \u003d NODE[\u0027properties\u0027].get(\u0027root_device\u0027)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        if not root_device_hints:"},{"line_number":508,"context_line":"            return utils.guess_root_disk(block_devices).name"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_5c2a1e91","line":505,"in_reply_to":"bab6814e_0dd194fa","updated":"2016-05-20 16:47:32.000000000","message":"Done","commit_id":"c323088d200d2ef895f6695818e411bfc7e2042d"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"b53fe7529a854629f15d20e0fe937a92964f2f9e","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    def get_os_install_device(self):"},{"line_number":500,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":501,"context_line":"        root_device_hints \u003d utils.parse_root_device_hints()"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        if not root_device_hints:"},{"line_number":504,"context_line":"            return utils.guess_root_disk(block_devices).name"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_8212fc56","side":"PARENT","line":501,"range":{"start_line":501,"start_character":34,"end_line":501,"end_character":57},"updated":"2016-05-24 04:33:08.000000000","message":"this method should be deprecated I assume, it was only used here","commit_id":"015fad6054d0572daadd193b68ba17c9de0ae8e0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1047c250ddde82542f07d01e0623491248dd929c","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    def get_os_install_device(self):"},{"line_number":500,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":501,"context_line":"        root_device_hints \u003d utils.parse_root_device_hints()"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        if not root_device_hints:"},{"line_number":504,"context_line":"            return utils.guess_root_disk(block_devices).name"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_17af6495","side":"PARENT","line":501,"range":{"start_line":501,"start_character":34,"end_line":501,"end_character":57},"in_reply_to":"bab6814e_8212fc56","updated":"2016-05-24 08:16:14.000000000","message":"Right, yes it\u0027s used only here. I can remove it as part of this patch","commit_id":"015fad6054d0572daadd193b68ba17c9de0ae8e0"}],"releasenotes/notes/device-hints-from-node-object-9a689f5a4175a1a6.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fac3eed3ad57313cd9b5995b4b1266c65228cd44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - IPA now gets the root device hints directly from the node object"},{"line_number":4,"context_line":"    representation instead of the kernel command line. This is a required"},{"line_number":5,"context_line":"    work in order to support a more complex syntax for the hints in"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_197a6824","line":2,"updated":"2016-05-26 14:07:59.000000000","message":"Not sure if it\u0027s a feature yet :)","commit_id":"33535cd572b90a817b9c96b42a0d2fe54751351d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4f40168f2334dd86a44b1bca7e641697d9dd567d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - IPA now gets the root device hints directly from the node object"},{"line_number":4,"context_line":"    representation instead of the kernel command line. This is a required"},{"line_number":5,"context_line":"    work in order to support a more complex syntax for the hints in"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9abb7d3a_8fba35bf","line":2,"in_reply_to":"bab6814e_197a6824","updated":"2016-05-27 03:42:47.000000000","message":"I think it can be treated as a feature.","commit_id":"33535cd572b90a817b9c96b42a0d2fe54751351d"}]}