)]}'
{"ironic_python_agent/agent.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"c9a3708b635f50547d3016010116ac4ab539f8f8","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if self.hardware_initialization_delay \u003e 0:"},{"line_number":299,"context_line":"            LOG.info(\u0027Waiting %d seconds before proceeding\u0027,"},{"line_number":300,"context_line":"                     self.hardware_initialization_delay)"},{"line_number":301,"context_line":"            time.sleep(self.hardware_initialization_delay)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if not self.standalone:"},{"line_number":304,"context_line":"            # Inspection should be started before call to lookup, otherwise"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b13256f0","line":301,"updated":"2016-05-20 15:14:23.000000000","message":"Don\u0027t we want to do this before we do the initialize_hardware step? If this is for waiting for things like the RAID controllers then it would make sense to me to wait before we dispatch out to the initialize step thats looking for disks.","commit_id":"8e0fe827537ed43d7d9fa774021e619c2ad12b51"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"22348ceb510dfe11902a181158983dfb47d0ac65","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if self.hardware_initialization_delay \u003e 0:"},{"line_number":299,"context_line":"            LOG.info(\u0027Waiting %d seconds before proceeding\u0027,"},{"line_number":300,"context_line":"                     self.hardware_initialization_delay)"},{"line_number":301,"context_line":"            time.sleep(self.hardware_initialization_delay)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if not self.standalone:"},{"line_number":304,"context_line":"            # Inspection should be started before call to lookup, otherwise"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_89a1ad96","line":301,"in_reply_to":"bab6814e_0e7ae387","updated":"2016-05-23 12:28:25.000000000","message":"Do we need to make the kernel parameters hw manager specific if we do things like that?","commit_id":"8e0fe827537ed43d7d9fa774021e619c2ad12b51"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1069239fcb65c178e9cd403cfa843134deb3c01a","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if self.hardware_initialization_delay \u003e 0:"},{"line_number":299,"context_line":"            LOG.info(\u0027Waiting %d seconds before proceeding\u0027,"},{"line_number":300,"context_line":"                     self.hardware_initialization_delay)"},{"line_number":301,"context_line":"            time.sleep(self.hardware_initialization_delay)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if not self.standalone:"},{"line_number":304,"context_line":"            # Inspection should be started before call to lookup, otherwise"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_a34e5038","line":301,"in_reply_to":"bab6814e_48b86375","updated":"2016-05-23 11:53:36.000000000","message":"That\u0027s something I had considered but I wasn\u0027t sure whether it was something we wanted to enforce gets handled for consistency or to leave it down to the hardware manager to run, and potentially have some hardware managers just ignore it.","commit_id":"8e0fe827537ed43d7d9fa774021e619c2ad12b51"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cf92135cc320b2185c2eeda8a63296fd778e6249","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if self.hardware_initialization_delay \u003e 0:"},{"line_number":299,"context_line":"            LOG.info(\u0027Waiting %d seconds before proceeding\u0027,"},{"line_number":300,"context_line":"                     self.hardware_initialization_delay)"},{"line_number":301,"context_line":"            time.sleep(self.hardware_initialization_delay)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if not self.standalone:"},{"line_number":304,"context_line":"            # Inspection should be started before call to lookup, otherwise"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_48b86375","line":301,"in_reply_to":"bab6814e_680e07e6","updated":"2016-05-23 11:48:15.000000000","message":"I can also move the sleep to initialize_hardware itself, so that hardware managers can control where to sleep.","commit_id":"8e0fe827537ed43d7d9fa774021e619c2ad12b51"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"cd29f232a3ce31495611379bada94ed3b15f3fff","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if self.hardware_initialization_delay \u003e 0:"},{"line_number":299,"context_line":"            LOG.info(\u0027Waiting %d seconds before proceeding\u0027,"},{"line_number":300,"context_line":"                     self.hardware_initialization_delay)"},{"line_number":301,"context_line":"            time.sleep(self.hardware_initialization_delay)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if not self.standalone:"},{"line_number":304,"context_line":"            # Inspection should be started before call to lookup, otherwise"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_680e07e6","line":301,"in_reply_to":"bab6814e_83ab8974","updated":"2016-05-23 11:40:43.000000000","message":"hmmm interesting :/ spitballing ideas: maybe we need a pre and a post delay step? First step modprobes, then we wait for an amount of time, then the last step does things like poll for at least one disk to show up? Maybe something to think about in the future :/","commit_id":"8e0fe827537ed43d7d9fa774021e619c2ad12b51"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3944d61b4c38f493896722b1b96edb7b1e9fdf3c","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if self.hardware_initialization_delay \u003e 0:"},{"line_number":299,"context_line":"            LOG.info(\u0027Waiting %d seconds before proceeding\u0027,"},{"line_number":300,"context_line":"                     self.hardware_initialization_delay)"},{"line_number":301,"context_line":"            time.sleep(self.hardware_initialization_delay)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if not self.standalone:"},{"line_number":304,"context_line":"            # Inspection should be started before call to lookup, otherwise"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_0e7ae387","line":301,"in_reply_to":"bab6814e_a34e5038","updated":"2016-05-23 12:04:26.000000000","message":"Hmm, it actually sounds a feature: wait some time with the generic hw manager, but do not wait with a specific one which can initialize hardware properly..","commit_id":"8e0fe827537ed43d7d9fa774021e619c2ad12b51"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d22f786813cbbf223ae87be62939666c794aa0bc","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if self.hardware_initialization_delay \u003e 0:"},{"line_number":299,"context_line":"            LOG.info(\u0027Waiting %d seconds before proceeding\u0027,"},{"line_number":300,"context_line":"                     self.hardware_initialization_delay)"},{"line_number":301,"context_line":"            time.sleep(self.hardware_initialization_delay)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if not self.standalone:"},{"line_number":304,"context_line":"            # Inspection should be started before call to lookup, otherwise"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_83ab8974","line":301,"in_reply_to":"bab6814e_b13256f0","updated":"2016-05-20 15:39:30.000000000","message":"I imagined initalize_hardware may do some modprobing, and then here we wait for modules to do their job.","commit_id":"8e0fe827537ed43d7d9fa774021e619c2ad12b51"}],"releasenotes/notes/sleep-ebe58fbe07d30219.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e2bd43364320f50e05199ed3c2a39e3e8f0337f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a configurable (and disabled by default) sleep before IPA does any"},{"line_number":4,"context_line":"    actions."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_a6a1a296","line":4,"updated":"2016-05-25 20:34:00.000000000","message":"It would be good to mention the configuration option.","commit_id":"c09753bb60be1819ef102ba8a86b534bba146ccb"}]}