)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"c75b955de0b57e5a02559104221a2a50a54f3d6c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"has part of the list interfaces stage of the generic hardware manager,"},{"line_number":13,"context_line":"this information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_cbf3ed71","line":12,"range":{"start_line":12,"start_character":69,"end_line":12,"end_character":70},"updated":"2016-05-26 13:02:52.000000000","message":".","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"c75b955de0b57e5a02559104221a2a50a54f3d6c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"has part of the list interfaces stage of the generic hardware manager,"},{"line_number":13,"context_line":"this information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_8bdf25d5","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":3},"updated":"2016-05-26 13:02:52.000000000","message":"as","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"has part of the list interfaces stage of the generic hardware manager,"},{"line_number":13,"context_line":"this information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_01a69152","line":12,"range":{"start_line":12,"start_character":69,"end_line":12,"end_character":70},"in_reply_to":"bab6814e_cbf3ed71","updated":"2016-05-31 14:23:10.000000000","message":"Done","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"c75b955de0b57e5a02559104221a2a50a54f3d6c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"has part of the list interfaces stage of the generic hardware manager,"},{"line_number":13,"context_line":"this information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"},{"line_number":16,"context_line":"for server side processing hooks to process as much or a little of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_0bea1574","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":4},"updated":"2016-05-26 13:02:52.000000000","message":"This","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"has part of the list interfaces stage of the generic hardware manager,"},{"line_number":13,"context_line":"this information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"},{"line_number":16,"context_line":"for server side processing hooks to process as much or a little of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_6165dd1c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":4},"in_reply_to":"bab6814e_0bea1574","updated":"2016-05-31 14:23:10.000000000","message":"Done","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"92cef141850267275329cc0dadae6bae67622c1b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"this information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"},{"line_number":16,"context_line":"for server side processing hooks to process as much or a little of the"},{"line_number":17,"context_line":"data that they want, this is to allow for multi-vendor environments that"},{"line_number":18,"context_line":"might use different parts of the LLDP packet, to use a generic ramdisk"},{"line_number":19,"context_line":"as that level of processing is pluggable server side."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_a86e5d2c","line":16,"updated":"2016-05-26 17:13:03.000000000","message":"\"or as little\"","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"this information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"},{"line_number":16,"context_line":"for server side processing hooks to process as much or a little of the"},{"line_number":17,"context_line":"data that they want, this is to allow for multi-vendor environments that"},{"line_number":18,"context_line":"might use different parts of the LLDP packet, to use a generic ramdisk"},{"line_number":19,"context_line":"as that level of processing is pluggable server side."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_1c19d479","line":16,"in_reply_to":"bab6814e_a86e5d2c","updated":"2016-05-31 14:23:10.000000000","message":"Done","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"92cef141850267275329cc0dadae6bae67622c1b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"},{"line_number":16,"context_line":"for server side processing hooks to process as much or a little of the"},{"line_number":17,"context_line":"data that they want, this is to allow for multi-vendor environments that"},{"line_number":18,"context_line":"might use different parts of the LLDP packet, to use a generic ramdisk"},{"line_number":19,"context_line":"as that level of processing is pluggable server side."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_a8dc9de4","line":17,"updated":"2016-05-26 17:13:03.000000000","message":"\"as they want. This\"","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"},{"line_number":15,"context_line":"done on this data in ironic python agent is limited, this is to allow"},{"line_number":16,"context_line":"for server side processing hooks to process as much or a little of the"},{"line_number":17,"context_line":"data that they want, this is to allow for multi-vendor environments that"},{"line_number":18,"context_line":"might use different parts of the LLDP packet, to use a generic ramdisk"},{"line_number":19,"context_line":"as that level of processing is pluggable server side."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_dc12ac56","line":17,"in_reply_to":"bab6814e_a8dc9de4","updated":"2016-05-31 14:23:10.000000000","message":"Done","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ed4ae2fade6dabbc80b8a072ba3e4a7ddd476c6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support LLDP data as part of interfaces in inventory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"as part of the list interfaces stage of the generic hardware manager."},{"line_number":13,"context_line":"This information can then be processed by the ironic inspector to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a9d85d2_bbe7693f","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":26},"updated":"2016-06-20 05:47:38.000000000","message":"NICs","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ed4ae2fade6dabbc80b8a072ba3e4a7ddd476c6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support LLDP data as part of interfaces in inventory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"as part of the list interfaces stage of the generic hardware manager."},{"line_number":13,"context_line":"This information can then be processed by the ironic inspector to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a9d85d2_fbcf31b1","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":31},"updated":"2016-06-20 05:47:38.000000000","message":"bare-metal","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6ac98db3129531891524382fb39b8a3a1c8dbf31","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support LLDP data as part of interfaces in inventory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"as part of the list interfaces stage of the generic hardware manager."},{"line_number":13,"context_line":"This information can then be processed by the ironic inspector to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a9d85d2_74b062f5","line":10,"range":{"start_line":10,"start_character":22,"end_line":10,"end_character":26},"in_reply_to":"5a9d85d2_bbe7693f","updated":"2016-06-20 13:43:58.000000000","message":"Done","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6ac98db3129531891524382fb39b8a3a1c8dbf31","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support LLDP data as part of interfaces in inventory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"as part of the list interfaces stage of the generic hardware manager."},{"line_number":13,"context_line":"This information can then be processed by the ironic inspector to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a9d85d2_d495d640","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":31},"in_reply_to":"5a9d85d2_fbcf31b1","updated":"2016-06-20 13:43:58.000000000","message":"Done","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9ed4ae2fade6dabbc80b8a072ba3e4a7ddd476c6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"as part of the list interfaces stage of the generic hardware manager."},{"line_number":13,"context_line":"This information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a9d85d2_dbd4f548","line":11,"range":{"start_line":11,"start_character":61,"end_line":11,"end_character":65},"updated":"2016-06-20 05:47:38.000000000","message":"Please define acronym once.","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6ac98db3129531891524382fb39b8a3a1c8dbf31","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support multi-tenant networking in Ironic we need to be able to"},{"line_number":10,"context_line":"discover not just the nics a BM machine has but also the physical"},{"line_number":11,"context_line":"connectivity to switches in the network. This patch collects LLDP data"},{"line_number":12,"context_line":"as part of the list interfaces stage of the generic hardware manager."},{"line_number":13,"context_line":"This information can then be processed by the ironic inspector to"},{"line_number":14,"context_line":"populate the local link information on each ironic port. The processing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a9d85d2_14a0fe9e","line":11,"range":{"start_line":11,"start_character":61,"end_line":11,"end_character":65},"in_reply_to":"5a9d85d2_dbd4f548","updated":"2016-06-20 13:43:58.000000000","message":"Done","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aa04159af0560e91809c171d58d0455ed9d8b09b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"plugins."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Reserved fields switch_port_descr and switch_chassis_descr have been"},{"line_number":26,"context_line":"removed in favor of passing the whole packet."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Idae9b1ede1797029da1bd521501b121957ca1f1a"},{"line_number":29,"context_line":"Partial-Bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3aaa91ec_24acca9f","line":26,"updated":"2016-06-22 14:41:17.000000000","message":"s/removed/deprecated (and will be removed in Ocata)/","commit_id":"fc9b62ce0ac7ab85b09b5352320b0f56160f2389"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a09e8bfeecf2fd902960116679984564b922f2e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"plugins."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Reserved fields switch_port_descr and switch_chassis_descr have been"},{"line_number":26,"context_line":"removed in favor of passing the whole packet."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Idae9b1ede1797029da1bd521501b121957ca1f1a"},{"line_number":29,"context_line":"Partial-Bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3aaa91ec_415bbd87","line":26,"in_reply_to":"3aaa91ec_24acca9f","updated":"2016-06-22 17:26:29.000000000","message":"Done","commit_id":"fc9b62ce0ac7ab85b09b5352320b0f56160f2389"}],"doc/source/index.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6a05d448c79d0ff1c9441c254856b17f4d9b137","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If option ``lldp_in_inventory`` is set to True"},{"line_number":114,"context_line":"    the ``lldp`` field will be populated by a list of TLVs pulled from LLDP."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``system_vendor``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_6f0bbf24","line":113,"updated":"2016-06-01 13:46:44.000000000","message":"s/lldp_in_inventory/collect_lldp/","commit_id":"acd81a065fd97b0e92c60a92c70417e7f50eba70"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"c77432a52066457aaf2da9fe3d03be3c8643f67d","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If option ``lldp_in_inventory`` is set to True"},{"line_number":114,"context_line":"    the ``lldp`` field will be populated by a list of TLVs pulled from LLDP."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``system_vendor``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9abb7d3a_71736b16","line":113,"in_reply_to":"9abb7d3a_6f0bbf24","updated":"2016-06-02 10:58:51.000000000","message":"Done","commit_id":"acd81a065fd97b0e92c60a92c70417e7f50eba70"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae273336a694edcbc58e99d71b2409256b1aa34d","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If option ``collect_lldp`` is set to True"},{"line_number":114,"context_line":"    the ``lldp`` field will be populated by a list of TLVs pulled from LLDP."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``system_vendor``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_eb13ffb5","line":113,"updated":"2016-06-14 21:40:17.000000000","message":"s/option/configuration option/","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a3703c789b0d4cdfd60715f97eb0c629757a91aa","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If option ``collect_lldp`` is set to True"},{"line_number":114,"context_line":"    the ``lldp`` field will be populated by a list of TLVs pulled from LLDP."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``system_vendor``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_8ec6b066","line":113,"in_reply_to":"7aa08908_eb13ffb5","updated":"2016-06-15 11:23:51.000000000","message":"Done","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae273336a694edcbc58e99d71b2409256b1aa34d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If option ``collect_lldp`` is set to True"},{"line_number":114,"context_line":"    the ``lldp`` field will be populated by a list of TLVs pulled from LLDP."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``system_vendor``"},{"line_number":117,"context_line":"    system vendor information from SMBIOS as reported by ``dmidecode``:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_ab4737ba","line":114,"updated":"2016-06-14 21:40:17.000000000","message":"did you get rid of switch_port_descr \u0026 switch_chassis_descr?\n\nI realize they are reserved, etc, but they are/were returned. Would we break anyone by not returning that any more? \n\nAt the very least, shouldn\u0027t it be mentioned in the commit. (and maybe relno, don\u0027t know.)","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a3703c789b0d4cdfd60715f97eb0c629757a91aa","unresolved":false,"context_lines":[{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If option ``collect_lldp`` is set to True"},{"line_number":114,"context_line":"    the ``lldp`` field will be populated by a list of TLVs pulled from LLDP."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``system_vendor``"},{"line_number":117,"context_line":"    system vendor information from SMBIOS as reported by ``dmidecode``:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_ee9bf464","line":114,"in_reply_to":"7aa08908_ab4737ba","updated":"2016-06-15 11:23:51.000000000","message":"These fields were returned but were always None, so I\u0027d hope removing them shouldn\u0027t break anyone. Do you think I need an deprecation period? I\u0027ve added a note to the commit message and release note.","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4eb72283031ab59a4c3973bd017f397503a01cab","unresolved":false,"context_lines":[{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If option ``collect_lldp`` is set to True"},{"line_number":114,"context_line":"    the ``lldp`` field will be populated by a list of TLVs pulled from LLDP."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"``system_vendor``"},{"line_number":117,"context_line":"    system vendor information from SMBIOS as reported by ``dmidecode``:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_39389a3d","line":114,"in_reply_to":"7aa08908_ee9bf464","updated":"2016-06-15 15:09:59.000000000","message":"I don\u0027t know what/if there is some policy wrt deprecations. Maybe we can discuss in midcycle. I am fine with noting it; maybe JayF has an opinion.","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aa04159af0560e91809c171d58d0455ed9d8b09b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    set to True the ``lldp`` field will be populated by a list of TLVs pulled"},{"line_number":115,"context_line":"    from LLDP. Currently IPA also returns 2 fields ``switch_port_descr`` and"},{"line_number":116,"context_line":"    ``switch_chassis_descr`` which were reserved for future use, these are now"},{"line_number":117,"context_line":"    deprecated to be removed in Ocata."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"``system_vendor``"},{"line_number":120,"context_line":"    system vendor information from SMBIOS as reported by ``dmidecode``:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3aaa91ec_a4f27ad0","line":117,"updated":"2016-06-22 14:41:17.000000000","message":"if you do another revision and think it is useful, maybe s/deprecated/deprecated (because that information will be available via ``lldp`` field)/","commit_id":"fc9b62ce0ac7ab85b09b5352320b0f56160f2389"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a09e8bfeecf2fd902960116679984564b922f2e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    set to True the ``lldp`` field will be populated by a list of TLVs pulled"},{"line_number":115,"context_line":"    from LLDP. Currently IPA also returns 2 fields ``switch_port_descr`` and"},{"line_number":116,"context_line":"    ``switch_chassis_descr`` which were reserved for future use, these are now"},{"line_number":117,"context_line":"    deprecated to be removed in Ocata."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"``system_vendor``"},{"line_number":120,"context_line":"    system vendor information from SMBIOS as reported by ``dmidecode``:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3aaa91ec_c1fded3b","line":117,"in_reply_to":"3aaa91ec_a4f27ad0","updated":"2016-06-22 17:26:29.000000000","message":"Done","commit_id":"fc9b62ce0ac7ab85b09b5352320b0f56160f2389"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cd2174222eb6f48f398e1c8caaf74bf38e6d195","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"``interfaces``"},{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If configuration option ``collect_lldp`` is"},{"line_number":114,"context_line":"    set to True the ``lldp`` field will be populated by a list of TLVs pulled"},{"line_number":115,"context_line":"    from LLDP. Currently IPA also returns 2 fields ``switch_port_descr`` and"},{"line_number":116,"context_line":"    ``switch_chassis_descr`` which were reserved for future use, these are now"},{"line_number":117,"context_line":"    deprecated to be removed in Ocata in favor of including all LLDP data in"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3aaa91ec_84213350","line":114,"range":{"start_line":113,"start_character":66,"end_line":114,"end_character":70},"updated":"2016-06-22 17:38:35.000000000","message":"nit: Maybe in a follow-up could define TLV","commit_id":"a7f0af722f96950e3bf67e26b922f80c1bd503ab"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cd2174222eb6f48f398e1c8caaf74bf38e6d195","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    list of network interfaces with fields: ``name``, ``mac_address``,"},{"line_number":113,"context_line":"    ``ipv4_address``, ``lldp``. If configuration option ``collect_lldp`` is"},{"line_number":114,"context_line":"    set to True the ``lldp`` field will be populated by a list of TLVs pulled"},{"line_number":115,"context_line":"    from LLDP. Currently IPA also returns 2 fields ``switch_port_descr`` and"},{"line_number":116,"context_line":"    ``switch_chassis_descr`` which were reserved for future use, these are now"},{"line_number":117,"context_line":"    deprecated to be removed in Ocata in favor of including all LLDP data in"},{"line_number":118,"context_line":"    the ``lddp`` field."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3aaa91ec_84e813e4","line":115,"range":{"start_line":115,"start_character":9,"end_line":115,"end_character":13},"updated":"2016-06-22 17:38:35.000000000","message":"nit: And define LLDP","commit_id":"a7f0af722f96950e3bf67e26b922f80c1bd503ab"}],"ironic_python_agent/cmd/agent.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6bf9194ea0f9c4f1de71a1004fe6ca1505f06ae5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_utils import strutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic_python_agent import agent"},{"line_number":22,"context_line":"from ironic_python_agent import config  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_7e3668b5","line":22,"updated":"2016-05-24 17:32:18.000000000","message":"I think you can use oslo.config\u0027s import_opt option to avoid needing to noqa this.","commit_id":"8362237f3523d071ef732de792f800b1b1387400"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4fcf3fdcb9271098ac4a402133aab7c06d6df291","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_utils import strutils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from ironic_python_agent import agent"},{"line_number":22,"context_line":"from ironic_python_agent import config  # noqa"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_ba143c9f","line":22,"in_reply_to":"bab6814e_7e3668b5","updated":"2016-05-25 11:04:23.000000000","message":"Realised I don\u0027t need the noqa here anyway because I use config.APARMS further down :)","commit_id":"8362237f3523d071ef732de792f800b1b1387400"}],"ironic_python_agent/config.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"32d5db2a190a661ee1a946b1d326d0d0ae014987","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027lldp_in_inventory\u0027,"},{"line_number":95,"context_line":"                default\u003dAPARAMS.get(\u0027lldp-in-inventory\u0027, False),"},{"line_number":96,"context_line":"                help\u003d\u0027Whether IPA should attempt to receive LLDP packets for\u0027"},{"line_number":97,"context_line":"                     \u0027each network interface it discovers in the inventory\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_8d3642e5","line":94,"updated":"2016-05-31 08:31:56.000000000","message":"maybe \"collect_lldp\" would be clearer?","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027lldp_in_inventory\u0027,"},{"line_number":95,"context_line":"                default\u003dAPARAMS.get(\u0027lldp-in-inventory\u0027, False),"},{"line_number":96,"context_line":"                help\u003d\u0027Whether IPA should attempt to receive LLDP packets for\u0027"},{"line_number":97,"context_line":"                     \u0027each network interface it discovers in the inventory\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_9c38243f","line":94,"in_reply_to":"9abb7d3a_8d3642e5","updated":"2016-05-31 14:23:10.000000000","message":"I like it! :D","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6a05d448c79d0ff1c9441c254856b17f4d9b137","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027collect_lldp\u0027,"},{"line_number":95,"context_line":"                default\u003dAPARAMS.get(\u0027collect-lldp\u0027, False),"},{"line_number":96,"context_line":"                help\u003d\u0027Whether IPA should attempt to receive LLDP packets for\u0027"},{"line_number":97,"context_line":"                     \u0027each network interface it discovers in the inventory\u0027),"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_cf162b4b","line":95,"updated":"2016-06-01 13:46:44.000000000","message":"I wonder if we need \"ipa-\" prefix like with majority of other options..","commit_id":"acd81a065fd97b0e92c60a92c70417e7f50eba70"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"c77432a52066457aaf2da9fe3d03be3c8643f67d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027collect_lldp\u0027,"},{"line_number":95,"context_line":"                default\u003dAPARAMS.get(\u0027collect-lldp\u0027, False),"},{"line_number":96,"context_line":"                help\u003d\u0027Whether IPA should attempt to receive LLDP packets for\u0027"},{"line_number":97,"context_line":"                     \u0027each network interface it discovers in the inventory\u0027),"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_b115d39c","line":95,"in_reply_to":"9abb7d3a_cf162b4b","updated":"2016-06-02 10:58:51.000000000","message":"Done. Is it a bug that the lldp-timeout option above isn\u0027t prefixed? Its the only one with it missing.","commit_id":"acd81a065fd97b0e92c60a92c70417e7f50eba70"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae273336a694edcbc58e99d71b2409256b1aa34d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027collect_lldp\u0027,"},{"line_number":96,"context_line":"                default\u003dAPARAMS.get(\u0027ipa-collect-lldp\u0027, False),"},{"line_number":97,"context_line":"                help\u003d\u0027Whether IPA should attempt to receive LLDP packets for\u0027"},{"line_number":98,"context_line":"                     \u0027each network interface it discovers in the inventory\u0027),"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"},{"line_number":101,"context_line":"                default\u003dAPARAMS.get(\u0027ipa-standalone\u0027, False),"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_6b28afe2","line":98,"updated":"2016-06-14 21:40:17.000000000","message":"missing a blank space before \u0027each\u0027 (or after \u0027for\u0027 above)\n\nThe other help messages seem to end with a period so this should too I guess.","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a3703c789b0d4cdfd60715f97eb0c629757a91aa","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027collect_lldp\u0027,"},{"line_number":96,"context_line":"                default\u003dAPARAMS.get(\u0027ipa-collect-lldp\u0027, False),"},{"line_number":97,"context_line":"                help\u003d\u0027Whether IPA should attempt to receive LLDP packets for\u0027"},{"line_number":98,"context_line":"                     \u0027each network interface it discovers in the inventory\u0027),"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"},{"line_number":101,"context_line":"                default\u003dAPARAMS.get(\u0027ipa-standalone\u0027, False),"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_4eccc88a","line":98,"in_reply_to":"7aa08908_6b28afe2","updated":"2016-06-15 11:23:51.000000000","message":"Done","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6bf9194ea0f9c4f1de71a1004fe6ca1505f06ae5","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        iface_names \u003d os.listdir(\u0027{0}/class/net\u0027.format(self.sys_path))"},{"line_number":450,"context_line":"        iface_names \u003d [name for name in iface_names if self._is_device(name)]"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        self._cache_lldp_data(iface_names)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        return [self._get_interface_info(name) for name in iface_names]"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_9e134c0d","line":452,"updated":"2016-05-24 17:32:18.000000000","message":"This must be made optional. If not, you\u0027re going to increase time to run a deployment or a clean step by LLDP_TIMEOUT at a max. Also LLDP is not universally supported.","commit_id":"8362237f3523d071ef732de792f800b1b1387400"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4fcf3fdcb9271098ac4a402133aab7c06d6df291","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        iface_names \u003d os.listdir(\u0027{0}/class/net\u0027.format(self.sys_path))"},{"line_number":450,"context_line":"        iface_names \u003d [name for name in iface_names if self._is_device(name)]"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        self._cache_lldp_data(iface_names)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        return [self._get_interface_info(name) for name in iface_names]"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_07c52c8d","line":452,"in_reply_to":"bab6814e_9e134c0d","updated":"2016-05-25 11:04:23.000000000","message":"Done","commit_id":"8362237f3523d071ef732de792f800b1b1387400"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"33fd933ef48c43e05c5a9647e57d7f98fb407719","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _cache_lldp_data(self, interface_names):"},{"line_number":427,"context_line":"        interface_names \u003d [name for name in interface_names if name !\u003d \u0027lo\u0027]"},{"line_number":428,"context_line":"        self.lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":429,"context_line":"        # convert the tlv value to hex"},{"line_number":430,"context_line":"        for ifname, tlvs in self.lldp_data.items():"},{"line_number":431,"context_line":"            for idx, tlv in enumerate(tlvs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_f429909c","line":428,"updated":"2016-05-25 21:47:16.000000000","message":"exception might occur here it should be properly handled.","commit_id":"d946a4c4695b46cc744d062f8938da7cfa0d6b06"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d515145c0c03753d3701806f54a8a2647087b7a8","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _cache_lldp_data(self, interface_names):"},{"line_number":427,"context_line":"        interface_names \u003d [name for name in interface_names if name !\u003d \u0027lo\u0027]"},{"line_number":428,"context_line":"        self.lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":429,"context_line":"        # convert the tlv value to hex"},{"line_number":430,"context_line":"        for ifname, tlvs in self.lldp_data.items():"},{"line_number":431,"context_line":"            for idx, tlv in enumerate(tlvs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_6832cef3","line":428,"in_reply_to":"bab6814e_f429909c","updated":"2016-05-26 10:30:40.000000000","message":"Done","commit_id":"d946a4c4695b46cc744d062f8938da7cfa0d6b06"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"d1bd4bf83ed75f354ef06a996de36589102c223d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.mac_address \u003d mac_addr"},{"line_number":193,"context_line":"        self.ipv4_address \u003d ipv4_address"},{"line_number":194,"context_line":"        self.has_carrier \u003d has_carrier"},{"line_number":195,"context_line":"        self.lldp \u003d lldp"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"class CPU(encoding.SerializableComparable):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_1ecc1869","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":24},"updated":"2016-05-26 11:19:54.000000000","message":"please update hardware inventory doc accordingly\n\n https://github.com/openstack/ironic-python-agent/blob/99f70370b7cbe7a89a2d23ec32d872bac36745ae/doc/source/index.rst#hardware-inventory","commit_id":"56e776bc3d280b2b2a3f22dd103069b78c9792ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"32d5db2a190a661ee1a946b1d326d0d0ae014987","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # convert the tlv value to hex"},{"line_number":433,"context_line":"        for ifname, tlvs in self.lldp_data.items():"},{"line_number":434,"context_line":"            for idx, tlv in enumerate(tlvs):"},{"line_number":435,"context_line":"                tlvs[idx] \u003d (tlv[0], binascii.hexlify(tlv[1]).decode())"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def _get_lldp_data(self, interface_name):"},{"line_number":438,"context_line":"        if self.lldp_data:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_4d245aae","line":435,"updated":"2016-05-31 08:31:56.000000000","message":"I don\u0027t think it\u0027s a good idea to alter object we\u0027re iterating over. Also I\u0027d prefer we convert it to some more readable format, maybe at least a dictionary rather than list of tuples?","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ea0c0503e3d6100b3d28f07b442a79c711c7fab3","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # convert the tlv value to hex"},{"line_number":433,"context_line":"        for ifname, tlvs in self.lldp_data.items():"},{"line_number":434,"context_line":"            for idx, tlv in enumerate(tlvs):"},{"line_number":435,"context_line":"                tlvs[idx] \u003d (tlv[0], binascii.hexlify(tlv[1]).decode())"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def _get_lldp_data(self, interface_name):"},{"line_number":438,"context_line":"        if self.lldp_data:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_96684a89","line":435,"range":{"start_line":435,"start_character":46,"end_line":435,"end_character":53},"updated":"2016-05-30 07:41:57.000000000","message":"Need to handle exceptions raised by hexlify. binascii.Error, binascii.Incomplete","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        # convert the tlv value to hex"},{"line_number":433,"context_line":"        for ifname, tlvs in self.lldp_data.items():"},{"line_number":434,"context_line":"            for idx, tlv in enumerate(tlvs):"},{"line_number":435,"context_line":"                tlvs[idx] \u003d (tlv[0], binascii.hexlify(tlv[1]).decode())"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def _get_lldp_data(self, interface_name):"},{"line_number":438,"context_line":"        if self.lldp_data:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_ad07b416","line":435,"in_reply_to":"9abb7d3a_4d245aae","updated":"2016-05-31 14:23:10.000000000","message":"I don\u0027t think a dict will work, because the key is the TLV type, and its possible to have multiple copies of the same TLV type containing different data in one packet. However I will definitely fix the modifying the thing we\u0027re iterating over part, we shouldn\u0027t be doing that. I\u0027ll also make sure to catch any errors from binascii.","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"32d5db2a190a661ee1a946b1d326d0d0ae014987","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        iface_names \u003d os.listdir(\u0027{0}/class/net\u0027.format(self.sys_path))"},{"line_number":479,"context_line":"        iface_names \u003d [name for name in iface_names if self._is_device(name)]"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        if CONF.lldp_in_inventory:"},{"line_number":482,"context_line":"            self._cache_lldp_data(iface_names)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        return [self._get_interface_info(name) for name in iface_names]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_ad3b46d0","line":481,"updated":"2016-05-31 08:31:56.000000000","message":".. and not self.lldp_data:","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        iface_names \u003d os.listdir(\u0027{0}/class/net\u0027.format(self.sys_path))"},{"line_number":479,"context_line":"        iface_names \u003d [name for name in iface_names if self._is_device(name)]"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        if CONF.lldp_in_inventory:"},{"line_number":482,"context_line":"            self._cache_lldp_data(iface_names)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        return [self._get_interface_info(name) for name in iface_names]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_60a2eefe","line":481,"in_reply_to":"9abb7d3a_ad3b46d0","updated":"2016-05-31 14:23:10.000000000","message":"I wondered if I should do this or not. I decided not as each time list_network_interfaces is run, it might produce a different list of interfaces because of slow drivers loading etc, so I think if its enabled then we should probably retry the caching with the new list of interfaces names. WDYT?","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6a05d448c79d0ff1c9441c254856b17f4d9b137","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                                           binascii.hexlify(data).decode()))"},{"line_number":441,"context_line":"                except (binascii.Error, binascii.Incomplete) as e:"},{"line_number":442,"context_line":"                    LOG.warning(\u0027An error occured while processing TLV type %s\u0027"},{"line_number":443,"context_line":"                                \u0027for interface %s: %s\u0027 % (typ, ifname, e))"},{"line_number":444,"context_line":"            self.lldp_data[ifname] \u003d processed_tlvs"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def _get_lldp_data(self, interface_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_8f08a329","line":443,"updated":"2016-06-01 13:46:44.000000000","message":"% -\u003e ,","commit_id":"acd81a065fd97b0e92c60a92c70417e7f50eba70"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"c77432a52066457aaf2da9fe3d03be3c8643f67d","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                                           binascii.hexlify(data).decode()))"},{"line_number":441,"context_line":"                except (binascii.Error, binascii.Incomplete) as e:"},{"line_number":442,"context_line":"                    LOG.warning(\u0027An error occured while processing TLV type %s\u0027"},{"line_number":443,"context_line":"                                \u0027for interface %s: %s\u0027 % (typ, ifname, e))"},{"line_number":444,"context_line":"            self.lldp_data[ifname] \u003d processed_tlvs"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def _get_lldp_data(self, interface_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_5188e7c6","line":443,"in_reply_to":"9abb7d3a_8f08a329","updated":"2016-06-02 10:58:51.000000000","message":"Done","commit_id":"acd81a065fd97b0e92c60a92c70417e7f50eba70"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b21a92655f8a173fc8fac5c95e280c7c24b11fbd","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        try:"},{"line_number":430,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":431,"context_line":"        except Exception:"},{"line_number":432,"context_line":"            return"},{"line_number":433,"context_line":"        # convert the tlv value to hex"},{"line_number":434,"context_line":"        self.lldp_data \u003d {}"},{"line_number":435,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_5521eab3","line":432,"updated":"2016-06-02 13:43:43.000000000","message":"Should we log the details of the exception?","commit_id":"2c3bde276ceb43cceb850568716754ab693f5165"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"02ea57bb25b775fbf38e57a7ee5e328c9c99da71","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            return"},{"line_number":448,"context_line":"        # convert the tlv value to hex"},{"line_number":449,"context_line":"        self.lldp_data \u003d {}"},{"line_number":450,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_f5d491e9","line":447,"updated":"2016-06-14 15:27:04.000000000","message":"a note would be handy that get_lldp_info already did logging for any exception. I nearly -1\u0027ed due to that :)","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4eb72283031ab59a4c3973bd017f397503a01cab","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            return"},{"line_number":448,"context_line":"        # convert the tlv value to hex"},{"line_number":449,"context_line":"        self.lldp_data \u003d {}"},{"line_number":450,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_7984e2b0","line":447,"in_reply_to":"7aa08908_5f70f473","updated":"2016-06-15 15:09:59.000000000","message":"How about adding a comment with what Mathieu mentions. So \u0027Keeping whatever lldp information was there because ...\u0027","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"306fdb6e13cbdf7dd7d602f14dc178d9cfa2cbd4","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            return"},{"line_number":448,"context_line":"        # convert the tlv value to hex"},{"line_number":449,"context_line":"        self.lldp_data \u003d {}"},{"line_number":450,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_5f70f473","line":447,"in_reply_to":"7aa08908_69525e6a","updated":"2016-06-15 11:48:00.000000000","message":"Given how this is lldp data and that it\u0027s used to discover physical peers, any currently collected lldp information is good to use and should not be invalidated. It is expected that physical topology does **not** change during inspection/profiling.","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a3703c789b0d4cdfd60715f97eb0c629757a91aa","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            return"},{"line_number":448,"context_line":"        # convert the tlv value to hex"},{"line_number":449,"context_line":"        self.lldp_data \u003d {}"},{"line_number":450,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_69525e6a","line":447,"in_reply_to":"7aa08908_abe3b7a2","updated":"2016-06-15 11:23:51.000000000","message":"Hmm, I originally thought that if _cache_lldp_data fails here it shouldn\u0027t touch self.lldp_data, i.e. only replace the variable once we know we have data to put in it. Now thinking about it again, I\u0027m not sure which I prefer.","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae273336a694edcbc58e99d71b2409256b1aa34d","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            return"},{"line_number":448,"context_line":"        # convert the tlv value to hex"},{"line_number":449,"context_line":"        self.lldp_data \u003d {}"},{"line_number":450,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_abe3b7a2","line":447,"in_reply_to":"7aa08908_f5d491e9","updated":"2016-06-14 21:40:17.000000000","message":"++\n\nThe other question I have is, if self.lldp_data is not None or {}, do you want to clear it or use whatever is there.","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"a3703c789b0d4cdfd60715f97eb0c629757a91aa","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            return"},{"line_number":448,"context_line":"        # convert the tlv value to hex"},{"line_number":449,"context_line":"        self.lldp_data \u003d {}"},{"line_number":450,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_4977a23b","line":447,"in_reply_to":"7aa08908_f5d491e9","updated":"2016-06-15 11:23:51.000000000","message":"Done","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae273336a694edcbc58e99d71b2409256b1aa34d","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                    processed_tlvs.append((typ,"},{"line_number":455,"context_line":"                                           binascii.hexlify(data).decode()))"},{"line_number":456,"context_line":"                except (binascii.Error, binascii.Incomplete) as e:"},{"line_number":457,"context_line":"                    LOG.warning(\u0027An error occured while processing TLV type %s\u0027"},{"line_number":458,"context_line":"                                \u0027for interface %s: %s\u0027, (typ, ifname, e))"},{"line_number":459,"context_line":"            self.lldp_data[ifname] \u003d processed_tlvs"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_4b8693b9","line":457,"updated":"2016-06-14 21:40:17.000000000","message":"s/occured/occurred/","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae273336a694edcbc58e99d71b2409256b1aa34d","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                                           binascii.hexlify(data).decode()))"},{"line_number":456,"context_line":"                except (binascii.Error, binascii.Incomplete) as e:"},{"line_number":457,"context_line":"                    LOG.warning(\u0027An error occured while processing TLV type %s\u0027"},{"line_number":458,"context_line":"                                \u0027for interface %s: %s\u0027, (typ, ifname, e))"},{"line_number":459,"context_line":"            self.lldp_data[ifname] \u003d processed_tlvs"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def _get_lldp_data(self, interface_name):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_8ba35b42","line":458,"updated":"2016-06-14 21:40:17.000000000","message":"missing blank space before \u0027for\u0027","commit_id":"d2c19710fbf1f664ff124ddcdda4056bddff95d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5cbc5ed3797b88183d6386f7e644fd2b6d25ba77","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            # The get_lldp_info function will log this exception"},{"line_number":448,"context_line":"            return"},{"line_number":449,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"},{"line_number":450,"context_line":"            # Convert each tlv value to hex so that it can be serialised safely"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_7e58d631","line":447,"updated":"2016-06-17 12:35:47.000000000","message":"nit: Ruby requested a comment that we don\u0027t remove cached data on failure","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6ac98db3129531891524382fb39b8a3a1c8dbf31","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        try:"},{"line_number":445,"context_line":"            raw_lldp_data \u003d netutils.get_lldp_info(interface_names)"},{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            # The get_lldp_info function will log this exception"},{"line_number":448,"context_line":"            return"},{"line_number":449,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"},{"line_number":450,"context_line":"            # Convert each tlv value to hex so that it can be serialised safely"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a9d85d2_54c72612","line":447,"in_reply_to":"7aa08908_7e58d631","updated":"2016-06-20 13:43:58.000000000","message":"Done","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"47f4c9f0e7ef17d8750ce04bd59ebdaa2c8882cc","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.ipv4_address \u003d ipv4_address"},{"line_number":195,"context_line":"        self.has_carrier \u003d has_carrier"},{"line_number":196,"context_line":"        self.lldp \u003d lldp"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class CPU(encoding.SerializableComparable):"},{"line_number":200,"context_line":"    serializable_fields \u003d (\u0027model_name\u0027, \u0027frequency\u0027, \u0027count\u0027, \u0027architecture\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_078f3e24","line":197,"updated":"2016-06-21 21:43:54.000000000","message":"While I know self.switch_port_descr have never been populated (and I have no code relying on it downstream), shouldn\u0027t this be considered an incompatible breaking change to folks writing hardware managers?","commit_id":"06a9c1e83f4c431f3867017180ed666fdbfcf4ba"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"118fafe1b948d22d693f57b1efcb68e49ac71306","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        except Exception:"},{"line_number":447,"context_line":"            # NOTE(sambetts) The get_lldp_info function will log this exception"},{"line_number":448,"context_line":"            # and we don\u0027t invalidate any existing data in the cache if we fail"},{"line_number":449,"context_line":"            # to get data to replace it so just return."},{"line_number":450,"context_line":"            return"},{"line_number":451,"context_line":"        for ifname, tlvs in raw_lldp_data.items():"},{"line_number":452,"context_line":"            # NOTE(sambetts) Convert each tlv value to hex so that it can be"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a9d85d2_6951690e","line":449,"updated":"2016-06-21 13:56:10.000000000","message":"I liked Mathieu\u0027s reason for *why* we aren\u0027t invalidating, but at least we have a comment. Thx.","commit_id":"06a9c1e83f4c431f3867017180ed666fdbfcf4ba"}],"ironic_python_agent/ironic_api_client.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"544b82db10df0c7c43a4c714c94a9baa05d084a0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            response \u003d self._request(\u0027POST\u0027, path, data\u003ddata)"},{"line_number":118,"context_line":"        except Exception as e:"},{"line_number":119,"context_line":"            print(e)"},{"line_number":120,"context_line":"            LOG.warning(\u0027POST failed: %s\u0027 % str(e))"},{"line_number":121,"context_line":"            return False"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5be1f6cf","line":119,"updated":"2016-05-24 17:23:57.000000000","message":"is this left over from debugging?","commit_id":"8362237f3523d071ef732de792f800b1b1387400"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4fcf3fdcb9271098ac4a402133aab7c06d6df291","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            response \u003d self._request(\u0027POST\u0027, path, data\u003ddata)"},{"line_number":118,"context_line":"        except Exception as e:"},{"line_number":119,"context_line":"            print(e)"},{"line_number":120,"context_line":"            LOG.warning(\u0027POST failed: %s\u0027 % str(e))"},{"line_number":121,"context_line":"            return False"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_673a389a","line":119,"in_reply_to":"bab6814e_5be1f6cf","updated":"2016-05-25 11:04:23.000000000","message":"Done","commit_id":"8362237f3523d071ef732de792f800b1b1387400"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b21a92655f8a173fc8fac5c95e280c7c24b11fbd","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                                               mocked_ifaddresses,"},{"line_number":313,"context_line":"                                               mocked_lldp_info):"},{"line_number":314,"context_line":"        CONF.set_override(\u0027collect_lldp\u0027, True)"},{"line_number":315,"context_line":"        mocked_listdir.return_value \u003d [\u0027lo\u0027, \u0027eth0\u0027]"},{"line_number":316,"context_line":"        mocked_exists.side_effect \u003d [False, True]"},{"line_number":317,"context_line":"        mocked_open.return_value.__enter__ \u003d lambda s: s"},{"line_number":318,"context_line":"        mocked_open.return_value.__exit__ \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_f0358ca8","line":315,"updated":"2016-06-02 13:43:43.000000000","message":"These nine lines seem to be duplicated in four tests - can you factor them out?","commit_id":"2c3bde276ceb43cceb850568716754ab693f5165"}],"ironic_python_agent/tests/unit/test_ironic_api_client.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ea0c0503e3d6100b3d28f07b442a79c711c7fab3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.hardware_info \u003d {"},{"line_number":42,"context_line":"            \u0027interfaces\u0027: ["},{"line_number":43,"context_line":"                hardware.NetworkInterface(\u0027eth0\u0027, \u002700:0c:29:8c:11:b1\u0027),"},{"line_number":44,"context_line":"                hardware.NetworkInterface(\u0027eth1\u0027, \u002700:0c:29:8c:11:b2\u0027),"},{"line_number":45,"context_line":"            ],"},{"line_number":46,"context_line":"            \u0027cpu\u0027: hardware.CPU(\u0027Awesome Jay CPU x10 9001\u0027, \u00279001\u0027, \u002710\u0027,"},{"line_number":47,"context_line":"                                \u0027ARMv9\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_9c9b4972","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":69},"updated":"2016-05-30 07:41:57.000000000","message":"Better to add lldp data to one of the interface and test it.","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.hardware_info \u003d {"},{"line_number":42,"context_line":"            \u0027interfaces\u0027: ["},{"line_number":43,"context_line":"                hardware.NetworkInterface(\u0027eth0\u0027, \u002700:0c:29:8c:11:b1\u0027),"},{"line_number":44,"context_line":"                hardware.NetworkInterface(\u0027eth1\u0027, \u002700:0c:29:8c:11:b2\u0027),"},{"line_number":45,"context_line":"            ],"},{"line_number":46,"context_line":"            \u0027cpu\u0027: hardware.CPU(\u0027Awesome Jay CPU x10 9001\u0027, \u00279001\u0027, \u002710\u0027,"},{"line_number":47,"context_line":"                                \u0027ARMv9\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_804c329f","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":69},"in_reply_to":"9abb7d3a_9c9b4972","updated":"2016-05-31 14:23:10.000000000","message":"Done","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ea0c0503e3d6100b3d28f07b442a79c711c7fab3","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    u\u0027name\u0027: u\u0027eth1\u0027,"},{"line_number":168,"context_line":"                    u\u0027ipv4_address\u0027: None,"},{"line_number":169,"context_line":"                    u\u0027has_carrier\u0027: True,"},{"line_number":170,"context_line":"                    u\u0027lldp\u0027: None,"},{"line_number":171,"context_line":"                }"},{"line_number":172,"context_line":"            ],"},{"line_number":173,"context_line":"            u\u0027cpu\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_5c78c12b","line":170,"range":{"start_line":170,"start_character":20,"end_line":170,"end_character":34},"updated":"2016-05-30 07:41:57.000000000","message":"Better to test by passing some valid lldp data to one of the interface.","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e2759085e467006a489e835ac2e3486327ef095d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    u\u0027name\u0027: u\u0027eth1\u0027,"},{"line_number":168,"context_line":"                    u\u0027ipv4_address\u0027: None,"},{"line_number":169,"context_line":"                    u\u0027has_carrier\u0027: True,"},{"line_number":170,"context_line":"                    u\u0027lldp\u0027: None,"},{"line_number":171,"context_line":"                }"},{"line_number":172,"context_line":"            ],"},{"line_number":173,"context_line":"            u\u0027cpu\u0027: {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_207d86b1","line":170,"range":{"start_line":170,"start_character":20,"end_line":170,"end_character":34},"in_reply_to":"9abb7d3a_5c78c12b","updated":"2016-05-31 14:23:10.000000000","message":"Done","commit_id":"99d717e3d52dae0d52940aface2717c998087e8c"}],"releasenotes/notes/support-lldp-in-inventory-4ab6e45ccd35dace.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5cbc5ed3797b88183d6386f7e644fd2b6d25ba77","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    collect_lldp is set to True. Each interface returned in the inventory that"},{"line_number":5,"context_line":"    receives an LLDP packet will contain the whole LLDP packet represented as a"},{"line_number":6,"context_line":"    list of TLVs in the field \u0027lldp\u0027."},{"line_number":7,"context_line":"  - Remove reserved fields switch_port_descr and switch_chassis_descr in favor"},{"line_number":8,"context_line":"    of returning the whole LLDP packet for each interface so that IPA"},{"line_number":9,"context_line":"    processing of this data remains generic and full processing can be"},{"line_number":10,"context_line":"    customised server side instead of having to create custom ramdisks."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7aa08908_9e530216","line":7,"updated":"2016-06-17 12:35:47.000000000","message":"this should go in upgrade section","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"6ac98db3129531891524382fb39b8a3a1c8dbf31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    collect_lldp is set to True. Each interface returned in the inventory that"},{"line_number":5,"context_line":"    receives an LLDP packet will contain the whole LLDP packet represented as a"},{"line_number":6,"context_line":"    list of TLVs in the field \u0027lldp\u0027."},{"line_number":7,"context_line":"  - Remove reserved fields switch_port_descr and switch_chassis_descr in favor"},{"line_number":8,"context_line":"    of returning the whole LLDP packet for each interface so that IPA"},{"line_number":9,"context_line":"    processing of this data remains generic and full processing can be"},{"line_number":10,"context_line":"    customised server side instead of having to create custom ramdisks."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5a9d85d2_14fd9e3a","line":7,"in_reply_to":"7aa08908_9e530216","updated":"2016-06-20 13:43:58.000000000","message":"Done","commit_id":"534363ce49687f0bc59e4c73783b87c43c695d13"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"aa04159af0560e91809c171d58d0455ed9d8b09b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    receives an LLDP packet will contain the whole LLDP packet represented as a"},{"line_number":6,"context_line":"    list of TLVs in the field \u0027lldp\u0027."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - Deprecated reserved fields switch_port_descr and switch_chassis_descr in"},{"line_number":9,"context_line":"    favor of returning the whole LLDP packet for each interface so that IPA"},{"line_number":10,"context_line":"    processing of this data remains generic and full processing can be"},{"line_number":11,"context_line":"    customised server side instead of having to create custom ramdisks."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3aaa91ec_24ffaa68","line":8,"updated":"2016-06-22 14:41:17.000000000","message":"might be useful to mention that they will be removed in Ocata.","commit_id":"fc9b62ce0ac7ab85b09b5352320b0f56160f2389"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"4a09e8bfeecf2fd902960116679984564b922f2e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    receives an LLDP packet will contain the whole LLDP packet represented as a"},{"line_number":6,"context_line":"    list of TLVs in the field \u0027lldp\u0027."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - Deprecated reserved fields switch_port_descr and switch_chassis_descr in"},{"line_number":9,"context_line":"    favor of returning the whole LLDP packet for each interface so that IPA"},{"line_number":10,"context_line":"    processing of this data remains generic and full processing can be"},{"line_number":11,"context_line":"    customised server side instead of having to create custom ramdisks."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3aaa91ec_e1662928","line":8,"in_reply_to":"3aaa91ec_24ffaa68","updated":"2016-06-22 17:26:29.000000000","message":"Done","commit_id":"fc9b62ce0ac7ab85b09b5352320b0f56160f2389"}]}