)]}'
{"id":"openstack%2Fironic-python-agent~323050","triplet_id":"openstack%2Fironic-python-agent~master~Ibb675d4496d7814778f3bab9c161734013479116","project":"openstack/ironic-python-agent","branch":"master","topic":"root-device-hints","hashtags":[],"change_id":"Ibb675d4496d7814778f3bab9c161734013479116","subject":"Remove unused SUPPORTED_ROOT_DEVICE_HINTS","status":"MERGED","created":"2016-05-31 01:52:07.000000000","updated":"2016-06-02 09:04:16.000000000","submitted":"2016-06-02 09:04:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8328a339fe2a9c5415a9dffc7fc95b1fa29f236e","_number":323050,"virtual_id_number":323050,"owner":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":2,"date":"2016-06-02 09:04:16.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"recommended":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"all":[{"value":1,"date":"2016-06-02 02:35:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-31 14:01:02.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":2,"date":"2016-05-31 08:06:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"all":[{"value":0,"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-06-02 08:38:18.000000000","_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-31 08:06:58.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-06-02 02:35:41.000000000","updated_by":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"reviewer":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"state":"REVIEWER"},{"updated":"2016-06-02 08:38:18.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2016-06-02 09:04:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b63050952b434b5550ea54ae5493dd476d43eb2a","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2016-05-31 01:52:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2bd72deb5553ca29269c1a986c60d1f3f487d4a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-31 02:39:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/50/323050/1/check/gate-ironic-python-agent-docs/2bdfd24//doc/build/html/ : SUCCESS in 1m 58s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/50/323050/1/check/gate-ironic-python-agent-pep8/8a394c2/ : SUCCESS in 2m 03s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/50/323050/1/check/gate-ironic-python-agent-python27/9e09f43/ : SUCCESS in 1m 32s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/50/323050/1/check/gate-ironic-python-agent-python34/890b1e6/ : SUCCESS in 2m 35s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/50/323050/1/check/gate-tempest-dsvm-ironic-agent_ssh-src/a0e03a3/ : SUCCESS in 40m 13s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/50/323050/1/check/gate-tempest-dsvm-ironic-pxe_ipa-src/a329011/ : SUCCESS in 41m 12s\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/50/323050/1/check/gate-ironic-inspector-dsvm-ipa-src-nv/f4474ae/ : SUCCESS in 42m 06s (non-voting)\n- gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv http://logs.openstack.org/50/323050/1/check/gate-tempest-dsvm-ironic-pxe_ipa-tinyipa-src-nv/882f540/ : SUCCESS in 43m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"eb88bc022bd93cd29540eec91d8b359759f2e2f7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-05-31 08:06:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fb1c505bf5f981113cae86d14dfdf02c87b91e4c","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2016-05-31 09:31:07.000000000","message":"Patch Set 1: Code-Review-1\n\nSUPPORTED_ROOT_DEVICE_HINTS was not used any more. But I think we should use it instead of delete it.\nSo previously, utils.parse_root_device_hints() will validate the hints and normalize the value, which is useful to see if the hints are supported by this version of IPA. But currently IPA will take anything from nodes, so is there a plan to let ironic do the validation and normalization?","accounts_in_message":[],"_revision_number":1},{"id":"67035e7b0f36dab975eb513d9d5bd8605e1d9a2c","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-05-31 11:41:56.000000000","message":"Patch Set 1:\n\nTan Lin, https://github.com/openstack/ironic/blob/293759c7f16e156dfbb80729ecf1c9a99d33065f/ironic/drivers/modules/deploy_utils.py#L714-L720. We have to make sure we don\u0027t accidentally remove this bit when removing support for the old ramdisk.","accounts_in_message":[],"_revision_number":1},{"id":"5ac1e8f48e290be2c6aa12abc0c0272838986e9a","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-05-31 14:01:02.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks Ruby,\n\n@Tan thanks for the comment, yeah as @dmitry pointed out Ironic already does validate such hints and we should keep doing that. Ironic is our source of truth in this case and the ramdisk should assume that the information contained in the node is correct (the driver deploy interface is validated prior to a the deployment to start).","accounts_in_message":[],"_revision_number":1},{"id":"2ac847c6c1942e3ef8f6867ef3b7e61bb32f5b76","author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"date":"2016-06-02 02:35:41.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks to the link, Dmitry and thanks to explain Lucas.\nThis make sense to me.","accounts_in_message":[],"_revision_number":1},{"id":"798c809bdad9107ca6e1deac8121818779300f79","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-06-02 08:38:18.000000000","message":"Patch Set 1: Workflow+1\n\nCool thanks @Tan,\n\nApproving it now then :-)","accounts_in_message":[],"_revision_number":1},{"id":"6c51bb8c2484e1158bd89c8f6200e940e04c00d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-02 08:38:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e19e40663a0e39c921356c5e7aae216eb50ba624","date":"2016-06-02 09:04:16.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"1798ae5b7ae8c4097629e7e5fc6039903ff29569","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-02 09:04:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/50/323050/1/gate/gate-ironic-python-agent-docs/3bcdf95//doc/build/html/ : SUCCESS in 4m 03s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/50/323050/1/gate/gate-ironic-python-agent-pep8/281578d/ : SUCCESS in 2m 42s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/50/323050/1/gate/gate-ironic-python-agent-python27/5a849f2/ : SUCCESS in 3m 42s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/50/323050/1/gate/gate-ironic-python-agent-python34/1237c30/ : SUCCESS in 2m 58s\n- gate-tempest-dsvm-ironic-agent_ssh-src http://logs.openstack.org/50/323050/1/gate/gate-tempest-dsvm-ironic-agent_ssh-src/a34f6da/ : SUCCESS in 25m 11s\n- gate-tempest-dsvm-ironic-pxe_ipa-src http://logs.openstack.org/50/323050/1/gate/gate-tempest-dsvm-ironic-pxe_ipa-src/2afbadc/ : SUCCESS in 24m 26s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cc0733c34801dd559a24a22c15f99ff31ae9d359","revisions":{"cc0733c34801dd559a24a22c15f99ff31ae9d359":{"kind":"REWORK","_number":1,"created":"2016-05-31 01:52:07.000000000","uploader":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"ref":"refs/changes/50/323050/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/50/323050/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/323050/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/323050/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/323050/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/323050/1"}}},"commit":{"parents":[{"commit":"01d49886aca3175f6eaaf1e5f62183cc31a49249","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/01d49886aca3175f6eaaf1e5f62183cc31a49249"}]}],"author":{"name":"Ruby Loo","email":"ruby.loo@intel.com","date":"2016-05-31 01:50:14.000000000","tz":-240},"committer":{"name":"Ruby Loo","email":"ruby.loo@intel.com","date":"2016-05-31 01:50:14.000000000","tz":-240},"subject":"Remove unused SUPPORTED_ROOT_DEVICE_HINTS","message":"Remove unused SUPPORTED_ROOT_DEVICE_HINTS\n\nutils.SUPPORTED_ROOT_DEVICE_HINTS is no longer being used so\ndelete it. (The method that used it was removed in\n33535cd572b90a817b9c96b42a0d2fe54751351d).\n\nChange-Id: Ibb675d4496d7814778f3bab9c161734013479116\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cc0733c34801dd559a24a22c15f99ff31ae9d359"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cc0733c34801dd559a24a22c15f99ff31ae9d359"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}