)]}'
{"ironic_python_agent/config.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b585d0f48e6e80ab0c47a8e78904e357deaa8617","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               help\u003d\u0027The Ironic driver in use for this node\u0027),"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.FloatOpt(\u0027lldp_timeout\u0027,"},{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027ipa-lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_4a7132e0","line":91,"updated":"2016-06-02 19:20:24.000000000","message":"We\u0027re going to have to deprecate the old option properly and make this support both of them.","commit_id":"b97f6ccd3ef248bedf84ba2112e1738398d9c5ca"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"cf25a9c74460fb9a7197f766d80a511c8f7071fa","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               help\u003d\u0027The Ironic driver in use for this node\u0027),"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.FloatOpt(\u0027lldp_timeout\u0027,"},{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027ipa-lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_fd21c9b5","line":91,"in_reply_to":"9abb7d3a_4a7132e0","updated":"2016-06-02 21:17:56.000000000","message":"Done","commit_id":"b97f6ccd3ef248bedf84ba2112e1738398d9c5ca"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"192f00bae8ce1c124f6cbc27c0f916daf662dab8","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.FloatOpt(\u0027lldp_timeout\u0027,"},{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027ipa-lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 deprecated_name\u003d\u0027lldp-timeout\u0027,"},{"line_number":93,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_e05762c8","line":92,"updated":"2016-06-02 21:25:23.000000000","message":"This isn\u0027t going to work; APARAMS setting the default is sort of taking an end-around oslo.config. As far as the config module is concerned, the config is and has always been named lldp_timeout.\n\nYou\u0027ll probably need to check if APARAMS.get(\u0027ipa-lldp-timeout\u0027) is none, if so, check APARAMS.get(\u0027lldp-timeout\u0027), and if that is none have it fall back to 30.0 as the default.","commit_id":"3dbb1638d2d3d46708db152638eaa650049b3168"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c305bbe1977e3e5d37111cae00d253ebb0259213","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.FloatOpt(\u0027lldp_timeout\u0027,"},{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027ipa-lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 deprecated_name\u003d\u0027lldp-timeout\u0027,"},{"line_number":93,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_e6081a2b","line":92,"in_reply_to":"9abb7d3a_23f8547c","updated":"2016-06-02 22:02:52.000000000","message":"Ah, I believe those were actually renamed from their old oslo equivalents, not from the kernel command line params. See: https://github.com/openstack/ironic-python-agent/commit/597d6245b159ecd46e27e60c5df6469db48b9700#diff-861749ac6442d4c56da06a2564db703e","commit_id":"3dbb1638d2d3d46708db152638eaa650049b3168"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1db6afe8d56b0fc5526fb5d629f6c392201450f8","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.FloatOpt(\u0027lldp_timeout\u0027,"},{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027ipa-lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 deprecated_name\u003d\u0027lldp-timeout\u0027,"},{"line_number":93,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_23f8547c","line":92,"in_reply_to":"9abb7d3a_c3b4e8d2","updated":"2016-06-02 21:52:37.000000000","message":"You\u0027re exactly right. Yikes. :(","commit_id":"3dbb1638d2d3d46708db152638eaa650049b3168"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"5965cd9b21f2c4b5f8626263e95a40b423f25e3c","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.FloatOpt(\u0027lldp_timeout\u0027,"},{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027ipa-lldp-timeout\u0027, 30.0),"},{"line_number":92,"context_line":"                 deprecated_name\u003d\u0027lldp-timeout\u0027,"},{"line_number":93,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_c3b4e8d2","line":92,"in_reply_to":"9abb7d3a_e05762c8","updated":"2016-06-02 21:51:25.000000000","message":"Don\u0027t the deprecated options above have this problem as well?","commit_id":"3dbb1638d2d3d46708db152638eaa650049b3168"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3f0c83ac6490e05ad56219b48bb8eb1fd7870b94","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.FloatOpt(\u0027lldp_timeout\u0027,"},{"line_number":91,"context_line":"                 default\u003dAPARAMS.get(\u0027ipa-lldp-timeout\u0027,"},{"line_number":92,"context_line":"                                     APARAMS.get(\u0027lldp-timeout\u0027, 30.0)),"},{"line_number":93,"context_line":"                 help\u003d\u0027The amount of seconds to wait for LLDP packets.\u0027),"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027standalone\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_ffaa3d84","line":92,"updated":"2016-06-03 11:32:18.000000000","message":"++ this looks good.\n\nI\u0027d say we should log a deprecation warning in utils.get_agent_params() if we see \u0027lldp-timeout\u0027. I know IPA logs aren\u0027t usually looked at, but I\u0027m not really sure what more we can do. :)","commit_id":"7ee974313d873922e57535b427095f62cd602120"}],"ironic_python_agent/utils.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4378b46175e695471b2260c9e3ea73676d1fdd5b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        deprecated_params \u003d {\u0027lldp-timeout\u0027: \u0027ipa-lldp-timeout\u0027}"},{"line_number":222,"context_line":"        for old_param, new_param in deprecated_params.items():"},{"line_number":223,"context_line":"            if params.get(old_param) is not None:"},{"line_number":224,"context_line":"                LOG.warning(\"The parameter \u0027%s\u0027 has been deprecated. Please \""},{"line_number":225,"context_line":"                            \"use %s instead.\", old_param, new_param)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    return copy.deepcopy(params)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_58aeed85","line":224,"updated":"2016-06-03 16:23:41.000000000","message":"This needs a _LW(): http://docs.openstack.org/developer/oslo.i18n/guidelines.html#log-translation","commit_id":"90c15e10cb9b532b41aaf7102a31d9d9e4beb85e"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"ee333bfc57c3cba1a785d1ea16d84f08ad5779ba","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        deprecated_params \u003d {\u0027lldp-timeout\u0027: \u0027ipa-lldp-timeout\u0027}"},{"line_number":222,"context_line":"        for old_param, new_param in deprecated_params.items():"},{"line_number":223,"context_line":"            if params.get(old_param) is not None:"},{"line_number":224,"context_line":"                LOG.warning(\"The parameter \u0027%s\u0027 has been deprecated. Please \""},{"line_number":225,"context_line":"                            \"use %s instead.\", old_param, new_param)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    return copy.deepcopy(params)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_ec3f2623","line":224,"in_reply_to":"9abb7d3a_58aeed85","updated":"2016-06-03 16:42:17.000000000","message":"It looks like These log translation functions haven\u0027t been included in this project at all and are not yet being used anywhere?","commit_id":"90c15e10cb9b532b41aaf7102a31d9d9e4beb85e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"944260ea59fb623c117a3506cdb1a0a037137fdd","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        deprecated_params \u003d {\u0027lldp-timeout\u0027: \u0027ipa-lldp-timeout\u0027}"},{"line_number":222,"context_line":"        for old_param, new_param in deprecated_params.items():"},{"line_number":223,"context_line":"            if params.get(old_param) is not None:"},{"line_number":224,"context_line":"                LOG.warning(\"The parameter \u0027%s\u0027 has been deprecated. Please \""},{"line_number":225,"context_line":"                            \"use %s instead.\", old_param, new_param)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    return copy.deepcopy(params)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_9b120a08","line":224,"in_reply_to":"9abb7d3a_ec3f2623","updated":"2016-06-03 18:12:14.000000000","message":"Agreed; we don\u0027t translate IPA logs today. If we should change that decision, I\u0027m game for it, but we should do it all at once and then start enforcing it :)","commit_id":"90c15e10cb9b532b41aaf7102a31d9d9e4beb85e"}],"releasenotes/notes/prefix-lldp-timeout-50acc656313d8dd2.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"25da753c79d11133235b33318df577c590023d1e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Every other Ironic python agent kernel parameter is prefixed with \"ipa-\"."},{"line_number":4,"context_line":"    This patch allows users to use the old \"lldp-timeout\" parameter or the"},{"line_number":5,"context_line":"    new \"ipa-lldp-timeout\" parameter."},{"line_number":6,"context_line":"  - Correct typo on line 61 (\"amaount\" should be \"amount\")."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_266d0233","line":6,"updated":"2016-06-02 22:22:09.000000000","message":"This can be removed if you have a future patchset; these are more for operator consumption and they probably don\u0027t care.","commit_id":"7ee974313d873922e57535b427095f62cd602120"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3f0c83ac6490e05ad56219b48bb8eb1fd7870b94","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Every other Ironic python agent kernel parameter is prefixed with \"ipa-\"."},{"line_number":4,"context_line":"    This patch allows users to use the old \"lldp-timeout\" parameter or the"},{"line_number":5,"context_line":"    new \"ipa-lldp-timeout\" parameter."},{"line_number":6,"context_line":"  - Correct typo on line 61 (\"amaount\" should be \"amount\")."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_5f1549e3","line":6,"in_reply_to":"9abb7d3a_266d0233","updated":"2016-06-03 11:32:18.000000000","message":"++","commit_id":"7ee974313d873922e57535b427095f62cd602120"}]}