)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ddcba29b1d61f791dfb82d632fbc53356e4168f2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"appropriate PCI devices."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id7521d66410e7d408d7eada692b6123e769ce084"},{"line_number":17,"context_line":"Partial-Bug: #1580893"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3aaa91ec_a1080f29","line":17,"updated":"2016-06-25 09:46:28.000000000","message":"it should be closes-bug unless you need more patches to *this* project (IPA).","commit_id":"f7e080c8bfeae354b4ca17e41663f8b84c4e7e1a"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1da26046aa6ec68d9ae66f8f505b420f955376d5","unresolved":false,"context_lines":[{"line_number":651,"context_line":"                        pxe_interface\u003dpxe_interface)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def get_pci_devices_info(self):"},{"line_number":654,"context_line":"        pci_devices_path \u003d \u0027/sys/bus/pci/devices\u0027"},{"line_number":655,"context_line":"        pci_devices_info \u003d []"},{"line_number":656,"context_line":"        for _, dirnames, _ in os.walk(pci_devices_path):"},{"line_number":657,"context_line":"            for subdir in dirnames:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5186cf65","line":654,"range":{"start_line":654,"start_character":7,"end_line":654,"end_character":49},"updated":"2016-06-07 09:30:57.000000000","message":"We may need to wait for the pci devices to be available if inspection is attempted.","commit_id":"829c3544b20f01e90f25b0ef0410fca03295850e"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1da26046aa6ec68d9ae66f8f505b420f955376d5","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                    vendor \u003d vendor_file.read().strip().split(\u0027x\u0027)[1]"},{"line_number":661,"context_line":"                with open(\u0027/\u0027.join([pci_devices_path, subdir,"},{"line_number":662,"context_line":"                                    \u0027device\u0027])) as vendor_device:"},{"line_number":663,"context_line":"                    device \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":664,"context_line":"                LOG.debug("},{"line_number":665,"context_line":"                    \u0027Found a pci device with vendor id %s and product id %s\u0027,"},{"line_number":666,"context_line":"                    vendor, device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7f4e3797","line":663,"updated":"2016-06-07 09:30:57.000000000","message":"Need to handle exception cases here. It\u0027s possible that inspection may be attempted even before the system is stabilized resulting in no path.","commit_id":"829c3544b20f01e90f25b0ef0410fca03295850e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"355f685a257349e51263f017915675a8e62f1fce","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def __init__(self, vendor_id, product_id):"},{"line_number":240,"context_line":"        self.vendor_id \u003d vendor_id"},{"line_number":241,"context_line":"        self.product_id \u003d product_id"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_587652d9","line":241,"updated":"2016-06-09 12:42:15.000000000","message":"this class is not used in this module and should not be defined here IMO","commit_id":"3bd91476dbc5f7f2c81a61d0f1372dc23997c030"}],"ironic_python_agent/inspector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"355f685a257349e51263f017915675a8e62f1fce","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                    device \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":412,"context_line":"            except IOError:"},{"line_number":413,"context_line":"                LOG.warning(\u0027Failed to gather vendor id or product id \u0027"},{"line_number":414,"context_line":"                            \u0027from pci device %s\u0027, subdir)"},{"line_number":415,"context_line":"                continue"},{"line_number":416,"context_line":"            except IndexError:"},{"line_number":417,"context_line":"                LOG.warning(\u0027Wrong format of vendor id or product id in pci \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_387386e9","line":414,"updated":"2016-06-09 12:42:15.000000000","message":"1. please upper-case PCI in log messages\n\n2. please include the original error message in the log, like:\n\n except IOError as exc:\n     LOG.warning(\u0027Failed to gather vendor ID or product ID from PCI device %s: %s\u0027,\n                 subdir, exc)","commit_id":"3bd91476dbc5f7f2c81a61d0f1372dc23997c030"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"355f685a257349e51263f017915675a8e62f1fce","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            LOG.debug("},{"line_number":421,"context_line":"                \u0027Found a pci device with vendor id %s and product id %s\u0027,"},{"line_number":422,"context_line":"                vendor, device)"},{"line_number":423,"context_line":"            pci_devices_info.append(hardware.PciDeviceInfo(vendor, device))"},{"line_number":424,"context_line":"    except OSError as exc:"},{"line_number":425,"context_line":"        msg \u003d \u0027Failed to get list of PCI devices: %s\u0027"},{"line_number":426,"context_line":"        failures.add(msg, exc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9880ba8d","line":423,"updated":"2016-06-09 12:42:15.000000000","message":"I think you could just use a dict instead of introducing a new PciDeviceInfo class, as it\u0027s not part of the hardware inventory.","commit_id":"3bd91476dbc5f7f2c81a61d0f1372dc23997c030"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"355f685a257349e51263f017915675a8e62f1fce","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            pci_devices_info.append(hardware.PciDeviceInfo(vendor, device))"},{"line_number":424,"context_line":"    except OSError as exc:"},{"line_number":425,"context_line":"        msg \u003d \u0027Failed to get list of PCI devices: %s\u0027"},{"line_number":426,"context_line":"        failures.add(msg, exc)"},{"line_number":427,"context_line":"    data[\u0027pci_devices\u0027] \u003d pci_devices_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_787d0eb1","line":426,"updated":"2016-06-09 12:42:15.000000000","message":"what do you try to achieve here? you\u0027re catching some exceptions in the loop without a failure. I suggest you move this try..except block to cover only the relevant code","commit_id":"3bd91476dbc5f7f2c81a61d0f1372dc23997c030"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"69681da6facccf9d13a544fcf23d6ad0201c354e","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            pci_devices_info.append(hardware.PciDeviceInfo(vendor, device))"},{"line_number":424,"context_line":"    except OSError as exc:"},{"line_number":425,"context_line":"        msg \u003d \u0027Failed to get list of PCI devices: %s\u0027"},{"line_number":426,"context_line":"        failures.add(msg, exc)"},{"line_number":427,"context_line":"    data[\u0027pci_devices\u0027] \u003d pci_devices_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_d1aca937","line":426,"in_reply_to":"7aa08908_787d0eb1","updated":"2016-06-10 09:20:46.000000000","message":"That try..except block catches error from os.listdir method. It can be caught when, for example, system has not mounted yet /sys filesystem. The errors inside the loop are not so relevant as that one, as they refer to the single PCI device entry and can be only warnings.","commit_id":"3bd91476dbc5f7f2c81a61d0f1372dc23997c030"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f38fd72261bccbd147dad5f0c5176cd810d3ddda","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                vendor, device)"},{"line_number":426,"context_line":"            pci_devices_info.append({\u0027vendor_id\u0027: vendor,"},{"line_number":427,"context_line":"                                     \u0027product_id\u0027: device})"},{"line_number":428,"context_line":"    except OSError as exc:"},{"line_number":429,"context_line":"        msg \u003d \u0027Failed to get list of PCI devices: %s\u0027"},{"line_number":430,"context_line":"        failures.add(msg, exc)"},{"line_number":431,"context_line":"    data[\u0027pci_devices\u0027] \u003d pci_devices_info"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_49e2cd02","line":430,"range":{"start_line":428,"start_character":4,"end_line":430,"end_character":30},"updated":"2016-06-10 09:21:54.000000000","message":"this comment was not addressed. if it catches an exception from listdir, please move it to where listdir is","commit_id":"63a22d667bb416c2ec873f36bfb2cb25b16ea954"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"6a01546fdffea086a9363f6e5e1c6b0f312c7122","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                vendor, device)"},{"line_number":426,"context_line":"            pci_devices_info.append({\u0027vendor_id\u0027: vendor,"},{"line_number":427,"context_line":"                                     \u0027product_id\u0027: device})"},{"line_number":428,"context_line":"    except OSError as exc:"},{"line_number":429,"context_line":"        msg \u003d \u0027Failed to get list of PCI devices: %s\u0027"},{"line_number":430,"context_line":"        failures.add(msg, exc)"},{"line_number":431,"context_line":"    data[\u0027pci_devices\u0027] \u003d pci_devices_info"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_4c1bfb1c","line":430,"range":{"start_line":428,"start_character":4,"end_line":430,"end_character":30},"in_reply_to":"7aa08908_49e2cd02","updated":"2016-06-10 09:37:03.000000000","message":"Listdir is called in loop which is wrapped by that try..except. I do not understand your idea here. I changed this in latest patch - extracted listdir to variable.","commit_id":"63a22d667bb416c2ec873f36bfb2cb25b16ea954"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbedd4d85727305f261d2473466e78cacdc51554","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    except OSError as exc:"},{"line_number":404,"context_line":"        msg \u003d \u0027Failed to get list of PCI devices: %s\u0027"},{"line_number":405,"context_line":"        failures.add(msg, exc)"},{"line_number":406,"context_line":"        data[\u0027pci_devices\u0027] \u003d []"},{"line_number":407,"context_line":"        return"},{"line_number":408,"context_line":"    for subdir in subdirs:"},{"line_number":409,"context_line":"        if not os.path.isdir(os.path.join(pci_devices_path, subdir)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_50e8a97c","line":406,"range":{"start_line":406,"start_character":8,"end_line":406,"end_character":32},"updated":"2016-06-10 12:08:07.000000000","message":"nit: this is not really required. inspector will anyway have to be prepared to not receive any pci_devices","commit_id":"4f4189c62124aaa105acd2b7c896fa52d8b7f4b9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1cf689b8015adec8ecb2004671f983e9d3f01c2","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        msg \u003d \u0027Failed to get list of PCI devices: %s\u0027"},{"line_number":405,"context_line":"        failures.add(msg, exc)"},{"line_number":406,"context_line":"        return"},{"line_number":407,"context_line":"    for subdir in subdirs:"},{"line_number":408,"context_line":"        if not os.path.isdir(os.path.join(pci_devices_path, subdir)):"},{"line_number":409,"context_line":"            continue"},{"line_number":410,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_bc9b4d72","line":407,"updated":"2016-06-17 22:58:10.000000000","message":"nit / style:\n\n subdir_path \u003d os.path.join(pci_devices_path, subdir)\n if not os.path.isdir(subdir_path):\n    continue\n\nAnd then below it maybe looks nicer.\n\nPure nit though.","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1cf689b8015adec8ecb2004671f983e9d3f01c2","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            # we only need that part after \u0027x\u0027 delimiter"},{"line_number":414,"context_line":"            with open(os.path.join(pci_devices_path, subdir,"},{"line_number":415,"context_line":"                                   \u0027vendor\u0027)) as vendor_file:"},{"line_number":416,"context_line":"                vendor \u003d vendor_file.read().strip().split(\u0027x\u0027)[1]"},{"line_number":417,"context_line":"            with open(os.path.join(pci_devices_path, subdir,"},{"line_number":418,"context_line":"                                   \u0027device\u0027)) as vendor_device:"},{"line_number":419,"context_line":"                device \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_3cfabd77","line":416,"updated":"2016-06-17 22:58:10.000000000","message":"Maybe? I\u0027m not sure though.\n\n vendor_file.read().strip()[1:]","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"e2028dc334eaa3b98c4774abfd61c53be502801c","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            # we only need that part after \u0027x\u0027 delimiter"},{"line_number":414,"context_line":"            with open(os.path.join(pci_devices_path, subdir,"},{"line_number":415,"context_line":"                                   \u0027vendor\u0027)) as vendor_file:"},{"line_number":416,"context_line":"                vendor \u003d vendor_file.read().strip().split(\u0027x\u0027)[1]"},{"line_number":417,"context_line":"            with open(os.path.join(pci_devices_path, subdir,"},{"line_number":418,"context_line":"                                   \u0027device\u0027)) as vendor_device:"},{"line_number":419,"context_line":"                device \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_91b17792","line":416,"in_reply_to":"7aa08908_3cfabd77","updated":"2016-06-21 07:30:05.000000000","message":"It will return id with the preceding \u0027x\u0027, so it is not correct. I can though place \u00272\u0027 instead of \u00271\u0027:\nvendor_file.read().strip()[2:]","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1cf689b8015adec8ecb2004671f983e9d3f01c2","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                device \u003d vendor_device.read().strip().split(\u0027x\u0027)[1]"},{"line_number":420,"context_line":"        except IOError as exc:"},{"line_number":421,"context_line":"            LOG.warning(\u0027Failed to gather vendor id or product id \u0027"},{"line_number":422,"context_line":"                        \u0027from PCI device %s: %s\u0027, subdir, exc)"},{"line_number":423,"context_line":"            continue"},{"line_number":424,"context_line":"        except IndexError as exc:"},{"line_number":425,"context_line":"            LOG.warning(\u0027Wrong format of vendor id or product id in PCI \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_9c4771a2","line":422,"updated":"2016-06-17 22:58:10.000000000","message":"I would think the \u0027subdir_path\u0027 variable idea I mentioned would make this log message better in my opinion.","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1cf689b8015adec8ecb2004671f983e9d3f01c2","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            \u0027Found a PCI device with vendor id %s and product id %s\u0027,"},{"line_number":430,"context_line":"            vendor, device)"},{"line_number":431,"context_line":"        pci_devices_info.append({\u0027vendor_id\u0027: vendor,"},{"line_number":432,"context_line":"                                 \u0027product_id\u0027: device})"},{"line_number":433,"context_line":"    data[\u0027pci_devices\u0027] \u003d pci_devices_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_1cd261d1","line":432,"updated":"2016-06-17 22:58:10.000000000","message":"Why \u0027product_id\u0027. Seems like the correct term would be \u0027device_id\u0027\n\nhttps://en.wikipedia.org/wiki/PCI_configuration_space#Standardized_registers","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8da85e0446285c5c2a80ec5fc2d3546f4eacde62","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            \u0027Found a PCI device with vendor id %s and product id %s\u0027,"},{"line_number":430,"context_line":"            vendor, device)"},{"line_number":431,"context_line":"        pci_devices_info.append({\u0027vendor_id\u0027: vendor,"},{"line_number":432,"context_line":"                                 \u0027product_id\u0027: device})"},{"line_number":433,"context_line":"    data[\u0027pci_devices\u0027] \u003d pci_devices_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_ab404ca6","line":432,"in_reply_to":"5a9d85d2_a419cf7b","updated":"2016-06-23 14:11:16.000000000","message":"Seems like the spec is wrong to me:\n\nhttps://en.wikipedia.org/wiki/PCI_configuration_space#Standardized_registers","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"e2028dc334eaa3b98c4774abfd61c53be502801c","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            \u0027Found a PCI device with vendor id %s and product id %s\u0027,"},{"line_number":430,"context_line":"            vendor, device)"},{"line_number":431,"context_line":"        pci_devices_info.append({\u0027vendor_id\u0027: vendor,"},{"line_number":432,"context_line":"                                 \u0027product_id\u0027: device})"},{"line_number":433,"context_line":"    data[\u0027pci_devices\u0027] \u003d pci_devices_info"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_a419cf7b","line":432,"in_reply_to":"7aa08908_1cd261d1","updated":"2016-06-21 07:30:05.000000000","message":"Please read http://specs.openstack.org/openstack/ironic-inspector-specs/specs/generic-pci-resource.html\nThe code is written according to that spec.","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"}],"ironic_python_agent/tests/unit/test_inspector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbedd4d85727305f261d2473466e78cacdc51554","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        inspector.collect_pci_devices_info(self.data, self.failures)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        self.assertEqual(2 * len(subdirs), mock_open.call_count)"},{"line_number":488,"context_line":"        self.assertEqual(len(expected_pci_devices),"},{"line_number":489,"context_line":"                         len(self.data[\u0027pci_devices\u0027]))"},{"line_number":490,"context_line":"        self.assertListEqual(expected_pci_devices, self.data[\u0027pci_devices\u0027])"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def test_wrong_path(self, mock_listdir):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_50b6e98a","line":489,"range":{"start_line":488,"start_character":0,"end_line":489,"end_character":55},"updated":"2016-06-10 12:08:07.000000000","message":"this is not needed, it\u0027s covered by the next line","commit_id":"4f4189c62124aaa105acd2b7c896fa52d8b7f4b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbedd4d85727305f261d2473466e78cacdc51554","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        # note(sborkows): due to throwing IOError, the corresponding mock_open"},{"line_number":517,"context_line":"        # will not be called, so there are 5 mock_open calls in total"},{"line_number":518,"context_line":"        self.assertEqual(5, mock_open.call_count)"},{"line_number":519,"context_line":"        self.assertEqual(len(expected_pci_devices),"},{"line_number":520,"context_line":"                         len(self.data[\u0027pci_devices\u0027]))"},{"line_number":521,"context_line":"        self.assertListEqual(expected_pci_devices, self.data[\u0027pci_devices\u0027])"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_30b99d7a","line":520,"range":{"start_line":519,"start_character":0,"end_line":520,"end_character":55},"updated":"2016-06-10 12:08:07.000000000","message":"ditto","commit_id":"4f4189c62124aaa105acd2b7c896fa52d8b7f4b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55822285f079dda9731b8d476db4c2ca4c8c9203","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    @mock.patch.object(os.path, \u0027isdir\u0027, autospec\u003dTrue)"},{"line_number":473,"context_line":"    @mock.patch(\u0027six.moves.builtins.open\u0027, create\u003dTrue)"},{"line_number":474,"context_line":"    def test(self, mock_open, mock_isdir, mock_listdir):"},{"line_number":475,"context_line":"        subdirs \u003d [\u0027foo\u0027, \u0027bar\u0027]"},{"line_number":476,"context_line":"        mock_listdir.return_value \u003d subdirs"},{"line_number":477,"context_line":"        mock_isdir.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_8f462a79","line":474,"updated":"2016-06-13 08:21:31.000000000","message":"nit: maybe call it test_success?","commit_id":"1dc04b6c596c8c3d9a050f6404378980dbb98b53"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1cf689b8015adec8ecb2004671f983e9d3f01c2","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        mock_file \u003d mock_open.return_value.__enter__.return_value"},{"line_number":480,"context_line":"        reads \u003d [\u00270x1234\u0027, \u00270x5678\u0027, \u00270x9876\u0027, \u00270x5432\u0027]"},{"line_number":481,"context_line":"        mock_file.read.side_effect \u003d reads"},{"line_number":482,"context_line":"        expected_pci_devices \u003d [{\u0027vendor_id\u0027: \u00271234\u0027, \u0027product_id\u0027: \u00275678\u0027},"},{"line_number":483,"context_line":"                                {\u0027vendor_id\u0027: \u00279876\u0027, \u0027product_id\u0027: \u00275432\u0027}]"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        inspector.collect_pci_devices_info(self.data, self.failures)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_7cce0584","line":482,"updated":"2016-06-17 22:58:10.000000000","message":"nit: Might be better to use mock.mock_open() as this is complicated.\n\nhttps://docs.python.org/3/library/unittest.mock.html#mock-open","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":19213,"name":"Szymon Borkowski","email":"szymon.borkowski@intel.com","username":"sborkows"},"change_message_id":"30b1a7073cabc0a04f7584a5ad53fca32b351f6f","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        mock_file \u003d mock_open.return_value.__enter__.return_value"},{"line_number":480,"context_line":"        reads \u003d [\u00270x1234\u0027, \u00270x5678\u0027, \u00270x9876\u0027, \u00270x5432\u0027]"},{"line_number":481,"context_line":"        mock_file.read.side_effect \u003d reads"},{"line_number":482,"context_line":"        expected_pci_devices \u003d [{\u0027vendor_id\u0027: \u00271234\u0027, \u0027product_id\u0027: \u00275678\u0027},"},{"line_number":483,"context_line":"                                {\u0027vendor_id\u0027: \u00279876\u0027, \u0027product_id\u0027: \u00275432\u0027}]"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        inspector.collect_pci_devices_info(self.data, self.failures)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_dd1b0e1a","line":482,"in_reply_to":"7aa08908_7cce0584","updated":"2016-06-21 08:34:48.000000000","message":"Earlier I tried to do this with mock_open(), however it did not work properly. I cannot just simply use it, because:\n1. In tested method there are 2 successive open() calls -\u003e using mock_open() even with side_effect, will return 2 times last element,\n2. There is a need to provide python 2.7/python 3.4 compatibility -\u003e so I use six module.","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a1cf689b8015adec8ecb2004671f983e9d3f01c2","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        mock_file \u003d mock_open.return_value.__enter__.return_value"},{"line_number":506,"context_line":"        reads \u003d [\u00270x1234\u0027, \u00270x5678\u0027, \u00270x9876\u0027, IOError, IndexError,"},{"line_number":507,"context_line":"                 \u00270x5432\u0027]"},{"line_number":508,"context_line":"        mock_file.read.side_effect \u003d reads"},{"line_number":509,"context_line":"        expected_pci_devices \u003d [{\u0027vendor_id\u0027: \u00271234\u0027, \u0027product_id\u0027: \u00275678\u0027}]"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        inspector.collect_pci_devices_info(self.data, self.failures)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_9cc13151","line":508,"updated":"2016-06-17 22:58:10.000000000","message":"Same as L482 comment","commit_id":"6ba466ab6f5736f63ee1a5195e84c6f256653a98"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"99466204e47610e0123531e93441cc4069c3dd44","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    @mock.patch.object(os.path, \u0027isdir\u0027, autospec\u003dTrue)"},{"line_number":473,"context_line":"    @mock.patch(\u0027six.moves.builtins.open\u0027, create\u003dTrue)"},{"line_number":474,"context_line":"    def test_success(self, mock_open, mock_isdir, mock_listdir):"},{"line_number":475,"context_line":"        subdirs \u003d [\u0027foo\u0027, \u0027bar\u0027]"},{"line_number":476,"context_line":"        mock_listdir.return_value \u003d subdirs"},{"line_number":477,"context_line":"        mock_isdir.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_c97f7dde","line":474,"updated":"2016-06-24 04:12:08.000000000","message":"Regarding mock.mock_open()\n\nThis worked for me:\n\n    @mock.patch.object(os.path, \u0027isdir\u0027, autospec\u003dTrue)\n    def test_success(self, mock_isdir, mock_listdir):\n        subdirs \u003d [\u0027foo\u0027, \u0027bar\u0027]\n        mock_listdir.return_value \u003d subdirs\n        mock_isdir.return_value \u003d True\n\n        reads \u003d [\u00270x1234\u0027, \u00270x5678\u0027, \u00270x9876\u0027, \u00270x5432\u0027]\n        expected_pci_devices \u003d [{\u0027vendor_id\u0027: \u00271234\u0027, \u0027product_id\u0027: \u00275678\u0027},\n                                {\u0027vendor_id\u0027: \u00279876\u0027, \u0027product_id\u0027: \u00275432\u0027}]\n        mock_open \u003d mock.mock_open()\n        with mock.patch(\u0027six.moves.builtins.open\u0027, mock_open):\n            mock_read \u003d mock_open.return_value.read\n            mock_read.side_effect \u003d reads\n\n            inspector.collect_pci_devices_info(self.data, self.failures)\n\n        self.assertEqual(2 * len(subdirs), mock_open.call_count)\n        self.assertListEqual(expected_pci_devices, self.data[\u0027pci_devices\u0027])","commit_id":"78d15eb0aa6dd869828a492b3fa2b0d1fb77d73a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"99466204e47610e0123531e93441cc4069c3dd44","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    @mock.patch.object(os.path, \u0027isdir\u0027, autospec\u003dTrue)"},{"line_number":499,"context_line":"    @mock.patch(\u0027six.moves.builtins.open\u0027, create\u003dTrue)"},{"line_number":500,"context_line":"    def test_bad_pci_device_info(self, mock_open, mock_isdir, mock_listdir):"},{"line_number":501,"context_line":"        subdirs \u003d [\u0027foo\u0027, \u0027bar\u0027, \u0027baz\u0027]"},{"line_number":502,"context_line":"        mock_listdir.return_value \u003d subdirs"},{"line_number":503,"context_line":"        mock_isdir.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_e91359b6","line":500,"updated":"2016-06-24 04:12:08.000000000","message":"Regarding mock.mock_open()\n\nThis worked for me:\n\n    @mock.patch.object(os.path, \u0027isdir\u0027, autospec\u003dTrue)\n    def test_bad_pci_device_info(self, mock_isdir, mock_listdir):\n        subdirs \u003d [\u0027foo\u0027, \u0027bar\u0027, \u0027baz\u0027]\n        mock_listdir.return_value \u003d subdirs\n        mock_isdir.return_value \u003d True\n\n        reads \u003d [\u00270x1234\u0027, \u00270x5678\u0027, \u00270x9876\u0027, IOError, IndexError,\n                 \u00270x5432\u0027]\n        expected_pci_devices \u003d [{\u0027vendor_id\u0027: \u00271234\u0027, \u0027product_id\u0027: \u00275678\u0027}]\n        mock_open \u003d mock.mock_open()\n        with mock.patch(\u0027six.moves.builtins.open\u0027, mock_open):\n            mock_read \u003d mock_open.return_value.read\n            mock_read.side_effect \u003d reads\n\n            inspector.collect_pci_devices_info(self.data, self.failures)\n\n        # note(sborkows): due to throwing IOError, the corresponding mock_open\n        # will not be called, so there are 5 mock_open calls in total\n        self.assertEqual(5, mock_open.call_count)\n        self.assertListEqual(expected_pci_devices, self.data[\u0027pci_devices\u0027])","commit_id":"78d15eb0aa6dd869828a492b3fa2b0d1fb77d73a"}],"releasenotes/notes/add-pci-devices-info-3f86934a505d1b31.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbedd4d85727305f261d2473466e78cacdc51554","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new PCI devices collector to inspector module,"},{"line_number":4,"context_line":"    according to \"Generic PCI Resource\" spec."},{"line_number":5,"context_line":"    Data is gathered from /sys/bus/pci/devices directory "},{"line_number":6,"context_line":"    and is stored as a dictionary containing \"vendor_id\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_900cd143","line":3,"updated":"2016-06-10 12:08:07.000000000","message":"please mention the collector name here","commit_id":"4f4189c62124aaa105acd2b7c896fa52d8b7f4b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbedd4d85727305f261d2473466e78cacdc51554","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new PCI devices collector to inspector module,"},{"line_number":4,"context_line":"    according to \"Generic PCI Resource\" spec."},{"line_number":5,"context_line":"    Data is gathered from /sys/bus/pci/devices directory "},{"line_number":6,"context_line":"    and is stored as a dictionary containing \"vendor_id\""},{"line_number":7,"context_line":"    and \"product_id\" keys, which then will be used by"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_d0581959","line":4,"updated":"2016-06-10 12:08:07.000000000","message":"if you want to mention the spec, please add a link to it: http://specs.openstack.org/openstack/ironic-inspector-specs/specs/generic-pci-resource.html. But it\u0027s not really required.","commit_id":"4f4189c62124aaa105acd2b7c896fa52d8b7f4b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbedd4d85727305f261d2473466e78cacdc51554","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new PCI devices collector to inspector module,"},{"line_number":4,"context_line":"    according to \"Generic PCI Resource\" spec."},{"line_number":5,"context_line":"    Data is gathered from /sys/bus/pci/devices directory "},{"line_number":6,"context_line":"    and is stored as a dictionary containing \"vendor_id\""},{"line_number":7,"context_line":"    and \"product_id\" keys, which then will be used by"},{"line_number":8,"context_line":"    the inspector to distinguish various PCI devices."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_506d4903","line":5,"range":{"start_line":5,"start_character":56,"end_line":5,"end_character":57},"updated":"2016-06-10 12:08:07.000000000","message":"nit: please remove the trailing space","commit_id":"4f4189c62124aaa105acd2b7c896fa52d8b7f4b9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bbedd4d85727305f261d2473466e78cacdc51554","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds new PCI devices collector to inspector module,"},{"line_number":4,"context_line":"    according to \"Generic PCI Resource\" spec."},{"line_number":5,"context_line":"    Data is gathered from /sys/bus/pci/devices directory "},{"line_number":6,"context_line":"    and is stored as a dictionary containing \"vendor_id\""},{"line_number":7,"context_line":"    and \"product_id\" keys, which then will be used by"},{"line_number":8,"context_line":"    the inspector to distinguish various PCI devices."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_1018e183","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":33},"updated":"2016-06-10 12:08:07.000000000","message":"please mention the key under which it\u0027s stored (\"pci_devices\")","commit_id":"4f4189c62124aaa105acd2b7c896fa52d8b7f4b9"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"355f685a257349e51263f017915675a8e62f1fce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    default \u003d ironic_python_agent.inspector:collect_default"},{"line_number":34,"context_line":"    logs \u003d ironic_python_agent.inspector:collect_logs"},{"line_number":35,"context_line":"    extra-hardware \u003d ironic_python_agent.inspector:collect_extra_hardware"},{"line_number":36,"context_line":"    pci-devices-info \u003d ironic_python_agent.inspector:collect_pci_devices_info"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[pbr]"},{"line_number":39,"context_line":"autodoc_index_modules \u003d True"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"7aa08908_d848828d","line":36,"updated":"2016-06-09 12:42:15.000000000","message":"lets call the entry point just \"pci-devices\", \"info\" is redundant","commit_id":"3bd91476dbc5f7f2c81a61d0f1372dc23997c030"}]}
