)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38de5f0c498452c95f7b73456d2893267608c050","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yossi Ovadia \u003cjabadia@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-14 15:32:51 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle diskless hardware connected to remote iscsi."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is required to issue iscsistart -b on those hardware in order for"},{"line_number":10,"context_line":"/dev/sda /dev/sdb etc to be exposed to the OS."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7aa08908_8e2785b4","line":7,"updated":"2016-06-16 14:56:34.000000000","message":"nit: we don\u0027t usually put dots in the end of the summary","commit_id":"69d7f4a3df124d8bb845e3612791948b10e8e5bf"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"73f2e82d5737bad295baff363cacdc7953b7faa4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"/dev/sda /dev/sdb etc to be exposed to the OS."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"On this type of hw, without the fix"},{"line_number":13,"context_line":"introspection failes with -  missing: [\u0027local_gb\u0027]\u0027 err."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If6667b123e9b890d97c03612596fb78ee2b0ae85"},{"line_number":16,"context_line":"Closes-Bug: 1590606"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5a9d85d2_6d76f53f","line":13,"range":{"start_line":13,"start_character":14,"end_line":13,"end_character":20},"updated":"2016-06-18 17:35:15.000000000","message":"s/failes/fails/","commit_id":"69d7f4a3df124d8bb845e3612791948b10e8e5bf"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"04a679093c1db526d514dbb142b377e071f1cd75","unresolved":false,"context_lines":[{"line_number":9,"context_line":"It is required to issue iscsistart -b on those hardware in order for"},{"line_number":10,"context_line":"/dev/sda /dev/sdb etc to be exposed to the OS."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"On this type of hw, without the fix"},{"line_number":13,"context_line":"introspection fails with -  missing: [\u0027local_gb\u0027]\u0027 err."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If6667b123e9b890d97c03612596fb78ee2b0ae85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"dada55a8_49086bda","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":18},"updated":"2016-07-21 13:26:47.000000000","message":"nit: s/hw/hardware/","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3582fa44aa8c78651e60d3e8ab0a2657dda264c1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":84,"context_line":"        LOG.info(\u0027No iscsi connection detected. Skipping iscsi.\u0027)"},{"line_number":85,"context_line":"        return"},{"line_number":86,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_194cbe75","line":83,"range":{"start_line":83,"start_character":45,"end_line":83,"end_character":50},"updated":"2016-06-09 16:38:28.000000000","message":"e is not used","commit_id":"d56aa6ca3f639b4615929badfe94576354aec636"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"0fbb302c4379a0c46f2a5179afb1fbb9e28ede7d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":84,"context_line":"        LOG.info(\u0027No iscsi connection detected. Skipping iscsi.\u0027)"},{"line_number":85,"context_line":"        return"},{"line_number":86,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_598126fb","line":83,"range":{"start_line":83,"start_character":45,"end_line":83,"end_character":50},"in_reply_to":"7aa08908_194cbe75","updated":"2016-06-09 16:43:12.000000000","message":"+1","commit_id":"d56aa6ca3f639b4615929badfe94576354aec636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3582fa44aa8c78651e60d3e8ab0a2657dda264c1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":84,"context_line":"        LOG.info(\u0027No iscsi connection detected. Skipping iscsi.\u0027)"},{"line_number":85,"context_line":"        return"},{"line_number":86,"context_line":"    try:"},{"line_number":87,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-b\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f929f28a","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":16},"updated":"2016-06-09 16:38:28.000000000","message":"I think it should be debug, not info","commit_id":"d56aa6ca3f639b4615929badfe94576354aec636"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"0fbb302c4379a0c46f2a5179afb1fbb9e28ede7d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":84,"context_line":"        LOG.info(\u0027No iscsi connection detected. Skipping iscsi.\u0027)"},{"line_number":85,"context_line":"        return"},{"line_number":86,"context_line":"    try:"},{"line_number":87,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-b\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_3986da13","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":16},"in_reply_to":"7aa08908_f929f28a","updated":"2016-06-09 16:43:12.000000000","message":"+1","commit_id":"d56aa6ca3f639b4615929badfe94576354aec636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3582fa44aa8c78651e60d3e8ab0a2657dda264c1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    :param block_type: Type of block device to find"},{"line_number":104,"context_line":"    :return: A list of BlockDevices"},{"line_number":105,"context_line":"    \"\"\""},{"line_number":106,"context_line":"    _check_for_iscsi()"},{"line_number":107,"context_line":"    _udev_settle()"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    columns \u003d [\u0027KNAME\u0027, \u0027MODEL\u0027, \u0027SIZE\u0027, \u0027ROTA\u0027, \u0027TYPE\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_79ab42d7","line":106,"range":{"start_line":106,"start_character":3,"end_line":106,"end_character":22},"updated":"2016-06-09 16:38:28.000000000","message":"this will be called every time an inventory is request, which is probably not something you want to do. please see below where to put this call.","commit_id":"d56aa6ca3f639b4615929badfe94576354aec636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3582fa44aa8c78651e60d3e8ab0a2657dda264c1","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    def __init__(self):"},{"line_number":435,"context_line":"        self.sys_path \u003d \u0027/sys\u0027"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def evaluate_hardware_support(self):"},{"line_number":438,"context_line":"        # Do some initialization before we declare ourself ready"},{"line_number":439,"context_line":"        self._wait_for_disks()"},{"line_number":440,"context_line":"        return HardwareSupport.GENERIC"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def _wait_for_disks(self):"},{"line_number":443,"context_line":"        # Wait for at least one suitable disk to show up, otherwise neither"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_59a48607","line":440,"range":{"start_line":437,"start_character":0,"end_line":440,"end_character":38},"updated":"2016-06-09 16:38:28.000000000","message":"you new call should go to this function","commit_id":"d56aa6ca3f639b4615929badfe94576354aec636"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3006d94d103da9fd7173236a4f506eb6b2fe89fa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":84,"context_line":"        LOG.warning(\u0027No iscsi connection detected. Skipping iscsi.\u0027"},{"line_number":85,"context_line":"                    \u0027Error: %s\u0027, e)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f1a28599","line":83,"updated":"2016-06-10 08:22:35.000000000","message":"please also catch EnvironmentError, the gate is failed due to iscsistart not being found.","commit_id":"a528f15cdb1ef519d70ef8a2951c8b140084676c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3006d94d103da9fd7173236a4f506eb6b2fe89fa","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":84,"context_line":"        LOG.warning(\u0027No iscsi connection detected. Skipping iscsi.\u0027"},{"line_number":85,"context_line":"                    \u0027Error: %s\u0027, e)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d19f894e","line":84,"updated":"2016-06-10 08:22:35.000000000","message":"s/warning/debug/ as this is a normal condition","commit_id":"a528f15cdb1ef519d70ef8a2951c8b140084676c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08ab4ef6d7aab9d66b7229620ebfab28c50dd869","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def _check_for_iscsi():"},{"line_number":74,"context_line":"    \"\"\"iscsi detection"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    iscsistart -f will print the iBFT or OF info."},{"line_number":77,"context_line":"    In case such connection exists, we would like to issue"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_0fe07a95","line":74,"updated":"2016-06-13 08:17:36.000000000","message":"Lets maybe change the summary to \"Connect iSCSI shared connected via iBFT or OF.\"","commit_id":"176057b6d21f4927934d4aee16ab9a2a7c9caa43"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"73f2e82d5737bad295baff363cacdc7953b7faa4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except (processutils.ProcessExecutionError, EnvironmentError) as e:"},{"line_number":84,"context_line":"        LOG.debug(\u0027No iscsi connection detected. Skipping iscsi.\u0027"},{"line_number":85,"context_line":"                  \u0027Error: %s\u0027, e)"},{"line_number":86,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a9d85d2_6dad5588","line":83,"updated":"2016-06-18 17:35:15.000000000","message":"A unit test for this code patch would be good.","commit_id":"69d7f4a3df124d8bb845e3612791948b10e8e5bf"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"73f2e82d5737bad295baff363cacdc7953b7faa4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    try:"},{"line_number":82,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":83,"context_line":"    except (processutils.ProcessExecutionError, EnvironmentError) as e:"},{"line_number":84,"context_line":"        LOG.debug(\u0027No iscsi connection detected. Skipping iscsi.\u0027"},{"line_number":85,"context_line":"                  \u0027Error: %s\u0027, e)"},{"line_number":86,"context_line":"        return"},{"line_number":87,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a9d85d2_2da34da0","line":84,"updated":"2016-06-18 17:35:15.000000000","message":"Missing trailing space. Like L90","commit_id":"69d7f4a3df124d8bb845e3612791948b10e8e5bf"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"73f2e82d5737bad295baff363cacdc7953b7faa4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    try:"},{"line_number":88,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-b\u0027)"},{"line_number":89,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":90,"context_line":"        LOG.warning(\u0027Something went wrong executing iscsistart -b\u0027"},{"line_number":91,"context_line":"                    \u0027Error: %s\u0027, e)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a9d85d2_ed98256d","line":90,"updated":"2016-06-18 17:35:15.000000000","message":"This message will look like:\n\n .... iscsistart -bError: ...\n\nNeed trailing space added.\n\nMaybe something like:\n LOG.warning(\"Error executing \u0027iscsistart -b\u0027 \"\n             \"Error: %s\", e)","commit_id":"69d7f4a3df124d8bb845e3612791948b10e8e5bf"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"04a679093c1db526d514dbb142b377e071f1cd75","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    iscsistart -f will print the iBFT or OF info."},{"line_number":76,"context_line":"    In case such connection exists, we would like to issue"},{"line_number":77,"context_line":"    iscsistart -b to create a session to the target."},{"line_number":78,"context_line":"    - if no connection is detected we simply return."},{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_69d3afd5","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":8},"updated":"2016-07-21 13:26:47.000000000","message":"nit: s/- if/If/","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"04a679093c1db526d514dbb142b377e071f1cd75","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":82,"context_line":"    except (processutils.ProcessExecutionError, EnvironmentError) as e:"},{"line_number":83,"context_line":"        LOG.debug(\"No iscsi connection detected. Skipping iscsi. \""},{"line_number":84,"context_line":"                  \"Error: %s\", e)"},{"line_number":85,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_8459aa90","line":82,"range":{"start_line":82,"start_character":48,"end_line":82,"end_character":64},"updated":"2016-07-21 13:26:47.000000000","message":"Could be an OSError like other utils.execute calls, right?\n\nsee: https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/utils.py#L72","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9aa45575684cf46eeb2c030a4fb4139d9717fdb","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        utils.execute(\u0027iscsistart\u0027, \u0027-f\u0027)"},{"line_number":82,"context_line":"    except (processutils.ProcessExecutionError, EnvironmentError) as e:"},{"line_number":83,"context_line":"        LOG.debug(\"No iscsi connection detected. Skipping iscsi. \""},{"line_number":84,"context_line":"                  \"Error: %s\", e)"},{"line_number":85,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_7bf1b46a","line":82,"range":{"start_line":82,"start_character":48,"end_line":82,"end_character":64},"in_reply_to":"dada55a8_8459aa90","updated":"2016-07-21 13:51:32.000000000","message":"EnvironmentError is the base exception class, so I think it would be caught.  I think.","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d9e61c172ba4caa29b617ceb6a877ee49984b654","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def evaluate_hardware_support(self):"},{"line_number":437,"context_line":"        # Do some initialization before we declare ourself ready"},{"line_number":438,"context_line":"        _check_for_iscsi()"},{"line_number":439,"context_line":"        self._wait_for_disks()"},{"line_number":440,"context_line":"        return HardwareSupport.GENERIC"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_04bba7c5","line":438,"updated":"2016-07-18 16:24:39.000000000","message":"This seems like something that shouldn\u0027t be in the generic hardware manager. ISCSI support would be better provided in a separate manager, with this code only running if explicitly enabled.\n\nHas anyone done any benchmarking on how much time this adds to a deployment for the non-iscsi use case?\n\nI\u0027m just concerned we\u0027re encoding the \u0027monolithic hardware manager\u0027 pattern into IPA, given this is a clear example of a non-generic hardware setup that we may want to support only optionally.\n\nMy suggestion --\n\nadd a config option to enable iscsi, that can be enabled via Ironic (either in pxe_append_params or via a new config option -- maybe even just simply look for a node attribute?)\n\nadd a small class in a new module,\n\nclass ISCSIHardwareManager(HardwareManager):\n   def evaluate_hardware_support(self):\n       if CONF.enable_iscsi # or something similar? Maybe just a node attr?\n          _check_for_iscsi() # modify this method to fail if it doesn\u0027t find iscsi\n          return MAINLINE\n       else:\n           return NONE\n\nThis also has the benefit of being able to properly fail in cases we expect iscsi and don\u0027t have.\n\nWDYT?","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"34af7b0939bbf78447a349f85249af0ee32e6cef","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    def evaluate_hardware_support(self):"},{"line_number":437,"context_line":"        # Do some initialization before we declare ourself ready"},{"line_number":438,"context_line":"        _check_for_iscsi()"},{"line_number":439,"context_line":"        self._wait_for_disks()"},{"line_number":440,"context_line":"        return HardwareSupport.GENERIC"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def _wait_for_disks(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_d22cef03","line":439,"range":{"start_line":439,"start_character":8,"end_line":439,"end_character":30},"updated":"2016-07-13 15:28:17.000000000","message":"Should it still wait for disks? Should there be any priority of iscsi over disks or vice-versa? What should be the behavior  in case node has both iscsi and disks present?","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2ecbb2a33f5383d827e52420dba2ca8e14b2d4e3","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    def evaluate_hardware_support(self):"},{"line_number":437,"context_line":"        # Do some initialization before we declare ourself ready"},{"line_number":438,"context_line":"        _check_for_iscsi()"},{"line_number":439,"context_line":"        self._wait_for_disks()"},{"line_number":440,"context_line":"        return HardwareSupport.GENERIC"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def _wait_for_disks(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1aa78d24_922d47aa","line":439,"range":{"start_line":439,"start_character":8,"end_line":439,"end_character":30},"in_reply_to":"1aa78d24_d22cef03","updated":"2016-07-13 15:31:22.000000000","message":"1. Yes of course, iSCSI is not instant\n\n2. I don\u0027t think so, and it\u0027s none of our business here\n\n3. The same as now: root device hints will decide.","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"}],"ironic_python_agent/tests/unit/test_agent.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d8f3dc44d3ac1952bbba64517b10604084039387","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        self.agent._wait_for_interface()"},{"line_number":269,"context_line":"        mocked_dispatch.assert_has_calls(expected_dispatch_calls)"},{"line_number":270,"context_line":"        mocked_sleep.assert_has_calls(expected_sleep_calls)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":273,"context_line":"    @mock.patch(\u0027wsgiref.simple_server.make_server\u0027, autospec\u003dTrue)"},{"line_number":274,"context_line":"    @mock.patch.object(hardware.HardwareManager, \u0027list_hardware_info\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_181fa25c","line":271,"updated":"2016-06-27 15:39:24.000000000","message":"I suspect we need a mock here to make tests pass","commit_id":"55830f6113875c9d26e2d43298f78b8382f0425d"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08ab4ef6d7aab9d66b7229620ebfab28c50dd869","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"    @mock.patch.object(hardware.GenericHardwareManager, \u0027list_block_devices\u0027,"},{"line_number":1149,"context_line":"                       autospec\u003dTrue)"},{"line_number":1150,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, autospec\u003dTrue)"},{"line_number":1151,"context_line":"    @mock.patch.object(utils, \u0027guess_root_disk\u0027, autospec\u003dTrue)"},{"line_number":1152,"context_line":"    def test_evaluate_hw_waits_for_disks(self, mocked_root_dev, mocked_sleep,"},{"line_number":1153,"context_line":"                                         mocked_block_dev):"},{"line_number":1154,"context_line":"        mocked_root_dev.side_effect \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_6fef7e87","line":1151,"updated":"2016-06-13 08:17:36.000000000","message":"we need to mock a new function here to fix unit tests","commit_id":"176057b6d21f4927934d4aee16ab9a2a7c9caa43"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"6d17e6a3953ac6646ed2251a6bb54d84042e6511","unresolved":false,"context_lines":[{"line_number":1338,"context_line":"        hardware._udev_settle()"},{"line_number":1339,"context_line":"        mocked_execute.assert_called_once_with(\u0027udevadm\u0027, \u0027settle\u0027)"},{"line_number":1340,"context_line":""},{"line_number":1341,"context_line":"    def test__check_for_iscsi(self, mocked_execute):"},{"line_number":1342,"context_line":"        hardware._check_for_iscsi()"},{"line_number":1343,"context_line":"        mocked_execute.assert_has_calls(["},{"line_number":1344,"context_line":"            mock.call(\u0027iscsistart\u0027, \u0027-f\u0027),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_c0f443f2","line":1341,"updated":"2016-06-30 16:50:50.000000000","message":"Please add some tests for the failure cases.","commit_id":"55830f6113875c9d26e2d43298f78b8382f0425d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"537bc009578dcd74e190cc818ea8a12ffe959b6e","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"        hardware._check_for_iscsi()"},{"line_number":1350,"context_line":"        mocked_execute.assert_has_calls(["},{"line_number":1351,"context_line":"            mock.call(\u0027iscsistart\u0027, \u0027-f\u0027)])"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"def create_hdparm_info(supported\u003dFalse, enabled\u003dFalse, frozen\u003dFalse,"},{"line_number":1354,"context_line":"                       enhanced_erase\u003dFalse):"},{"line_number":1355,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_5ea54f45","line":1352,"updated":"2016-07-10 09:42:46.000000000","message":"an additional newline is needed here to make pep8 job happy","commit_id":"330097a4277733ff9008f77971b899f7527f7d9c"}],"releasenotes/notes/iscsi-detection-on-diskless-hw-f27dcce3aaa35ac2.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3006d94d103da9fd7173236a4f506eb6b2fe89fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes a bug where introspection fails in case of diskless hardware with remote isci connection."},{"line_number":4,"context_line":"    before disks detection phase a iscsi probe is done in case connection to iscsi exists."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_31ad2d89","line":3,"updated":"2016-06-10 08:22:35.000000000","message":"typo in iSCSI","commit_id":"a528f15cdb1ef519d70ef8a2951c8b140084676c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3006d94d103da9fd7173236a4f506eb6b2fe89fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes a bug where introspection fails in case of diskless hardware with remote isci connection."},{"line_number":4,"context_line":"    before disks detection phase a iscsi probe is done in case connection to iscsi exists."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7aa08908_11aab170","line":4,"updated":"2016-06-10 08:22:35.000000000","message":"this is not only about introspection, deployment would fail just as well.","commit_id":"a528f15cdb1ef519d70ef8a2951c8b140084676c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08ab4ef6d7aab9d66b7229620ebfab28c50dd869","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes a bug in case of diskless hardware with remote iscsi connection."},{"line_number":4,"context_line":"    before disks detection phase a iscsi probe is done in case connection to iscsi exists."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7aa08908_4ff4425a","line":4,"updated":"2016-06-13 08:17:36.000000000","message":"maybe \"If iBFT or OF information is present, connect an iSCSI share before detecting disks\"","commit_id":"176057b6d21f4927934d4aee16ab9a2a7c9caa43"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"73f2e82d5737bad295baff363cacdc7953b7faa4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - If iBFT or OF information is present, connect an iSCSI share before detecting disks"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a9d85d2_8dba41bf","line":3,"updated":"2016-06-18 17:35:15.000000000","message":"Please explain what \"iBFT\" and \"OF\" are. I have no idea and don\u0027t want to have to Google them to understand the release notes.","commit_id":"69d7f4a3df124d8bb845e3612791948b10e8e5bf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afcdab47bbd11e4f19d3928021416acd9b01d9dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - If iscsi connection present, connect an iSCSI target share before detecting disks."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"dada55a8_440852da","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":31},"updated":"2016-07-21 13:20:34.000000000","message":"Nit: I think this should be more along the lines of \"Upon initialization of the agent, an attempt to identify and initialize any configured hardware iSCSI initiators is performed prior to detecting disks.","commit_id":"90424fad0af9cda1c14bd5d4a7c0f397705c1751"}]}
