)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"5e5b5f1659ced48cf8a7c4f95f7c601213d7df6d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This bumps the CoreOS version to 1010.6.0."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This approach was used instead of fetching the latest version number at"},{"line_number":12,"context_line":"build time because that meant a CoreOS could break our gate."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The backdraw is that we are possibly never going to bump this version"},{"line_number":15,"context_line":"number again for 2 years. A solution is to put in place a proposal bot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1aa78d24_6f5b6d2f","line":12,"updated":"2016-07-08 12:04:45.000000000","message":"Nit: \"a CoreOS update\"","commit_id":"d079e462dd66fd9188cc7603dbaf7a2b91035d1a"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"5e5b5f1659ced48cf8a7c4f95f7c601213d7df6d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This approach was used instead of fetching the latest version number at"},{"line_number":12,"context_line":"build time because that meant a CoreOS could break our gate."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The backdraw is that we are possibly never going to bump this version"},{"line_number":15,"context_line":"number again for 2 years. A solution is to put in place a proposal bot"},{"line_number":16,"context_line":"that submits new CoreOS versions for review. That way, we would merge"},{"line_number":17,"context_line":"the changes and stay up-to-date, without breaking our gates unwillingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1aa78d24_2f51650f","line":14,"updated":"2016-07-08 12:04:45.000000000","message":"I\u0027ve never heard \"backdraw\" before, but Google informs me it\u0027s Scots. TIL :-) If you do another revision, I think \"drawback\" is more common.","commit_id":"d079e462dd66fd9188cc7603dbaf7a2b91035d1a"}],"imagebuild/coreos/coreos-oem-inject.py":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1eb0f74cf3070361b4f1bb4f82fbe245cdaa4bef","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    raise ValueError(\u0027Could not fetch latest CoreOS stable version\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COREOS_STABLE_URL \u003d (\u0027http://stable.release.core-os.net/amd64-usr\u0027"},{"line_number":36,"context_line":"                     \u0027/current/version.txt\u0027)"},{"line_number":37,"context_line":"COREOS_VERSION \u003d get_latest_coreos_version()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_869fad4f","line":35,"range":{"start_line":35,"start_character":56,"end_line":35,"end_character":65},"updated":"2016-07-08 09:42:54.000000000","message":"As we don\u0027t hardcode the arch below in the URL should we also {arch} here?","commit_id":"ac0b9eda2d24ae9c6832987e9db0a7c3a0d4a230"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"503930be267cb5a47ff09990974e58a5875581b2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    raise ValueError(\u0027Could not fetch latest CoreOS stable version\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COREOS_STABLE_URL \u003d (\u0027http://stable.release.core-os.net/amd64-usr\u0027"},{"line_number":36,"context_line":"                     \u0027/current/version.txt\u0027)"},{"line_number":37,"context_line":"COREOS_VERSION \u003d get_latest_coreos_version()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_905d1b4b","line":35,"range":{"start_line":35,"start_character":56,"end_line":35,"end_character":65},"in_reply_to":"1aa78d24_869fad4f","updated":"2016-07-08 11:33:51.000000000","message":"Fixed.","commit_id":"ac0b9eda2d24ae9c6832987e9db0a7c3a0d4a230"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1eb0f74cf3070361b4f1bb4f82fbe245cdaa4bef","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COREOS_STABLE_URL \u003d (\u0027http://stable.release.core-os.net/amd64-usr\u0027"},{"line_number":36,"context_line":"                     \u0027/current/version.txt\u0027)"},{"line_number":37,"context_line":"COREOS_VERSION \u003d get_latest_coreos_version()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"COREOS_ARCH \u003d \"amd64-usr\""},{"line_number":40,"context_line":"COREOS_BASE_URL \u003d (\"http://stable.release.core-os.net/{arch}/{ver}\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_06161da7","line":37,"updated":"2016-07-08 09:42:54.000000000","message":"I\u0027m not sure we need all this logic to determine the latest version, if we just change COREOS_VERSION\u003d\"current\" we\u0027ll get the current version.","commit_id":"ac0b9eda2d24ae9c6832987e9db0a7c3a0d4a230"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"503930be267cb5a47ff09990974e58a5875581b2","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"COREOS_STABLE_URL \u003d (\u0027http://stable.release.core-os.net/amd64-usr\u0027"},{"line_number":36,"context_line":"                     \u0027/current/version.txt\u0027)"},{"line_number":37,"context_line":"COREOS_VERSION \u003d get_latest_coreos_version()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"COREOS_ARCH \u003d \"amd64-usr\""},{"line_number":40,"context_line":"COREOS_BASE_URL \u003d (\"http://stable.release.core-os.net/{arch}/{ver}\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_10176b55","line":37,"in_reply_to":"1aa78d24_06161da7","updated":"2016-07-08 11:33:51.000000000","message":"COREOS_VERSION is used for the imagecache below. Using current would overwrite the same cache all the time. Additionally, using current for multiple non-atomic operation could lead to fetching binaries from different releases during a CoreOS release.","commit_id":"ac0b9eda2d24ae9c6832987e9db0a7c3a0d4a230"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"2c7f478581d19967c109e115b61f8f0c5311ad4f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        for line in f:"},{"line_number":27,"context_line":"            if \u0027\u003d\u0027 in line:"},{"line_number":28,"context_line":"                k, v \u003d line.strip().split(\u0027\u003d\u0027)"},{"line_number":29,"context_line":"                if k \u003d\u003d \u0027COREOS_VERSION_ID\u0027:"},{"line_number":30,"context_line":"                    return v"},{"line_number":31,"context_line":"    raise ValueError(\u0027Could not read CoreOS version number from file\u0027)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_2f084591","line":29,"updated":"2016-07-08 12:18:22.000000000","message":"Nit: I\u0027d reverse the order of these operations, ie only do the split if line.startswith(\u0027COREOS_VERSION_ID\u0027).","commit_id":"22984c60348d3585181d452abddb464b134c4c76"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9ebda8a2f91a21d97158cb017ed3032d7ebb781a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def get_coreos_version(version_file, key\u003d\u0027COREOS_VERSION_ID\u0027):"},{"line_number":25,"context_line":"    with open(version_file) as f:"},{"line_number":26,"context_line":"        for line in f:"},{"line_number":27,"context_line":"            if line.startswith(key) and \u0027\u003d\u0027 in line:"},{"line_number":28,"context_line":"                k, v \u003d line.strip().split(\u0027\u003d\u0027)"},{"line_number":29,"context_line":"                if k \u003d\u003d key:"},{"line_number":30,"context_line":"                    return v"}],"source_content_type":"text/x-python","patch_set":13,"id":"1aa78d24_980edde3","line":27,"updated":"2016-07-08 12:59:20.000000000","message":"Even simpler, as sambetts suggested in IRC:\n\nif line.startswith(\"%s\u003d\" % key):\n    return line.strip().split(\"\u003d\")[1]\n\nBut what you have is already acceptable, IMHO.","commit_id":"cf48a5c991f6bb954eaa797e23e1133c37fd13fb"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"648560d948568e1265ab2f7e40402afd013088b6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def get_coreos_version(version_file, key\u003d\u0027COREOS_VERSION_ID\u0027):"},{"line_number":25,"context_line":"    with open(version_file) as f:"},{"line_number":26,"context_line":"        for line in f:"},{"line_number":27,"context_line":"            if line.startswith(key) and \u0027\u003d\u0027 in line:"},{"line_number":28,"context_line":"                k, v \u003d line.strip().split(\u0027\u003d\u0027)"},{"line_number":29,"context_line":"                if k \u003d\u003d key:"},{"line_number":30,"context_line":"                    return v"}],"source_content_type":"text/x-python","patch_set":13,"id":"1aa78d24_a33a8ee5","line":27,"in_reply_to":"1aa78d24_980edde3","updated":"2016-07-08 13:27:41.000000000","message":"Done :)","commit_id":"cf48a5c991f6bb954eaa797e23e1133c37fd13fb"}]}