)]}'
{"id":"openstack%2Fironic-python-agent~330451","triplet_id":"openstack%2Fironic-python-agent~master~I2d1c78fe71fe03e350b1035123b0a48b7186a6ec","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1510007","hashtags":[],"change_id":"I2d1c78fe71fe03e350b1035123b0a48b7186a6ec","subject":"Use assertIn and assertNotIn","status":"MERGED","created":"2016-06-16 10:43:45.000000000","updated":"2016-06-19 16:29:46.000000000","submitted":"2016-06-19 16:29:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3473b360328b98bce73efc48719e8c814aa00cec","_number":330451,"virtual_id_number":330451,"owner":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-06-19 16:29:46.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},{"value":2,"date":"2016-06-17 18:26:48.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":1,"date":"2016-06-19 03:06:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":2,"date":"2016-06-19 16:26:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":1,"date":"2016-06-19 16:26:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-16 13:12:53.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2016-06-17 18:26:48.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2016-06-19 03:06:13.000000000","updated_by":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"reviewer":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"state":"REVIEWER"},{"updated":"2016-06-19 16:26:05.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-06-19 16:29:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c0e44928a4a39559f51382a836eecd29fbf8fbd2","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-16 10:43:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5c28fe4370b3165f479df147b41c72f42cd8028","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-16 10:53:25.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"94ccf30cbb2f2a435c589c5b43d52846a2535e89","author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"date":"2016-06-16 11:21:09.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e7becd629969806d6873e4df9d11ff7b5d5079fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-16 12:47:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/51/330451/2/check/gate-ironic-python-agent-docs/d46af4e//doc/build/html/ : SUCCESS in 3m 42s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/51/330451/2/check/gate-ironic-python-agent-pep8/4f6fb5f/ : SUCCESS in 3m 17s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/51/330451/2/check/gate-ironic-python-agent-python27/d0ee88c/ : SUCCESS in 1m 45s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/51/330451/2/check/gate-ironic-python-agent-python34/f0d2d11/ : SUCCESS in 3m 35s","accounts_in_message":[],"_revision_number":2},{"id":"ca22e5934b5b8e5d1a42297f2cd53a2f35e18339","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2016-06-16 13:12:53.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nThanks for the patch. I see another case in test_utils.py (https://github.com/openstack/ironic-python-agent/blob/33535cd572b90a817b9c96b42a0d2fe54751351d/ironic_python_agent/tests/unit/test_utils.py#L149).","accounts_in_message":[],"_revision_number":2},{"id":"18345354bd38a86348aaa53f9181ccaa737eb3cc","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-16 13:18:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9d4dde257a850adb244dd6efe3421a1fe91dd7ce","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-16 13:31:03.000000000","message":"Patch Set 3:\n\nThanks for noticing Ruby.","accounts_in_message":[],"_revision_number":3},{"id":"14da84e44f41ffc20f7370c933a6b817f828fd5c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-16 15:07:11.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/51/330451/3/check/gate-ironic-python-agent-docs/49c8450//doc/build/html/ : SUCCESS in 3m 17s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/51/330451/3/check/gate-ironic-python-agent-pep8/b4d12c3/ : SUCCESS in 3m 46s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/51/330451/3/check/gate-ironic-python-agent-python27/852897f/ : SUCCESS in 2m 34s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/51/330451/3/check/gate-ironic-python-agent-python34/92458bd/ : SUCCESS in 4m 02s","accounts_in_message":[],"_revision_number":3},{"id":"2d164a49b5526ad84ded084563b51d5afa15b9b0","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-06-17 08:51:51.000000000","message":"Patch Set 3: Code-Review+2\n\n(5 comments)","accounts_in_message":[],"_revision_number":3},{"id":"86e4700ed37c6a9710f8045747abe16aa05eb601","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-17 16:07:44.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d2d44a9f3af896d4460c1c57613117c2b1f2e031","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-17 16:08:04.000000000","message":"Patch Set 3:\n\n(5 comments)","accounts_in_message":[],"_revision_number":3},{"id":"fffa8fabee081a44d1b28e15837bb49254cd9b9e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-17 18:04:37.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/51/330451/4/check/gate-ironic-python-agent-docs/c1d24a3//doc/build/html/ : SUCCESS in 3m 38s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/51/330451/4/check/gate-ironic-python-agent-pep8/604e8ec/ : SUCCESS in 2m 44s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/51/330451/4/check/gate-ironic-python-agent-python27/44a6131/ : SUCCESS in 3m 04s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/51/330451/4/check/gate-ironic-python-agent-python34/f67f9a0/ : SUCCESS in 4m 03s","accounts_in_message":[],"_revision_number":4},{"id":"0dc6013f115cd9fa3c6d678fc9257b0c69453abb","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-06-17 18:26:48.000000000","message":"Patch Set 4: Code-Review+2\n\nThanks Edan","accounts_in_message":[],"_revision_number":4},{"id":"1d16fee53faa448bb9617db716196c67299a35df","author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"date":"2016-06-19 03:06:13.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"07c3ee72ebcc8723d119320eb37b7ec135176d4f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-06-19 16:26:05.000000000","message":"Patch Set 4: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"85c42147401a8ee41fffa0ff92f0c1e29b25133f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-19 16:26:16.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"508275d4ba63fa09c3bf4cf0717005bd0bddb0d0","date":"2016-06-19 16:29:46.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"b739e626e13d427eb2025f3e19c5e1f42a915ea4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-19 16:29:46.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/51/330451/4/gate/gate-ironic-python-agent-docs/2df5266//doc/build/html/ : SUCCESS in 3m 08s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/51/330451/4/gate/gate-ironic-python-agent-pep8/231837e/ : SUCCESS in 3m 29s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/51/330451/4/gate/gate-ironic-python-agent-python27/fddd854/ : SUCCESS in 3m 16s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/51/330451/4/gate/gate-ironic-python-agent-python34/fb88073/ : SUCCESS in 3m 09s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"1e8652a8d038c3795b903c9eba02a6b0a8a5b872","revisions":{"f306859f134e25e4d935fc0ecfaa86846567921d":{"kind":"REWORK","_number":1,"created":"2016-06-16 10:43:45.000000000","uploader":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"ref":"refs/changes/51/330451/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/51/330451/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/1"}}},"commit":{"parents":[{"commit":"d7eccc43dfa6a39ded0fa2c55e13753ff2492d00","subject":"Merge \"Wait for at least one interface before node lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d7eccc43dfa6a39ded0fa2c55e13753ff2492d00"}]}],"author":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-16 10:40:03.000000000","tz":-240},"committer":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-16 10:40:03.000000000","tz":-240},"subject":"Tests should use:   self.assertIn(value, list)   self.assertNotIn(value, list)","message":"Tests should use:\n  self.assertIn(value, list)\n  self.assertNotIn(value, list)\n\ninstead of:\n  self.assertTrue(value in list)\n  self.assertFalse(value in list)\n\nbecause assertIn and assertNotIn raise more meaningful errors:\n  self.assertIn(3, [1, 2]\n  \u003e\u003e\u003e MismatchError: 3 not in [1, 2]\n\n  self.assertTrue(3 in [1, 2])\n  \u003e\u003e\u003e AssertionError: False is not true\n\nChange-Id: I2d1c78fe71fe03e350b1035123b0a48b7186a6ec\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f306859f134e25e4d935fc0ecfaa86846567921d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f306859f134e25e4d935fc0ecfaa86846567921d"}]},"branch":"refs/heads/master"},"23abb64394b64f2b9302d0c9b76315576c886e92":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-06-16 10:53:25.000000000","uploader":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"ref":"refs/changes/51/330451/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/51/330451/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/2"}}},"commit":{"parents":[{"commit":"d7eccc43dfa6a39ded0fa2c55e13753ff2492d00","subject":"Merge \"Wait for at least one interface before node lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d7eccc43dfa6a39ded0fa2c55e13753ff2492d00"}]}],"author":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-16 10:40:03.000000000","tz":-240},"committer":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-16 10:51:38.000000000","tz":-240},"subject":"Tests should use:   self.assertIn(value, list)   self.assertNotIn(value, list)","message":"Tests should use:\n  self.assertIn(value, list)\n  self.assertNotIn(value, list)\n\ninstead of:\n  self.assertTrue(value in list)\n  self.assertFalse(value in list)\n\nbecause assertIn and assertNotIn raise more meaningful errors:\n  self.assertIn(3, [1, 2]\n  \u003e\u003e\u003e MismatchError: 3 not in [1, 2]\n\n  self.assertTrue(3 in [1, 2])\n  \u003e\u003e\u003e AssertionError: False is not true\n\nChange-Id: I2d1c78fe71fe03e350b1035123b0a48b7186a6ec\nCloses-Bug: #1510007\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/23abb64394b64f2b9302d0c9b76315576c886e92"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/23abb64394b64f2b9302d0c9b76315576c886e92"}]},"branch":"refs/heads/master"},"0d3e21f4bcd9b8e1a61f97baf5c53ff5a680da84":{"kind":"REWORK","_number":3,"created":"2016-06-16 13:18:00.000000000","uploader":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"ref":"refs/changes/51/330451/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/51/330451/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/3"}}},"commit":{"parents":[{"commit":"d7eccc43dfa6a39ded0fa2c55e13753ff2492d00","subject":"Merge \"Wait for at least one interface before node lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d7eccc43dfa6a39ded0fa2c55e13753ff2492d00"}]}],"author":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-16 10:40:03.000000000","tz":-240},"committer":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-16 13:16:30.000000000","tz":-240},"subject":"Use assertIn and assertNotIn","message":"Use assertIn and assertNotIn\n\nTests should use:\n  self.assertIn(value, list)\n  self.assertNotIn(value, list)\n\ninstead of:\n  self.assertTrue(value in list)\n  self.assertFalse(value in list)\n\nbecause assertIn and assertNotIn raise more meaningful errors:\n  self.assertIn(3, [1, 2]\n  \u003e\u003e\u003e MismatchError: 3 not in [1, 2]\n\n  self.assertTrue(3 in [1, 2])\n  \u003e\u003e\u003e AssertionError: False is not true\n\nChange-Id: I2d1c78fe71fe03e350b1035123b0a48b7186a6ec\nCloses-Bug: #1510007\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0d3e21f4bcd9b8e1a61f97baf5c53ff5a680da84"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0d3e21f4bcd9b8e1a61f97baf5c53ff5a680da84"}]},"branch":"refs/heads/master"},"1e8652a8d038c3795b903c9eba02a6b0a8a5b872":{"kind":"REWORK","_number":4,"created":"2016-06-17 16:07:44.000000000","uploader":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"ref":"refs/changes/51/330451/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/51/330451/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/51/330451/4"}}},"commit":{"parents":[{"commit":"d7eccc43dfa6a39ded0fa2c55e13753ff2492d00","subject":"Merge \"Wait for at least one interface before node lookup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/d7eccc43dfa6a39ded0fa2c55e13753ff2492d00"}]}],"author":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-16 10:40:03.000000000","tz":-240},"committer":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-17 16:01:43.000000000","tz":-240},"subject":"Use assertIn and assertNotIn","message":"Use assertIn and assertNotIn\n\nTests should use:\n  self.assertIn(value, list)\n  self.assertNotIn(value, list)\n\ninstead of:\n  self.assertTrue(value in list)\n  self.assertFalse(value in list)\n\nbecause assertIn and assertNotIn raise more meaningful errors:\n  self.assertIn(3, [1, 2]\n  \u003e\u003e\u003e MismatchError: 3 not in [1, 2]\n\n  self.assertTrue(3 in [1, 2])\n  \u003e\u003e\u003e AssertionError: False is not true\n\nChange-Id: I2d1c78fe71fe03e350b1035123b0a48b7186a6ec\nCloses-Bug: #1510007\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1e8652a8d038c3795b903c9eba02a6b0a8a5b872"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1e8652a8d038c3795b903c9eba02a6b0a8a5b872"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}