)]}'
{"id":"openstack%2Fironic-python-agent~331466","triplet_id":"openstack%2Fironic-python-agent~master~I384b24e81543999a8b873e3223cd409ed799ffa0","project":"openstack/ironic-python-agent","branch":"master","topic":"default_mutable","hashtags":[],"change_id":"I384b24e81543999a8b873e3223cd409ed799ffa0","subject":"Removes the use of mutables as default args","status":"MERGED","created":"2016-06-19 09:57:10.000000000","updated":"2016-06-20 17:25:29.000000000","submitted":"2016-06-20 17:25:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1afede50dd9a29fe0f076c99b649409312907291","_number":331466,"virtual_id_number":331466,"owner":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-06-20 17:25:29.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":2,"date":"2016-06-20 14:04:18.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":2,"date":"2016-06-20 17:13:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":1,"date":"2016-06-20 17:13:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-19 09:58:29.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2016-06-19 09:58:43.000000000","updated_by":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"reviewer":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"state":"REVIEWER"},{"updated":"2016-06-20 14:04:18.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2016-06-20 17:13:07.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-06-20 17:25:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1fde2a2d91478fffab70c955cb9431f12ec930ca","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-19 09:57:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b3139191c7917ec471d3af87b6c07a2599e6935","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-19 10:00:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/66/331466/1/check/gate-ironic-python-agent-docs/4af028d//doc/build/html/ : SUCCESS in 2m 58s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/66/331466/1/check/gate-ironic-python-agent-pep8/0fec40b/ : SUCCESS in 2m 46s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/66/331466/1/check/gate-ironic-python-agent-python27/370d7ba/ : SUCCESS in 3m 02s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/66/331466/1/check/gate-ironic-python-agent-python34/b8fb9a4/ : SUCCESS in 3m 17s","accounts_in_message":[],"_revision_number":1},{"id":"104d6c55c7bc15770078d17bbe438c4b5765af2b","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-06-20 04:23:17.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"32d57049a6304a21f1675465f9cf4a3be2d80353","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-20 05:52:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2407815fd5e21888a8869edc482f0407608d22f8","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-06-20 06:03:59.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1d2f4c119b9f9bec97b2c469717b81c9cff1d431","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 06:05:33.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs http://logs.openstack.org/66/331466/2/check/gate-ironic-python-agent-docs/92da099/ : POST_FAILURE in 12m 38s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/66/331466/2/check/gate-ironic-python-agent-pep8/2cf3949/ : POST_FAILURE in 9m 17s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/66/331466/2/check/gate-ironic-python-agent-python27/4f525da/ : POST_FAILURE in 12m 12s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/66/331466/2/check/gate-ironic-python-agent-python34/414bd5c/ : POST_FAILURE in 12m 46s","accounts_in_message":[],"_revision_number":2},{"id":"64b9d64a5ac92a7ee16fcc7075d4a53be4a56221","author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"date":"2016-06-20 06:13:36.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"bfdca7c5100826d5bccd5719faee3935de057228","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 06:29:37.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs http://logs.openstack.org/66/331466/3/check/gate-ironic-python-agent-docs/86f75c2/ : POST_FAILURE in 10m 17s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/66/331466/3/check/gate-ironic-python-agent-pep8/d904f27/ : POST_FAILURE in 8m 26s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/66/331466/3/check/gate-ironic-python-agent-python27/d25b3a1/ : POST_FAILURE in 11m 15s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/66/331466/3/check/gate-ironic-python-agent-python34/8a8b1d0/ : POST_FAILURE in 10m 15s","accounts_in_message":[],"_revision_number":3},{"id":"63732fcecfb241a38e818a44eed4425e4e62b85c","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-06-20 13:45:11.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"b6a06280bc41053057607b25a89a18d1243b225c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 14:02:43.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/66/331466/3/check/gate-ironic-python-agent-docs/12bc9b6//doc/build/html/ : SUCCESS in 2m 44s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/66/331466/3/check/gate-ironic-python-agent-pep8/6c484d1/ : SUCCESS in 4m 06s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/66/331466/3/check/gate-ironic-python-agent-python27/ac3d150/ : SUCCESS in 4m 25s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/66/331466/3/check/gate-ironic-python-agent-python34/8ce7740/ : SUCCESS in 3m 17s","accounts_in_message":[],"_revision_number":3},{"id":"e39c93f4aee37234b68735fb79a3e1decfdbbea7","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-06-20 14:04:18.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks Edan","accounts_in_message":[],"_revision_number":3},{"id":"58b6440d641b07ddb655a7d4b58625b863db25fa","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-06-20 17:13:07.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d632a8021a77dfdbe626bcc9c1b47eb6dc9e7448","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 17:13:17.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"4cf3f9390535fbdf554a6a32e59c99f45bf1941c","date":"2016-06-20 17:25:29.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"b7588c52c5fb81075196b4102add5cd0d0e64f92","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 17:25:29.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs http://docs-draft.openstack.org/66/331466/3/gate/gate-ironic-python-agent-docs/4ebb3bd//doc/build/html/ : SUCCESS in 9m 47s\n- gate-ironic-python-agent-pep8 http://logs.openstack.org/66/331466/3/gate/gate-ironic-python-agent-pep8/73a9523/ : SUCCESS in 8m 16s\n- gate-ironic-python-agent-python27 http://logs.openstack.org/66/331466/3/gate/gate-ironic-python-agent-python27/469faac/ : SUCCESS in 11m 34s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/66/331466/3/gate/gate-ironic-python-agent-python34/6f366d3/ : SUCCESS in 10m 52s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"438c69af7c6ce8f33ab64cff2f470ac0cd35ef30","revisions":{"fa0890c0191135db8276da57a40b210ea00259ed":{"kind":"REWORK","_number":1,"created":"2016-06-19 09:57:10.000000000","uploader":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"ref":"refs/changes/66/331466/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/331466/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/1"}}},"commit":{"parents":[{"commit":"da0a8aff88e67fce7603b03a220b77b451349e7d","subject":"Fix unwanted unmounting of /usr/share/oem","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/da0a8aff88e67fce7603b03a220b77b451349e7d"}]}],"author":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-19 09:52:11.000000000","tz":-240},"committer":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-19 09:52:11.000000000","tz":-240},"subject":"Removes the use of mutables as default args","message":"Removes the use of mutables as default args\n\nPassing mutable objects as default args is a known Python pitfall.\nWe\u0027d better avoid this. This commit changes mutable default args with\nNone, \u0027arg \u003d arg or []\u0027.\n\nTrivialFix\n\nChange-Id: I384b24e81543999a8b873e3223cd409ed799ffa0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fa0890c0191135db8276da57a40b210ea00259ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fa0890c0191135db8276da57a40b210ea00259ed"}]},"branch":"refs/heads/master"},"10da3a0b6f200567afb60612a347a2d4d32d0a04":{"kind":"REWORK","_number":2,"created":"2016-06-20 05:52:35.000000000","uploader":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"ref":"refs/changes/66/331466/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/331466/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/2"}}},"commit":{"parents":[{"commit":"da0a8aff88e67fce7603b03a220b77b451349e7d","subject":"Fix unwanted unmounting of /usr/share/oem","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/da0a8aff88e67fce7603b03a220b77b451349e7d"}]}],"author":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-19 09:52:11.000000000","tz":-240},"committer":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-20 05:46:12.000000000","tz":-240},"subject":"Removes the use of mutables as default args","message":"Removes the use of mutables as default args\n\nPassing mutable objects as default args is a known Python pitfall.\nWe\u0027d better avoid this. This commit changes mutable default args with\nNone, \u0027arg \u003d arg or []\u0027.\n\nTrivialFix\n\nChange-Id: I384b24e81543999a8b873e3223cd409ed799ffa0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/10da3a0b6f200567afb60612a347a2d4d32d0a04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/10da3a0b6f200567afb60612a347a2d4d32d0a04"}]},"branch":"refs/heads/master"},"438c69af7c6ce8f33ab64cff2f470ac0cd35ef30":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-06-20 06:13:36.000000000","uploader":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"ref":"refs/changes/66/331466/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/331466/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/331466/3"}}},"commit":{"parents":[{"commit":"da0a8aff88e67fce7603b03a220b77b451349e7d","subject":"Fix unwanted unmounting of /usr/share/oem","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/da0a8aff88e67fce7603b03a220b77b451349e7d"}]}],"author":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-19 09:52:11.000000000","tz":-240},"committer":{"name":"Edan David","email":"edand@mellanox.com","date":"2016-06-20 06:08:12.000000000","tz":-240},"subject":"Removes the use of mutables as default args","message":"Removes the use of mutables as default args\n\nPassing mutable objects as default args is a known Python pitfall.\nWe\u0027d better avoid this. This commit changes mutable default args with\nNone, \u0027arg \u003d [] if arg is None else arg\u0027.\n\nTrivialFix\n\nChange-Id: I384b24e81543999a8b873e3223cd409ed799ffa0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/438c69af7c6ce8f33ab64cff2f470ac0cd35ef30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/438c69af7c6ce8f33ab64cff2f470ac0cd35ef30"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}