)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e932205126b7655f514bd5f165e8b66c8a4399b8","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Update the kernel args to the grub"},{"line_number":133,"context_line":"        if kernel_args:"},{"line_number":134,"context_line":"            for args in kernel_args:"},{"line_number":135,"context_line":"                utils.execute(\u0027chroot %(path)s /bin/bash -c \u0027"},{"line_number":136,"context_line":"                              \u0027\"/usr/sbin/grubby --update-kernel\u003dALL --args\u003d\u0027"},{"line_number":137,"context_line":"                              \u0027%(args)s\"\u0027 % {\u0027path\u0027: path, \u0027args\u0027: args},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_5a47f476","line":134,"updated":"2016-06-29 10:55:32.000000000","message":"why not pass \u0027 \u0027.join(kernel_args) in one grubby call?","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a6a0d5aa2a88629b7e74d9671373f0b82e6d17de","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Update the kernel args to the grub"},{"line_number":133,"context_line":"        if kernel_args:"},{"line_number":134,"context_line":"            for args in kernel_args:"},{"line_number":135,"context_line":"                utils.execute(\u0027chroot %(path)s /bin/bash -c \u0027"},{"line_number":136,"context_line":"                              \u0027\"/usr/sbin/grubby --update-kernel\u003dALL --args\u003d\u0027"},{"line_number":137,"context_line":"                              \u0027%(args)s\"\u0027 % {\u0027path\u0027: path, \u0027args\u0027: args},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_c05e27e8","line":134,"in_reply_to":"3aaa91ec_5a47f476","updated":"2016-06-30 05:39:06.000000000","message":"Done.","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"48d9dbdeefe01ad2b1d56e1a3b326388d35d356b","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Update the kernel args to the grub"},{"line_number":133,"context_line":"        if kernel_args:"},{"line_number":134,"context_line":"            for args in kernel_args:"},{"line_number":135,"context_line":"                utils.execute(\u0027chroot %(path)s /bin/bash -c \u0027"},{"line_number":136,"context_line":"                              \u0027\"/usr/sbin/grubby --update-kernel\u003dALL --args\u003d\u0027"},{"line_number":137,"context_line":"                              \u0027%(args)s\"\u0027 % {\u0027path\u0027: path, \u0027args\u0027: args},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_c333b860","line":134,"in_reply_to":"3aaa91ec_9a0d9591","updated":"2016-06-30 14:23:37.000000000","message":"@Tim, I have verified the changes with tinyipa build, it is working. We have to give the additional quotes (refer https://review.openstack.org/#/c/335052/3/ironic_python_agent/extensions/image.py@136)","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"b1bcb4a286d38171eb12ccc1537d37f7794aec58","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Update the kernel args to the grub"},{"line_number":133,"context_line":"        if kernel_args:"},{"line_number":134,"context_line":"            for args in kernel_args:"},{"line_number":135,"context_line":"                utils.execute(\u0027chroot %(path)s /bin/bash -c \u0027"},{"line_number":136,"context_line":"                              \u0027\"/usr/sbin/grubby --update-kernel\u003dALL --args\u003d\u0027"},{"line_number":137,"context_line":"                              \u0027%(args)s\"\u0027 % {\u0027path\u0027: path, \u0027args\u0027: args},"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9a0d9591","line":134,"in_reply_to":"3aaa91ec_c05e27e8","updated":"2016-06-30 13:35:32.000000000","message":"Just FYI when I tried this in one call, params were missing when the image boot loaded.  That\u0027s why i switched it to this.  Someone should test the all in one to make sure it works.","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e932205126b7655f514bd5f165e8b66c8a4399b8","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                              \u0027%(args)s\"\u0027 % {\u0027path\u0027: path, \u0027args\u0027: args},"},{"line_number":138,"context_line":"                              shell\u003dTrue,"},{"line_number":139,"context_line":"                              env_variables\u003d{\u0027PATH\u0027: path_variable})"},{"line_number":140,"context_line":"            LOG.info(\"Kernel args updated to GRUB\")"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":143,"context_line":"        error_msg \u003d (\u0027Installing GRUB2 boot loader to device %(dev)s \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_ba5ed842","line":140,"updated":"2016-06-29 10:55:32.000000000","message":"please log the new kernel args too","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a6a0d5aa2a88629b7e74d9671373f0b82e6d17de","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                              \u0027%(args)s\"\u0027 % {\u0027path\u0027: path, \u0027args\u0027: args},"},{"line_number":138,"context_line":"                              shell\u003dTrue,"},{"line_number":139,"context_line":"                              env_variables\u003d{\u0027PATH\u0027: path_variable})"},{"line_number":140,"context_line":"            LOG.info(\"Kernel args updated to GRUB\")"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    except processutils.ProcessExecutionError as e:"},{"line_number":143,"context_line":"        error_msg \u003d (\u0027Installing GRUB2 boot loader to device %(dev)s \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9063fbdc","line":140,"in_reply_to":"3aaa91ec_ba5ed842","updated":"2016-06-30 05:39:06.000000000","message":"Done","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e932205126b7655f514bd5f165e8b66c8a4399b8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        :param root_uuid: The UUID of the root partition."},{"line_number":200,"context_line":"        :param efi_system_part_uuid: The UUID of the efi system partition."},{"line_number":201,"context_line":"            To be used only for uefi boot mode.  For uefi boot mode, the"},{"line_number":202,"context_line":"            boot loader will be installed here."},{"line_number":203,"context_line":"        :raises: CommandExecutionError if the installation of the"},{"line_number":204,"context_line":"                 bootloader fails."},{"line_number":205,"context_line":"        :raises: DeviceNotFound if the root partition is not found."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9a595c5e","line":202,"updated":"2016-06-29 10:55:32.000000000","message":"missing :param kernel_args:","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a6a0d5aa2a88629b7e74d9671373f0b82e6d17de","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        :param root_uuid: The UUID of the root partition."},{"line_number":200,"context_line":"        :param efi_system_part_uuid: The UUID of the efi system partition."},{"line_number":201,"context_line":"            To be used only for uefi boot mode.  For uefi boot mode, the"},{"line_number":202,"context_line":"            boot loader will be installed here."},{"line_number":203,"context_line":"        :raises: CommandExecutionError if the installation of the"},{"line_number":204,"context_line":"                 bootloader fails."},{"line_number":205,"context_line":"        :raises: DeviceNotFound if the root partition is not found."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_9572cde1","line":202,"in_reply_to":"3aaa91ec_9a595c5e","updated":"2016-06-30 05:39:06.000000000","message":"Done","commit_id":"6d54d6e0a7e2f036b420ba14b32f521575a01875"}]}