)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f447434e5e7cfe46a55fc49416a3416533810e9","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"                    if key \u003d\u003d \u0027size\u0027:"},{"line_number":638,"context_line":"                        # Since we don\u0027t support units yet we expect the size"},{"line_number":639,"context_line":"                        # in GiB for now"},{"line_number":640,"context_line":"                        value \u003d value / units.Gi"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"                    if not match(key, value, device.name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_5e8eefd0","line":639,"updated":"2016-07-10 09:41:19.000000000","message":"I remember we had a place were we force value to be int(). I can\u0027t find it :/ Lets maybe convert it here just in case? I\u0027ve seen a lot of people passing a string.","commit_id":"31d54d071c229720df76afa1669e59e05f469ee0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"77056667eaea2784fb38b1234e3fb3f0a199f196","unresolved":false,"context_lines":[{"line_number":636,"context_line":""},{"line_number":637,"context_line":"                    if key \u003d\u003d \u0027size\u0027:"},{"line_number":638,"context_line":"                        # Since we don\u0027t support units yet we expect the size"},{"line_number":639,"context_line":"                        # in GiB for now"},{"line_number":640,"context_line":"                        value \u003d value / units.Gi"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"                    if not match(key, value, device.name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_1f63a5dd","line":639,"in_reply_to":"1aa78d24_5e8eefd0","updated":"2016-07-11 13:29:11.000000000","message":"good point, will do","commit_id":"31d54d071c229720df76afa1669e59e05f469ee0"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"49a14ea4eb878f4050a26cfb8520f40062b4eef0","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                        hint_value \u003d int(hint_value)"},{"line_number":616,"context_line":"                    except (ValueError, TypeError):"},{"line_number":617,"context_line":"                        LOG.warning(\u0027Root device hint \"size\" is not an \u0027"},{"line_number":618,"context_line":"                                    \u0027integer. Currently type: %s\u0027,"},{"line_number":619,"context_line":"                                    str(hint_value))"},{"line_number":620,"context_line":"                        return False"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b879b084","line":618,"range":{"start_line":618,"start_character":56,"end_line":618,"end_character":60},"updated":"2016-07-11 21:52:41.000000000","message":"This doesn\u0027t indicate the type, it indicates the actual value","commit_id":"11079a20419ebb286ead755400c5da0fa1fcab74"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"70d7dddac08842faa32313f3d86c4785973d5349","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                        hint_value \u003d int(hint_value)"},{"line_number":616,"context_line":"                    except (ValueError, TypeError):"},{"line_number":617,"context_line":"                        LOG.warning(\u0027Root device hint \"size\" is not an \u0027"},{"line_number":618,"context_line":"                                    \u0027integer. Currently type: %s\u0027,"},{"line_number":619,"context_line":"                                    str(hint_value))"},{"line_number":620,"context_line":"                        return False"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_c887775f","line":618,"range":{"start_line":618,"start_character":56,"end_line":618,"end_character":60},"in_reply_to":"1aa78d24_b83ed088","updated":"2016-07-12 09:06:40.000000000","message":"Ops, good catch! I will update the code","commit_id":"11079a20419ebb286ead755400c5da0fa1fcab74"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"991d90b8e79c0adbdbec4394e326cf409c8d856e","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                        hint_value \u003d int(hint_value)"},{"line_number":616,"context_line":"                    except (ValueError, TypeError):"},{"line_number":617,"context_line":"                        LOG.warning(\u0027Root device hint \"size\" is not an \u0027"},{"line_number":618,"context_line":"                                    \u0027integer. Currently type: %s\u0027,"},{"line_number":619,"context_line":"                                    str(hint_value))"},{"line_number":620,"context_line":"                        return False"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b83ed088","line":618,"range":{"start_line":618,"start_character":56,"end_line":618,"end_character":60},"in_reply_to":"1aa78d24_b879b084","updated":"2016-07-11 21:53:41.000000000","message":"Maybe you can print str(hint_value) as well as type(hint_value) if needed.","commit_id":"11079a20419ebb286ead755400c5da0fa1fcab74"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"f08a611d6d18ac4e8ef333bf3ba90ff2769c9a6a","unresolved":false,"context_lines":[{"line_number":604,"context_line":"            return utils.guess_root_disk(block_devices).name"},{"line_number":605,"context_line":"        else:"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"            def match(hint, current_value, device):"},{"line_number":608,"context_line":"                hint_value \u003d root_device_hints[hint]"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"                if hint \u003d\u003d \u0027rotational\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_06d95e57","line":607,"updated":"2016-07-12 15:02:17.000000000","message":"Since we are refactoring this now, maybe it would be useful to define this helper outside of the function call so that the function doesn\u0027t get created every time get_os_install_device is called.\n\nOn the other hand, perhaps the improved readability is worth the slight performance cost.\n\nJust some thoughts. I still think this is a very nice improvement.","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d7898ad87f5e667d622632a8565629024d404398","unresolved":false,"context_lines":[{"line_number":604,"context_line":"            return utils.guess_root_disk(block_devices).name"},{"line_number":605,"context_line":"        else:"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"            def match(hint, current_value, device):"},{"line_number":608,"context_line":"                hint_value \u003d root_device_hints[hint]"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"                if hint \u003d\u003d \u0027rotational\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_9d147844","line":607,"in_reply_to":"1aa78d24_06d95e57","updated":"2016-07-12 15:24:28.000000000","message":"Good suggestion, I would refrain of doing this as part of this patch. Because the scope of this patch is about refactoring how we deal with the size argument.\n\nBut I can put another patch up for removing this function from the get_os_install_device() scope + updating the unittests to check each function separately.","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"f08a611d6d18ac4e8ef333bf3ba90ff2769c9a6a","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"                elif hint \u003d\u003d \u0027size\u0027:"},{"line_number":614,"context_line":"                    try:"},{"line_number":615,"context_line":"                        hint_value \u003d int(hint_value)"},{"line_number":616,"context_line":"                    except (ValueError, TypeError):"},{"line_number":617,"context_line":"                        LOG.warning("},{"line_number":618,"context_line":"                            \u0027Root device hint \"size\" is not an integer. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_e6eed2eb","line":615,"updated":"2016-07-12 15:02:17.000000000","message":"Perhaps it would be also good to check if this is a positive number here.","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7b7c3c1aa514678b4734c1fbcdac173c8a632e72","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"                elif hint \u003d\u003d \u0027size\u0027:"},{"line_number":614,"context_line":"                    try:"},{"line_number":615,"context_line":"                        hint_value \u003d int(hint_value)"},{"line_number":616,"context_line":"                    except (ValueError, TypeError):"},{"line_number":617,"context_line":"                        LOG.warning("},{"line_number":618,"context_line":"                            \u0027Root device hint \"size\" is not an integer. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_aa5a4c28","line":615,"in_reply_to":"1aa78d24_e67ed2ad","updated":"2016-07-14 16:01:49.000000000","message":"Actually, looking into it I think we should not test this here, but here instead: https://github.com/openstack/ironic/blob/bd8bbf5e7dc3483841aa80a4df1807d24db5631f/ironic/drivers/modules/deploy_utils.py#L684\n\nIronic should validate the hints before it proceeds with the deployment.","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d7898ad87f5e667d622632a8565629024d404398","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"                elif hint \u003d\u003d \u0027size\u0027:"},{"line_number":614,"context_line":"                    try:"},{"line_number":615,"context_line":"                        hint_value \u003d int(hint_value)"},{"line_number":616,"context_line":"                    except (ValueError, TypeError):"},{"line_number":617,"context_line":"                        LOG.warning("},{"line_number":618,"context_line":"                            \u0027Root device hint \"size\" is not an integer. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_e67ed2ad","line":615,"in_reply_to":"1aa78d24_e6eed2eb","updated":"2016-07-12 15:24:28.000000000","message":"good point","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"137d18a1d51bcb72e41397df57b5fc0f1958241d","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                    try:"},{"line_number":615,"context_line":"                        hint_value \u003d int(hint_value)"},{"line_number":616,"context_line":"                    except (ValueError, TypeError):"},{"line_number":617,"context_line":"                        LOG.warning("},{"line_number":618,"context_line":"                            \u0027Root device hint \"size\" is not an integer. \u0027"},{"line_number":619,"context_line":"                            \u0027Current value: \"%(value)s\"; and type: \"%(type)s\"\u0027,"},{"line_number":620,"context_line":"                            {\u0027value\u0027: hint_value, \u0027type\u0027: type(hint_value)})"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_3f0df237","line":617,"updated":"2016-07-19 09:34:49.000000000","message":"I wonder if we should fail completely in this case.. though it\u0027s probably going to be done by ironic anyway","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"e7b303bfc7c55eb371108cd2b88ccec81caec0ea","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                        LOG.warning("},{"line_number":618,"context_line":"                            \u0027Root device hint \"size\" is not an integer. \u0027"},{"line_number":619,"context_line":"                            \u0027Current value: \"%(value)s\"; and type: \"%(type)s\"\u0027,"},{"line_number":620,"context_line":"                            {\u0027value\u0027: hint_value, \u0027type\u0027: type(hint_value)})"},{"line_number":621,"context_line":"                        return False"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"                if hint_value !\u003d current_value:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_2b054379","line":620,"updated":"2016-07-12 14:49:15.000000000","message":"from IRC:\n\n09:43 \u003c mariojv\u003e 1. will hint_value implicitly be converted to a string while logging?\n09:43 \u003c mariojv\u003e 2. does IPA use _(\"log message) for i18n?","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"773638922e38dce4d1b1c5eeb1595b2231cc1b25","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                        LOG.warning("},{"line_number":618,"context_line":"                            \u0027Root device hint \"size\" is not an integer. \u0027"},{"line_number":619,"context_line":"                            \u0027Current value: \"%(value)s\"; and type: \"%(type)s\"\u0027,"},{"line_number":620,"context_line":"                            {\u0027value\u0027: hint_value, \u0027type\u0027: type(hint_value)})"},{"line_number":621,"context_line":"                        return False"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"                if hint_value !\u003d current_value:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_a6b04a44","line":620,"in_reply_to":"1aa78d24_2b054379","updated":"2016-07-12 14:55:50.000000000","message":"Hi there,\n\n1. Yes, so the masks %()s means it\u0027s a string, e.g: http://paste.openstack.org/show/530898/\n\n2. So IPA does not have i18n at the moment.","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"f08a611d6d18ac4e8ef333bf3ba90ff2769c9a6a","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                        LOG.warning("},{"line_number":618,"context_line":"                            \u0027Root device hint \"size\" is not an integer. \u0027"},{"line_number":619,"context_line":"                            \u0027Current value: \"%(value)s\"; and type: \"%(type)s\"\u0027,"},{"line_number":620,"context_line":"                            {\u0027value\u0027: hint_value, \u0027type\u0027: type(hint_value)})"},{"line_number":621,"context_line":"                        return False"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"                if hint_value !\u003d current_value:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_86c8ae56","line":620,"in_reply_to":"1aa78d24_a6b04a44","updated":"2016-07-12 15:02:17.000000000","message":"Thanks, I missed the s at the end of %().","commit_id":"5f09bd03e17d3973c2a5d68f6c407104d3d3b91e"}]}
