)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f443d1a5d064948edf92931b065b186f5e8842e1","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        If multiple hardware managers return the same step name, the following"},{"line_number":356,"context_line":"        logic will be used to determine which manager\u0027s step \"wins\":"},{"line_number":357,"context_line":"        * Keep the step that belongs to HardwareManager with highest"},{"line_number":358,"context_line":"        HardwareSupport (larger int) value."},{"line_number":359,"context_line":"        * If equal support level, keep the step with the higher defined"},{"line_number":360,"context_line":"        priority (larger int)."},{"line_number":361,"context_line":"        * If equal support level and priority, keep the step associated"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_21119f52","line":358,"updated":"2016-07-07 19:38:18.000000000","message":"does this work? I would have thought it would have to be indented.","commit_id":"367fc39d8b277f7b0120c29bd5062eb406869717"}],"ironic_python_agent/tests/functional/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f443d1a5d064948edf92931b065b186f5e8842e1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        :param expect_json: whether to expect a JSON response. if True, convert"},{"line_number":78,"context_line":"                            it to a dict before returning, otherwise return the"},{"line_number":79,"context_line":"                            Response object"},{"line_number":80,"context_line":"        :param kwargs: keyword args to pass to the request method"},{"line_number":81,"context_line":"        :raises: HTTPError if an error is returned that was not expected"},{"line_number":82,"context_line":"        :raises: AssertionError if a received HTTP status code does not match"},{"line_number":83,"context_line":"                 expect_error"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_260a5526","line":80,"updated":"2016-07-07 19:38:18.000000000","message":"I think \"\\*\\*kwargs\" works but I don\u0027t know if it should be \"**kwargs\" or \"kwargs\". So this is fine until someone that knows better can comment :)","commit_id":"367fc39d8b277f7b0120c29bd5062eb406869717"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"20deffce5322a29552c9d8c59560a2c19b6cc0e3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        :raises: HTTPError if an error is returned that was not expected"},{"line_number":82,"context_line":"        :raises: AssertionError if a received HTTP status code does not match"},{"line_number":83,"context_line":"                 expect_error"},{"line_number":84,"context_line":"        :returns: the response object"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        res \u003d requests.request(method, \u0027http://localhost:%s/v1/%s\u0027 %"},{"line_number":87,"context_line":"                               (self.test_port, path), **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_11d78cc0","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":37},"updated":"2016-07-07 21:36:52.000000000","message":"nit: what  you think of s/:returns: the response object/:returns: requests.Response -- the response object/\n\nAs in: http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"57221e58b12a2c4db4957cf13fb4ca74d6d2c685"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f5900d57ff7325a4d8f42742deda4e05d3584fa2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        :raises: HTTPError if an error is returned that was not expected"},{"line_number":82,"context_line":"        :raises: AssertionError if a received HTTP status code does not match"},{"line_number":83,"context_line":"                 expect_error"},{"line_number":84,"context_line":"        :returns: the response object"},{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        res \u003d requests.request(method, \u0027http://localhost:%s/v1/%s\u0027 %"},{"line_number":87,"context_line":"                               (self.test_port, path), **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_8feb1a78","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":37},"in_reply_to":"1aa78d24_11d78cc0","updated":"2016-07-14 18:40:54.000000000","message":"Xavier, that seems like a good idea but outside the scope of this patch.","commit_id":"57221e58b12a2c4db4957cf13fb4ca74d6d2c685"}]}