)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6f197ee7e8c18685d1ad3ebc28611d6a5caf9046","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        \"\"\""},{"line_number":294,"context_line":"        raise errors.IncompatibleHardwareMethodError"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def erase_block_device_metadata(self, node, block_device):"},{"line_number":297,"context_line":"        \"\"\"Attempt to erase a block device metadata."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        The same as \"erase_block_device\" but instead of erasing all"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_46116c03","line":296,"updated":"2016-07-21 16:27:01.000000000","message":"I don\u0027t think we need to add this to the base hardware manager class, as it\u0027s not going to be essential to external hardware managers.","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"988c2f917b2227dcc6e47164696a01785e4c1085","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        \"\"\""},{"line_number":294,"context_line":"        raise errors.IncompatibleHardwareMethodError"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def erase_block_device_metadata(self, node, block_device):"},{"line_number":297,"context_line":"        \"\"\"Attempt to erase a block device metadata."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        The same as \"erase_block_device\" but instead of erasing all"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dfd2315b","line":296,"in_reply_to":"dada55a8_46116c03","updated":"2016-07-21 22:27:14.000000000","message":"agreed, why not in the GenericHardwareManager instead?","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0fe02060cbda6c70c12bc968e117a492bcc3f084","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        \"\"\""},{"line_number":294,"context_line":"        raise errors.IncompatibleHardwareMethodError"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def erase_block_device_metadata(self, node, block_device):"},{"line_number":297,"context_line":"        \"\"\"Attempt to erase a block device metadata."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        The same as \"erase_block_device\" but instead of erasing all"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f223d9a5","line":296,"in_reply_to":"dada55a8_dfd2315b","updated":"2016-07-22 09:25:56.000000000","message":"Done","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"38d57a66b5ea558eae475e86bb3ba9666bff2aea","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        \"\"\"Attempt to erase a block device metadata."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        The same as \"erase_block_device\" but instead of erasing all"},{"line_number":300,"context_line":"        the data this method only destroy the metadata (partition tables,"},{"line_number":301,"context_line":"        signatures, etc...) from the target device."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        :param node: Ironic node object."}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_5f5a332b","line":300,"range":{"start_line":300,"start_character":34,"end_line":300,"end_character":41},"updated":"2016-07-20 06:23:40.000000000","message":"nit: s/destroy/destroys","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0fe02060cbda6c70c12bc968e117a492bcc3f084","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        \"\"\"Attempt to erase a block device metadata."},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        The same as \"erase_block_device\" but instead of erasing all"},{"line_number":300,"context_line":"        the data this method only destroy the metadata (partition tables,"},{"line_number":301,"context_line":"        signatures, etc...) from the target device."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        :param node: Ironic node object."}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_323611e8","line":300,"range":{"start_line":300,"start_character":34,"end_line":300,"end_character":41},"in_reply_to":"dada55a8_5f5a332b","updated":"2016-07-22 09:25:56.000000000","message":"Done","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6f197ee7e8c18685d1ad3ebc28611d6a5caf9046","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            },"},{"line_number":435,"context_line":"            {"},{"line_number":436,"context_line":"                \u0027step\u0027: \u0027erase_devices_metadata\u0027,"},{"line_number":437,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":438,"context_line":"                \u0027interface\u0027: \u0027deploy\u0027,"},{"line_number":439,"context_line":"                \u0027reboot_requested\u0027: False,"},{"line_number":440,"context_line":"                \u0027abortable\u0027: True"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_66aab086","line":437,"updated":"2016-07-21 16:27:01.000000000","message":"Honestly, I could see leaving this enabled as a very high priority. We run a similar step downstream, basically as \"insurance\" that even in case of hardware malfunction, and any cleaning steps whatsoever have run, the machine will never boot into a customer OS again.","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0fe02060cbda6c70c12bc968e117a492bcc3f084","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            },"},{"line_number":435,"context_line":"            {"},{"line_number":436,"context_line":"                \u0027step\u0027: \u0027erase_devices_metadata\u0027,"},{"line_number":437,"context_line":"                \u0027priority\u0027: 0,"},{"line_number":438,"context_line":"                \u0027interface\u0027: \u0027deploy\u0027,"},{"line_number":439,"context_line":"                \u0027reboot_requested\u0027: False,"},{"line_number":440,"context_line":"                \u0027abortable\u0027: True"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_126dcdcc","line":437,"in_reply_to":"dada55a8_66aab086","updated":"2016-07-22 09:25:56.000000000","message":"Cool, I will change it then. I\u0027ve set it to 0 (disabled) first because the erase_devices will already get rid of all the metadata. But I agree that removing the metadata before could be beneficial and the time it takes is also trivial, it should be very quick.","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"38d57a66b5ea558eae475e86bb3ba9666bff2aea","unresolved":false,"context_lines":[{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def erase_block_device_metadata(self, node, block_device):"},{"line_number":782,"context_line":"        # Check if the block device is virtual media and skip the device."},{"line_number":783,"context_line":"        if self._is_virtual_media_device(block_device):"},{"line_number":784,"context_line":"            LOG.info(\"Skipping the erase of virtual media device %s\","},{"line_number":785,"context_line":"                     block_device.name)"},{"line_number":786,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_7f97373a","line":783,"range":{"start_line":783,"start_character":7,"end_line":783,"end_character":55},"updated":"2016-07-20 06:23:40.000000000","message":"Need to add a testcase for this path.","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0fe02060cbda6c70c12bc968e117a492bcc3f084","unresolved":false,"context_lines":[{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def erase_block_device_metadata(self, node, block_device):"},{"line_number":782,"context_line":"        # Check if the block device is virtual media and skip the device."},{"line_number":783,"context_line":"        if self._is_virtual_media_device(block_device):"},{"line_number":784,"context_line":"            LOG.info(\"Skipping the erase of virtual media device %s\","},{"line_number":785,"context_line":"                     block_device.name)"},{"line_number":786,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_326451e4","line":783,"range":{"start_line":783,"start_character":7,"end_line":783,"end_character":55},"in_reply_to":"dada55a8_7f97373a","updated":"2016-07-22 09:25:56.000000000","message":"Done","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"38d57a66b5ea558eae475e86bb3ba9666bff2aea","unresolved":false,"context_lines":[{"line_number":786,"context_line":"            return"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        try:"},{"line_number":789,"context_line":"            disk_utils.destroy_disk_metadata(block_device.name, node[\u0027uuid\u0027])"},{"line_number":790,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":791,"context_line":"            error_msg \u003d (\u0027Failed to erase the metadata on device \"%s\"\u0027 %"},{"line_number":792,"context_line":"                         block_device.name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_1f8f1b2b","line":789,"range":{"start_line":789,"start_character":12,"end_line":789,"end_character":77},"updated":"2016-07-20 06:23:40.000000000","message":"Do we need to return \u0027Success\u0027 or something as this is being captured by caller as a dictionary in the form {device.name: erasure output} ?","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0fe02060cbda6c70c12bc968e117a492bcc3f084","unresolved":false,"context_lines":[{"line_number":786,"context_line":"            return"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        try:"},{"line_number":789,"context_line":"            disk_utils.destroy_disk_metadata(block_device.name, node[\u0027uuid\u0027])"},{"line_number":790,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":791,"context_line":"            error_msg \u003d (\u0027Failed to erase the metadata on device \"%s\"\u0027 %"},{"line_number":792,"context_line":"                         block_device.name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d280554c","line":789,"range":{"start_line":789,"start_character":12,"end_line":789,"end_character":77},"in_reply_to":"dada55a8_1f8f1b2b","updated":"2016-07-22 09:25:56.000000000","message":"I was following the erase_devices one which didn\u0027t return anything. But yeah, I will look into it.","commit_id":"a8161ac7cb200b43e32ab42c0745ec2a9620b910"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9e2c5d4c260803340125003a5a129f0e7048b2a8","unresolved":false,"context_lines":[{"line_number":912,"context_line":"        return out.strip()"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"    def get_clean_steps(self, node, ports):"},{"line_number":915,"context_line":"        clean_steps \u003d super(GenericHardwareManager, self).get_clean_steps("},{"line_number":916,"context_line":"            node, ports)"},{"line_number":917,"context_line":"        clean_steps.append({\u0027step\u0027: \u0027erase_devices_metadata\u0027,"},{"line_number":918,"context_line":"                            \u0027priority\u0027: 20,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_0f810e4e","line":915,"updated":"2016-07-22 15:45:00.000000000","message":"You don\u0027t have to call super here. IPA does the mixing of hardware manager clean steps for you. Just simply return the step you\u0027re adding.","commit_id":"04f8b3e3386138851e6203d006b2063cac2d1917"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"47da24b7f5c3ac4b472a37890a84f4552416fbe3","unresolved":false,"context_lines":[{"line_number":912,"context_line":"        return out.strip()"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"    def get_clean_steps(self, node, ports):"},{"line_number":915,"context_line":"        clean_steps \u003d super(GenericHardwareManager, self).get_clean_steps("},{"line_number":916,"context_line":"            node, ports)"},{"line_number":917,"context_line":"        clean_steps.append({\u0027step\u0027: \u0027erase_devices_metadata\u0027,"},{"line_number":918,"context_line":"                            \u0027priority\u0027: 20,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_6f91aa52","line":915,"in_reply_to":"dada55a8_0f810e4e","updated":"2016-07-22 15:48:27.000000000","message":"Done","commit_id":"04f8b3e3386138851e6203d006b2063cac2d1917"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9e2c5d4c260803340125003a5a129f0e7048b2a8","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        clean_steps \u003d super(GenericHardwareManager, self).get_clean_steps("},{"line_number":916,"context_line":"            node, ports)"},{"line_number":917,"context_line":"        clean_steps.append({\u0027step\u0027: \u0027erase_devices_metadata\u0027,"},{"line_number":918,"context_line":"                            \u0027priority\u0027: 20,"},{"line_number":919,"context_line":"                            \u0027interface\u0027: \u0027deploy\u0027,"},{"line_number":920,"context_line":"                            \u0027reboot_requested\u0027: False,"},{"line_number":921,"context_line":"                            \u0027abortable\u0027: True})"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_4f402608","line":918,"updated":"2016-07-22 15:45:00.000000000","message":"iLO has some clean steps that default to priority: 30, so in order to have this run first, we should set priority \u003e30. I\u0027d suggest something like 99 to ensure it runs first, but given there\u0027s no standard just \u003e30 should be good enough.","commit_id":"04f8b3e3386138851e6203d006b2063cac2d1917"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"47da24b7f5c3ac4b472a37890a84f4552416fbe3","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        clean_steps \u003d super(GenericHardwareManager, self).get_clean_steps("},{"line_number":916,"context_line":"            node, ports)"},{"line_number":917,"context_line":"        clean_steps.append({\u0027step\u0027: \u0027erase_devices_metadata\u0027,"},{"line_number":918,"context_line":"                            \u0027priority\u0027: 20,"},{"line_number":919,"context_line":"                            \u0027interface\u0027: \u0027deploy\u0027,"},{"line_number":920,"context_line":"                            \u0027reboot_requested\u0027: False,"},{"line_number":921,"context_line":"                            \u0027abortable\u0027: True})"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_cf9ed662","line":918,"in_reply_to":"dada55a8_4f402608","updated":"2016-07-22 15:48:27.000000000","message":"Done","commit_id":"04f8b3e3386138851e6203d006b2063cac2d1917"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"37f9a2374aa6743f366ce577a2b007d9b462b19d","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"class GenericHardwareManager(HardwareManager):"},{"line_number":431,"context_line":"    HARDWARE_MANAGER_NAME \u003d \u0027generic_hardware_manager\u0027"},{"line_number":432,"context_line":"    HARDWARE_MANAGER_VERSION \u003d \u00271.0\u0027"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def __init__(self):"},{"line_number":435,"context_line":"        self.sys_path \u003d \u0027/sys\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_8263cc40","line":432,"updated":"2016-07-25 16:23:58.000000000","message":"You need to bump this version since you\u0027re changing cleaning steps.","commit_id":"2a74d527f8ce415c17191c437ab7dee3e17ce90a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"beb9b40f8c3be3f44a962e00267b4ba7aa5ec915","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"class GenericHardwareManager(HardwareManager):"},{"line_number":431,"context_line":"    HARDWARE_MANAGER_NAME \u003d \u0027generic_hardware_manager\u0027"},{"line_number":432,"context_line":"    HARDWARE_MANAGER_VERSION \u003d \u00271.0\u0027"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def __init__(self):"},{"line_number":435,"context_line":"        self.sys_path \u003d \u0027/sys\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_765e5dea","line":432,"in_reply_to":"dada55a8_8263cc40","updated":"2016-07-25 16:34:44.000000000","message":"++\n\nWill submit a new patch-set in a second :-)","commit_id":"2a74d527f8ce415c17191c437ab7dee3e17ce90a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7037b944c29f928b6eeba40732457b9996ce5858","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"            try:"},{"line_number":758,"context_line":"                disk_utils.destroy_disk_metadata(dev.name, node[\u0027uuid\u0027])"},{"line_number":759,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":760,"context_line":"                LOG.error(\u0027Failed to erase the metadata on device \"%(dev)s\". \u0027"},{"line_number":761,"context_line":"                          \u0027Error: %(error)s\u0027, {\u0027dev\u0027: dev.name, \u0027error\u0027: e})"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_fb032940","line":759,"range":{"start_line":759,"start_character":12,"end_line":759,"end_character":59},"updated":"2016-07-26 11:01:21.000000000","message":"Please add a test case for this exception path.","commit_id":"0af6227f6cb2e5a55b1e84b34059173a928451a4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437b0391a9ef2b2c729852ab16204c6d283b726e","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"            try:"},{"line_number":758,"context_line":"                disk_utils.destroy_disk_metadata(dev.name, node[\u0027uuid\u0027])"},{"line_number":759,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":760,"context_line":"                LOG.error(\u0027Failed to erase the metadata on device \"%(dev)s\". \u0027"},{"line_number":761,"context_line":"                          \u0027Error: %(error)s\u0027, {\u0027dev\u0027: dev.name, \u0027error\u0027: e})"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_be14c89f","line":759,"range":{"start_line":759,"start_character":12,"end_line":759,"end_character":59},"in_reply_to":"dada55a8_fb032940","updated":"2016-07-27 10:41:20.000000000","message":"Done","commit_id":"0af6227f6cb2e5a55b1e84b34059173a928451a4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7037b944c29f928b6eeba40732457b9996ce5858","unresolved":false,"context_lines":[{"line_number":757,"context_line":"            try:"},{"line_number":758,"context_line":"                disk_utils.destroy_disk_metadata(dev.name, node[\u0027uuid\u0027])"},{"line_number":759,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":760,"context_line":"                LOG.error(\u0027Failed to erase the metadata on device \"%(dev)s\". \u0027"},{"line_number":761,"context_line":"                          \u0027Error: %(error)s\u0027, {\u0027dev\u0027: dev.name, \u0027error\u0027: e})"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def _shred_block_device(self, node, block_device):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_5b6995f8","line":760,"range":{"start_line":760,"start_character":16,"end_line":760,"end_character":78},"updated":"2016-07-26 11:01:21.000000000","message":"How would this failure communicated back to Ironic to mark clean_step failure?","commit_id":"0af6227f6cb2e5a55b1e84b34059173a928451a4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437b0391a9ef2b2c729852ab16204c6d283b726e","unresolved":false,"context_lines":[{"line_number":757,"context_line":"            try:"},{"line_number":758,"context_line":"                disk_utils.destroy_disk_metadata(dev.name, node[\u0027uuid\u0027])"},{"line_number":759,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":760,"context_line":"                LOG.error(\u0027Failed to erase the metadata on device \"%(dev)s\". \u0027"},{"line_number":761,"context_line":"                          \u0027Error: %(error)s\u0027, {\u0027dev\u0027: dev.name, \u0027error\u0027: e})"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def _shred_block_device(self, node, block_device):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_1e523467","line":760,"range":{"start_line":760,"start_character":16,"end_line":760,"end_character":78},"in_reply_to":"dada55a8_037f98e0","updated":"2016-07-27 10:41:20.000000000","message":"Good point indeed... Looking at the erase_devices clean step it will return a dict in the form of {device name: erasure output}.\n\nLet\u0027s keep this behavior for new cleaning step as well?","commit_id":"0af6227f6cb2e5a55b1e84b34059173a928451a4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a031187297ae04d2a1ff1d73e8838eecaf19a973","unresolved":false,"context_lines":[{"line_number":757,"context_line":"            try:"},{"line_number":758,"context_line":"                disk_utils.destroy_disk_metadata(dev.name, node[\u0027uuid\u0027])"},{"line_number":759,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":760,"context_line":"                LOG.error(\u0027Failed to erase the metadata on device \"%(dev)s\". \u0027"},{"line_number":761,"context_line":"                          \u0027Error: %(error)s\u0027, {\u0027dev\u0027: dev.name, \u0027error\u0027: e})"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def _shred_block_device(self, node, block_device):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_037f98e0","line":760,"range":{"start_line":760,"start_character":16,"end_line":760,"end_character":78},"in_reply_to":"dada55a8_5b6995f8","updated":"2016-07-26 18:50:17.000000000","message":"That\u0027s a good point; shouldn\u0027t we just raise the error through here?","commit_id":"0af6227f6cb2e5a55b1e84b34059173a928451a4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"165647f2a1ea2deee9c11f5c6eb2c2bd81ce004b","unresolved":false,"context_lines":[{"line_number":767,"context_line":"            except processutils.ProcessExecutionError as e:"},{"line_number":768,"context_line":"                LOG.error(\u0027Failed to erase the metadata on device \"%(dev)s\". \u0027"},{"line_number":769,"context_line":"                          \u0027Error: %(error)s\u0027, {\u0027dev\u0027: dev.name, \u0027error\u0027: e})"},{"line_number":770,"context_line":"                erase_results[dev.name] \u003d (\u0027Error when erasing the device \u0027"},{"line_number":771,"context_line":"                                           \u0027metadata. Error: %s\u0027 % e)"},{"line_number":772,"context_line":"        return erase_results"},{"line_number":773,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_52410139","line":770,"updated":"2016-07-27 16:13:35.000000000","message":"You still aren\u0027t bubbling up this error. In erase_devices, we eventually raise an error if we can\u0027t erase the device. We need to do the same here.","commit_id":"b87ab525d6ea1ca0faa2c2e1cd93f32d754529da"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4652ca483e4bb8d7553876323a743210b39c9c2c","unresolved":false,"context_lines":[{"line_number":768,"context_line":"                             \u0027\"%(dev)s\". Error: %(error)s\u0027 % {\u0027dev\u0027: dev.name,"},{"line_number":769,"context_line":"                                                              \u0027error\u0027: e})"},{"line_number":770,"context_line":"                LOG.error(error_msg)"},{"line_number":771,"context_line":"                raise errors.BlockDeviceEraseError(error_msg)"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    def _shred_block_device(self, node, block_device):"},{"line_number":774,"context_line":"        \"\"\"Erase a block device using shred."}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_d048255e","line":771,"range":{"start_line":771,"start_character":16,"end_line":771,"end_character":61},"updated":"2016-07-28 09:42:40.000000000","message":"Exception is raised upon hitting first error, it would be better to accumulate the devices where this fails and then raise a single exception listing all failed devices.","commit_id":"aaf1baad54408865c3c4897d39110fc91368709f"}],"releasenotes/notes/erase-device-metadata-clean-step-31b4a615c0ff7f18.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"932f3fc16d06ed172e89da4934ca3f1e27d9140e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Add a new cleaning step called \"erase_devices_metadata\" to the generic"},{"line_number":4,"context_line":"    hardware manager which is responsible for destroying the metadata"},{"line_number":5,"context_line":"    on the disk devices (partition tables, signatures, file-system"},{"line_number":6,"context_line":"    identifications, etc...)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_85a2ff98","line":6,"updated":"2016-07-22 16:12:22.000000000","message":"I wonder if we should add a release note about the change to HW.get_clean_steps()?\n\nI\u0027m thinking no.","commit_id":"2a74d527f8ce415c17191c437ab7dee3e17ce90a"}]}
