)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2cbf0e02cbef017f17e9b3059f220fb3da5e40cc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"time to finish the work, this changes to do it in parallel"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If5cfb6ec000a654d07103c4b378d4c135249e238"},{"line_number":13,"context_line":"Closes-Bug: #1546949"},{"line_number":14,"context_line":"Co-Authored-By: yuan liang \u003cleetpy2@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f79a3b5_34f14101","line":13,"updated":"2018-10-01 15:42:12.000000000","message":"please update to use a link to the story, not launchpad","commit_id":"7ab1624ab260ab277a12204be13f23187432233c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1149f2a2d007996ee2ba77b1915b9a8a73637fc7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"time to finish the work, this changes to do it in parallel"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If5cfb6ec000a654d07103c4b378d4c135249e238"},{"line_number":13,"context_line":"Closes-Bug: #1546949"},{"line_number":14,"context_line":"Co-Authored-By: yuan liang \u003cleetpy2@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3f79a3b5_1c13725b","line":13,"in_reply_to":"3f79a3b5_34f14101","updated":"2018-10-09 04:01:42.000000000","message":"Done","commit_id":"7ab1624ab260ab277a12204be13f23187432233c"}],"ironic_python_agent/config.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9cf45aa256c6bc98f68c64266fcb2ba6e4309af6","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                help\u003d\u0027Verify HTTPS connections. Can be supplied as \u0027"},{"line_number":197,"context_line":"                     \u0027\"ipa-insecure\" kernel parameter.\u0027),"},{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase_disk_parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallel erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, each disk erase in a process.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_7e366eb5","line":199,"range":{"start_line":199,"start_character":37,"end_line":199,"end_character":56},"updated":"2018-08-03 00:57:23.000000000","message":"to be consistent, maybe ``erase-disk-parallel``?","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":25675,"name":"yuan liang","email":"leetpy2@gmail.com","username":"leetpy"},"change_message_id":"a281810187ef17ed8c6a2f0c957a63482703ea00","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                help\u003d\u0027Verify HTTPS connections. Can be supplied as \u0027"},{"line_number":197,"context_line":"                     \u0027\"ipa-insecure\" kernel parameter.\u0027),"},{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase_disk_parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallel erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, each disk erase in a process.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_0c17f99f","line":199,"range":{"start_line":199,"start_character":37,"end_line":199,"end_character":56},"in_reply_to":"5f7c97a3_7e366eb5","updated":"2018-08-14 03:23:16.000000000","message":"Done","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9cf45aa256c6bc98f68c64266fcb2ba6e4309af6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                     \u0027\"ipa-insecure\" kernel parameter.\u0027),"},{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase_disk_parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallel erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, each disk erase in a process.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"},{"line_number":203,"context_line":"               help\u003d\u0027Path to PEM encoded Certificate Authority file \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_3e5556c1","line":200,"range":{"start_line":200,"start_character":52,"end_line":200,"end_character":60},"updated":"2018-08-03 00:57:23.000000000","message":"nit: parallelly","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":25675,"name":"yuan liang","email":"leetpy2@gmail.com","username":"leetpy"},"change_message_id":"a281810187ef17ed8c6a2f0c957a63482703ea00","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                     \u0027\"ipa-insecure\" kernel parameter.\u0027),"},{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase_disk_parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallel erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, each disk erase in a process.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"},{"line_number":203,"context_line":"               help\u003d\u0027Path to PEM encoded Certificate Authority file \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_cc76e10c","line":200,"range":{"start_line":200,"start_character":52,"end_line":200,"end_character":60},"in_reply_to":"5f7c97a3_3e5556c1","updated":"2018-08-14 03:23:16.000000000","message":"Done","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9cf45aa256c6bc98f68c64266fcb2ba6e4309af6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase_disk_parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallel erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, each disk erase in a process.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"},{"line_number":203,"context_line":"               help\u003d\u0027Path to PEM encoded Certificate Authority file \u0027"},{"line_number":204,"context_line":"                    \u0027to use when verifying HTTPS connections. \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_bee3a602","line":201,"range":{"start_line":201,"start_character":39,"end_line":201,"end_character":67},"updated":"2018-08-03 00:57:23.000000000","message":"perhaps, we can reword like this: processes will be created for each disk to be erased.","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":25675,"name":"yuan liang","email":"leetpy2@gmail.com","username":"leetpy"},"change_message_id":"a281810187ef17ed8c6a2f0c957a63482703ea00","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase_disk_parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallel erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, each disk erase in a process.\u0027),"},{"line_number":202,"context_line":"    cfg.StrOpt(\u0027cafile\u0027,"},{"line_number":203,"context_line":"               help\u003d\u0027Path to PEM encoded Certificate Authority file \u0027"},{"line_number":204,"context_line":"                    \u0027to use when verifying HTTPS connections. \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_6c7b0df3","line":201,"range":{"start_line":201,"start_character":39,"end_line":201,"end_character":67},"in_reply_to":"5f7c97a3_bee3a602","updated":"2018-08-14 03:23:16.000000000","message":"Done","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2cbf0e02cbef017f17e9b3059f220fb3da5e40cc","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                help\u003d\u0027Verify HTTPS connections. Can be supplied as \u0027"},{"line_number":197,"context_line":"                     \u0027\"ipa-insecure\" kernel parameter.\u0027),"},{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase-disk-parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallelly erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, processes will be created for each \u0027"},{"line_number":202,"context_line":"                     \u0027disk to be erased.\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_f4f2e9e2","line":199,"updated":"2018-10-01 15:42:12.000000000","message":"should the default be True or False. If we want existing behavior, seems like we\u0027d want False.","commit_id":"7ab1624ab260ab277a12204be13f23187432233c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"dee18bdb0f320509b9a947e4b0227bda8e706474","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                help\u003d\u0027Verify HTTPS connections. Can be supplied as \u0027"},{"line_number":197,"context_line":"                     \u0027\"ipa-insecure\" kernel parameter.\u0027),"},{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase-disk-parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallelly erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, processes will be created for each \u0027"},{"line_number":202,"context_line":"                     \u0027disk to be erased.\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_d8cc46c0","line":199,"in_reply_to":"3f79a3b5_f4f2e9e2","updated":"2018-10-07 02:57:50.000000000","message":"I concur, it should be set to false for the backwards compatibility.\nAs Julia mentioned, it is expected to be controlled from ironic side, so this option does not necessarily exist, unless we want both.","commit_id":"7ab1624ab260ab277a12204be13f23187432233c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1149f2a2d007996ee2ba77b1915b9a8a73637fc7","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                help\u003d\u0027Verify HTTPS connections. Can be supplied as \u0027"},{"line_number":197,"context_line":"                     \u0027\"ipa-insecure\" kernel parameter.\u0027),"},{"line_number":198,"context_line":"    cfg.BoolOpt(\u0027erase_disk_parallel\u0027,"},{"line_number":199,"context_line":"                default\u003dAPARAMS.get(\u0027erase-disk-parallel\u0027, True),"},{"line_number":200,"context_line":"                help\u003d\u0027Whether IPA should attempt to parallelly erase disk \u0027"},{"line_number":201,"context_line":"                     \u0027devices. If set, processes will be created for each \u0027"},{"line_number":202,"context_line":"                     \u0027disk to be erased.\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_fceeb6b3","line":199,"in_reply_to":"3f79a3b5_f4f2e9e2","updated":"2018-10-09 04:01:42.000000000","message":"Removed this option, I think it didn\u0027t provide much help since we\u0027ll control it from ironic.","commit_id":"7ab1624ab260ab277a12204be13f23187432233c"}],"ironic_python_agent/hardware.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"e1f4e3025bb1500c6cc03dfe58802b51b731cb13","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        \"\"\""},{"line_number":326,"context_line":"        erase_results \u003d {}"},{"line_number":327,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":328,"context_line":"        thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":329,"context_line":"        for block_device in block_devices:"},{"line_number":330,"context_line":"            params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":331,"context_line":"            erase_results[block_device.name] \u003d thread_pool.apply_async("}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_6577bd9f","line":328,"updated":"2016-07-25 17:49:56.000000000","message":"I\u0027m curious what people would think about making this configurable instead of forcing 1 thread per device here. I don\u0027t see a huge disadvantage to having 1 thread per device, but maybe it\u0027s something to consider.","commit_id":"c6065b89903e1f4829061ce7296df453fa3bffac"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"76da46862439c5fdbeae73b4544f00509572f776","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        \"\"\""},{"line_number":326,"context_line":"        erase_results \u003d {}"},{"line_number":327,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":328,"context_line":"        thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":329,"context_line":"        for block_device in block_devices:"},{"line_number":330,"context_line":"            params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":331,"context_line":"            erase_results[block_device.name] \u003d thread_pool.apply_async("}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_474a2a56","line":328,"in_reply_to":"dada55a8_6577bd9f","updated":"2016-07-27 08:01:46.000000000","message":"thanks for the review Mario, erasing devices parallel seems to be an improvement than doing it one by one, so I\u0027m confused why we need to add a config for costing more time.","commit_id":"c6065b89903e1f4829061ce7296df453fa3bffac"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"e1f4e3025bb1500c6cc03dfe58802b51b731cb13","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":329,"context_line":"        for block_device in block_devices:"},{"line_number":330,"context_line":"            params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":331,"context_line":"            erase_results[block_device.name] \u003d thread_pool.apply_async("},{"line_number":332,"context_line":"                dispatch_to_managers, (\u0027erase_block_device\u0027, ), params)"},{"line_number":333,"context_line":"        thread_pool.close()"},{"line_number":334,"context_line":"        thread_pool.join()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_65d33d60","line":331,"updated":"2016-07-25 17:49:56.000000000","message":"I\u0027d like to see tests updated (or a new test added) to make sure that apply_async is called.\n\nhttps://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/tests/unit/test_hardware.py#L787","commit_id":"c6065b89903e1f4829061ce7296df453fa3bffac"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"76da46862439c5fdbeae73b4544f00509572f776","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":329,"context_line":"        for block_device in block_devices:"},{"line_number":330,"context_line":"            params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":331,"context_line":"            erase_results[block_device.name] \u003d thread_pool.apply_async("},{"line_number":332,"context_line":"                dispatch_to_managers, (\u0027erase_block_device\u0027, ), params)"},{"line_number":333,"context_line":"        thread_pool.close()"},{"line_number":334,"context_line":"        thread_pool.join()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_aadf660b","line":331,"in_reply_to":"dada55a8_65d33d60","updated":"2016-07-27 08:01:46.000000000","message":"Done","commit_id":"c6065b89903e1f4829061ce7296df453fa3bffac"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8a59ea1ca726d40215f7e71ec69a901fc585e61e","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        erase_results \u003d {}"},{"line_number":391,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":394,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":395,"context_line":"            for block_device in block_devices:"},{"line_number":396,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_dc57f3c9","line":393,"updated":"2018-08-10 17:35:29.000000000","message":"Should this also be a conductor driven option as well?  Asking since many operators don\u0027t modify their ramdisks that often, but they do modify their conductor configuration, and we have an established pattern to tell IPA of settings in driver_internal_info.","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3e4332b37cbf7d4a8ef569cca2174cf79e275903","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        erase_results \u003d {}"},{"line_number":391,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":394,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":395,"context_line":"            for block_device in block_devices:"},{"line_number":396,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_f1f0cdff","line":393,"in_reply_to":"3f79a3b5_dc57f3c9","updated":"2018-08-11 01:59:49.000000000","message":"This option is retrieved from APARAMS, which comes from kernel command line, we have pxe_append_params at ironic side, so it\u0027s fine. Perhaps we needs an documentation update.","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8a59ea1ca726d40215f7e71ec69a901fc585e61e","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":394,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":395,"context_line":"            for block_device in block_devices:"},{"line_number":396,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":397,"context_line":"                erase_results[block_device.name] \u003d thread_pool.apply_async("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_fc2aef29","line":394,"updated":"2018-08-10 17:35:29.000000000","message":"What if len returns 0?","commit_id":"edcb9d910c0c547c4243964cd8149ec22be8af67"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"922a9dfcc93cdf81e6e34c3ccad607c2b27dcefa","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":394,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":395,"context_line":"            for block_device in block_devices:"},{"line_number":396,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":397,"context_line":"                erase_results[block_device.name] \u003d thread_pool.apply_async("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_bff789d3","line":394,"range":{"start_line":394,"start_character":37,"end_line":394,"end_character":55},"updated":"2018-08-10 17:37:45.000000000","message":"what happens when len returns 0?","commit_id":"a6fd76bc8beba36c2f021aab7a86a82e6d819fdb"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"3e4332b37cbf7d4a8ef569cca2174cf79e275903","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        block_devices \u003d self.list_block_devices()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":394,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":395,"context_line":"            for block_device in block_devices:"},{"line_number":396,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":397,"context_line":"                erase_results[block_device.name] \u003d thread_pool.apply_async("}],"source_content_type":"text/x-python","patch_set":10,"id":"3f79a3b5_b199f5c4","line":394,"range":{"start_line":394,"start_character":37,"end_line":394,"end_character":55},"in_reply_to":"3f79a3b5_bff789d3","updated":"2018-08-11 01:59:49.000000000","message":"It will raise a ValueError exception, we could add a check after L391","commit_id":"a6fd76bc8beba36c2f021aab7a86a82e6d819fdb"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5d239d36e4e24ddf2b81a25556de8b5a5ac8a804","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if not len(block_devices):"},{"line_number":393,"context_line":"            return {}"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":396,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":397,"context_line":"            for block_device in block_devices:"},{"line_number":398,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_07c34408","line":395,"updated":"2018-09-25 02:41:23.000000000","message":"FYI, we generally allow for this to be conductor side configuration in the [agent] section. See around line 796 for an example of the logic we typically put into the agent.","commit_id":"19a9e54a38e0192bec36749331538f35aeaf519c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"605f064641c77050186e9c864943621cca382527","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if not len(block_devices):"},{"line_number":393,"context_line":"            return {}"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":396,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":397,"context_line":"            for block_device in block_devices:"},{"line_number":398,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_3070d873","line":395,"in_reply_to":"3f79a3b5_07c34408","updated":"2018-09-26 07:40:20.000000000","message":"Hmm, that needs a patch from ironic side, I hope this small fix won\u0027t require a spec :)","commit_id":"19a9e54a38e0192bec36749331538f35aeaf519c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"784f125fb397751cb3c9bc7ac2848880f086d2d7","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if not len(block_devices):"},{"line_number":393,"context_line":"            return {}"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":396,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":397,"context_line":"            for block_device in block_devices:"},{"line_number":398,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f79a3b5_d5a7e8bb","line":395,"in_reply_to":"3f79a3b5_3070d873","updated":"2018-09-27 20:01:05.000000000","message":"It _can_ use both potentially :)  And the ironic side is something like 6 lines of code. It is a well known pattern, no spec required.","commit_id":"19a9e54a38e0192bec36749331538f35aeaf519c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2cbf0e02cbef017f17e9b3059f220fb3da5e40cc","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        if not len(block_devices):"},{"line_number":395,"context_line":"            return {}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":398,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":399,"context_line":"            for block_device in block_devices:"},{"line_number":400,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_f4e0a9fa","line":397,"updated":"2018-10-01 15:42:12.000000000","message":"presumably, the number of block_devices is small, so we don\u0027t need to worry about restricting the number of threads? Otherwise, we could change erase_disk_parallel to be max number of threads, which could be icky. (Just thought I\u0027d mention this.)","commit_id":"7ab1624ab260ab277a12204be13f23187432233c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"1149f2a2d007996ee2ba77b1915b9a8a73637fc7","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        if not len(block_devices):"},{"line_number":395,"context_line":"            return {}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        if CONF.erase_disk_parallel:"},{"line_number":398,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":399,"context_line":"            for block_device in block_devices:"},{"line_number":400,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f79a3b5_3ccc2e61","line":397,"in_reply_to":"3f79a3b5_f4e0a9fa","updated":"2018-10-09 04:01:42.000000000","message":"I think a boolean is suitable here, dozens of disks is the most case I have seen, surely there are other cases I didn\u0027t experience, but I think it fits in most cases.\nIf it really becomes an issue, I think we can handle that by introducing a new integer option to set the maximum number of threads, wdyt?","commit_id":"7ab1624ab260ab277a12204be13f23187432233c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6e2f8e70a545fea61a691f098d1594c8b5824334","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import binascii"},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"from multiprocessing.dummy import Pool as ThreadPool"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import shlex"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_dbe52bdd","line":19,"updated":"2018-10-18 10:13:54.000000000","message":"let\u0027s import ThreadPool from multiprocessing.pool to avoid any confusion around \"dummy\"","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6ec40f5631e81422883dd4e1bb91685a19f1d559","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import binascii"},{"line_number":17,"context_line":"import functools"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"from multiprocessing.dummy import Pool as ThreadPool"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import shlex"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_a801d109","line":19,"in_reply_to":"3f79a3b5_dbe52bdd","updated":"2018-10-22 03:35:44.000000000","message":"Done\n\nI am not sure which one is less confusing, dummy is officially documented, while multiprocessing.pool.ThreadPool is not.","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6e2f8e70a545fea61a691f098d1594c8b5824334","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            return {}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":398,"context_line":"        in_parallel \u003d info.get(\u0027agent_enable_parallel_erasure\u0027, False)"},{"line_number":399,"context_line":"        if in_parallel:"},{"line_number":400,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":401,"context_line":"            for block_device in block_devices:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_7bcad747","line":398,"updated":"2018-10-18 10:13:54.000000000","message":"Instead of True/False, let\u0027s add disk_erasure_concurrency (you don\u0027t need to prefix it with \"agent_\") that will provide the size of the thread pool. Then set it to 1 by default to keep the previous behavior.","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"454e77c9a61e0a840429539ec71135b701855fdb","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            return {}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":398,"context_line":"        in_parallel \u003d info.get(\u0027agent_enable_parallel_erasure\u0027, False)"},{"line_number":399,"context_line":"        if in_parallel:"},{"line_number":400,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":401,"context_line":"            for block_device in block_devices:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_db666e29","line":398,"in_reply_to":"3f79a3b5_4a892e23","updated":"2018-10-19 12:37:01.000000000","message":"I think it is fine, we seem to use eventlet anyway..","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6ec40f5631e81422883dd4e1bb91685a19f1d559","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            return {}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":398,"context_line":"        in_parallel \u003d info.get(\u0027agent_enable_parallel_erasure\u0027, False)"},{"line_number":399,"context_line":"        if in_parallel:"},{"line_number":400,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":401,"context_line":"            for block_device in block_devices:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_e88269a6","line":398,"in_reply_to":"3f79a3b5_7bcad747","updated":"2018-10-22 03:35:44.000000000","message":"Done","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"09dd4aceb85f512c495e590130eb6966598bd7d4","unresolved":false,"context_lines":[{"line_number":395,"context_line":"            return {}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":398,"context_line":"        in_parallel \u003d info.get(\u0027agent_enable_parallel_erasure\u0027, False)"},{"line_number":399,"context_line":"        if in_parallel:"},{"line_number":400,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":401,"context_line":"            for block_device in block_devices:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_4a892e23","line":398,"in_reply_to":"3f79a3b5_7bcad747","updated":"2018-10-19 08:58:56.000000000","message":"so we use threading anyway? this is also suggested by rloo in the previous patchset.","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b8c37305f7f1d5225bf9b41e07095854a3311dc1","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":398,"context_line":"        in_parallel \u003d info.get(\u0027agent_enable_parallel_erasure\u0027, False)"},{"line_number":399,"context_line":"        if in_parallel:"},{"line_number":400,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":401,"context_line":"            for block_device in block_devices:"},{"line_number":402,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_b2b065de","line":399,"range":{"start_line":399,"start_character":11,"end_line":399,"end_character":22},"updated":"2018-10-09 06:30:00.000000000","message":"if another revision is required, will change this to:\n\n  if len(block_devices) \u003e 1 and in_parallel:","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"769c8df18b0ac1fae6e0556376a54bc23c3bf02f","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":398,"context_line":"        in_parallel \u003d info.get(\u0027agent_enable_parallel_erasure\u0027, False)"},{"line_number":399,"context_line":"        if in_parallel:"},{"line_number":400,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":401,"context_line":"            for block_device in block_devices:"},{"line_number":402,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_d1ae83e3","line":399,"range":{"start_line":399,"start_character":11,"end_line":399,"end_character":22},"in_reply_to":"3f79a3b5_b2b065de","updated":"2018-10-17 13:34:57.000000000","message":"or as a follow-up :)","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6c3532e0305ef820a2453996e1aa83bc11e28fa7","unresolved":false,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        info \u003d node.get(\u0027driver_internal_info\u0027, {})"},{"line_number":398,"context_line":"        in_parallel \u003d info.get(\u0027agent_enable_parallel_erasure\u0027, False)"},{"line_number":399,"context_line":"        if in_parallel:"},{"line_number":400,"context_line":"            thread_pool \u003d ThreadPool(len(block_devices))"},{"line_number":401,"context_line":"            for block_device in block_devices:"},{"line_number":402,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_c1c0e3fc","line":399,"range":{"start_line":399,"start_character":11,"end_line":399,"end_character":22},"in_reply_to":"3f79a3b5_d1ae83e3","updated":"2018-10-18 05:56:09.000000000","message":"follow up is fine, what makes me feel uncomfortable is this feature is not covered by ci jobs.","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6e2f8e70a545fea61a691f098d1594c8b5824334","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            for block_device in block_devices:"},{"line_number":402,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":403,"context_line":"                erase_results[block_device.name] \u003d thread_pool.apply_async("},{"line_number":404,"context_line":"                    dispatch_to_managers, (\u0027erase_block_device\u0027, ), params)"},{"line_number":405,"context_line":"            thread_pool.close()"},{"line_number":406,"context_line":"            thread_pool.join()"},{"line_number":407,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_9bc7b33e","line":404,"updated":"2018-10-18 10:13:54.000000000","message":"Let us update the docstring of erase_block_device to mention that it must be thread-safe now. It also deserves mentioning on the release notes.","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6ec40f5631e81422883dd4e1bb91685a19f1d559","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            for block_device in block_devices:"},{"line_number":402,"context_line":"                params \u003d {\u0027node\u0027: node, \u0027block_device\u0027: block_device}"},{"line_number":403,"context_line":"                erase_results[block_device.name] \u003d thread_pool.apply_async("},{"line_number":404,"context_line":"                    dispatch_to_managers, (\u0027erase_block_device\u0027, ), params)"},{"line_number":405,"context_line":"            thread_pool.close()"},{"line_number":406,"context_line":"            thread_pool.join()"},{"line_number":407,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_087ec5bf","line":404,"in_reply_to":"3f79a3b5_9bc7b33e","updated":"2018-10-22 03:35:44.000000000","message":"Done","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6e2f8e70a545fea61a691f098d1594c8b5824334","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"            for device_name, result in erase_results.items():"},{"line_number":409,"context_line":"                erase_results[device_name] \u003d result.get()"},{"line_number":410,"context_line":"        else:"},{"line_number":411,"context_line":"            for block_device in block_devices:"},{"line_number":412,"context_line":"                result \u003d dispatch_to_managers("},{"line_number":413,"context_line":"                    \u0027erase_block_device\u0027, node\u003dnode, block_device\u003dblock_device)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_3bd45fea","line":410,"updated":"2018-10-18 10:13:54.000000000","message":"I\u0027d prefer to avoid special-casing in_parallel\u003dFalse - see above","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6ec40f5631e81422883dd4e1bb91685a19f1d559","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"            for device_name, result in erase_results.items():"},{"line_number":409,"context_line":"                erase_results[device_name] \u003d result.get()"},{"line_number":410,"context_line":"        else:"},{"line_number":411,"context_line":"            for block_device in block_devices:"},{"line_number":412,"context_line":"                result \u003d dispatch_to_managers("},{"line_number":413,"context_line":"                    \u0027erase_block_device\u0027, node\u003dnode, block_device\u003dblock_device)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f79a3b5_a8deb1d8","line":410,"in_reply_to":"3f79a3b5_3bd45fea","updated":"2018-10-22 03:35:44.000000000","message":"Done","commit_id":"32370993b49ee9c2e0e88e66746ed28f817b7abc"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d9d954325e7a5d553ce39e2d2651c90b34b9b373","unresolved":false,"context_lines":[{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"        result \u003d self.hardware.erase_devices(self.node, [])"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        self.assertTrue(mocked_async.called)"},{"line_number":1322,"context_line":"        self.assertEqual(expected, result)"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"    @mock.patch.object(hardware, \u0027ThreadPool\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_ca1af07e","line":1321,"updated":"2018-10-22 18:57:34.000000000","message":"Ideally we should be verifying the calls made to this method to ensure that it was indeed called twice to launch both erasures.","commit_id":"1ee42cc3ff585abd370c2e7974951c93f2816394"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"f7d4e56532f31151272fda646b1353873bc46929","unresolved":false,"context_lines":[{"line_number":1318,"context_line":""},{"line_number":1319,"context_line":"        result \u003d self.hardware.erase_devices(self.node, [])"},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        self.assertTrue(mocked_async.called)"},{"line_number":1322,"context_line":"        self.assertEqual(expected, result)"},{"line_number":1323,"context_line":""},{"line_number":1324,"context_line":"    @mock.patch.object(hardware, \u0027ThreadPool\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_9a1d0279","line":1321,"in_reply_to":"3f79a3b5_ca1af07e","updated":"2018-10-24 02:55:47.000000000","message":"Indeed, I have posted a follow up https://review.openstack.org/#/c/612874/ to ensure that, thanks!","commit_id":"1ee42cc3ff585abd370c2e7974951c93f2816394"}],"releasenotes/notes/parallel-erase-disk-devices-09ea33d5443aead0.yaml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0e7138bc2497a31e9861748147acdd13ff2ffd80","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support parallel erase disk devices through kernel command line parameter"},{"line_number":4,"context_line":"    `erase_disk_parallel`."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_a6051913","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":25},"updated":"2018-08-14 02:32:21.000000000","message":"The command line option is exposed as erase-disk-parallel, also please use double quotes.","commit_id":"5e39d60ba6fec8b1766bd76dc85e6ddabd5e8b31"},{"author":{"_account_id":25675,"name":"yuan liang","email":"leetpy2@gmail.com","username":"leetpy"},"change_message_id":"bda0bcd795b8c41008826002d2137bb4291e994a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support parallel erase disk devices through kernel command line parameter"},{"line_number":4,"context_line":"    `erase_disk_parallel`."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_86f1fd6d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":25},"in_reply_to":"3f79a3b5_a6051913","updated":"2018-08-14 11:37:37.000000000","message":"Done","commit_id":"5e39d60ba6fec8b1766bd76dc85e6ddabd5e8b31"}]}
