)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e454c4927a4ba4f2da5f9d9fb860b3308cd133f1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  * /opt/stack/new/requirements/upper-constraints.txt"},{"line_number":24,"context_line":"  * upper-constraints.txt from openstack/requirements git repository"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partial-bug: #1611528"},{"line_number":27,"context_line":"Change-Id: Ib5c0c57cafdb6ffd7456e61f3b1bb5fa57520e5a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1ac06dbe_5bc6394a","line":26,"updated":"2016-08-24 15:52:53.000000000","message":"This isn\u0027t really the bug.\n\nProbably a new bug should be created that says ramdisk building doesn\u0027t honor upper constraints","commit_id":"ced3a9814bc09f2afc5d5604bc5151b36f5a41ab"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"8b4cd9876c35638764754b77244f6d5b2951b7b2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  * /opt/stack/new/requirements/upper-constraints.txt"},{"line_number":24,"context_line":"  * upper-constraints.txt from openstack/requirements git repository"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Partial-bug: #1611528"},{"line_number":27,"context_line":"Change-Id: Ib5c0c57cafdb6ffd7456e61f3b1bb5fa57520e5a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1ac06dbe_6fda4feb","line":26,"in_reply_to":"1ac06dbe_5bc6394a","updated":"2016-08-24 17:06:04.000000000","message":"You\u0027re right. Fixed.","commit_id":"ced3a9814bc09f2afc5d5604bc5151b36f5a41ab"}],"Dockerfile":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"af9f57ea1f1658562118de8e3881a1678af819a1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Install requirements separately, because pip understands a git+https url"},{"line_number":40,"context_line":"# while setuptools doesn\u0027t"},{"line_number":41,"context_line":"RUN proxy.sh pip install --upgrade pip"},{"line_number":42,"context_line":"# NOTE(mmitchell): pip honors the PIP_CONSTRAINTS environment variable"},{"line_number":43,"context_line":"#                  configured by docker_build.sh in proxy.sh"},{"line_number":44,"context_line":"RUN proxy.sh pip install --no-cache-dir -r /tmp/ironic-python-agent/requirements.txt"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"1ac06dbe_652dd894","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":49},"updated":"2016-08-22 23:37:02.000000000","message":"nit: PIP_CONSTRAINT","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"}],"imagebuild/common/extract_upper_constraints_from_tox_ini.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cc3f7cd5356cde91e55f46820ebd91ed7b5cedf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#                  scripts. This is specially done to leverage the release"},{"line_number":6,"context_line":"#                  tools that automatically update the tox.ini when projects"},{"line_number":7,"context_line":"#                  are released."},{"line_number":8,"context_line":"sed -n \u0027s/^.*{env:UPPER_CONSTRAINTS_FILE\\:\\([^}]*\\)}.*$/\\1/p\u0027 $1"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_c95c687f","line":8,"updated":"2016-08-23 18:00:27.000000000","message":"Wonder if it should maybe have a \u0027head -n1\u0027\n\nIn case there is more than one line with that in it?","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"}],"imagebuild/common/generate_upper_constraints.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cc3f7cd5356cde91e55f46820ebd91ed7b5cedf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"log \"Generating local constraints file...\""},{"line_number":41,"context_line":"log \"UPPER_CONSTRAINTS_FILE is \u0027${UPPER_CONSTRAINTS_FILE-\"\"}\u0027\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_499a386f","line":41,"updated":"2016-08-23 18:00:27.000000000","message":"Seems to work but bash docs say there should be a \u0027:\u0027 in there\n\n ${parameter:-word}\n Use Default Values.  If parameter is unset or null, the expansion of word is substituted.  Otherwise, the value of parameter is substituted.","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"1148d0717214669f6a13c0c07a0d3da640743706","unresolved":false,"context_lines":[{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"log \"Generating local constraints file...\""},{"line_number":41,"context_line":"log \"UPPER_CONSTRAINTS_FILE is \u0027${UPPER_CONSTRAINTS_FILE-\"\"}\u0027\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_592cbc98","line":41,"in_reply_to":"1ac06dbe_499a386f","updated":"2016-08-23 20:31:49.000000000","message":"Done","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cc3f7cd5356cde91e55f46820ebd91ed7b5cedf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"log \"Generating local constraints file...\""},{"line_number":41,"context_line":"log \"UPPER_CONSTRAINTS_FILE is \u0027${UPPER_CONSTRAINTS_FILE-\"\"}\u0027\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_c984680c","line":43,"updated":"2016-08-23 18:00:27.000000000","message":"ditto","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"1148d0717214669f6a13c0c07a0d3da640743706","unresolved":false,"context_lines":[{"line_number":40,"context_line":"log \"Generating local constraints file...\""},{"line_number":41,"context_line":"log \"UPPER_CONSTRAINTS_FILE is \u0027${UPPER_CONSTRAINTS_FILE-\"\"}\u0027\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_b91fb059","line":43,"in_reply_to":"1ac06dbe_c984680c","updated":"2016-08-23 20:31:49.000000000","message":"Done","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cc3f7cd5356cde91e55f46820ebd91ed7b5cedf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"log \"UPPER_CONSTRAINTS_FILE is \u0027${UPPER_CONSTRAINTS_FILE-\"\"}\u0027\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_29809cf4","line":44,"updated":"2016-08-23 18:00:27.000000000","message":"ditto\n\nmight be nice if this was indented to show it is a continuation line more clearly","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"1148d0717214669f6a13c0c07a0d3da640743706","unresolved":false,"context_lines":[{"line_number":41,"context_line":"log \"UPPER_CONSTRAINTS_FILE is \u0027${UPPER_CONSTRAINTS_FILE-\"\"}\u0027\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_9922b4a1","line":44,"in_reply_to":"1ac06dbe_29809cf4","updated":"2016-08-23 20:31:49.000000000","message":"Done","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cc3f7cd5356cde91e55f46820ebd91ed7b5cedf","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_09016038","line":45,"updated":"2016-08-23 18:00:27.000000000","message":"might be nice if this was indented to show it is a continuation line more clearly","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"1148d0717214669f6a13c0c07a0d3da640743706","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_d938acd5","line":45,"in_reply_to":"1ac06dbe_09016038","updated":"2016-08-23 20:31:49.000000000","message":"Done","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cc3f7cd5356cde91e55f46820ebd91ed7b5cedf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_49f7d858","line":46,"updated":"2016-08-23 18:00:27.000000000","message":"might be nice if this was indented to show it is a continuation line more clearly","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"1148d0717214669f6a13c0c07a0d3da640743706","unresolved":false,"context_lines":[{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"download \"${UPPER_CONSTRAINTS_FILE-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_393460dc","line":46,"in_reply_to":"1ac06dbe_49f7d858","updated":"2016-08-23 20:31:49.000000000","message":"Done","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5c12aac0269c746f721162b2176e3383915c559f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"copy \"${UPPER_CONSTRAINTS_FILE:-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":44,"context_line":"  download \"${UPPER_CONSTRAINTS_FILE:-\"\"}\" \"${DESTINATION}\" || \\"},{"line_number":45,"context_line":"    copy \"/opt/stack/new/requirements/upper-constraints.txt\" \"${DESTINATION}\" || \\"},{"line_number":46,"context_line":"      download \"$(${COMMON_ROOT}/extract_upper_constraints_from_tox_ini.sh ${COMMON_ROOT}/../../tox.ini)\" \"${DESTINATION}\""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1ac06dbe_19b40433","line":45,"updated":"2016-08-23 20:40:45.000000000","message":"Don\u0027t need to keep indenting :)","commit_id":"d72cdc7b04d9108022f874ebc452ba037d2daed7"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"af39423fcc802f98d1591bb4aadf715c3f325142","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    log \"File \u0027${src}\u0027 not found. Skipping.\""},{"line_number":20,"context_line":"    return 1"},{"line_number":21,"context_line":"  fi"},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"download() {"},{"line_number":25,"context_line":"  local url\u003d$1"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1ac06dbe_48a17f45","line":22,"updated":"2016-08-24 01:06:58.000000000","message":"I\u0027d have an explicit return 0 here otherwise the function will return 4? of the last command run.  Which is fine until y\u0027all add something else in here.","commit_id":"688eb3a88bf6fc569b9f5146aa756e93d414d2e8"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"f0784c6a441bd31bd1124c388fa380ae3c3ec0e2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    log \"File \u0027${src}\u0027 not found. Skipping.\""},{"line_number":20,"context_line":"    return 1"},{"line_number":21,"context_line":"  fi"},{"line_number":22,"context_line":"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"download() {"},{"line_number":25,"context_line":"  local url\u003d$1"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1ac06dbe_2b7eb869","line":22,"in_reply_to":"1ac06dbe_48a17f45","updated":"2016-08-24 03:35:19.000000000","message":"In my tests I was getting a 0 for \"natural\" exit. I will add it to the next patchset.","commit_id":"688eb3a88bf6fc569b9f5146aa756e93d414d2e8"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"af39423fcc802f98d1591bb4aadf715c3f325142","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     return 1"},{"line_number":30,"context_line":"  else"},{"line_number":31,"context_line":"    log \"Downloading from \u0027${url}\u0027\""},{"line_number":32,"context_line":"    curl ${url} -o \"${destination}\" || exit 1"},{"line_number":33,"context_line":"  fi"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1ac06dbe_e8fb0b45","line":32,"range":{"start_line":32,"start_character":39,"end_line":32,"end_character":43},"updated":"2016-08-24 01:06:58.000000000","message":"Wont this abort the whole script if the download fails?\n\nPerhaps return 1","commit_id":"688eb3a88bf6fc569b9f5146aa756e93d414d2e8"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3d5a04fde9969d6994581b07fb9682c6464b3ee5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     return 1"},{"line_number":30,"context_line":"  else"},{"line_number":31,"context_line":"    log \"Downloading from \u0027${url}\u0027\""},{"line_number":32,"context_line":"    curl ${url} -o \"${destination}\" || exit 1"},{"line_number":33,"context_line":"  fi"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1ac06dbe_1cece028","line":32,"range":{"start_line":32,"start_character":39,"end_line":32,"end_character":43},"in_reply_to":"1ac06dbe_abb3c84b","updated":"2016-08-24 05:43:17.000000000","message":"That\u0027s fine.  If it was intentional that\u0027s cool.  It may be work a comment so that future reviewers don\u0027t make the same mistake I did.","commit_id":"688eb3a88bf6fc569b9f5146aa756e93d414d2e8"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"f0784c6a441bd31bd1124c388fa380ae3c3ec0e2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"     return 1"},{"line_number":30,"context_line":"  else"},{"line_number":31,"context_line":"    log \"Downloading from \u0027${url}\u0027\""},{"line_number":32,"context_line":"    curl ${url} -o \"${destination}\" || exit 1"},{"line_number":33,"context_line":"  fi"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1ac06dbe_abb3c84b","line":32,"range":{"start_line":32,"start_character":39,"end_line":32,"end_character":43},"in_reply_to":"1ac06dbe_e8fb0b45","updated":"2016-08-24 03:35:19.000000000","message":"That\u0027s the intended purpose. If the user provided a link and it failed to download, we want to make the whole script fail, instead of falling back on other options. What do you think?","commit_id":"688eb3a88bf6fc569b9f5146aa756e93d414d2e8"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"af39423fcc802f98d1591bb4aadf715c3f325142","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    log \"Downloading from \u0027${url}\u0027\""},{"line_number":32,"context_line":"    curl ${url} -o \"${destination}\" || exit 1"},{"line_number":33,"context_line":"  fi"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"log() {"},{"line_number":37,"context_line":"  echo \"${SCRIPT_NAME}: ${@}\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1ac06dbe_28bfe361","line":34,"updated":"2016-08-24 01:06:58.000000000","message":"As https://review.openstack.org/#/c/358855/6/imagebuild/common/generate_upper_constraints.sh@22","commit_id":"688eb3a88bf6fc569b9f5146aa756e93d414d2e8"}],"imagebuild/coreos/docker_build.bash":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"af9f57ea1f1658562118de8e3881a1678af819a1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Create a temporary proxy.sh script, that will be used by the Dockerfile."},{"line_number":25,"context_line":"# Since we are calling \u0027docker build\u0027 we can not use --env-file/--env as those"},{"line_number":26,"context_line":"# are arguments to \u0027docker run\u0027"},{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_e16ffd28","line":27,"updated":"2016-08-22 23:37:02.000000000","message":"This wont work in a situation where you have an IPA change that \u0027Depends-On\u0027 any change (or series) that updates upper-constraints.txt\n\nIn https://review.openstack.org/#/c/353124/ I gave a very poor example of how to handle this.","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"842b09137d886038ff5cdac7e6757d61fe222247","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Create a temporary proxy.sh script, that will be used by the Dockerfile."},{"line_number":25,"context_line":"# Since we are calling \u0027docker build\u0027 we can not use --env-file/--env as those"},{"line_number":26,"context_line":"# are arguments to \u0027docker run\u0027"},{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_ee3ec526","line":27,"in_reply_to":"1ac06dbe_cbdbfb4d","updated":"2016-08-23 01:46:15.000000000","message":"For tox jobs yes.\n\nIt gets more complex for dsvm jobs.  This code needs to work in the gate in both tox and dsvm *and* for local development (which is where the URL will mostly be used)","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"ccbacc25f8b5c5fc21f8b4740aadea685b939c8e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Create a temporary proxy.sh script, that will be used by the Dockerfile."},{"line_number":25,"context_line":"# Since we are calling \u0027docker build\u0027 we can not use --env-file/--env as those"},{"line_number":26,"context_line":"# are arguments to \u0027docker run\u0027"},{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_cbdbfb4d","line":27,"in_reply_to":"1ac06dbe_e16ffd28","updated":"2016-08-23 00:56:04.000000000","message":"If I understand correctly, UPPER_CONSTRAINTS_FILE will be a local file in those cases?","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bbb8c6bfdff3d233b63af8dc6531b098649df9f0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"},{"line_number":31,"context_line":"chmod 0755 proxy.sh"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"docker build -t oemdocker ."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_1ffb9648","line":30,"updated":"2016-08-22 21:11:05.000000000","message":"Doesn\u0027t this break across branches? Or do we use the same constraints file for all branches (including old stable/*)","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"842b09137d886038ff5cdac7e6757d61fe222247","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"},{"line_number":31,"context_line":"chmod 0755 proxy.sh"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"docker build -t oemdocker ."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_8b4c639f","line":30,"in_reply_to":"1ac06dbe_0bfcf3b6","updated":"2016-08-23 01:46:15.000000000","message":"Right we\u0027ve added the comment to the wrong line.  I think what John is asking for is to get the default URL from tox.ini to avoid it bing hardcoded here.\n\nThe rational for this is when we take master and call it stable/newton we\u0027ll automagically update the URL in tox.ini and things will \"just work\" rather than y\u0027all needing to follow along and cleanup this URL","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9a986f3c4b7ae68b67bc3f591089c3ff4a88204e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"},{"line_number":31,"context_line":"chmod 0755 proxy.sh"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"docker build -t oemdocker ."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_8138c93e","line":30,"in_reply_to":"1ac06dbe_1ffb9648","updated":"2016-08-22 23:21:01.000000000","message":"I think it might be better if this could be overridden by the tox.ini file.\n\nThat is what is done currently for stable releases. They change the location of the link.","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"af9f57ea1f1658562118de8e3881a1678af819a1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"},{"line_number":31,"context_line":"chmod 0755 proxy.sh"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"docker build -t oemdocker ."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_e141bdaa","line":30,"in_reply_to":"1ac06dbe_1ffb9648","updated":"2016-08-22 23:37:02.000000000","message":"Yes but it\u0027s totally reasonable to add a ?h\u003dstable/foo to the URL in the backport.","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"ccbacc25f8b5c5fc21f8b4740aadea685b939c8e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"},{"line_number":31,"context_line":"chmod 0755 proxy.sh"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"docker build -t oemdocker ."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_0bfcf3b6","line":30,"in_reply_to":"1ac06dbe_85c9f428","updated":"2016-08-23 00:56:04.000000000","message":"(on mobile now) ill make it read the tox.ini, but afaik gate jobs provided the UPPER_CONSTRAINTS_FILE and we \"needed\" to honor it.. I guess I can always do both, read from environment and fallback to reading tox.ini. I\u0027ll push an update tomorrow.","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"68e243a631504c1ffa6ab537ac06c5dd14466eee","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"},{"line_number":31,"context_line":"chmod 0755 proxy.sh"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"docker build -t oemdocker ."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_e5a26898","line":30,"in_reply_to":"1ac06dbe_e141bdaa","updated":"2016-08-22 23:39:41.000000000","message":"True, but would be cleaner if the backport didn\u0027t have to do that.\n\nAlso have to remember when release stable/newton to come to this file and update. And same for stable/ocata and ...","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"6c328f0703ddd62fe48e49075f2cacc9ede2693e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONSTRAINTS_URL\u003d\"https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt\""},{"line_number":28,"context_line":"echo \u0027#!/bin/sh\u0027 \u003e proxy.sh"},{"line_number":29,"context_line":"echo \u0027echo Running: $*\u0027 \u003e\u003e proxy.sh"},{"line_number":30,"context_line":"echo \"PIP_CONSTRAINT\u003d${UPPER_CONSTRAINTS_FILE-\"$CONSTRAINTS_URL\"} http_proxy\u003d${http_proxy:-} https_proxy\u003d${https_proxy:-} no_proxy\u003d${no_proxy:-} \"\u0027$*\u0027 \u003e\u003e proxy.sh"},{"line_number":31,"context_line":"chmod 0755 proxy.sh"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"docker build -t oemdocker ."}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ac06dbe_85c9f428","line":30,"in_reply_to":"1ac06dbe_e5a26898","updated":"2016-08-22 23:48:03.000000000","message":"Totally true.  If you can work out how to do that that *awesome*  We can use it everywhere.\n\nYou *could* do something like:\n\n eval $(sed -n \u0027s/^.*{env:\\(UPPER_CONSTRAINTS_FILE[^}]*\\)}.*$/\\1/p\u0027 tox.ini)\n\nbut that seems a little fragile.  My point was from a policy POV changing the URL is fine.","commit_id":"cd38ffbdb27c3f3ed70192c6baa12fa8bc12703f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8cc3f7cd5356cde91e55f46820ebd91ed7b5cedf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Build the docker image"},{"line_number":18,"context_line":"cd ../../"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"imagebuild/common/generate_upper_constraints.sh upper-constraints.txt"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(jlvilla): Once Docker 1.9 is widely deployed, switch to using the \u0027ARG\u0027"},{"line_number":23,"context_line":"# command which was added in Docker 1.9. Currently Ubuntu 14.04 uses Docker"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_893710fe","line":20,"updated":"2016-08-23 18:00:27.000000000","message":"I\u0027m slighty confused on where this file lands","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"1148d0717214669f6a13c0c07a0d3da640743706","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Build the docker image"},{"line_number":18,"context_line":"cd ../../"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"imagebuild/common/generate_upper_constraints.sh upper-constraints.txt"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(jlvilla): Once Docker 1.9 is widely deployed, switch to using the \u0027ARG\u0027"},{"line_number":23,"context_line":"# command which was added in Docker 1.9. Currently Ubuntu 14.04 uses Docker"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_963d63df","line":20,"in_reply_to":"1ac06dbe_893710fe","updated":"2016-08-23 20:31:49.000000000","message":"In the root of the checkout, right next to the Dockerfile. It will be added to Docker as part of the \"ADD . /tmp/ironic-python-agent\" command.","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0962a7ba35af654553e50956bd212667218d20e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Build the docker image"},{"line_number":18,"context_line":"cd ../../"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"imagebuild/common/generate_upper_constraints.sh upper-constraints.txt"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# TODO(jlvilla): Once Docker 1.9 is widely deployed, switch to using the \u0027ARG\u0027"},{"line_number":23,"context_line":"# command which was added in Docker 1.9. Currently Ubuntu 14.04 uses Docker"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ac06dbe_5964bcb7","line":20,"in_reply_to":"1ac06dbe_963d63df","updated":"2016-08-23 20:40:10.000000000","message":"And I should remember this since I did the proxy.sh stuff below :)","commit_id":"314f7f11e7d6d6babe3a578df3f8e060cf04ad00"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5c12aac0269c746f721162b2176e3383915c559f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"fi"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Build the docker image"},{"line_number":18,"context_line":"cd ../../"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"imagebuild/common/generate_upper_constraints.sh upper-constraints.txt"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1ac06dbe_19ec04f2","line":18,"updated":"2016-08-23 20:40:45.000000000","message":"Would you mind adding a comment that everything stored in this directory will end up being accessible to the Dockerfile in /tmp/ironic-python-agent/","commit_id":"d72cdc7b04d9108022f874ebc452ba037d2daed7"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a4b3079a9329c223258688504a1fe89f39db5553","unresolved":false,"context_lines":[{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Build the docker image"},{"line_number":19,"context_line":"cd ${IPA_ROOT}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"imagebuild/common/generate_upper_constraints.sh ${IPA_ROOT}/upper-constraints.txt"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1ac06dbe_6259fc8d","line":19,"updated":"2016-08-23 23:56:03.000000000","message":"I still would think the comment that everything in $IPA_ROOT will end up being mounted in /tmp/ironic-python-agent/ would be useful.","commit_id":"fd15db8223d5f198042e75ecdf5bb22accbdd5cd"}],"imagebuild/tinyipa/build-tinyipa.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"95407c6dbac9aaaeea59b9c819f6662bffddd58f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"done \u003c $WORKDIR/build_files/buildreqs.lst"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Build python wheels"},{"line_number":92,"context_line":"$CHROOT_CMD python /tmp/get-pip.py"},{"line_number":93,"context_line":"$CHROOT_CMD pip install pbr"},{"line_number":94,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels setuptools"},{"line_number":95,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels pip"}],"source_content_type":"text/x-sh","patch_set":10,"id":"fa7ab95a_922b3aeb","line":92,"updated":"2016-08-26 14:12:58.000000000","message":"I think this should this have -c constraints","commit_id":"a0ca6ce157b8a84f282d8abbdd27c75f48d991ff"}],"imagebuild/tinyipa/finalise-tinyipa.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"95407c6dbac9aaaeea59b9c819f6662bffddd58f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"# If flag is set install the python now"},{"line_number":78,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":79,"context_line":"    cp -a $BUILDDIR/tmp/upper-constraints.txt $FINALDIR/tmp/upper-constraints.txt"},{"line_number":80,"context_line":"    $CHROOT_CMD python /tmp/get-pip.py -c /tmp/upper-constraints.txt --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse ironic_python_agent"},{"line_number":81,"context_line":"    rm -rf $FINALDIR/tmp/upper-constraints.txt"},{"line_number":82,"context_line":"    rm -rf $FINALDIR/tmp/wheelhouse"},{"line_number":83,"context_line":"    rm -rf $FINALDIR/tmp/get-pip.py"}],"source_content_type":"text/x-sh","patch_set":10,"id":"fa7ab95a_521b721b","line":80,"updated":"2016-08-26 14:12:58.000000000","message":"I didn\u0027t know get-pip supported constraints. Now I do :)\n\nI checked!","commit_id":"a0ca6ce157b8a84f282d8abbdd27c75f48d991ff"}]}