)]}'
{"id":"openstack%2Fironic-python-agent~361811","triplet_id":"openstack%2Fironic-python-agent~master~I53c6d6d3e53d9fac38c50faf065c131d3aa55224","project":"openstack/ironic-python-agent","branch":"master","topic":"fixassertEqual","hashtags":[],"change_id":"I53c6d6d3e53d9fac38c50faf065c131d3aa55224","subject":"Using assertIsNone() is preferred over assertEqual()","status":"MERGED","created":"2016-08-29 03:10:09.000000000","updated":"2016-08-29 18:43:18.000000000","submitted":"2016-08-29 18:43:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e409aeec3e1f89d85f7e57585293735cd0d59550","_number":361811,"virtual_id_number":361811,"owner":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-08-29 18:43:18.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":0,"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"value":0,"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-29 18:34:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":1,"date":"2016-08-29 18:20:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":1,"date":"2016-08-29 13:41:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"value":1,"date":"2016-08-29 15:31:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},{"value":2,"date":"2016-08-29 12:08:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-29 18:34:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":0,"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"value":0,"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"value":0,"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":0,"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"value":0,"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-29 05:04:32.000000000","updated_by":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"reviewer":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"state":"REVIEWER"},{"updated":"2016-08-29 12:08:25.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-08-29 13:41:09.000000000","updated_by":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"reviewer":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"state":"REVIEWER"},{"updated":"2016-08-29 15:31:07.000000000","updated_by":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"reviewer":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"state":"REVIEWER"},{"updated":"2016-08-29 18:20:35.000000000","updated_by":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"reviewer":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"state":"REVIEWER"},{"updated":"2016-08-29 18:34:11.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2016-08-29 18:43:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"604722294a35fc93ecaf92f3bb9768bc9707fc4c","author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"date":"2016-08-29 03:10:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5d60631e2670088e23f934676645f4e4802d23ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 04:12:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/11/361811/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/0669e3e//doc/build/html/ : SUCCESS in 2m 21s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/11/361811/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/bb84ea2/ : SUCCESS in 2m 52s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/11/361811/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/275dd78/ : SUCCESS in 3m 15s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/11/361811/1/check/gate-ironic-python-agent-python34/86607cf/ : SUCCESS in 2m 19s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/11/361811/1/check/gate-ironic-python-agent-python35/f39a85d/ : SUCCESS in 4m 06s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/11/361811/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/b7e2407/ : SUCCESS in 4m 40s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src/79bcbc7/ : SUCCESS in 30m 01s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv/9329f10/ : SUCCESS in 1h 00m 11s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src/e9235d5/ : SUCCESS in 38m 27s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv/2f3a485/ : SUCCESS in 53m 11s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src/8b4e14a/ : SUCCESS in 38m 08s\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src/b767717/ : SUCCESS in 42m 04s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv/0ec4ac4/ : FAILURE in 50m 08s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv/1ee6b01/ : FAILURE in 1h 01m 07s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv/0a02e76/ : SUCCESS in 39m 47s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv http://logs.openstack.org/11/361811/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv/8981f05/ : SUCCESS in 1h 01m 50s (non-voting)\n- gate-ironic-inspector-dsvm-ipa-src-nv http://logs.openstack.org/11/361811/1/check/gate-ironic-inspector-dsvm-ipa-src-nv/b3af645/ : SUCCESS in 45m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"43c11754f00fd3b31176396d6386801b7b55352f","author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"date":"2016-08-29 05:04:32.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nTuan,\n\nThanks for the nice patch, your fix looks good in terms of the assertion. But .idea directory has accidentally been committed.\n\nBest regards,\nNaohiro","accounts_in_message":[],"_revision_number":1},{"id":"43c2f7741e2d242c932fc35dfe7edbbd035f5a29","author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"date":"2016-08-29 05:10:09.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"4be2a988543d481ca12a475f5765aca765d36392","author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"date":"2016-08-29 05:22:40.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"36753778e1944f08ec099fa6d3ace2e0cb644980","author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"date":"2016-08-29 05:23:14.000000000","message":"Patch Set 3:\n\nNaohiro Tamura: Thanks for your help","accounts_in_message":[],"_revision_number":3},{"id":"cfe33a152649a0cb045bae67f9cf288b48447086","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 05:27:51.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/11/361811/3/check/gate-ironic-python-agent-docs-ubuntu-xenial/d597916//doc/build/html/ : SUCCESS in 3m 43s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/11/361811/3/check/gate-ironic-python-agent-pep8-ubuntu-xenial/a3bfae3/ : SUCCESS in 2m 05s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/11/361811/3/check/gate-ironic-python-agent-python27-ubuntu-xenial/149519d/ : SUCCESS in 2m 11s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/11/361811/3/check/gate-ironic-python-agent-python34/0fb43b6/ : SUCCESS in 2m 16s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/11/361811/3/check/gate-ironic-python-agent-python35/20e65c4/ : SUCCESS in 4m 13s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/11/361811/3/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/a4ad7e9/ : SUCCESS in 3m 51s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"230b5c84f6989163991e0ca2dbb89fb544265518","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-08-29 12:08:25.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"214a80627d458393cdbd5a06c880e80e1bb56827","author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"date":"2016-08-29 13:41:09.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"acf934b0f98f9dda184906cb2b1a713c95689833","author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"date":"2016-08-29 15:31:07.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"04fbb86d3d047ee6a4f440d6c65ab8480b894456","author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"date":"2016-08-29 18:20:35.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"b79de6f8ef306af2c4af1472559d24c107c7d6eb","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-08-29 18:34:11.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"54b5c0202af0b5cf40f8d9d76784cdbc4313cfee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 18:34:22.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"d06d197dd8aa15ba4fa59bf2b71002b943bb8216","date":"2016-08-29 18:43:18.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"f17ad0d56d8353bfc50761363940f258ada009ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 18:43:18.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/11/361811/3/gate/gate-ironic-python-agent-docs-ubuntu-xenial/dd94974//doc/build/html/ : SUCCESS in 3m 33s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/11/361811/3/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/afbc2c6/ : SUCCESS in 3m 28s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/11/361811/3/gate/gate-ironic-python-agent-python27-ubuntu-xenial/5b278fc/ : SUCCESS in 3m 24s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/11/361811/3/gate/gate-ironic-python-agent-python34/b1eb213/ : SUCCESS in 2m 56s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/11/361811/3/gate/gate-ironic-python-agent-python35/d9361dc/ : SUCCESS in 3m 40s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"814b60def3457751f5c4eed9befea2f9f0ec27cd","revisions":{"199b2728af76588a094b6adf053506b7bb3c5f1d":{"kind":"REWORK","_number":1,"created":"2016-08-29 03:10:09.000000000","uploader":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"ref":"refs/changes/11/361811/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/11/361811/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/1"}}},"commit":{"parents":[{"commit":"95f31be108f6f1a259d64535967d796a25e4d7cd","subject":"Re-use API client for Heartbeat operations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/95f31be108f6f1a259d64535967d796a25e4d7cd"}]}],"author":{"name":"Luong Anh Tuan","email":"tuanla@vn.fujitsu.com","date":"2016-08-29 03:07:14.000000000","tz":420},"committer":{"name":"Luong Anh Tuan","email":"tuanla@vn.fujitsu.com","date":"2016-08-29 03:09:40.000000000","tz":420},"subject":"Using assertIsNone() is preferred over assertEqual()","message":"Using assertIsNone() is preferred over assertEqual()\n\nFollowing OpenStack Style Guidelines[1]:\nhttp://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\n[H203] Unit test assertions tend to give better messages for more specific assertions.\nAs a result, assertIsNone(...) is preferred over assertEqual(None, ...)\n\nChange-Id: I53c6d6d3e53d9fac38c50faf065c131d3aa55224\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/199b2728af76588a094b6adf053506b7bb3c5f1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/199b2728af76588a094b6adf053506b7bb3c5f1d"}]},"branch":"refs/heads/master"},"0da9940885e666a505b5228754c21d09a08a3bf4":{"kind":"REWORK","_number":2,"created":"2016-08-29 05:10:09.000000000","uploader":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"ref":"refs/changes/11/361811/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/11/361811/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/2"}}},"commit":{"parents":[{"commit":"95f31be108f6f1a259d64535967d796a25e4d7cd","subject":"Re-use API client for Heartbeat operations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/95f31be108f6f1a259d64535967d796a25e4d7cd"}]}],"author":{"name":"Luong Anh Tuan","email":"tuanla@vn.fujitsu.com","date":"2016-08-29 03:07:14.000000000","tz":420},"committer":{"name":"Tuan Luong-Anh","email":"tuanla@vn.fujitsu.com","date":"2016-08-29 05:10:04.000000000","tz":0},"subject":"Using assertIsNone() is preferred over assertEqual()","message":"Using assertIsNone() is preferred over assertEqual()\n\nFollowing OpenStack Style Guidelines[1]:\nhttp://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\n[H203] Unit test assertions tend to give better messages for more specific assertions.\nAs a result, assertIsNone(...) is preferred over assertEqual(None, ...)\n\nChange-Id: I53c6d6d3e53d9fac38c50faf065c131d3aa55224\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0da9940885e666a505b5228754c21d09a08a3bf4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/0da9940885e666a505b5228754c21d09a08a3bf4"}]},"branch":"refs/heads/master"},"814b60def3457751f5c4eed9befea2f9f0ec27cd":{"kind":"REWORK","_number":3,"created":"2016-08-29 05:22:40.000000000","uploader":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"ref":"refs/changes/11/361811/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/11/361811/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/11/361811/3"}}},"commit":{"parents":[{"commit":"95f31be108f6f1a259d64535967d796a25e4d7cd","subject":"Re-use API client for Heartbeat operations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/95f31be108f6f1a259d64535967d796a25e4d7cd"}]}],"author":{"name":"Luong Anh Tuan","email":"tuanla@vn.fujitsu.com","date":"2016-08-29 03:07:14.000000000","tz":420},"committer":{"name":"Tuan Luong-Anh","email":"tuanla@vn.fujitsu.com","date":"2016-08-29 05:22:33.000000000","tz":0},"subject":"Using assertIsNone() is preferred over assertEqual()","message":"Using assertIsNone() is preferred over assertEqual()\n\nFollowing OpenStack Style Guidelines[1]:\nhttp://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\n[H203] Unit test assertions tend to give better messages for more specific assertions.\nAs a result, assertIsNone(...) is preferred over assertEqual(None, ...)\n\nChange-Id: I53c6d6d3e53d9fac38c50faf065c131d3aa55224\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/814b60def3457751f5c4eed9befea2f9f0ec27cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/814b60def3457751f5c4eed9befea2f9f0ec27cd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}