)]}'
{"id":"openstack%2Fironic-python-agent~362124","triplet_id":"openstack%2Fironic-python-agent~master~I5d47d775dcff194693d97db6b797b7b027cbab56","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"I5d47d775dcff194693d97db6b797b7b027cbab56","subject":"Changed an assert to more specific assert method","status":"MERGED","created":"2016-08-29 13:40:46.000000000","updated":"2016-09-19 09:42:47.000000000","submitted":"2016-08-29 18:42:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a98c39b2e7ef376e773690298822796e3197fa33","_number":362124,"virtual_id_number":362124,"owner":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-08-29 18:42:15.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-29 18:01:27.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2016-08-29 14:36:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":1,"date":"2016-08-29 16:04:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-29 18:01:27.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"date":"2016-09-19 09:42:47.000000000","post_submit":true,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-29 14:36:12.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-08-29 16:04:06.000000000","updated_by":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"reviewer":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"state":"REVIEWER"},{"updated":"2016-08-29 18:01:27.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2016-08-29 18:42:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-19 09:42:47.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"}],"messages":[{"id":"3fc37aa0e8e3adf21fcfa26b51414194e5ef63b0","author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"date":"2016-08-29 13:40:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"02f3ceaf82aff775adf7fd5be4e6bc163428c10c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 13:52:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/24/362124/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/e7d557a//doc/build/html/ : SUCCESS in 3m 24s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/24/362124/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/5772baf/ : SUCCESS in 2m 11s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/24/362124/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/1f33b05/ : SUCCESS in 2m 28s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/24/362124/1/check/gate-ironic-python-agent-python34/d196a1f/ : SUCCESS in 4m 33s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/24/362124/1/check/gate-ironic-python-agent-python35/fa9a108/ : SUCCESS in 2m 49s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/24/362124/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/04d9944/ : SUCCESS in 2m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1cf2f684c75326d3bb1d88880592ee78ae6714f0","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-08-29 14:36:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f2b90b3ec3de40e31227ad70ff0a60f1225f9f38","author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"date":"2016-08-29 16:04:06.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"980eba4efe4196c79e81199811459953fb651cd6","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2016-08-29 18:01:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"43457d8503cae16b4dcf497cf1918bc7716b4390","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 18:01:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b23d1cc8481be635d945de9ba8bf51593209bfa4","date":"2016-08-29 18:42:15.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"26ebd2a22a79b8f0517b84214d57c9a06c3a86f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 18:42:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/24/362124/1/gate/gate-ironic-python-agent-docs-ubuntu-xenial/a9c8dd4//doc/build/html/ : SUCCESS in 3m 23s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/24/362124/1/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/080ab26/ : SUCCESS in 3m 28s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/24/362124/1/gate/gate-ironic-python-agent-python27-ubuntu-xenial/16c7e94/ : SUCCESS in 4m 03s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/24/362124/1/gate/gate-ironic-python-agent-python34/1d26ba0/ : SUCCESS in 2m 14s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/24/362124/1/gate/gate-ironic-python-agent-python35/44736c1/ : SUCCESS in 3m 40s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4facf2c385efc460b6aac2bfd2b391595941f850","revisions":{"4facf2c385efc460b6aac2bfd2b391595941f850":{"kind":"REWORK","_number":1,"created":"2016-08-29 13:40:46.000000000","uploader":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"ref":"refs/changes/24/362124/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/24/362124/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/362124/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/362124/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/362124/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/24/362124/1"}}},"commit":{"parents":[{"commit":"95f31be108f6f1a259d64535967d796a25e4d7cd","subject":"Re-use API client for Heartbeat operations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/95f31be108f6f1a259d64535967d796a25e4d7cd"}]}],"author":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2016-08-29 13:37:42.000000000","tz":120},"committer":{"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","date":"2016-08-29 13:40:44.000000000","tz":120},"subject":"Changed an assert to more specific assert method","message":"Changed an assert to more specific assert method\n\nFollowing OpenStack Style Guidelines [1], I changed:\nassertFalse(sth in sth) to assertNotIn(sth, sth).\n\nAfter this change, a more specific message is shown on error.\n\n[1]: http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\nChange-Id: I5d47d775dcff194693d97db6b797b7b027cbab56\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4facf2c385efc460b6aac2bfd2b391595941f850"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4facf2c385efc460b6aac2bfd2b391595941f850"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}