)]}'
{"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a98531157cba33e0d5f5dbb071e9fc5cfaa5c120","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                log_msg \u003d (\u0027Image download failed. URL: {0}; time: {1} \u0027"},{"line_number":288,"context_line":"                           \u0027seconds. Error: {2}\u0027)"},{"line_number":289,"context_line":"                LOG.warning(log_msg.format(url, failtime, e.details))"},{"line_number":290,"context_line":"                details +\u003d e.details"},{"line_number":291,"context_line":"                continue"},{"line_number":292,"context_line":"            else:"},{"line_number":293,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_32603c01","line":290,"updated":"2016-09-16 08:24:12.000000000","message":"let\u0027s put the whole formatted log_msg here, it\u0027s useful to associate which URL failed with which reason.","commit_id":"3cabda329739834e27e841fc37a883ffa066b142"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"57d18317bf29c3b61e8968a060613b5ea8d90feb","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                log_msg \u003d (\u0027Image download failed. URL: {0}; time: {1} \u0027"},{"line_number":288,"context_line":"                           \u0027seconds. Error: {2}\u0027)"},{"line_number":289,"context_line":"                LOG.warning(log_msg.format(url, failtime, e.details))"},{"line_number":290,"context_line":"                details +\u003d e.details"},{"line_number":291,"context_line":"                continue"},{"line_number":292,"context_line":"            else:"},{"line_number":293,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_ef8502cf","line":290,"in_reply_to":"7a8ec9b2_32603c01","updated":"2016-09-16 11:20:23.000000000","message":"Done","commit_id":"3cabda329739834e27e841fc37a883ffa066b142"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a98531157cba33e0d5f5dbb071e9fc5cfaa5c120","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                break"},{"line_number":294,"context_line":"        else:"},{"line_number":295,"context_line":"            details \u003d \u0027/n\u0027.join(details)"},{"line_number":296,"context_line":"            msg \u003d (\u0027Image download failed for all URLs with exceptions: \u0027"},{"line_number":297,"context_line":"                   \u0027{}\u0027.format(details))"},{"line_number":298,"context_line":"            raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_525dc845","line":296,"updated":"2016-09-16 08:24:12.000000000","message":"s/exceptions/the following errors/","commit_id":"3cabda329739834e27e841fc37a883ffa066b142"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"57d18317bf29c3b61e8968a060613b5ea8d90feb","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                break"},{"line_number":294,"context_line":"        else:"},{"line_number":295,"context_line":"            details \u003d \u0027/n\u0027.join(details)"},{"line_number":296,"context_line":"            msg \u003d (\u0027Image download failed for all URLs with exceptions: \u0027"},{"line_number":297,"context_line":"                   \u0027{}\u0027.format(details))"},{"line_number":298,"context_line":"            raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_0f6f8e2b","line":296,"in_reply_to":"7a8ec9b2_525dc845","updated":"2016-09-16 11:20:23.000000000","message":"Done","commit_id":"3cabda329739834e27e841fc37a883ffa066b142"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d89709a3cd62420db343437ff4ae7f281ac8114","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                log_msg \u003d (\u0027Image download failed. URL: {0}; time: {1} \u0027"},{"line_number":288,"context_line":"                           \u0027seconds. Error: {2}\u0027).format("},{"line_number":289,"context_line":"                    url, failtime, e.details)"},{"line_number":290,"context_line":"                LOG.warning(log_msg)"},{"line_number":291,"context_line":"                details +\u003d log_msg"},{"line_number":292,"context_line":"                continue"},{"line_number":293,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_3706d520","line":290,"updated":"2016-09-20 09:53:19.000000000","message":"nit: I think we could avoid duplicate \"Image download failed\":\n\n log_msg \u003d \u0027URL: {0}; time: {1} seconds. Error: {2}\u0027.format(...)\n LOG.warning(\u0027Image download failed. %s\u0027, log_msg)\n details +\u003d log_msg","commit_id":"59883f2c55a362945bbc6891552afbdb83cb6815"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"d6da76edd9fe237cc74c6123ae64a6a5087d12f5","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                log_msg \u003d (\u0027Image download failed. URL: {0}; time: {1} \u0027"},{"line_number":288,"context_line":"                           \u0027seconds. Error: {2}\u0027).format("},{"line_number":289,"context_line":"                    url, failtime, e.details)"},{"line_number":290,"context_line":"                LOG.warning(log_msg)"},{"line_number":291,"context_line":"                details +\u003d log_msg"},{"line_number":292,"context_line":"                continue"},{"line_number":293,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_94b11c92","line":290,"in_reply_to":"7a8ec9b2_2c667429","updated":"2016-09-21 10:49:04.000000000","message":"Done","commit_id":"59883f2c55a362945bbc6891552afbdb83cb6815"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"d6da76edd9fe237cc74c6123ae64a6a5087d12f5","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                log_msg \u003d (\u0027Image download failed. URL: {0}; time: {1} \u0027"},{"line_number":288,"context_line":"                           \u0027seconds. Error: {2}\u0027).format("},{"line_number":289,"context_line":"                    url, failtime, e.details)"},{"line_number":290,"context_line":"                LOG.warning(log_msg)"},{"line_number":291,"context_line":"                details +\u003d log_msg"},{"line_number":292,"context_line":"                continue"},{"line_number":293,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_74b81076","line":290,"in_reply_to":"7a8ec9b2_3706d520","updated":"2016-09-21 10:49:04.000000000","message":"Done","commit_id":"59883f2c55a362945bbc6891552afbdb83cb6815"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5382549259f24390097807f28392fc7228e4c61","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                log_msg \u003d (\u0027Image download failed. URL: {0}; time: {1} \u0027"},{"line_number":288,"context_line":"                           \u0027seconds. Error: {2}\u0027).format("},{"line_number":289,"context_line":"                    url, failtime, e.details)"},{"line_number":290,"context_line":"                LOG.warning(log_msg)"},{"line_number":291,"context_line":"                details +\u003d log_msg"},{"line_number":292,"context_line":"                continue"},{"line_number":293,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_2c667429","line":290,"in_reply_to":"7a8ec9b2_3706d520","updated":"2016-09-20 14:29:52.000000000","message":"I think we should actually make this change. The final msg also has \u0027Image download failed for all URLs...\u0027.","commit_id":"59883f2c55a362945bbc6891552afbdb83cb6815"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e5382549259f24390097807f28392fc7228e4c61","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            details \u003d \u0027/n\u0027.join(details)"},{"line_number":297,"context_line":"            msg \u003d (\u0027Image download failed for all URLs with following errors: \u0027"},{"line_number":298,"context_line":"                   \u0027{}\u0027.format(details))"},{"line_number":299,"context_line":"            raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _download_file(self, image_info, url):"},{"line_number":302,"context_line":"        \"\"\"Opens a download stream for the given URL."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_67f6d5fa","line":299,"updated":"2016-09-20 14:29:52.000000000","message":"I didn\u0027t try this out. If someone has DEBUG or WARN level set, are they being spammed with too many logs, or does it look (more) useful?","commit_id":"59883f2c55a362945bbc6891552afbdb83cb6815"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"d6da76edd9fe237cc74c6123ae64a6a5087d12f5","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            details \u003d \u0027/n\u0027.join(details)"},{"line_number":297,"context_line":"            msg \u003d (\u0027Image download failed for all URLs with following errors: \u0027"},{"line_number":298,"context_line":"                   \u0027{}\u0027.format(details))"},{"line_number":299,"context_line":"            raise errors.ImageDownloadError(image_info[\u0027id\u0027], msg)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def _download_file(self, image_info, url):"},{"line_number":302,"context_line":"        \"\"\"Opens a download stream for the given URL."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_d4f9e44f","line":299,"in_reply_to":"7a8ec9b2_67f6d5fa","updated":"2016-09-21 10:49:04.000000000","message":"Yes, it looks useful, when all temp urls in a list failed and a user cannot recognize a problem. See https://bugs.launchpad.net/ironic/+bug/1512186\nWhen at least one of urls succeeded these messages will not spam a user","commit_id":"59883f2c55a362945bbc6891552afbdb83cb6815"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eae193ca493990a863d17c57e1cf3ed2b4eae5da","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                log_msg \u003d (\u0027URL: {0}; time: {1} \u0027"},{"line_number":288,"context_line":"                           \u0027seconds. Error: {2}\u0027).format("},{"line_number":289,"context_line":"                    url, failtime, e.details)"},{"line_number":290,"context_line":"                LOG.warning(\u0027Image download failed. %s\u0027 % log_msg)"},{"line_number":291,"context_line":"                details +\u003d log_msg"},{"line_number":292,"context_line":"                continue"},{"line_number":293,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_420a728b","line":290,"updated":"2016-09-21 11:09:12.000000000","message":"nit: % -\u003e ,","commit_id":"69f0526b7fbeca0ce336a7613a22f434ccb5a711"}]}