)]}'
{"id":"openstack%2Fironic-python-agent~384996","triplet_id":"openstack%2Fironic-python-agent~master~I5005ae02c283cdc01540ea46c341a7b0bf9d4c42","project":"openstack/ironic-python-agent","branch":"master","topic":"bug/1632637","hashtags":[],"change_id":"I5005ae02c283cdc01540ea46c341a7b0bf9d4c42","subject":"Install grub in the EFI \"Fallback path\"","status":"MERGED","created":"2016-10-11 13:28:10.000000000","updated":"2016-10-20 16:18:49.000000000","submitted":"2016-10-20 16:18:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"845199691abf8a9bdb9c44bea5982bad3e83808f","_number":384996,"virtual_id_number":384996,"owner":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-10-20 16:18:49.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":2,"date":"2016-10-20 15:22:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2016-10-20 14:53:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"value":2,"date":"2016-10-20 15:23:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"value":1,"date":"2016-10-20 15:23:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"value":0,"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-11 13:35:04.000000000","updated_by":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"reviewer":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"state":"REVIEWER"},{"updated":"2016-10-13 15:27:09.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2016-10-20 14:53:08.000000000","updated_by":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"reviewer":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"state":"REVIEWER"},{"updated":"2016-10-20 15:22:26.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"REVIEWER"},{"updated":"2016-10-20 15:23:40.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2016-10-20 16:18:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5534b5ff087def459c0e28a7263252b8bde8a860","author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"date":"2016-10-11 13:28:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"79df5fc88ec203362f99a16a449c6d55a40a5f25","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-10-11 13:34:08.000000000","message":"Patch Set 1: Code-Review-1\n\nCode looks good, thanks! This needs a release note (http://docs.openstack.org/developer/ironic/dev/faq.html#create-a-new-release-note) and a unit test. Also please consider filing a bug, so that this change is potentially backportable. Maybe also worth explaining how exactly --removable flag helps here.","accounts_in_message":[],"_revision_number":1},{"id":"487e067b22255381f784bcedf88d3a25df969efc","author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"date":"2016-10-11 13:35:04.000000000","message":"Patch Set 1: Code-Review-1\n\nThe code looks fine, but needs unittest","accounts_in_message":[],"_revision_number":1},{"id":"3222179b3dc0e6cf4e03941aba6cf55487af448e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-11 14:59:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/96/384996/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/a8b3b35//doc/build/html/ : SUCCESS in 3m 49s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/96/384996/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/d6390ec/ : SUCCESS in 5m 40s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/96/384996/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/6993f88/ : FAILURE in 2m 54s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/96/384996/1/check/gate-ironic-python-agent-python34/732aa38/ : FAILURE in 3m 05s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/96/384996/1/check/gate-ironic-python-agent-python35/ca20708/ : FAILURE in 3m 57s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/96/384996/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/62b89e7/ : SUCCESS in 3m 05s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src/e30613f/ : SUCCESS in 48m 03s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv/3ab43d9/ : SUCCESS in 48m 55s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src/9b132a5/ : SUCCESS in 44m 44s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv/10a2eba/ : SUCCESS in 47m 09s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src/ad82130/ : SUCCESS in 45m 36s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-tinyipa-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-tinyipa-src-nv/99f5503/ : FAILURE in 41m 46s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src/c3779a2/ : SUCCESS in 43m 13s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-coreos-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-coreos-src-nv/f236140/ : FAILURE in 40m 28s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv/0e0320c/ : SUCCESS in 43m 40s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv/5bce170/ : SUCCESS in 40m 02s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv/1da1ba5/ : SUCCESS in 45m 46s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv/1999201/ : SUCCESS in 48m 54s (non-voting)\n- gate-tempest-dsvm-ironic-inspector-src-nv http://logs.openstack.org/96/384996/1/check/gate-tempest-dsvm-ironic-inspector-src-nv/80df3e4/ : SUCCESS in 56m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a236ea2d47583ba44f4237b39b04589970161aeb","author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"date":"2016-10-12 09:57:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7dea7fac9d97fa01a0c3715632e2877b2983b1d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-12 10:42:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/96/384996/2/check/gate-ironic-python-agent-docs-ubuntu-xenial/7e13d86//doc/build/html/ : SUCCESS in 2m 50s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/96/384996/2/check/gate-ironic-python-agent-pep8-ubuntu-xenial/b196132/ : SUCCESS in 2m 09s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/96/384996/2/check/gate-ironic-python-agent-python27-ubuntu-xenial/082adde/ : SUCCESS in 2m 08s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/96/384996/2/check/gate-ironic-python-agent-python34/01ba2f7/ : SUCCESS in 2m 27s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/96/384996/2/check/gate-ironic-python-agent-python35/5801e30/ : SUCCESS in 2m 33s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/96/384996/2/check/gate-ironic-python-agent-releasenotes/a42235c//releasenotes/build/html/ : SUCCESS in 2m 31s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/96/384996/2/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/5783c37/ : SUCCESS in 2m 21s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src/5ca745c/ : SUCCESS in 31m 40s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv/d9f3ed8/ : SUCCESS in 32m 25s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src/7607339/ : SUCCESS in 30m 11s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv/985bf8a/ : SUCCESS in 43m 04s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src/7dddbac/ : SUCCESS in 44m 47s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-tinyipa-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-tinyipa-src-nv/3863c8c/ : SUCCESS in 30m 16s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src/7a7667f/ : SUCCESS in 34m 07s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-coreos-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-coreos-src-nv/f5393ae/ : SUCCESS in 33m 28s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv/bcbd898/ : SUCCESS in 33m 20s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv/9ade13d/ : SUCCESS in 38m 25s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv/c92a7b1/ : SUCCESS in 39m 04s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv/01519f7/ : SUCCESS in 32m 56s (non-voting)\n- gate-tempest-dsvm-ironic-inspector-src-nv http://logs.openstack.org/96/384996/2/check/gate-tempest-dsvm-ironic-inspector-src-nv/a0a2130/ : SUCCESS in 40m 19s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d4030c66b76263034ca57d63c10012cda0d1aa1c","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-10-12 23:27:43.000000000","message":"Patch Set 2: Code-Review-1\n\nI am not an expert in EFI boot, but given this option is explicitly exposed as for removable devices:\n\n\"--removable\nthe installation device is removable. This option is only available on EFI.\" from http://www.linuxhowtos.org/manpages/8/grub2-install.htm\n\nAre we certain there aren\u0027t going to be any negative side effects on non-virt installs from using this option? Can we possibly test this change on actual EFI hardware to ensure it doesn\u0027t cause any damage?\n\nInvalid EFI configurations can brick a machine, as was recently publicized as a bug in some linux distros -- because systemd left efi variable filesystems mounted. I just want to ensure we aren\u0027t going to introduce anything similarly scary.","accounts_in_message":[],"_revision_number":2},{"id":"0afe46408a479a7e5569bb2730d73c21400cf674","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-10-13 15:27:09.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nThis makes sense and I\u0027m kind of surprised we were not already ensuring that BOOTX64 was present.  I\u0027m okay with the change after reviewing the grub-install source code and the use of the removable flag.\n\nhttp://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-install.c#n1085\n\nThat being said, I would like to see the release note be a little more specific in regards to the case upon this occurs.\n\nFollow-up question, ironic-lib?","accounts_in_message":[],"_revision_number":2},{"id":"045644d91439786c14b29f78e188bf45dcfc2523","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-10-13 15:36:55.000000000","message":"Patch Set 2:\n\nTo further reply to JayF\u0027s concerns, looking at the code, it looks like it just copies the default file that the system would look for to load and prevents the binary from being registered in nvram, in effect, copies the file in case the default needs to be used.","accounts_in_message":[],"_revision_number":2},{"id":"9c4165ef963b5082229b13f432a7993e1d61007f","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-10-13 18:10:15.000000000","message":"Patch Set 2:\n\nThanks Julia, can we reflect some of this explanation in release notes/inline comments so that folks coming after can understand as well?","accounts_in_message":[],"_revision_number":2},{"id":"19fc6a15599fd7bb75bb1f4110b1625018f1a527","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-10-20 13:50:32.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"faa164c0454ec309cc96b7b747e926d719aee86d","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2016-10-20 13:51:00.000000000","message":"Patch Set 3:\n\nI updated the release note and the notes along side the command to provide additional context.","accounts_in_message":[],"_revision_number":3},{"id":"5afe3aac30d1f5ad0f0642f64cc8fb21b79b355b","author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"date":"2016-10-20 14:14:30.000000000","message":"Patch Set 3:\n\nSorry for not updating, I got distracted on other stuff and dropped the ball here","accounts_in_message":[],"_revision_number":3},{"id":"35ef4364e8a3abfd142484c82b2874f0e0af9986","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-20 14:44:26.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/96/384996/3/check/gate-ironic-python-agent-docs-ubuntu-xenial/1f2dc82//doc/build/html/ : SUCCESS in 2m 24s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/96/384996/3/check/gate-ironic-python-agent-pep8-ubuntu-xenial/f401cc3/ : SUCCESS in 7m 11s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/96/384996/3/check/gate-ironic-python-agent-python27-ubuntu-xenial/ecd5e14/ : SUCCESS in 1m 45s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/96/384996/3/check/gate-ironic-python-agent-python34/ea1afd9/ : SUCCESS in 1m 51s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/96/384996/3/check/gate-ironic-python-agent-python35/914b842/ : SUCCESS in 1m 50s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/96/384996/3/check/gate-ironic-python-agent-releasenotes/192c063//releasenotes/build/html/ : SUCCESS in 1m 43s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/96/384996/3/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/5f93cbf/ : SUCCESS in 2m 42s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src/e48e228/ : SUCCESS in 31m 48s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-coreos-src-nv/54030b9/ : SUCCESS in 53m 42s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src/11c7f58/ : SUCCESS in 30m 08s\n- gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ssh-tinyipa-src-nv/01c5150/ : SUCCESS in 46m 12s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src/d66b584/ : SUCCESS in 29m 27s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-tinyipa-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-tinyipa-src-nv/d9a608c/ : SUCCESS in 28m 55s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src/06bb671/ : SUCCESS in 30m 05s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-coreos-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_ssh-coreos-src-nv/46cfd91/ : SUCCESS in 30m 25s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-coreos-src-nv/d9c2615/ : SUCCESS in 31m 57s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-src-nv/606b0ac/ : SUCCESS in 30m 54s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-src-nv/6ac1812/ : SUCCESS in 30m 58s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-coreos-src-nv/d91c407/ : SUCCESS in 31m 54s (non-voting)\n- gate-tempest-dsvm-ironic-inspector-src-nv http://logs.openstack.org/96/384996/3/check/gate-tempest-dsvm-ironic-inspector-src-nv/9573668/ : SUCCESS in 39m 52s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"366f9b4e91a8f91f7e72aca73840bd28c62f0df7","author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"date":"2016-10-20 14:53:08.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"97b7edd8c7190f827a55d40fa6dda1403056bb4a","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2016-10-20 15:22:26.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0364ecd7d8c4b0a203a0aa7e318f4bc7984509c4","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2016-10-20 15:23:40.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nThanks!","accounts_in_message":[],"_revision_number":3},{"id":"2d8a832a0b702b302fc074b9038a8abb0b7960a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-20 15:23:51.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"9cc165adff9033c39876d655711eeb02c12b7ad6","date":"2016-10-20 16:18:49.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"cf5c0a1d6e2f16f3bdcf3dc3a21bc5471ab92fd0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-20 16:18:49.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/96/384996/3/gate/gate-ironic-python-agent-docs-ubuntu-xenial/7981fb8//doc/build/html/ : SUCCESS in 3m 08s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/96/384996/3/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/832d6a2/ : SUCCESS in 2m 20s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/96/384996/3/gate/gate-ironic-python-agent-python27-ubuntu-xenial/a97b65e/ : SUCCESS in 2m 14s\n- gate-ironic-python-agent-python34 http://logs.openstack.org/96/384996/3/gate/gate-ironic-python-agent-python34/6a73a59/ : SUCCESS in 4m 41s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/96/384996/3/gate/gate-ironic-python-agent-python35/3c8c79b/ : SUCCESS in 2m 54s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/96/384996/3/gate/gate-ironic-python-agent-releasenotes/bfbbcf8//releasenotes/build/html/ : SUCCESS in 1m 36s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src http://logs.openstack.org/96/384996/3/gate/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-coreos-src/a260493/ : SUCCESS in 30m 59s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src http://logs.openstack.org/96/384996/3/gate/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa-src/8bd8e10/ : SUCCESS in 29m 40s\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src http://logs.openstack.org/96/384996/3/gate/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-coreos-src/01a55cb/ : SUCCESS in 54m 56s\n- gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src http://logs.openstack.org/96/384996/3/gate/gate-tempest-dsvm-ironic-ipa-partition-pxe_ssh-tinyipa-src/e2d6736/ : SUCCESS in 30m 24s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"cc5556d06b19ec7b5f9eba1b2cfe8ac195d0e5ee","revisions":{"1eefb82651229c6786c8959c04c5ca5c9f4d6751":{"kind":"REWORK","_number":1,"created":"2016-10-11 13:28:10.000000000","uploader":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"ref":"refs/changes/96/384996/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/96/384996/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/1"}}},"commit":{"parents":[{"commit":"6490425b5bdfa0efd1b8cbc2e37fbbbf9076f5a8","subject":"Merge \"Remove Python 2.6 format style\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6490425b5bdfa0efd1b8cbc2e37fbbbf9076f5a8"}]}],"author":{"name":"Derek Higgins","email":"derekh@redhat.com","date":"2016-10-11 11:52:43.000000000","tz":60},"committer":{"name":"Derek Higgins","email":"derekh@redhat.com","date":"2016-10-11 13:28:00.000000000","tz":60},"subject":"Install grub in the EFI \"Fallback path\"","message":"Install grub in the EFI \"Fallback path\"\n\nIn systems where the nvram may have been reset, add\n\\EFI\\BOOT\\BOOTx64.EFI to the EFI system partition so that\nthe image continues to boot. This will be particularly useful\nif the NVRAM wasn\u0027t written correctly or if the baremetal\nserver is be simulated on virt and the NVRAM was been reset\non start (as is the case in libvirt).\n\nChange-Id: I5005ae02c283cdc01540ea46c341a7b0bf9d4c42\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1eefb82651229c6786c8959c04c5ca5c9f4d6751"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1eefb82651229c6786c8959c04c5ca5c9f4d6751"}]},"branch":"refs/heads/master"},"fecc727bb0bf8a9b5aa2c821c9e927287e3a558d":{"kind":"REWORK","_number":2,"created":"2016-10-12 09:57:51.000000000","uploader":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"ref":"refs/changes/96/384996/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/96/384996/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/2"}}},"commit":{"parents":[{"commit":"6490425b5bdfa0efd1b8cbc2e37fbbbf9076f5a8","subject":"Merge \"Remove Python 2.6 format style\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6490425b5bdfa0efd1b8cbc2e37fbbbf9076f5a8"}]}],"author":{"name":"Derek Higgins","email":"derekh@redhat.com","date":"2016-10-11 11:52:43.000000000","tz":60},"committer":{"name":"Derek Higgins","email":"derekh@redhat.com","date":"2016-10-12 09:56:56.000000000","tz":60},"subject":"Install grub in the EFI \"Fallback path\"","message":"Install grub in the EFI \"Fallback path\"\n\nIn systems where the nvram may have been reset, add\n\\EFI\\BOOT\\BOOTx64.EFI to the EFI system partition so that\nthe image continues to boot. This will be particularly useful\nif the NVRAM wasn\u0027t written correctly or if the baremetal\nserver is be simulated on virt and the NVRAM was been reset\non start (as is the case in libvirt).\n\nChange-Id: I5005ae02c283cdc01540ea46c341a7b0bf9d4c42\nCloses-Bug: #1632637\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fecc727bb0bf8a9b5aa2c821c9e927287e3a558d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fecc727bb0bf8a9b5aa2c821c9e927287e3a558d"}]},"branch":"refs/heads/master"},"cc5556d06b19ec7b5f9eba1b2cfe8ac195d0e5ee":{"kind":"REWORK","_number":3,"created":"2016-10-20 13:50:32.000000000","uploader":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"ref":"refs/changes/96/384996/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/96/384996/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/96/384996/3"}}},"commit":{"parents":[{"commit":"6490425b5bdfa0efd1b8cbc2e37fbbbf9076f5a8","subject":"Merge \"Remove Python 2.6 format style\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6490425b5bdfa0efd1b8cbc2e37fbbbf9076f5a8"}]}],"author":{"name":"Derek Higgins","email":"derekh@redhat.com","date":"2016-10-11 11:52:43.000000000","tz":60},"committer":{"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","date":"2016-10-20 13:50:02.000000000","tz":0},"subject":"Install grub in the EFI \"Fallback path\"","message":"Install grub in the EFI \"Fallback path\"\n\nIn systems where the nvram may have been reset, add\n\\EFI\\BOOT\\BOOTx64.EFI to the EFI system partition so that\nthe image continues to boot. This will be particularly useful\nif the NVRAM wasn\u0027t written correctly or if the baremetal\nserver is be simulated on virt and the NVRAM was been reset\non start (as is the case in libvirt).\n\nChange-Id: I5005ae02c283cdc01540ea46c341a7b0bf9d4c42\nCloses-Bug: #1632637\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cc5556d06b19ec7b5f9eba1b2cfe8ac195d0e5ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/cc5556d06b19ec7b5f9eba1b2cfe8ac195d0e5ee"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}