)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e40da9b34d867fa0698b9b654b45209aae975c71","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            extra[\u0027hctl\u0027] \u003d os.listdir("},{"line_number":162,"context_line":"                \u0027/sys/block/%s/device/scsi_device\u0027 % device[\u0027KNAME\u0027])[0]"},{"line_number":163,"context_line":"        except (OSError, IndexError):"},{"line_number":164,"context_line":"            LOG.debug(\u0027Could not find the HCTL for device %s\u0027, name)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        devices.append(BlockDevice(name\u003dname,"},{"line_number":167,"context_line":"                                   model\u003ddevice[\u0027MODEL\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_91728b48","line":164,"updated":"2016-12-07 15:13:46.000000000","message":"do you think it deserves a warning?","commit_id":"1ac91a9575a2a62d8a2b39b4a00e6f3beadec1f5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5f152c942454934c6c6b22bf9cf76278d46db7f2","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            extra[\u0027hctl\u0027] \u003d os.listdir("},{"line_number":162,"context_line":"                \u0027/sys/block/%s/device/scsi_device\u0027 % device[\u0027KNAME\u0027])[0]"},{"line_number":163,"context_line":"        except (OSError, IndexError):"},{"line_number":164,"context_line":"            LOG.debug(\u0027Could not find the HCTL for device %s\u0027, name)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        devices.append(BlockDevice(name\u003dname,"},{"line_number":167,"context_line":"                                   model\u003ddevice[\u0027MODEL\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_9419997c","line":164,"in_reply_to":"3a71b18c_91728b48","updated":"2016-12-07 15:24:31.000000000","message":"I left as debug because HCTL will always exist for SCSI controllers, so the only case where I see this being logged is if the controller is something else (e.g IDE). Maybe the log should reflect that ?\n\nBut yeah, a warning would make sense anyway. I will change it and improve the wording.","commit_id":"1ac91a9575a2a62d8a2b39b4a00e6f3beadec1f5"}]}