)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ca806e9e56fe6e455102c020d86d7fe474d481d","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            total \u003d None"},{"line_number":605,"context_line":"            LOG.warning(\"Cannot fetch total memory size: unsupported psutil \""},{"line_number":606,"context_line":"                        \"version %s\", psutil.version_info[0])"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        try:"},{"line_number":609,"context_line":"            out, _e \u003d utils.execute(\"dmidecode --type 17 | grep Size\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_7e5a2f52","line":606,"updated":"2017-01-24 23:40:46.000000000","message":"i hope we don\u0027t have to deal with versions 3 \u0026 4.","commit_id":"e4919e04aa250b51e351c4e9dbfb3761f5f93a70"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"dd7f4e0662fde5a2ed1c05c395c5cd9e58b670d8","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            total \u003d None"},{"line_number":605,"context_line":"            LOG.warning(\"Cannot fetch total memory size: unsupported psutil \""},{"line_number":606,"context_line":"                        \"version %s\", psutil.version_info[0])"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        try:"},{"line_number":609,"context_line":"            out, _e \u003d utils.execute(\"dmidecode --type 17 | grep Size\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_6440de36","line":606,"in_reply_to":"5a3905b3_7e5a2f52","updated":"2017-01-25 00:12:15.000000000","message":"I think in a follow up we should support all the middle versions, this was a quick up to unbreak things.","commit_id":"e4919e04aa250b51e351c4e9dbfb3761f5f93a70"}],"ironic_python_agent/tests/unit/test_hardware.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ca806e9e56fe6e455102c020d86d7fe474d481d","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            (\"Foo\\nSize: 2048 MB\\nSize: 2 GB\\n\""},{"line_number":738,"context_line":"             \"Installed Size: Not Installed\\n\""},{"line_number":739,"context_line":"             \"Enabled Size: Not Installed\\n\""},{"line_number":740,"context_line":"             \"Size: No Module Installed\\n\"),"},{"line_number":741,"context_line":"            \"\""},{"line_number":742,"context_line":"        )"},{"line_number":743,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_3e16e755","line":740,"updated":"2017-01-24 23:40:46.000000000","message":"don\u0027t you want to leave the existing test since it tests version 2, and add this one to test version 5?","commit_id":"e4919e04aa250b51e351c4e9dbfb3761f5f93a70"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"dd7f4e0662fde5a2ed1c05c395c5cd9e58b670d8","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            (\"Foo\\nSize: 2048 MB\\nSize: 2 GB\\n\""},{"line_number":738,"context_line":"             \"Installed Size: Not Installed\\n\""},{"line_number":739,"context_line":"             \"Enabled Size: Not Installed\\n\""},{"line_number":740,"context_line":"             \"Size: No Module Installed\\n\"),"},{"line_number":741,"context_line":"            \"\""},{"line_number":742,"context_line":"        )"},{"line_number":743,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_c45ef211","line":740,"in_reply_to":"5a3905b3_3e16e755","updated":"2017-01-25 00:12:15.000000000","message":"+1 probably a good idea in a follow up to support + test all the versions we can support (which according to requirements, right now, is anything \u003e1, which we might want to change).","commit_id":"e4919e04aa250b51e351c4e9dbfb3761f5f93a70"}]}