)]}'
{"imagebuild/tinyipa/install-deps.sh":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"6e324adb1f100653d7222bc220be19f7dca4543f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# first zypper in case zypper-aptitude is installed"},{"line_number":8,"context_line":"if [ -x \"/usr/bin/zypper\" ]; then"},{"line_number":9,"context_line":"    # squashfs-tools \u003d\u003e squashfs on SUSE"},{"line_number":10,"context_line":"    sudo -E zypper -n install -l ${PACKAGES/-tools}"},{"line_number":11,"context_line":"elif [ -x \"/usr/bin/apt-get\" ]; then"},{"line_number":12,"context_line":"    sudo -E apt-get update"},{"line_number":13,"context_line":"    sudo -E apt-get install -y $PACKAGES"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a430d35_b7c11631","line":10,"updated":"2017-02-03 12:27:41.000000000","message":"For clarity, I think this should be made explicit instead of applying a filter on the somewhat universal package list.","commit_id":"745470d6e2cff11b907ac972ac03dfc10a7fbaa0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f578cdcf02c02ed90c081013fedc39ff053239ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# first zypper in case zypper-aptitude is installed"},{"line_number":8,"context_line":"if [ -x \"/usr/bin/zypper\" ]; then"},{"line_number":9,"context_line":"    # squashfs-tools \u003d\u003e squashfs on SUSE"},{"line_number":10,"context_line":"    sudo -E zypper -n install -l ${PACKAGES/-tools}"},{"line_number":11,"context_line":"elif [ -x \"/usr/bin/apt-get\" ]; then"},{"line_number":12,"context_line":"    sudo -E apt-get update"},{"line_number":13,"context_line":"    sudo -E apt-get install -y $PACKAGES"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a430d35_d3b36c96","line":10,"in_reply_to":"1a430d35_083f9f87","updated":"2017-02-08 11:21:13.000000000","message":"+1 to Sam suggestion.\nAlso might be add INSTALL_CMD\u003d\"\" something like\n\nif [ -x \"zypper\" ]; then\n    INSTALL_CMD\u003d\"zypper -n install -l $COMMON_PACKAGES $ZYPPER_PACKAGES\"\nelif [ -x \"/usr/bin/apt-get\" ]; then\n    INSTALL_CMD\u003d\"apt-get update; apt-get install -y $PACKAGES\"\n....\nfi\n\nsudo -E $INSTALL_CMD","commit_id":"745470d6e2cff11b907ac972ac03dfc10a7fbaa0"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"42bf66693e4c2bb47254d529ec700fa20c0c9c7a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# first zypper in case zypper-aptitude is installed"},{"line_number":8,"context_line":"if [ -x \"/usr/bin/zypper\" ]; then"},{"line_number":9,"context_line":"    # squashfs-tools \u003d\u003e squashfs on SUSE"},{"line_number":10,"context_line":"    sudo -E zypper -n install -l ${PACKAGES/-tools}"},{"line_number":11,"context_line":"elif [ -x \"/usr/bin/apt-get\" ]; then"},{"line_number":12,"context_line":"    sudo -E apt-get update"},{"line_number":13,"context_line":"    sudo -E apt-get install -y $PACKAGES"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a430d35_a5015608","line":10,"in_reply_to":"1a430d35_726fbc92","updated":"2017-02-07 18:30:52.000000000","message":"I was thinking of something like this:\n\nZYPPER_PACKAGES\u003d\"${PACKAGES/-tools}\"\nAPT_PACKAGES\u003d\"${PACKAGES}\"\nDNF_PACKAGES\u003d\"${PACKAGES}\"\nYUM_PACKAGES\u003d\"${PACKAGES}\"\n\n*or* making them explicit all the way; duplicating the package names :(\n\nbut I reconsidered your change as-is and I feel it is almost the same. My suggestion does not clarify the intent much.","commit_id":"745470d6e2cff11b907ac972ac03dfc10a7fbaa0"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"12c7cc3b950f6edb1de044062ea2043f7f23b56a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# first zypper in case zypper-aptitude is installed"},{"line_number":8,"context_line":"if [ -x \"/usr/bin/zypper\" ]; then"},{"line_number":9,"context_line":"    # squashfs-tools \u003d\u003e squashfs on SUSE"},{"line_number":10,"context_line":"    sudo -E zypper -n install -l ${PACKAGES/-tools}"},{"line_number":11,"context_line":"elif [ -x \"/usr/bin/apt-get\" ]; then"},{"line_number":12,"context_line":"    sudo -E apt-get update"},{"line_number":13,"context_line":"    sudo -E apt-get install -y $PACKAGES"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a430d35_083f9f87","line":10,"in_reply_to":"1a430d35_a5015608","updated":"2017-02-07 18:36:58.000000000","message":"I think that I would prefer something like:\n\nCOMMON_PACKAGES \u003d \"wget python-pip unzip sudo gawk\"\nYUM_AND_APT_PACKAGES \u003d COMMON_PACKAGES + \"squashfs-tools\"\nZYPPER_PACKAGES \u003d COMMON_PACKAGES + \"squashfs\"\n\nI don\u0027t like using a regex because it doesn\u0027t seem particularly reusable if we need to add other packages that are different in the future.","commit_id":"745470d6e2cff11b907ac972ac03dfc10a7fbaa0"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"1ffe764158eb6c75d797f1b9932aaf0820f91810","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# first zypper in case zypper-aptitude is installed"},{"line_number":8,"context_line":"if [ -x \"/usr/bin/zypper\" ]; then"},{"line_number":9,"context_line":"    # squashfs-tools \u003d\u003e squashfs on SUSE"},{"line_number":10,"context_line":"    sudo -E zypper -n install -l ${PACKAGES/-tools}"},{"line_number":11,"context_line":"elif [ -x \"/usr/bin/apt-get\" ]; then"},{"line_number":12,"context_line":"    sudo -E apt-get update"},{"line_number":13,"context_line":"    sudo -E apt-get install -y $PACKAGES"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a430d35_726fbc92","line":10,"in_reply_to":"1a430d35_b7c11631","updated":"2017-02-03 12:49:57.000000000","message":"Hi Mathieu,\n\nI am not sure I get that. What\u0027s wrong with the filter since it only applies to the zypper case? I thought the comment clarifies that\n\nDo you want me to remove squashfs-tools from the PACKAGES variable and instead use something like\n\n$distro-pkgmanager $PACKAGES squashfs-tools\n\nor\n\n$distro-pkgmanager $PACKAGES squashfs\n\ndepending on the available package manager?","commit_id":"745470d6e2cff11b907ac972ac03dfc10a7fbaa0"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7057d9cddc7b30d3ee021b71061bf98c20969b19","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# first zypper in case zypper-aptitude is installed"},{"line_number":11,"context_line":"if [ -x \"/usr/bin/zypper\" ]; then"},{"line_number":12,"context_line":"    # squashfs-tools \u003d\u003e squashfs on SUSE"},{"line_number":13,"context_line":"    sudo -E zypper -n install -l ${ZYPPER_PACKAGES}"},{"line_number":14,"context_line":"elif [ -x \"/usr/bin/apt-get\" ]; then"},{"line_number":15,"context_line":"    sudo -E apt-get update"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a430d35_2ddb691c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":40},"updated":"2017-02-08 12:56:21.000000000","message":"Nit: I\u0027m not sure we need this comment any more :)","commit_id":"ac53bdb6f7ddd8080cbcc1b99bf449ffab02b14f"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"b91ae93425de33aa48697318e8cd0d94af758a78","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# first zypper in case zypper-aptitude is installed"},{"line_number":11,"context_line":"if [ -x \"/usr/bin/zypper\" ]; then"},{"line_number":12,"context_line":"    # squashfs-tools \u003d\u003e squashfs on SUSE"},{"line_number":13,"context_line":"    sudo -E zypper -n install -l ${ZYPPER_PACKAGES}"},{"line_number":14,"context_line":"elif [ -x \"/usr/bin/apt-get\" ]; then"},{"line_number":15,"context_line":"    sudo -E apt-get update"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a430d35_cd8585cf","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":40},"in_reply_to":"1a430d35_2ddb691c","updated":"2017-02-08 12:58:59.000000000","message":"Done","commit_id":"ac53bdb6f7ddd8080cbcc1b99bf449ffab02b14f"}]}