)]}'
{"id":"openstack%2Fironic-python-agent~433050","triplet_id":"openstack%2Fironic-python-agent~master~I16e70450cecaebb81b5851bb9589bd17a544668b","project":"openstack/ironic-python-agent","branch":"master","topic":"reno_cleanup","hashtags":[],"change_id":"I16e70450cecaebb81b5851bb9589bd17a544668b","subject":"Correct error in Infiniband release note","status":"MERGED","created":"2017-02-13 13:20:17.000000000","updated":"2017-02-13 14:21:55.000000000","submitted":"2017-02-13 14:21:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f21f03124ae410bb0736f7ada5129706496f689e","_number":433050,"virtual_id_number":433050,"owner":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-02-13 14:21:55.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-02-13 14:15:31.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":1,"date":"2017-02-13 13:20:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":1,"date":"2017-02-13 14:17:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":2,"date":"2017-02-13 13:45:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-02-13 14:17:27.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"value":0,"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-13 13:20:55.000000000","updated_by":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"reviewer":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"state":"REVIEWER"},{"updated":"2017-02-13 13:45:36.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-02-13 14:17:01.000000000","updated_by":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"reviewer":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"state":"REVIEWER"},{"updated":"2017-02-13 14:17:27.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2017-02-13 14:21:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a61023fdcbf24b4c8e4922ed06a0504f560918ae","author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"date":"2017-02-13 13:20:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"083577fae9aa3c6eab324b4081510afc43c6954c","author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"date":"2017-02-13 13:20:55.000000000","message":"Patch Set 1: Code-Review+1\n\nI\u0027d love to see moshele\u0027s comment on that one though.","accounts_in_message":[],"_revision_number":1},{"id":"9194b686b455cf3be0d9646174abffdbb630167f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-13 13:23:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/50/433050/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/337a7c3//doc/build/html/ : SUCCESS in 1m 55s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/50/433050/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/e6c085e/ : SUCCESS in 2m 14s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/50/433050/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/396ae17/ : SUCCESS in 2m 06s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/50/433050/1/check/gate-ironic-python-agent-python35/5c50dcb/ : SUCCESS in 1m 50s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/50/433050/1/check/gate-ironic-python-agent-releasenotes/bb1d0d5//releasenotes/build/html/ : SUCCESS in 1m 51s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/50/433050/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/0415279/ : SUCCESS in 2m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7a7938120753e62b8fccd2d35a2ad04f55983f81","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-02-13 13:45:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a5e295f2dbb5ff94e0854d823cee2f2f0b43d212","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2017-02-13 14:15:31.000000000","message":"Patch Set 1: Code-Review+2\n\nwould also like to wait for moshele to confirm","accounts_in_message":[],"_revision_number":1},{"id":"7d9b9f1eb5d3c840ecb01c0a1ede0c30c3cdf35a","author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"date":"2017-02-13 14:17:01.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM thanks :)","accounts_in_message":[],"_revision_number":1},{"id":"759ab8de71c40bc71a503c10adbc280a1198944a","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2017-02-13 14:17:27.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e6384d4b45c4e62c07fef4c30d8f867161f08b88","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-13 14:17:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d468478aed7019fad31782271cf94130e025802f","date":"2017-02-13 14:21:55.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"bb30801691eb332c06b8823375761f2cf29d3464","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-13 14:21:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/50/433050/1/gate/gate-ironic-python-agent-docs-ubuntu-xenial/938613f//doc/build/html/ : SUCCESS in 1m 59s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/50/433050/1/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/4a767ef/ : SUCCESS in 4m 02s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/50/433050/1/gate/gate-ironic-python-agent-python27-ubuntu-xenial/8563854/ : SUCCESS in 2m 43s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/50/433050/1/gate/gate-ironic-python-agent-python35/416fda7/ : SUCCESS in 1m 47s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/50/433050/1/gate/gate-ironic-python-agent-releasenotes/47764a8//releasenotes/build/html/ : SUCCESS in 2m 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6993bd82f4489360c1fd4c294fe05f50dbec620d","revisions":{"6993bd82f4489360c1fd4c294fe05f50dbec620d":{"kind":"REWORK","_number":1,"created":"2017-02-13 13:20:17.000000000","uploader":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"ref":"refs/changes/50/433050/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/50/433050/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/433050/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/433050/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/433050/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/50/433050/1"}}},"commit":{"parents":[{"commit":"06183752b51a6a860c813006cf13b227588d1575","subject":"imagebuild: tinyipa: Make the install-deps.sh SUSE aware","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/06183752b51a6a860c813006cf13b227588d1575"}]}],"author":{"name":"Miles Gould","email":"mgould@redhat.com","date":"2017-02-13 13:16:43.000000000","tz":0},"committer":{"name":"Miles Gould","email":"mgould@redhat.com","date":"2017-02-13 13:16:43.000000000","tz":0},"subject":"Correct error in Infiniband release note","message":"Correct error in Infiniband release note\n\nThe release note says that a MAC and Client-ID are calculated for\nInfiniband nodes according to RFC 4390, but RFC 4390 actually says\n\u0027\"chaddr\" (client hardware address) field MUST be zeroed.\u0027 (see\nhttps://tools.ietf.org/html/rfc4390#page-2). This commit changes the\nrelease note to say \"a Mellanox-specific translation\", which matches the\ncomments in hardware_managers/mlnx.py.\n\nChange-Id: I16e70450cecaebb81b5851bb9589bd17a544668b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6993bd82f4489360c1fd4c294fe05f50dbec620d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6993bd82f4489360c1fd4c294fe05f50dbec620d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}