)]}'
{"id":"openstack%2Fironic-python-agent~447306","triplet_id":"openstack%2Fironic-python-agent~master~I620dce91abaa4440e1803aeefb3e93c0b65d1419","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"I620dce91abaa4440e1803aeefb3e93c0b65d1419","subject":"Add missing \u0027autospec\u0027 argument to mock.patch","status":"MERGED","created":"2017-03-19 17:05:18.000000000","updated":"2017-03-20 13:59:18.000000000","submitted":"2017-03-20 13:59:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"25b44182d00c6e8a1a1edab45a0d0470169ce2c7","_number":447306,"virtual_id_number":447306,"owner":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-03-20 13:59:18.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"recommended":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-03-20 08:56:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":2,"date":"2017-03-20 13:54:59.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":2,"date":"2017-03-20 09:10:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":1,"date":"2017-03-20 13:54:59.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-20 08:56:05.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2017-03-20 09:10:40.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-03-20 13:54:59.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2017-03-20 13:59:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6f3b5b2464da8f390e256b50ee846ce2b62432ea","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-03-19 17:05:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"834b742e370001c321fbe9e42b2299082a323333","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-19 17:09:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/06/447306/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/6eb6344//doc/build/html/ : SUCCESS in 2m 21s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/06/447306/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/a4e9635/ : SUCCESS in 3m 57s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/06/447306/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/4a41ce2/ : SUCCESS in 1m 51s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/06/447306/1/check/gate-ironic-python-agent-python35/bf1261b/ : SUCCESS in 1m 47s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/06/447306/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/674911f/ : SUCCESS in 3m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"97a6562c9b5598c174a05ffe836ad14edd2a4b0d","author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"date":"2017-03-20 08:56:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ca7d5797c67ed128ec6c5d15d1f15f093762cc3c","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-03-20 09:10:40.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"776b829b180df8f4479690cf870fb23f60c00f3b","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-03-20 13:46:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ce2d3b08d3f7d4698289f4f1bfbd3ae627684b78","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2017-03-20 13:54:59.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)\n\nDang, that\u0027s a lot of them. Nice work, thanks John :)","accounts_in_message":[],"_revision_number":1},{"id":"2d04cfaf0568864282371376937f30488ce7eec5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 13:55:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"937233cd467b753bf1d3d146593e1e381a0cd246","date":"2017-03-20 13:59:18.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"25b44182d00c6e8a1a1edab45a0d0470169ce2c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 13:59:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/06/447306/1/gate/gate-ironic-python-agent-docs-ubuntu-xenial/534372e//doc/build/html/ : SUCCESS in 3m 48s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/06/447306/1/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/bc31330/ : SUCCESS in 2m 25s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/06/447306/1/gate/gate-ironic-python-agent-python27-ubuntu-xenial/365ec90/ : SUCCESS in 3m 10s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/06/447306/1/gate/gate-ironic-python-agent-python35/761270d/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1695cb18c25f2afed27309fd4602dc91ba741864","revisions":{"1695cb18c25f2afed27309fd4602dc91ba741864":{"kind":"REWORK","_number":1,"created":"2017-03-19 17:05:18.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/06/447306/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/06/447306/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/447306/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/447306/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/447306/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/06/447306/1"}}},"commit":{"parents":[{"commit":"24b4e3f1c099cb4c3c6e267e2676137f08f484e0","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/24b4e3f1c099cb4c3c6e267e2676137f08f484e0"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-03-19 15:30:25.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-03-19 17:04:19.000000000","tz":-420},"subject":"Add missing \u0027autospec\u0027 argument to mock.patch","message":"Add missing \u0027autospec\u0027 argument to mock.patch\n\nAdd missing \u0027autospec\u0027 keyword argument to mock.patch and\nmock.patch.object calls. Use \u0027autospec\u003dTrue\u0027 except for a few cases\nwhere it fails because the mocked function is a @classmethod and it\ndoesn\u0027t work. In that case explicity set it to \u0027autospec\u003dFalse\u0027\n\nChange-Id: I620dce91abaa4440e1803aeefb3e93c0b65d1419\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1695cb18c25f2afed27309fd4602dc91ba741864"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1695cb18c25f2afed27309fd4602dc91ba741864"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}