)]}'
{"id":"openstack%2Fironic-python-agent~452603","triplet_id":"openstack%2Fironic-python-agent~master~Idf87d09a9c01a6bfe2767f8becabe65c02983518","project":"openstack/ironic-python-agent","branch":"master","topic":"no_more_exec_in_tests","hashtags":[],"change_id":"Idf87d09a9c01a6bfe2767f8becabe65c02983518","subject":"Prevent tests\u0027 unmocked access to utils.execute()","status":"MERGED","created":"2017-04-03 05:37:15.000000000","updated":"2017-05-15 13:48:35.000000000","submitted":"2017-05-15 04:25:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":17,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7e601a93679e6f647dded24b6dabb5f2b4c1f38b","_number":452603,"virtual_id_number":452603,"owner":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-05-15 04:25:45.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-05-15 08:29:43.000000000","post_submit":true,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2017-05-15 04:22:25.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2017-05-15 04:22:25.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-05 01:19:59.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2017-04-05 15:28:45.000000000","updated_by":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"reviewer":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"state":"REVIEWER"},{"updated":"2017-04-28 10:22:56.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-05-15 04:22:25.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2017-05-15 04:25:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-05-15 08:29:43.000000000","updated_by":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"reviewer":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"state":"REVIEWER"}],"messages":[{"id":"486eb53934b245f3e3de851b60c5f848db1eb5ba","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-04-03 05:37:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2ed77ebc928de88daa267b70bb4aa9652b18797","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 05:41:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/fe964c1//doc/build/html/ : SUCCESS in 4m 17s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/b464d69/ : FAILURE in 3m 09s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/208a1fe/ : SUCCESS in 1m 50s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/1/check/gate-ironic-python-agent-python35/d6ac399/ : SUCCESS in 1m 51s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/03/452603/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/8035813/ : SUCCESS in 2m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e650ec21412e9af1322197f647f96ee99208f436","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-04-03 06:22:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7f6c23af3f45aca47c11cac7dc4c38152a5823d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 06:29:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/2/check/gate-ironic-python-agent-docs-ubuntu-xenial/598d999//doc/build/html/ : SUCCESS in 3m 20s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/2/check/gate-ironic-python-agent-pep8-ubuntu-xenial/4de4b15/ : SUCCESS in 3m 20s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/2/check/gate-ironic-python-agent-python27-ubuntu-xenial/a597d8b/ : SUCCESS in 3m 41s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/2/check/gate-ironic-python-agent-python35/1566d2c/ : SUCCESS in 2m 22s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/03/452603/2/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/70a5850/ : SUCCESS in 3m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"3832182400735836043340e9163ac6e316f9c2f2","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-04-03 23:37:09.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"b8e018c9ecbaef6dde5d8b9de7c6566021d537e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 23:40:13.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/3/check/gate-ironic-python-agent-docs-ubuntu-xenial/1fd4946//doc/build/html/ : SUCCESS in 2m 50s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/3/check/gate-ironic-python-agent-pep8-ubuntu-xenial/987f705/ : SUCCESS in 2m 45s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/3/check/gate-ironic-python-agent-python27-ubuntu-xenial/c3f4e18/ : SUCCESS in 1m 44s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/3/check/gate-ironic-python-agent-python35/8bd51d5/ : SUCCESS in 1m 56s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/03/452603/3/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/d33c5cd/ : SUCCESS in 2m 10s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"3068eb01e73a5917a75eba8f2adcdbf070776585","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-04-03 23:43:48.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"24a4048f1842052f755ed9c4577609ea0b07fb6d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 23:47:34.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/4/check/gate-ironic-python-agent-docs-ubuntu-xenial/2d87dfc//doc/build/html/ : SUCCESS in 1m 56s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/4/check/gate-ironic-python-agent-pep8-ubuntu-xenial/9a1c08e/ : SUCCESS in 2m 19s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/4/check/gate-ironic-python-agent-python27-ubuntu-xenial/cf849d1/ : SUCCESS in 2m 32s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/4/check/gate-ironic-python-agent-python35/f4d9eff/ : SUCCESS in 3m 16s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/03/452603/4/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/b835858/ : SUCCESS in 2m 53s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"1b29b634c5a8a2fe9e11afadd9ff2249efa7a73d","author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"date":"2017-04-05 15:28:45.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)\n\nThis is a super useful patch, thanks! 2 questions inline about why the tearDown methods in certain tests moved. That seems unrelated. Otherwise, LGTM.","accounts_in_message":[],"_revision_number":4},{"id":"d0541aaecda6d855b66e498bfa0370bc0bc77dbc","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-04-05 23:08:14.000000000","message":"Patch Set 4:\n\n(3 comments)\n\nThanks for the review Mario!\n\nThe unrelated changes are drive-by improvements, see inline.","accounts_in_message":[],"_revision_number":4},{"id":"c0e8379f475f754b0f5b477674b08b1a58b89702","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-04-13 02:48:37.000000000","message":"Patch Set 4:\n\nPlease recheck, people!","accounts_in_message":[],"_revision_number":4},{"id":"32475a19b3efa26f1a5e80dc70bd25d244ca347f","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-04-13 02:49:50.000000000","message":"Patch Set 5: Published edit on patch set 4","accounts_in_message":[],"_revision_number":5},{"id":"4460c3993e07416b59db62a4587df0572ebe5c02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-13 02:53:36.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/5/check/gate-ironic-python-agent-docs-ubuntu-xenial/5554453//doc/build/html/ : SUCCESS in 3m 12s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/5/check/gate-ironic-python-agent-pep8-ubuntu-xenial/6832056/ : SUCCESS in 3m 32s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/5/check/gate-ironic-python-agent-python27-ubuntu-xenial/a5b61fa/ : SUCCESS in 1m 56s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/5/check/gate-ironic-python-agent-python35/b6664b1/ : SUCCESS in 1m 52s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/03/452603/5/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/546e73f/ : SUCCESS in 3m 10s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"86501d78f0aa084db42fc85e868b98f803819921","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-04-28 10:22:56.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"ee3d84b041d1f6763e7cb65297b5b25677c0f445","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-05-11 04:00:03.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"081cb118ea75156a57277a54ebf544cc79109c5e","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-05-11 04:01:45.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nSorry for the delay in fixing, I\u0027ve been ill for a while. Please check again.","accounts_in_message":[],"_revision_number":5},{"id":"050b6043252aa59e3f6bc34a6b7c7e6e6bd299c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-11 04:04:09.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/6/check/gate-ironic-python-agent-docs-ubuntu-xenial/09b5d60//doc/build/html/ : SUCCESS in 3m 54s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/6/check/gate-ironic-python-agent-pep8-ubuntu-xenial/81de4bf/ : SUCCESS in 2m 13s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/6/check/gate-ironic-python-agent-python27-ubuntu-xenial/0c9c1bd/ : SUCCESS in 3m 28s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/6/check/gate-ironic-python-agent-python35/e6a49af/ : SUCCESS in 3m 49s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/03/452603/6/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/ba931c6/ : SUCCESS in 2m 28s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"1b1f0ae12d1efcefc0eea3f97741cabc4260f84a","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-11 16:01:55.000000000","message":"Patch Set 6: Code-Review-1\n\n(3 comments)\n\nLooks good. I would like a comment like done in test_utils.py to explain the two test classes which aren\u0027t using the new base test class.","accounts_in_message":[],"_revision_number":6},{"id":"f54fdc04041917cda77436e5c8b018a0f53e5b70","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-11 16:21:53.000000000","message":"Patch Set 6:\n\nAny plans on doing something similar for Ironic?","accounts_in_message":[],"_revision_number":6},{"id":"2e02aa649ab93a727cc46e8f4f99094cfc272cfc","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-11 20:24:21.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"3202f1a94ec28f8eef8923e0954eb283035e6845","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-05-15 00:50:30.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"d7da0b2a8410b373809c6a93d0321a6d8ae2f38c","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-05-15 00:54:24.000000000","message":"Patch Set 6:\n\n(3 comments)\n\n\u003e Any plans on doing something similar for Ironic?\n\nI was going to when I had time but I see you\u0027ve already done it!","accounts_in_message":[],"_revision_number":6},{"id":"0fba6ad802b08dc1d9cbe2c5614561843effcebf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-15 01:05:39.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/7/check/gate-ironic-python-agent-docs-ubuntu-xenial/8af66ef//doc/build/html/ : SUCCESS in 7m 56s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/7/check/gate-ironic-python-agent-pep8-ubuntu-xenial/72bb56f/ : SUCCESS in 8m 18s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/7/check/gate-ironic-python-agent-python27-ubuntu-xenial/c1e99fc/ : SUCCESS in 4m 31s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/7/check/gate-ironic-python-agent-python35/9b84a64/ : SUCCESS in 8m 17s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/03/452603/7/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/a64c496/ : SUCCESS in 4m 19s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"6d6f6c799b87c583daadeb6e0612a587b346e450","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-15 04:16:35.000000000","message":"Patch Set 7:\n\n\u003e (3 comments)\n \u003e \n \u003e \u003e Any plans on doing something similar for Ironic?\n \u003e \n \u003e I was going to when I had time but I see you\u0027ve already done it!\n\nI only did ironic-lib :) But if you don\u0027t have time I can try to do it also for ironic.","accounts_in_message":[],"_revision_number":7},{"id":"0523cd4b195ca47bffb468233497ffa65cada819","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-05-15 04:18:40.000000000","message":"Patch Set 7:\n\n\u003e I only did ironic-lib :) But if you don\u0027t have time I can try to do\n \u003e it also for ironic.\n\nI\u0027m cool if you want to do it. I wouldn\u0027t get around to it for a while anyway.","accounts_in_message":[],"_revision_number":7},{"id":"fcb741da224f5542a5da5e3d8720c7a478d4c5d9","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-15 04:22:25.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nThanks. This is awesome :)","accounts_in_message":[],"_revision_number":7},{"id":"2ef5c6a0301118e390f86a233380975c7ecf8156","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-15 04:22:35.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"ebf27cc857c395722e18e2313dcca8404dd38455","author":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"date":"2017-05-15 04:23:52.000000000","message":"Patch Set 7:\n\n\u003e Thanks. This is awesome :)\n\nWoo, thanks for reviewing!  I dread to think what\u0027s been getting executed on peoples\u0027 laptops...","accounts_in_message":[],"_revision_number":7},{"id":"9abcc755123952aead18392c986a1304f8e4d8bf","date":"2017-05-15 04:25:45.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":7},{"id":"143091203caf451b72452730c46da9b874280333","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-15 04:25:45.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/03/452603/7/gate/gate-ironic-python-agent-docs-ubuntu-xenial/a9035e6//doc/build/html/ : SUCCESS in 1m 57s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/03/452603/7/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/3e6cbe7/ : SUCCESS in 2m 14s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/03/452603/7/gate/gate-ironic-python-agent-python27-ubuntu-xenial/b646baa/ : SUCCESS in 1m 56s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/03/452603/7/gate/gate-ironic-python-agent-python35/13a8ab6/ : SUCCESS in 3m 08s","accounts_in_message":[],"_revision_number":7},{"id":"8e7c93f55b6da8f6aa829f99aea44bc3933534ba","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-15 06:25:19.000000000","message":"Patch Set 7:\n\nWhoops, I accidentally did a +A on this. Not what I intended.","accounts_in_message":[],"_revision_number":7},{"id":"1f6a93b06d939adff815990eb0becf9d5be1ae2a","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2017-05-15 08:29:43.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"9faa67ff535b01a6399938b0d03d824a4a7de355","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2017-05-15 08:46:10.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"a9cc001d51edce64b0ca4699a10e81cee67e2ced","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2017-05-15 08:46:38.000000000","message":"Patch Set 7:\n\nCannot post my mark anymore, so just commenting, +2 :)","accounts_in_message":[],"_revision_number":7},{"id":"25824f4c196d52edbc5032488f6335865836452b","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-15 13:48:35.000000000","message":"Patch Set 7:\n\n\u003e Cannot post my mark anymore, so just commenting, +2 :)\n\nThamks!","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"f57cbccf8b146152eacd99787a7ccc1097b80055","revisions":{"1ca3d8fc83574961bd1f7454015e208aa0f240c8":{"kind":"REWORK","_number":1,"created":"2017-04-03 05:37:15.000000000","uploader":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"ref":"refs/changes/03/452603/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/03/452603/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/1"}}},"commit":{"parents":[{"commit":"4be702242eb48e09eb77e46d997908b7c519127d","subject":"Merge \"Add missing \u0027autospec\u0027 argument to mock.patch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4be702242eb48e09eb77e46d997908b7c519127d"}]}],"author":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"committer":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"subject":"Prevent tests from using utils.execute()","message":"Prevent tests from using utils.execute()\n\nThis change introduces a new base test class that mocks out\nutils.execute and forces an exception if it gets called.\nThis has rooted out many tests that were doing this as a side effect of\ncalling other functions, doing things like modprobe and running iscsi\non the host\u0027s actual machine.\n\nThe tests are all now appropriately patched in places where this was\nhappening, and the new base class permanently prevents this from\naccidentally happening again.\n\nAlso I removed ExecuteTestCase which wasn\u0027t actually testing anything\nother than itself.\n\nChange-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1ca3d8fc83574961bd1f7454015e208aa0f240c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/1ca3d8fc83574961bd1f7454015e208aa0f240c8"}]},"branch":"refs/heads/master"},"51fcdd0ef49f16404463952580250372e5313c3c":{"kind":"REWORK","_number":2,"created":"2017-04-03 06:22:14.000000000","uploader":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"ref":"refs/changes/03/452603/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/03/452603/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/2"}}},"commit":{"parents":[{"commit":"4be702242eb48e09eb77e46d997908b7c519127d","subject":"Merge \"Add missing \u0027autospec\u0027 argument to mock.patch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4be702242eb48e09eb77e46d997908b7c519127d"}]}],"author":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"committer":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 06:21:40.000000000","tz":600},"subject":"Prevent tests from using utils.execute()","message":"Prevent tests from using utils.execute()\n\nThis change introduces a new base test class that mocks out\nutils.execute and forces an exception if it gets called.\nThis has rooted out many tests that were doing this as a side effect of\ncalling other functions, doing things like modprobe and running iscsi\non the host\u0027s actual machine.\n\nThe tests are all now appropriately patched in places where this was\nhappening, and the new base class permanently prevents this from\naccidentally happening again.\n\nAlso I removed ExecuteTestCase which wasn\u0027t actually testing anything\nother than itself.\n\nChange-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/51fcdd0ef49f16404463952580250372e5313c3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/51fcdd0ef49f16404463952580250372e5313c3c"}]},"branch":"refs/heads/master"},"84c4c23f1cd0bbcf207b486286edfc3c70b9b2ee":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2017-04-03 23:37:09.000000000","uploader":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"ref":"refs/changes/03/452603/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/03/452603/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/3"}}},"commit":{"parents":[{"commit":"4be702242eb48e09eb77e46d997908b7c519127d","subject":"Merge \"Add missing \u0027autospec\u0027 argument to mock.patch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4be702242eb48e09eb77e46d997908b7c519127d"}]}],"author":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"committer":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 23:37:01.000000000","tz":0},"subject":"WIP: Prevent tests from using utils.execute()","message":"WIP: Prevent tests from using utils.execute()\n\nThis change introduces a new base test class that mocks out\nutils.execute and forces an exception if it gets called.\nThis has rooted out many tests that were doing this as a side effect of\ncalling other functions, doing things like modprobe and running iscsi\non the host\u0027s actual machine.\n\nThe tests are all now appropriately patched in places where this was\nhappening, and the new base class permanently prevents this from\naccidentally happening again.\n\n\nChange-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/84c4c23f1cd0bbcf207b486286edfc3c70b9b2ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/84c4c23f1cd0bbcf207b486286edfc3c70b9b2ee"}]},"branch":"refs/heads/master"},"f8575f4e6e07751245896d1bee38b6289cbd400c":{"kind":"REWORK","_number":4,"created":"2017-04-03 23:43:48.000000000","uploader":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"ref":"refs/changes/03/452603/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/03/452603/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/4"}}},"commit":{"parents":[{"commit":"4be702242eb48e09eb77e46d997908b7c519127d","subject":"Merge \"Add missing \u0027autospec\u0027 argument to mock.patch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4be702242eb48e09eb77e46d997908b7c519127d"}]}],"author":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"committer":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 23:43:21.000000000","tz":600},"subject":"Prevent tests from using utils.execute()","message":"Prevent tests from using utils.execute()\n\nThis change introduces a new base test class that mocks out\nutils.execute and forces an exception if it gets called.\nThis has rooted out many tests that were doing this as a side effect of\ncalling other functions, doing things like modprobe and running iscsi\non the host\u0027s actual machine.\n\nThe tests are all now appropriately patched in places where this was\nhappening, and the new base class permanently prevents this from\naccidentally happening again.\n\nChange-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f8575f4e6e07751245896d1bee38b6289cbd400c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f8575f4e6e07751245896d1bee38b6289cbd400c"}]},"branch":"refs/heads/master"},"2956c4d098cb557a6824b5c5ba333523f8b1f0ff":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2017-04-13 02:49:50.000000000","uploader":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"ref":"refs/changes/03/452603/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/03/452603/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/5"}}},"commit":{"parents":[{"commit":"4be702242eb48e09eb77e46d997908b7c519127d","subject":"Merge \"Add missing \u0027autospec\u0027 argument to mock.patch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4be702242eb48e09eb77e46d997908b7c519127d"}]}],"author":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"committer":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-13 02:49:28.000000000","tz":0},"subject":"Prevent tests from using utils.execute()","message":"Prevent tests from using utils.execute()\n\nThis change introduces a new base test class that mocks out\nutils.execute and forces an exception if it gets called.\nThis has rooted out many tests that were doing this as a side effect of\ncalling other functions, doing things like modprobe and running iscsi\non the host\u0027s actual machine.\n\nThe tests are all now appropriately patched in places where this was\nhappening, and the new base class permanently prevents this from\naccidentally happening again.\n\nFixes: #1592199\n\nChange-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2956c4d098cb557a6824b5c5ba333523f8b1f0ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/2956c4d098cb557a6824b5c5ba333523f8b1f0ff"}]},"branch":"refs/heads/master"},"acb840ee5d3f43b39d96a710e1425139f0e977ed":{"kind":"REWORK","_number":6,"created":"2017-05-11 04:00:03.000000000","uploader":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"ref":"refs/changes/03/452603/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/03/452603/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/6"}}},"commit":{"parents":[{"commit":"4be702242eb48e09eb77e46d997908b7c519127d","subject":"Merge \"Add missing \u0027autospec\u0027 argument to mock.patch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4be702242eb48e09eb77e46d997908b7c519127d"}]}],"author":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"committer":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-05-11 03:59:50.000000000","tz":600},"subject":"Prevent tests from using utils.execute()","message":"Prevent tests from using utils.execute()\n\nThis change introduces a new base test class that mocks out\nutils.execute and forces an exception if it gets called.\nThis has rooted out many tests that were doing this as a side effect of\ncalling other functions, doing things like modprobe and running iscsi\non the host\u0027s actual machine.\n\nThe tests are all now appropriately patched in places where this was\nhappening, and the new base class permanently prevents this from\naccidentally happening again.\n\nChange-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/acb840ee5d3f43b39d96a710e1425139f0e977ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/acb840ee5d3f43b39d96a710e1425139f0e977ed"}]},"branch":"refs/heads/master"},"f57cbccf8b146152eacd99787a7ccc1097b80055":{"kind":"REWORK","_number":7,"created":"2017-05-15 00:50:30.000000000","uploader":{"_account_id":15750,"name":"Julian Edwards","email":"bigjools@gmail.com","username":"bigjools"},"ref":"refs/changes/03/452603/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/03/452603/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/03/452603/7"}}},"commit":{"parents":[{"commit":"4be702242eb48e09eb77e46d997908b7c519127d","subject":"Merge \"Add missing \u0027autospec\u0027 argument to mock.patch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4be702242eb48e09eb77e46d997908b7c519127d"}]}],"author":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-04-03 05:32:44.000000000","tz":600},"committer":{"name":"Julian Edwards","email":"bigjools@gmail.com","date":"2017-05-15 00:48:43.000000000","tz":600},"subject":"Prevent tests\u0027 unmocked access to utils.execute()","message":"Prevent tests\u0027 unmocked access to utils.execute()\n\nThis change introduces a new base test class that mocks out\nutils.execute and forces an exception if it gets called.\nThis has rooted out many tests that were doing this as a side effect of\ncalling other functions, doing things like modprobe and running iscsi\non the host\u0027s actual machine.\n\nThe tests are all now appropriately patched in places where this was\nhappening, and the new base class permanently prevents this from\naccidentally happening again.\n\nIf you really want to call utils.execute() then you need to re-mock it\nin your unit test.\n\nChange-Id: Idf87d09a9c01a6bfe2767f8becabe65c02983518\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f57cbccf8b146152eacd99787a7ccc1097b80055"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f57cbccf8b146152eacd99787a7ccc1097b80055"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}