)]}'
{"id":"openstack%2Fironic-python-agent~457547","triplet_id":"openstack%2Fironic-python-agent~master~I732c4aa3d1760c3159d9672e3fae81f8bd72497c","project":"openstack/ironic-python-agent","branch":"master","topic":"457547","hashtags":[],"change_id":"I732c4aa3d1760c3159d9672e3fae81f8bd72497c","subject":"Set valid inspection_dhcp_wait_timeout value in tests","status":"MERGED","created":"2017-04-18 10:04:47.000000000","updated":"2017-04-25 12:55:26.000000000","submitted":"2017-04-25 12:55:26.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0a622c665d8e94118772aa860df69f93a34535ef","_number":457547,"virtual_id_number":457547,"owner":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2017-04-25 12:55:26.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"value":2,"date":"2017-04-25 12:50:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2017-04-25 12:23:18.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"value":1,"date":"2017-04-25 12:50:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-25 12:23:18.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2017-04-25 12:50:20.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-04-25 12:55:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"284b0418e58dc6de535a31db09d350698b217313","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2017-04-18 10:04:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"577252bf97e978bdb790d7932ab03a48debfd78e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-18 10:10:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/47/457547/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/8144060//doc/build/html/ : SUCCESS in 3m 38s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/47/457547/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/4e0bf68/ : SUCCESS in 2m 35s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/47/457547/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/35a90dd/ : SUCCESS in 5m 21s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/47/457547/1/check/gate-ironic-python-agent-python35/30c7899/ : SUCCESS in 5m 23s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/47/457547/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/24078c5/ : SUCCESS in 2m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"649afa5f2bef76cbe1146a3c47045a3e8599b2c5","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-04-20 19:27:26.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks. You fixed that problem BUT it means the test will take 1+ seconds to run, instead of 0.03 ish secs. I think we\u0027ll need to mock time or whatever the code is doing.","accounts_in_message":[],"_revision_number":1},{"id":"04cd072089538770b6fa4fe10dbdddf8ada464a9","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-04-20 19:40:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"16526c7434ed1e7d9e271478e98f2bb245c2e03a","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2017-04-21 07:53:15.000000000","message":"Patch Set 1:\n\n\u003e Thanks. You fixed that problem BUT it means the test will take 1+\n \u003e seconds to run, instead of 0.03 ish secs. I think we\u0027ll need to\n \u003e mock time or whatever the code is doing.\n\nWe could also set dhcp_wait_timeout to be FloatOpt instead of IntOpt if we want this, otherwise our only chance is to set an integer value.\n\nWhich option do you think is best?","accounts_in_message":[],"_revision_number":1},{"id":"d5eb97f270c76ab9c5458578ae3a75d529e681bf","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-04-24 14:41:25.000000000","message":"Patch Set 1:\n\nI think that test was using small values so that it wouldn\u0027t take long to run the test. The right thing to do is to mock the time calls, (typically time.sleep but I don\u0027t know in this case w/o looking into it). Eg, I just reviewed this patch (in a different repo): https://review.openstack.org/#/c/459301/1/ironic/tests/unit/drivers/modules/redfish/test_utils.py","accounts_in_message":[],"_revision_number":1},{"id":"8b7216cc4f08fe50dce4cef0c3e5d52bfb363db5","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2017-04-24 15:34:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"032165c57a59fdf7ed67ccc9a970183eec270bd4","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2017-04-24 15:36:30.000000000","message":"Patch Set 2:\n\n\u003e I think that test was using small values so that it wouldn\u0027t take\n \u003e long to run the test. The right thing to do is to mock the time\n \u003e calls, (typically time.sleep but I don\u0027t know in this case w/o\n \u003e looking into it). Eg, I just reviewed this patch (in a different\n \u003e repo): https://review.openstack.org/#/c/459301/1/ironic/tests/unit/drivers/modules/redfish/test_utils.py\n\nOk, thanks for the hint. I think I got a good PS now. I have to mock both time.sleep() and time.time().","accounts_in_message":[],"_revision_number":2},{"id":"a3d2b60777105c3fa0f20eb9cee13e9b3e2d2f34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-24 15:42:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/47/457547/2/check/gate-ironic-python-agent-docs-ubuntu-xenial/d02531d//doc/build/html/ : SUCCESS in 2m 14s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/47/457547/2/check/gate-ironic-python-agent-pep8-ubuntu-xenial/525ebdc/ : SUCCESS in 4m 23s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/47/457547/2/check/gate-ironic-python-agent-python27-ubuntu-xenial/e076d75/ : SUCCESS in 3m 30s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/47/457547/2/check/gate-ironic-python-agent-python35/7e61ef4/ : SUCCESS in 5m 38s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/47/457547/2/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/b10d7e9/ : SUCCESS in 5m 34s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"aef965c4f5347089219f7a55034541eb249f84f0","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-04-24 20:16:45.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)\n\nThanks!","accounts_in_message":[],"_revision_number":2},{"id":"f9a7d0538a1807f0aef93cb721dc4310b64e5e1f","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2017-04-25 10:12:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f41a6b4687d1fb4fd3848ca9220e7828313fd550","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2017-04-25 10:14:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8f29e3beddf317c640319a7a56245db00b3fe9b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-25 10:18:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/47/457547/3/check/gate-ironic-python-agent-docs-ubuntu-xenial/788a66a//doc/build/html/ : SUCCESS in 3m 19s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/47/457547/3/check/gate-ironic-python-agent-pep8-ubuntu-xenial/f467b40/ : SUCCESS in 2m 16s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/47/457547/3/check/gate-ironic-python-agent-python27-ubuntu-xenial/4aad4f2/ : SUCCESS in 3m 19s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/47/457547/3/check/gate-ironic-python-agent-python35/da5e21e/ : SUCCESS in 5m 17s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/47/457547/3/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/48a4e14/ : SUCCESS in 2m 07s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b84d718091b8ce9e36441b23b6740d19c2951db6","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-04-25 12:23:18.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"db972632067a6854d33b32e4c00feaa414ad6748","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-04-25 12:50:20.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2\n\nMocking time may be dangerous, but let\u0027s see. Thanks!","accounts_in_message":[],"_revision_number":3},{"id":"fc45732ac9cb2a4d6fac97e2b01dee0877a4bc0c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-25 12:50:30.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"c7dc8b18319e6e5e967f2c1d0510a007a93b6e68","date":"2017-04-25 12:55:26.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"8e119bff8c1b078de87a048e757013e904ae5e82","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-25 12:55:26.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/47/457547/3/gate/gate-ironic-python-agent-docs-ubuntu-xenial/aba8191//doc/build/html/ : SUCCESS in 3m 31s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/47/457547/3/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/16a7eac/ : SUCCESS in 2m 23s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/47/457547/3/gate/gate-ironic-python-agent-python27-ubuntu-xenial/8518782/ : SUCCESS in 4m 36s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/47/457547/3/gate/gate-ironic-python-agent-python35/3e5ee43/ : SUCCESS in 3m 07s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"32ed01448bbd05fcea210ffd9ceb49ae2b09d4a5","revisions":{"818a9c785090f9a9fb0bdc4aa29c7133986d0eb8":{"kind":"REWORK","_number":1,"created":"2017-04-18 10:04:47.000000000","uploader":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"ref":"refs/changes/47/457547/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/457547/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/1"}}},"commit":{"parents":[{"commit":"92c33a0f477d7b1528beb2e143b326bf30a0f397","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/92c33a0f477d7b1528beb2e143b326bf30a0f397"}]}],"author":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2017-04-18 10:03:13.000000000","tz":120},"committer":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2017-04-18 10:04:45.000000000","tz":120},"subject":"Set valid inspection_dhcp_wait_timeout value in tests","message":"Set valid inspection_dhcp_wait_timeout value in tests\n\ninspection_dhcp_wait_timeout is defined as IntOpt, but its value was\nset in tests to 0.01. This was ok until oslo.config started enforcing\ntypes in [1], after that unit tests fail for test_timeout.\n\n[1] https://review.openstack.org/328692\n\nChange-Id: I732c4aa3d1760c3159d9672e3fae81f8bd72497c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/818a9c785090f9a9fb0bdc4aa29c7133986d0eb8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/818a9c785090f9a9fb0bdc4aa29c7133986d0eb8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"92c33a0f477d7b1528beb2e143b326bf30a0f397","is_merged_in_target_branch":true,"change_id":"Ic29c84030819bf98b9680b51edb5b8840479706c","change_number":455922,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"915aac85def3a4008d0c213785e7f785e4a43a52":{"kind":"REWORK","_number":2,"created":"2017-04-24 15:34:06.000000000","uploader":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"ref":"refs/changes/47/457547/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/457547/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/2"}}},"commit":{"parents":[{"commit":"92c33a0f477d7b1528beb2e143b326bf30a0f397","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/92c33a0f477d7b1528beb2e143b326bf30a0f397"}]}],"author":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2017-04-18 10:03:13.000000000","tz":120},"committer":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2017-04-24 15:34:04.000000000","tz":120},"subject":"Set valid inspection_dhcp_wait_timeout value in tests","message":"Set valid inspection_dhcp_wait_timeout value in tests\n\ninspection_dhcp_wait_timeout is defined as IntOpt, but its value was\nset in tests to 0.01. This was ok until oslo.config started enforcing\ntypes in [1], after that unit tests fail for test_timeout.\n\nFixing by setting the value to 1, and mocking time-related functions\nto avoid a longer wait.\n\n[1] https://review.openstack.org/328692\n\nChange-Id: I732c4aa3d1760c3159d9672e3fae81f8bd72497c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/915aac85def3a4008d0c213785e7f785e4a43a52"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/915aac85def3a4008d0c213785e7f785e4a43a52"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"92c33a0f477d7b1528beb2e143b326bf30a0f397","is_merged_in_target_branch":true,"change_id":"Ic29c84030819bf98b9680b51edb5b8840479706c","change_number":455922,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"32ed01448bbd05fcea210ffd9ceb49ae2b09d4a5":{"kind":"REWORK","_number":3,"created":"2017-04-25 10:12:58.000000000","uploader":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"ref":"refs/changes/47/457547/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/47/457547/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/47/457547/3"}}},"commit":{"parents":[{"commit":"92c33a0f477d7b1528beb2e143b326bf30a0f397","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/92c33a0f477d7b1528beb2e143b326bf30a0f397"}]}],"author":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2017-04-18 10:03:13.000000000","tz":120},"committer":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2017-04-25 10:12:49.000000000","tz":120},"subject":"Set valid inspection_dhcp_wait_timeout value in tests","message":"Set valid inspection_dhcp_wait_timeout value in tests\n\ninspection_dhcp_wait_timeout is defined as IntOpt, but its value was\nset in tests to 0.01. This was ok until oslo.config started enforcing\ntypes in [1], after that unit tests fail for test_timeout.\n\nFixing by setting the value to 1, and mocking time-related functions\nto avoid a longer wait.\n\n[1] https://review.openstack.org/328692\n\nChange-Id: I732c4aa3d1760c3159d9672e3fae81f8bd72497c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/32ed01448bbd05fcea210ffd9ceb49ae2b09d4a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/32ed01448bbd05fcea210ffd9ceb49ae2b09d4a5"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"92c33a0f477d7b1528beb2e143b326bf30a0f397","is_merged_in_target_branch":true,"change_id":"Ic29c84030819bf98b9680b51edb5b8840479706c","change_number":455922,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}