)]}'
{"id":"openstack%2Fironic-python-agent~466100","triplet_id":"openstack%2Fironic-python-agent~master~If4720ebed00f15c2a19cb8badbe4dc3c808eeece","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"If4720ebed00f15c2a19cb8badbe4dc3c808eeece","subject":"Improve the catching of calls to \u0027execute\u0027 related functions","status":"MERGED","created":"2017-05-18 20:35:34.000000000","updated":"2017-10-24 08:47:59.000000000","submitted":"2017-10-24 08:47:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"466100-1508834879201-12d18436","meta_rev_id":"ba618414500bc80542913cd2a2f3a31cabf92d5b","_number":466100,"virtual_id_number":466100,"owner":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2017-10-24 08:47:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":2,"date":"2017-10-23 21:55:09.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-10-24 08:37:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2017-10-24 08:37:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-18 20:41:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-10-23 21:55:09.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2017-10-24 08:37:03.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-10-24 08:47:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d32dc5408e00790d9dd2d3b5d1ab932f91891fd5","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-05-18 20:35:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"655adfe939ffdc9cfcb952085d75cbcb8877135e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-18 20:41:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/00/466100/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/fad0139//doc/build/html/ : SUCCESS in 3m 53s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/00/466100/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/3d31b78/ : FAILURE in 2m 23s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/00/466100/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/7b7ae77/ : SUCCESS in 2m 47s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/00/466100/1/check/gate-ironic-python-agent-python35/ad0e0ee/ : SUCCESS in 4m 24s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/00/466100/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/372a728/ : SUCCESS in 2m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"25ecdf0209bcbfd6d03249cc205a096bc4af1e9e","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-18 18:30:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5391127746887e980238f5aa72aaf819db13bb0e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-18 20:49:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- openstack-tox-pep8 http://logs.openstack.org/00/466100/2/check/openstack-tox-pep8/c339f41/ : SUCCESS in 3m 18s\n- openstack-tox-py27 http://logs.openstack.org/00/466100/2/check/openstack-tox-py27/682f948/ : SUCCESS in 3m 02s\n- openstack-tox-py35 http://logs.openstack.org/00/466100/2/check/openstack-tox-py35/6c901b0/ : SUCCESS in 4m 15s\n- build-openstack-sphinx-docs http://logs.openstack.org/00/466100/2/check/build-openstack-sphinx-docs/7cc36e1/html/ : SUCCESS in 4m 04s\n- legacy-ironic-python-agent-tox-func http://logs.openstack.org/00/466100/2/check/legacy-ironic-python-agent-tox-func/d271b74/ : SUCCESS in 4m 26s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"efb191824ec06834c3401d32c4ca572d7da77329","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-10-20 14:27:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1ae761f67a03ce2e5c1b997a0add0bde7011988a","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-10-23 13:48:26.000000000","message":"Patch Set 2: Code-Review-1\n\n(4 comments)\n\nThanks John, comments inline.","accounts_in_message":[],"_revision_number":2},{"id":"c7e304a263b7028264bcc9728a62b43ebaebc409","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-23 15:41:11.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"caf760d557581e84b5607b886955d044f2a43ff9","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-23 15:41:23.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"29b2cdd2859054bcc0f78e067553c69ebab9cb2b","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-23 15:44:35.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"bf6fc8cf1dd523d8db07613d22ceba2e2fac9b1c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-23 16:17:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- openstack-tox-pep8 http://logs.openstack.org/00/466100/4/check/openstack-tox-pep8/97b63fa/ : SUCCESS in 3m 08s\n- openstack-tox-py27 http://logs.openstack.org/00/466100/4/check/openstack-tox-py27/cce19c3/ : SUCCESS in 3m 00s\n- openstack-tox-py35 http://logs.openstack.org/00/466100/4/check/openstack-tox-py35/5f7322e/ : SUCCESS in 3m 17s\n- build-openstack-sphinx-docs http://logs.openstack.org/00/466100/4/check/build-openstack-sphinx-docs/128adf6/html/ : SUCCESS in 4m 28s\n- legacy-ironic-python-agent-tox-func http://logs.openstack.org/00/466100/4/check/legacy-ironic-python-agent-tox-func/2be2bdb/ : SUCCESS in 4m 28s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"c0199481e669417a196f2aa42a023463b6ea9f68","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-10-23 21:55:09.000000000","message":"Patch Set 4: Code-Review+2\n\nThanks!","accounts_in_message":[],"_revision_number":4},{"id":"81f7c5e6712b1a34df82fb044049c5fa08070647","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-10-24 08:37:03.000000000","message":"Patch Set 4: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"b9e96ee8cc45c651bcbf8e39b53fb515e93de8bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-24 08:37:14.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"a96e93a295b7920b62e3c7f894ee7edaeb5c36d5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-24 08:47:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"ba618414500bc80542913cd2a2f3a31cabf92d5b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-24 08:47:59.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/00/466100/4/gate/openstack-tox-pep8/5192160/ : SUCCESS in 3m 04s\n- openstack-tox-py27 http://logs.openstack.org/00/466100/4/gate/openstack-tox-py27/bcd1a4e/ : SUCCESS in 3m 39s\n- openstack-tox-py35 http://logs.openstack.org/00/466100/4/gate/openstack-tox-py35/a247dab/ : SUCCESS in 4m 46s\n- build-openstack-sphinx-docs http://logs.openstack.org/00/466100/4/gate/build-openstack-sphinx-docs/bfd4bda/html/ : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"ef838dd6bbb8d3c830a69ff2bf6a21b90b9adfaf","revisions":{"e8a480b67a5256e44654c9a9a54bc7d675f7fbcd":{"kind":"REWORK","_number":1,"created":"2017-05-18 20:35:34.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/00/466100/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/00/466100/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/1"}}},"commit":{"parents":[{"commit":"15878b7b181098db7abb6601ada0e245b6722d46","subject":"Merge \"Remove unused function _configdrive_location\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/15878b7b181098db7abb6601ada0e245b6722d46"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-05-17 18:00:38.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-05-18 20:36:09.000000000","tz":-420},"subject":"WIP: Some utils.execute() stuff","message":"WIP: Some utils.execute() stuff\n\nChange-Id: If4720ebed00f15c2a19cb8badbe4dc3c808eeece\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e8a480b67a5256e44654c9a9a54bc7d675f7fbcd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e8a480b67a5256e44654c9a9a54bc7d675f7fbcd"}]},"branch":"refs/heads/master"},"4027f2ea692420b3d15b89380050ae55aeec9642":{"kind":"REWORK","_number":2,"created":"2017-10-18 18:30:34.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/00/466100/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/00/466100/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/2"}}},"commit":{"parents":[{"commit":"265a072b7297b1516eb0db7f9eb821518b68a725","subject":"Have unit tests all derive from our base unit test class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/265a072b7297b1516eb0db7f9eb821518b68a725"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-05-17 18:00:38.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-18 18:28:14.000000000","tz":-420},"subject":"Improve the catching of calls to \u0027execute\u0027 related functions","message":"Improve the catching of calls to \u0027execute\u0027 related functions\n\nImprove the catching of calls to \u0027execute\u0027 related functions in unit\ntests. Before we only caught calls to utils.execute(). Now we catch\ncalls to:\n\n    processutils.execute()\n    subprocess.call()\n    subprocess.check_call()\n    subprocess.check_output()\n    utils.execute()\n\nChange-Id: If4720ebed00f15c2a19cb8badbe4dc3c808eeece\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4027f2ea692420b3d15b89380050ae55aeec9642"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4027f2ea692420b3d15b89380050ae55aeec9642"}]},"branch":"refs/heads/master"},"330c9c9e000c82e76368f2e6b4c1f4b0fe8c4fd3":{"kind":"REWORK","_number":3,"created":"2017-10-23 15:41:11.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/00/466100/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/00/466100/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/3"}}},"commit":{"parents":[{"commit":"265a072b7297b1516eb0db7f9eb821518b68a725","subject":"Have unit tests all derive from our base unit test class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/265a072b7297b1516eb0db7f9eb821518b68a725"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-05-17 18:00:38.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-23 15:29:53.000000000","tz":-420},"subject":"Improve the catching of calls to \u0027execute\u0027 related functions","message":"Improve the catching of calls to \u0027execute\u0027 related functions\n\nImprove the catching of calls to \u0027execute\u0027 related functions in unit\ntests. Before we only caught calls to utils.execute(). Now we catch\ncalls to:\n\n    ironic_lib.utils.execute()\n    processutils.execute()\n    subprocess.call()\n    subprocess.check_call()\n    subprocess.check_output()\n    utils.execute()\n\nChange-Id: If4720ebed00f15c2a19cb8badbe4dc3c808eeece\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/330c9c9e000c82e76368f2e6b4c1f4b0fe8c4fd3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/330c9c9e000c82e76368f2e6b4c1f4b0fe8c4fd3"}]},"branch":"refs/heads/master"},"ef838dd6bbb8d3c830a69ff2bf6a21b90b9adfaf":{"kind":"REWORK","_number":4,"created":"2017-10-23 15:44:35.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/00/466100/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/00/466100/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/00/466100/4"}}},"commit":{"parents":[{"commit":"265a072b7297b1516eb0db7f9eb821518b68a725","subject":"Have unit tests all derive from our base unit test class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/265a072b7297b1516eb0db7f9eb821518b68a725"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-05-17 18:00:38.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-23 15:44:23.000000000","tz":-420},"subject":"Improve the catching of calls to \u0027execute\u0027 related functions","message":"Improve the catching of calls to \u0027execute\u0027 related functions\n\nImprove the catching of calls to \u0027execute\u0027 related functions in unit\ntests. Before we only caught calls to utils.execute(). Now we catch\ncalls to:\n\n    ironic_lib.utils.execute()\n    processutils.execute()\n    subprocess.call()\n    subprocess.check_call()\n    subprocess.check_output()\n    utils.execute()\n\nChange-Id: If4720ebed00f15c2a19cb8badbe4dc3c808eeece\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ef838dd6bbb8d3c830a69ff2bf6a21b90b9adfaf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ef838dd6bbb8d3c830a69ff2bf6a21b90b9adfaf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}