)]}'
{"imagebuild/tinyipa/build-tinyipa.sh":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"669d80c6e2f518cac5ce956c78c4515bd0da1507","unresolved":false,"context_lines":[{"line_number":90,"context_line":"sudo mount --bind /proc $BUILDDIR/proc"},{"line_number":91,"context_line":"sudo mount --bind /dev/pts $BUILDDIR/dev/pts"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"if [ -d /opt/stack/new ]; then"},{"line_number":94,"context_line":"    # Running in CI environment, make checkouts available"},{"line_number":95,"context_line":"    $CHROOT_CMD mkdir -p /opt/stack/new"},{"line_number":96,"context_line":"    for project in $(ls /opt/stack/new); do"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_84ff6c33","line":93,"updated":"2017-06-07 14:27:07.000000000","message":"I\u0027m not crazy about this hardcoded path. What do you think about generalizing it by using an environ variable? Could the CI set that environ variable beforehand?","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f16b416482a9acf540261cb59d05bc8985236b03","unresolved":false,"context_lines":[{"line_number":90,"context_line":"sudo mount --bind /proc $BUILDDIR/proc"},{"line_number":91,"context_line":"sudo mount --bind /dev/pts $BUILDDIR/dev/pts"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"if [ -d /opt/stack/new ]; then"},{"line_number":94,"context_line":"    # Running in CI environment, make checkouts available"},{"line_number":95,"context_line":"    $CHROOT_CMD mkdir -p /opt/stack/new"},{"line_number":96,"context_line":"    for project in $(ls /opt/stack/new); do"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_6f767141","line":93,"in_reply_to":"df140735_0450fc31","updated":"2017-06-07 14:42:01.000000000","message":"ouch, that isn\u0027t good, there should be a way to set the environ variables before the script is run.","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff958b38e5f14f476fb246684a1a7b5210bd8cfe","unresolved":false,"context_lines":[{"line_number":90,"context_line":"sudo mount --bind /proc $BUILDDIR/proc"},{"line_number":91,"context_line":"sudo mount --bind /dev/pts $BUILDDIR/dev/pts"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"if [ -d /opt/stack/new ]; then"},{"line_number":94,"context_line":"    # Running in CI environment, make checkouts available"},{"line_number":95,"context_line":"    $CHROOT_CMD mkdir -p /opt/stack/new"},{"line_number":96,"context_line":"    for project in $(ls /opt/stack/new); do"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_0450fc31","line":93,"in_reply_to":"df140735_84ff6c33","updated":"2017-06-07 14:29:55.000000000","message":"I haven\u0027t found such variable, to be honest.","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"669d80c6e2f518cac5ce956c78c4515bd0da1507","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # Running in CI environment, make checkouts available"},{"line_number":95,"context_line":"    $CHROOT_CMD mkdir -p /opt/stack/new"},{"line_number":96,"context_line":"    for project in $(ls /opt/stack/new); do"},{"line_number":97,"context_line":"        if grep -q \"$project\" $BUILDDIR/tmp/upper-constraints.txt \u0026\u0026"},{"line_number":98,"context_line":"            [ -d \"/opt/stack/new/$project/.git\" ]; then"},{"line_number":99,"context_line":"            sudo cp -R \"/opt/stack/new/$project\" $BUILDDIR/opt/stack/new/"},{"line_number":100,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_24dc2017","line":97,"updated":"2017-06-07 14:27:07.000000000","message":"this is probably a dumb question and maybe it doesn\u0027t even matter. what if $project is not in upper-constraints.txt (as a project), but is a substring of another project which is in upper-constraints.txt?","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff958b38e5f14f476fb246684a1a7b5210bd8cfe","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # Running in CI environment, make checkouts available"},{"line_number":95,"context_line":"    $CHROOT_CMD mkdir -p /opt/stack/new"},{"line_number":96,"context_line":"    for project in $(ls /opt/stack/new); do"},{"line_number":97,"context_line":"        if grep -q \"$project\" $BUILDDIR/tmp/upper-constraints.txt \u0026\u0026"},{"line_number":98,"context_line":"            [ -d \"/opt/stack/new/$project/.git\" ]; then"},{"line_number":99,"context_line":"            sudo cp -R \"/opt/stack/new/$project\" $BUILDDIR/opt/stack/new/"},{"line_number":100,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_a42390be","line":97,"in_reply_to":"df140735_24dc2017","updated":"2017-06-07 14:29:55.000000000","message":"this is possible. I haven\u0027t put a lot of thoughts in it, to be honest, as in the worst case we just copy (and delete later) a directory we don\u0027t need.","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f16b416482a9acf540261cb59d05bc8985236b03","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # Running in CI environment, make checkouts available"},{"line_number":95,"context_line":"    $CHROOT_CMD mkdir -p /opt/stack/new"},{"line_number":96,"context_line":"    for project in $(ls /opt/stack/new); do"},{"line_number":97,"context_line":"        if grep -q \"$project\" $BUILDDIR/tmp/upper-constraints.txt \u0026\u0026"},{"line_number":98,"context_line":"            [ -d \"/opt/stack/new/$project/.git\" ]; then"},{"line_number":99,"context_line":"            sudo cp -R \"/opt/stack/new/$project\" $BUILDDIR/opt/stack/new/"},{"line_number":100,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_afa12998","line":97,"in_reply_to":"df140735_a42390be","updated":"2017-06-07 14:42:01.000000000","message":"Right wrt worst case -- worth adding a note about it then, that we\u0027re aware of that possibility.","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"}],"imagebuild/tinyipa/finalise-tinyipa.sh":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"669d80c6e2f518cac5ce956c78c4515bd0da1507","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"# If flag is set install the python now"},{"line_number":145,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":146,"context_line":"    $CHROOT_CMD python /tmp/get-pip.py --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse --pre ironic_python_agent"},{"line_number":147,"context_line":"    rm -rf $FINALDIR/tmp/wheelhouse"},{"line_number":148,"context_line":"    rm -rf $FINALDIR/tmp/get-pip.py"},{"line_number":149,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_29199987","line":146,"updated":"2017-06-07 14:27:07.000000000","message":"wondering if it might be useful to add a note here that we don\u0027t want to use upper constraints (to avoid someone in the future thinking we forgot to do that...)","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ff958b38e5f14f476fb246684a1a7b5210bd8cfe","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"# If flag is set install the python now"},{"line_number":145,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":146,"context_line":"    $CHROOT_CMD python /tmp/get-pip.py --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse --pre ironic_python_agent"},{"line_number":147,"context_line":"    rm -rf $FINALDIR/tmp/wheelhouse"},{"line_number":148,"context_line":"    rm -rf $FINALDIR/tmp/get-pip.py"},{"line_number":149,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_e412a862","line":146,"in_reply_to":"df140735_29199987","updated":"2017-06-07 14:29:55.000000000","message":"maybe? all this code could use some commenting, to be honest. it took me time to figure out.","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f16b416482a9acf540261cb59d05bc8985236b03","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"# If flag is set install the python now"},{"line_number":145,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":146,"context_line":"    $CHROOT_CMD python /tmp/get-pip.py --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse --pre ironic_python_agent"},{"line_number":147,"context_line":"    rm -rf $FINALDIR/tmp/wheelhouse"},{"line_number":148,"context_line":"    rm -rf $FINALDIR/tmp/get-pip.py"},{"line_number":149,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":14,"id":"df140735_2fdcf916","line":146,"in_reply_to":"df140735_e412a862","updated":"2017-06-07 14:42:01.000000000","message":"If you have time, then, it\u0027d be great to add more comments wherever it could have been useful for you.","commit_id":"381f5073b5d7b15ac848cdbc8dfbb252ff417aba"}]}