)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bf4c33f4c87e5a4d0038f1fa8996c2b5ca94e11b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The patch updates ``buildreqs.lst`` and ``finalreqs.lst`` to"},{"line_number":10,"context_line":"include python3.tcz and python3-dev.tcz. Patch also updates"},{"line_number":11,"context_line":"build scripts to switch to python3."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib4c42985a19205528a0a84224d5532d329fc8ddb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7f515b1d_096789eb","line":12,"updated":"2017-10-09 16:08:18.000000000","message":"Do we have a bug-id to track this?","commit_id":"0856cb8dd2cd6c03435ad9d097ae7b8c26162172"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c411ca33a0bb03429a74f64a22c1ada1f3e938d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anup Navare \u003canup.d.navare@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-25 18:38:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Build tinyipa with python3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch updates ``buildreqs.lst`` and ``finalreqs.lst`` to"},{"line_number":10,"context_line":"include python3.tcz and python3-dev.tcz. Patch also updates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"3f4b6375_2bcd7d30","line":7,"updated":"2017-10-25 19:16:06.000000000","message":"Add: DNM/WIP:\n\nTo the subject line. So people don\u0027t bother to review this until ready.\n\n DNM/WIP: Build tinyipa with Python 3","commit_id":"29a250a490203c26874fc97761878afe39f52ff6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"6454ff581b6e73b47ead88aace64c889a48e8fe7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anup Navare \u003canup.d.navare@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-25 21:14:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Build tinyipa with python3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch updates ``buildreqs.lst`` and ``finalreqs.lst`` to"},{"line_number":10,"context_line":"include python3.tcz and python3-dev.tcz. Patch also updates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3f4b6375_172adb2a","line":7,"updated":"2017-10-26 00:14:44.000000000","message":"I would change this to:\n\n DNM/WIP: Build tinyipa with Python 3\n\nUntil you are ready for reviews.","commit_id":"481589600b04fd9e7da28e8954fd030aec31a479"}],"imagebuild/tinyipa/build-tinyipa.sh":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"55a82d70afed76c9c07db92a67e1742aaa259aca","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    python3 setup.py sdist --dist-dir \"$BUILDDIR/tmp/localpip\" --quiet"},{"line_number":81,"context_line":"else"},{"line_number":82,"context_line":"    python setup.py sdist --dist-dir \"$BUILDDIR/tmp/localpip\" --quiet"},{"line_number":83,"context_line":"    $CHROOT_CMD python /tmp/get-pip.py"},{"line_number":84,"context_line":"fi"},{"line_number":85,"context_line":"cp requirements.txt $BUILDDIR/tmp/ipa-requirements.txt"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"7f515b1d_23443d1b","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":38},"updated":"2017-10-03 20:38:50.000000000","message":"Remove this, done down before building python wheels. Gate failing due to this","commit_id":"67d49c71847e15d91bd667ed3b4b6997194057bd"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"43247a700d91ebcd38d52631a73bc0e3a7fc133b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"if [[ $USE_PYTHON3 \u003d\u003d \"True\" ]]; then"},{"line_number":82,"context_line":"    TINYIPA_PYTHON_EXE\u003dpython3"},{"line_number":83,"context_line":"fi"},{"line_number":84,"context_line":"$(TINYIPA_PYTHON_EXE) setup.py sdist --dist-dir \"$BUILDDIR/tmp/localpip\" --quiet"},{"line_number":85,"context_line":"cp requirements.txt $BUILDDIR/tmp/ipa-requirements.txt"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"imagebuild/common/generate_upper_constraints.sh upper-constraints.txt"}],"source_content_type":"text/x-sh","patch_set":13,"id":"7f515b1d_c5e8ad7d","line":84,"updated":"2017-10-04 20:51:08.000000000","message":"This does not look like it will work to me.","commit_id":"ecb417aa3732b67ff13969b8145a4856dbc19db0"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"3257d18fab5efd5b0a2fbca712af060b67c0576e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"if [[ $USE_PYTHON3 \u003d\u003d \"True\" ]]; then"},{"line_number":82,"context_line":"    TINYIPA_PYTHON_EXE\u003dpython3"},{"line_number":83,"context_line":"fi"},{"line_number":84,"context_line":"$(TINYIPA_PYTHON_EXE) setup.py sdist --dist-dir \"$BUILDDIR/tmp/localpip\" --quiet"},{"line_number":85,"context_line":"cp requirements.txt $BUILDDIR/tmp/ipa-requirements.txt"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"imagebuild/common/generate_upper_constraints.sh upper-constraints.txt"}],"source_content_type":"text/x-sh","patch_set":13,"id":"7f515b1d_dddf1a0a","line":84,"in_reply_to":"7f515b1d_c5e8ad7d","updated":"2017-10-07 00:06:37.000000000","message":"Yes fixed it. Wrong braces.","commit_id":"ecb417aa3732b67ff13969b8145a4856dbc19db0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"43247a700d91ebcd38d52631a73bc0e3a7fc133b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"done \u003c $WORKDIR/build_files/buildreqs.lst"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# Build python wheels"},{"line_number":123,"context_line":"$CHROOT_CMD $(TINYIPA_PYTHON_EXE) /tmp/get-pip.py"},{"line_number":124,"context_line":"$CHROOT_CMD pip install pbr"},{"line_number":125,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels setuptools"},{"line_number":126,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels pip"}],"source_content_type":"text/x-sh","patch_set":13,"id":"7f515b1d_059485e7","line":123,"updated":"2017-10-04 20:51:08.000000000","message":"This does not look like it will work to me.","commit_id":"ecb417aa3732b67ff13969b8145a4856dbc19db0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e0c98eaf2780371cbfdee56526d1029353206f46","unresolved":false,"context_lines":[{"line_number":85,"context_line":"${TINYIPA_PYTHON_EXE} --version"},{"line_number":86,"context_line":"pwd"},{"line_number":87,"context_line":"${TINYIPA_PYTHON_EXE} setup.py sdist --dist-dir \"$BUILDDIR/tmp/localpip\" --quiet"},{"line_number":88,"context_line":"ls $BUILDIR/tmp/localpip"},{"line_number":89,"context_line":"cp requirements.txt $BUILDDIR/tmp/ipa-requirements.txt"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"imagebuild/common/generate_upper_constraints.sh upper-constraints.txt"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3f4b6375_56661c2c","line":88,"updated":"2017-10-25 19:58:19.000000000","message":"BUILDDIR is mis-spelled. Should have two \u0027D\u0027s\n\nAlso for things that might fail you might want to do:\n\n command_that_might_fail || true\n\nSo the build won\u0027t terminate","commit_id":"29a250a490203c26874fc97761878afe39f52ff6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c411ca33a0bb03429a74f64a22c1ada1f3e938d6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"$CHROOT_CMD pip --version"},{"line_number":131,"context_line":"echo \"Anup! chroot pip3 version\""},{"line_number":132,"context_line":"$CHROOT_CMD pip3 --version"},{"line_number":133,"context_line":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} /tmp/get-pip.py"},{"line_number":134,"context_line":"$CHROOT_CMD pip install pbr"},{"line_number":135,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels setuptools"},{"line_number":136,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels pip"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3f4b6375_ab53ad6a","line":133,"updated":"2017-10-25 19:16:06.000000000","message":"Should put this before the debug on the pip versions.","commit_id":"29a250a490203c26874fc97761878afe39f52ff6"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"c68a5770027023574fc8c88af6a3a5099ecdf5ae","unresolved":false,"context_lines":[{"line_number":130,"context_line":"$CHROOT_CMD pip --version"},{"line_number":131,"context_line":"echo \"Anup! chroot pip3 version\""},{"line_number":132,"context_line":"$CHROOT_CMD pip3 --version"},{"line_number":133,"context_line":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} /tmp/get-pip.py"},{"line_number":134,"context_line":"$CHROOT_CMD pip install pbr"},{"line_number":135,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels setuptools"},{"line_number":136,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels pip"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3f4b6375_ebb9a578","line":133,"in_reply_to":"3f4b6375_ab53ad6a","updated":"2017-10-25 19:21:14.000000000","message":"Yes, i will do that in next one. Right now in this build pip3 version can tell if there is any other pip3 already installed before we get from get-pip.py.","commit_id":"29a250a490203c26874fc97761878afe39f52ff6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1adab1ee20f209e7a4777c5934aaca0095406d92","unresolved":false,"context_lines":[{"line_number":130,"context_line":"$CHROOT_CMD pip --version"},{"line_number":131,"context_line":"echo \"Anup! chroot pip3 version\""},{"line_number":132,"context_line":"$CHROOT_CMD pip3 --version"},{"line_number":133,"context_line":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} /tmp/get-pip.py"},{"line_number":134,"context_line":"$CHROOT_CMD pip install pbr"},{"line_number":135,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels setuptools"},{"line_number":136,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels pip"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3f4b6375_363de08e","line":133,"in_reply_to":"3f4b6375_ebb9a578","updated":"2017-10-25 19:35:30.000000000","message":"Okay. My theory is that there is no pip, as I think that Python 3.4 is when pip was first bundled with Python 3","commit_id":"29a250a490203c26874fc97761878afe39f52ff6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9843283e94c72a7e4ccae2f10c07b9d3fefb9efc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"done \u003c $WORKDIR/build_files/buildreqs.lst"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Build python wheels"},{"line_number":127,"context_line":"echo \"Anup! chroot Python3 version\""},{"line_number":128,"context_line":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} --version || true"},{"line_number":129,"context_line":"echo \"Anup! chroot pip version\""},{"line_number":130,"context_line":"$CHROOT_CMD pip --version || true"},{"line_number":131,"context_line":"echo \"Anup! chroot pip3 version\""}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f4b6375_d9159c41","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":51},"updated":"2017-10-25 22:11:30.000000000","message":"Seems like we just don\u0027t need this.","commit_id":"481589600b04fd9e7da28e8954fd030aec31a479"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9843283e94c72a7e4ccae2f10c07b9d3fefb9efc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"# Build python wheels"},{"line_number":127,"context_line":"echo \"Anup! chroot Python3 version\""},{"line_number":128,"context_line":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} --version || true"},{"line_number":129,"context_line":"echo \"Anup! chroot pip version\""},{"line_number":130,"context_line":"$CHROOT_CMD pip --version || true"},{"line_number":131,"context_line":"echo \"Anup! chroot pip3 version\""},{"line_number":132,"context_line":"$CHROOT_CMD pip3 --version || true"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} /tmp/get-pip.py"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f4b6375_5902cc0b","line":132,"range":{"start_line":129,"start_character":0,"end_line":132,"end_character":34},"updated":"2017-10-25 22:11:30.000000000","message":"This seems like debugging? Seems like we don\u0027t need this.","commit_id":"481589600b04fd9e7da28e8954fd030aec31a479"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9843283e94c72a7e4ccae2f10c07b9d3fefb9efc","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} /tmp/get-pip.py"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"echo \"Anup! chroot pip version\""},{"line_number":137,"context_line":"$CHROOT_CMD pip --version || true"},{"line_number":138,"context_line":"echo \"Anup! chroot pip3 version\""},{"line_number":139,"context_line":"$CHROOT_CMD pip3 --version || true"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"$CHROOT_CMD pip install pbr"},{"line_number":142,"context_line":"$CHROOT_CMD pip wheel -c /tmp/upper-constraints.txt --wheel-dir /tmp/wheels setuptools"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3f4b6375_3905d011","line":139,"range":{"start_line":136,"start_character":0,"end_line":139,"end_character":34},"updated":"2017-10-25 22:11:30.000000000","message":"Same as above.","commit_id":"481589600b04fd9e7da28e8954fd030aec31a479"}],"imagebuild/tinyipa/finalise-tinyipa.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a9bfdf25e82c9450f3fe8fca4985f1196ad09fd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"PYOPTIMIZE_TINYIPA\u003d${PYOPTIMIZE_TINYIPA:-true}"},{"line_number":13,"context_line":"TINYIPA_REQUIRE_BIOSDEVNAME\u003d${TINYIPA_REQUIRE_BIOSDEVNAME:-false}"},{"line_number":14,"context_line":"TINYIPA_REQUIRE_IPMITOOL\u003d${TINYIPA_REQUIRE_IPMITOOL:-true}"},{"line_number":15,"context_line":"BUILD_TINYIPA_WITH_PYTHON3\u003d${BUILD_TINYIPA_WITH_PYTHON3:-false}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"TC\u003d1001"},{"line_number":18,"context_line":"STAFF\u003d50"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_908fd228","line":15,"updated":"2017-10-02 18:02:49.000000000","message":"These is a devstack variable \"USE_PYTHON3\", why don\u0027t we use that?","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a9bfdf25e82c9450f3fe8fca4985f1196ad09fd","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Ensure tinyipa picks up installed kernel modules"},{"line_number":143,"context_line":"$CHROOT_CMD depmod -a `$WORKDIR/build_files/fakeuname -r`"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# If flag is set install the python now"},{"line_number":146,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":147,"context_line":"    if $BUILD_TINYIPA_WITH_PYTHON3; then"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_5085da05","line":144,"updated":"2017-10-02 18:02:49.000000000","message":"What if we did this?\n\n TINYIPA_PYTHON_EXE\u003dpython\n if [[ $USE_PYTHON3 \u003d\u003d \"True\" ]]; then\n    TINYIPA_PYTHON_EXE\u003dpython3\n fi\n\nSee below for other idea","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"71c088a9ba363ce16103cb741f15cbc188e575a4","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Ensure tinyipa picks up installed kernel modules"},{"line_number":143,"context_line":"$CHROOT_CMD depmod -a `$WORKDIR/build_files/fakeuname -r`"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# If flag is set install the python now"},{"line_number":146,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":147,"context_line":"    if $BUILD_TINYIPA_WITH_PYTHON3; then"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_058ec526","line":144,"in_reply_to":"7f515b1d_5085da05","updated":"2017-10-04 20:59:45.000000000","message":"I can do this, but only thing is the new variable $TINYIPA_PYTHON_EXE would be useful at this one place only. Down at L191 i have to use if else block as when it is building with python3 I have to compile with python3.3 or else with python2.7. Hence these values are not what TINYIPA_PYTHON_EXE will hold. Let me know your thoughts. I am updating right now with your suggestion","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a9bfdf25e82c9450f3fe8fca4985f1196ad09fd","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# If flag is set install the python now"},{"line_number":146,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":147,"context_line":"    if $BUILD_TINYIPA_WITH_PYTHON3; then"},{"line_number":148,"context_line":"        $CHROOT_CMD python3 /tmp/get-pip.py --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse --pre ironic_python_agent"},{"line_number":149,"context_line":"    else"},{"line_number":150,"context_line":"        $CHROOT_CMD python /tmp/get-pip.py --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse --pre ironic_python_agent"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_107be227","line":147,"updated":"2017-10-02 18:02:49.000000000","message":"$CHROOT_CMD ${TINYIPA_PYTHON_EXE} /tmp/get-pip.py --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse --pre ironic_python_agent","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a9bfdf25e82c9450f3fe8fca4985f1196ad09fd","unresolved":false,"context_lines":[{"line_number":154,"context_line":"fi"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"if $BUILD_TINYIPA_WITH_PYTHON3; then"},{"line_number":157,"context_line":"    ls -l ${FINALDIR}/sbin/ldconfig"},{"line_number":158,"context_line":"    file ${FINALDIR}/sbin/ldconfig"},{"line_number":159,"context_line":"    if $(file ${FINALDIR}/sbin/ldconfig | grep -q ASCII); then"},{"line_number":160,"context_line":"    # Work around for tinycore 7.x /sbin/ldconfig file which is a shell script"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_700d76e6","line":157,"updated":"2017-10-02 18:02:49.000000000","message":"Why this debug code?","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"b56610e950169f5a499d55579b871a276a33c3d7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"fi"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"if $BUILD_TINYIPA_WITH_PYTHON3; then"},{"line_number":157,"context_line":"    ls -l ${FINALDIR}/sbin/ldconfig"},{"line_number":158,"context_line":"    file ${FINALDIR}/sbin/ldconfig"},{"line_number":159,"context_line":"    if $(file ${FINALDIR}/sbin/ldconfig | grep -q ASCII); then"},{"line_number":160,"context_line":"    # Work around for tinycore 7.x /sbin/ldconfig file which is a shell script"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_4a23e1a7","line":157,"in_reply_to":"7f515b1d_700d76e6","updated":"2017-10-03 00:49:36.000000000","message":"Removed","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a9bfdf25e82c9450f3fe8fca4985f1196ad09fd","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"if $BUILD_TINYIPA_WITH_PYTHON3; then"},{"line_number":157,"context_line":"    ls -l ${FINALDIR}/sbin/ldconfig"},{"line_number":158,"context_line":"    file ${FINALDIR}/sbin/ldconfig"},{"line_number":159,"context_line":"    if $(file ${FINALDIR}/sbin/ldconfig | grep -q ASCII); then"},{"line_number":160,"context_line":"    # Work around for tinycore 7.x /sbin/ldconfig file which is a shell script"},{"line_number":161,"context_line":"    # WITHOUT the \"#!/bin/sh\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_50103a00","line":158,"updated":"2017-10-02 18:02:49.000000000","message":"Why this debug code?","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a9bfdf25e82c9450f3fe8fca4985f1196ad09fd","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    # Remove this when switch to tinycore 8.x"},{"line_number":163,"context_line":"        echo \"Adding #!/bin/sh to ${FINALDIR}/sbin/ldconfig\""},{"line_number":164,"context_line":"        ${CHROOT_CMD} sed -i \u00271s+^+#!/bin/sh\\n+\u0027 /sbin/ldconfig"},{"line_number":165,"context_line":"        cat ${FINALDIR}/sbin/ldconfig"},{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":"    ( ${CHROOT_CMD} /sbin/ldconfig -p | grep libbz2 ) || true"},{"line_number":168,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_b0d52e1e","line":165,"updated":"2017-10-02 18:02:49.000000000","message":"Why this debug code?","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a9bfdf25e82c9450f3fe8fca4985f1196ad09fd","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        ${CHROOT_CMD} sed -i \u00271s+^+#!/bin/sh\\n+\u0027 /sbin/ldconfig"},{"line_number":165,"context_line":"        cat ${FINALDIR}/sbin/ldconfig"},{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":"    ( ${CHROOT_CMD} /sbin/ldconfig -p | grep libbz2 ) || true"},{"line_number":168,"context_line":"fi"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# Unmount /proc and clean up everything"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7f515b1d_70db364e","line":167,"updated":"2017-10-02 18:02:49.000000000","message":"Why this debug code?","commit_id":"e3e056a3511824953c767b929ffd0e55aae81cb0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"43247a700d91ebcd38d52631a73bc0e3a7fc133b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"fi"},{"line_number":149,"context_line":"# If flag is set install the python now"},{"line_number":150,"context_line":"if $BUILD_AND_INSTALL_TINYIPA ; then"},{"line_number":151,"context_line":"    $CHROOT_CMD $(TINYIPA_PYTHON_EXE) /tmp/get-pip.py --no-wheel --no-index --find-links\u003dfile:///tmp/wheelhouse --pre ironic_python_agent"},{"line_number":152,"context_line":"    rm -rf $FINALDIR/tmp/wheelhouse"},{"line_number":153,"context_line":"    rm -rf $FINALDIR/tmp/get-pip.py"},{"line_number":154,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"7f515b1d_e598491c","line":151,"updated":"2017-10-04 20:51:08.000000000","message":"This does not look like it will work to me.","commit_id":"ecb417aa3732b67ff13969b8145a4856dbc19db0"}],"releasenotes/notes/add-support-for-py3-01e3fc53a5dd98ec.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"adefdcd06936393a4178d39394ea8f3ed2e66a90","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch adds support for building tinyipa with python3.3. Right now"},{"line_number":5,"context_line":"    tinyipa only support python2.7 and this patch builds with default"},{"line_number":6,"context_line":"    python2.7 giving the option to build with python3.3 by setting"},{"line_number":7,"context_line":"    ``USE_PYTHON3`` to true."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f4b6375_6666072d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":14},"updated":"2017-10-25 22:07:04.000000000","message":"The way renos are generated, there should not be any reference to a patch. The best way to start out the sentence is \"Adds support for\"","commit_id":"481589600b04fd9e7da28e8954fd030aec31a479"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"adefdcd06936393a4178d39394ea8f3ed2e66a90","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch adds support for building tinyipa with python3.3. Right now"},{"line_number":5,"context_line":"    tinyipa only support python2.7 and this patch builds with default"},{"line_number":6,"context_line":"    python2.7 giving the option to build with python3.3 by setting"},{"line_number":7,"context_line":"    ``USE_PYTHON3`` to true."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f4b6375_867a23b7","line":5,"range":{"start_line":4,"start_character":65,"end_line":5,"end_character":34},"updated":"2017-10-25 22:07:04.000000000","message":"Perhaps instead state that \"Prior to this, the built tinyipa image only supported use of python2.7.\"","commit_id":"481589600b04fd9e7da28e8954fd030aec31a479"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"adefdcd06936393a4178d39394ea8f3ed2e66a90","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch adds support for building tinyipa with python3.3. Right now"},{"line_number":5,"context_line":"    tinyipa only support python2.7 and this patch builds with default"},{"line_number":6,"context_line":"    python2.7 giving the option to build with python3.3 by setting"},{"line_number":7,"context_line":"    ``USE_PYTHON3`` to true."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3f4b6375_c65dbb47","line":7,"range":{"start_line":6,"start_character":14,"end_line":7,"end_character":28},"updated":"2017-10-25 22:07:04.000000000","message":"Perhaps as a separate sentence, \"To build a tinyipa image utilizing python3.3, set the ``USE_PYTHON3`` environment variable to ``True``.","commit_id":"481589600b04fd9e7da28e8954fd030aec31a479"}]}