)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"39c8b02fa6345058787b505ed695fab719431617","unresolved":false,"context_lines":[{"line_number":955,"context_line":"                    LOG.warning(\u0027Invalid IP address: %s\u0027, out)"},{"line_number":956,"context_line":"                    continue"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"                # In case we get empty IP or 0.0.0.0 on a valid channel,"},{"line_number":959,"context_line":"                # we need to keep querying"},{"line_number":960,"context_line":"                if out !\u003d \u00270.0.0.0\u0027:"},{"line_number":961,"context_line":"                    return out"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_e0ff2865","line":958,"range":{"start_line":958,"start_character":32,"end_line":958,"end_character":41},"updated":"2017-09-11 15:30:43.000000000","message":"Is the \u0027empty IP\u0027 case handled above by netaddr.IPAddress()?\n\nIf so, should probably update this comment.","commit_id":"84b77d1672ae06428f56b60b91c0d87bfab05190"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cb9eee1520cd91619d32d174d8777681b84f872e","unresolved":false,"context_lines":[{"line_number":947,"context_line":"                    \" {{print $4}}\u0027\".format(channel), shell\u003dTrue)"},{"line_number":948,"context_line":"                if e.startswith(\"Invalid channel\"):"},{"line_number":949,"context_line":"                    continue"},{"line_number":950,"context_line":"                out \u003d out.strip()"},{"line_number":951,"context_line":""},{"line_number":952,"context_line":"                try:"},{"line_number":953,"context_line":"                    netaddr.IPAddress(out)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_82ff3ea9","line":950,"updated":"2017-09-11 23:01:39.000000000","message":"with the output provided here [0] seems it is possible to assign IP to different channels \n\n[0] https://bugs.launchpad.net/ironic-inspector/+bug/1714944/comments/7","commit_id":"d6ff5116f4a5586238d44a196ec89d844b151f9d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a6361d9f785897671ae4267486d13ed02a45d6ef","unresolved":false,"context_lines":[{"line_number":952,"context_line":"                try:"},{"line_number":953,"context_line":"                    netaddr.IPAddress(out)"},{"line_number":954,"context_line":"                except netaddr.AddrFormatError:"},{"line_number":955,"context_line":"                    LOG.warning(\u0027Invalid IP address: %s\u0027, out)"},{"line_number":956,"context_line":"                    continue"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"                # In case we get 0.0.0.0 on a valid channel, we need to keep"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_19b86174","line":955,"updated":"2017-09-12 05:03:46.000000000","message":"An empty IP is now logged as a warning whereas before it was just skipped ?","commit_id":"d6ff5116f4a5586238d44a196ec89d844b151f9d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"664678fe502ea17a55aaf8ec9eaa624aa512f49c","unresolved":false,"context_lines":[{"line_number":952,"context_line":"                try:"},{"line_number":953,"context_line":"                    netaddr.IPAddress(out)"},{"line_number":954,"context_line":"                except netaddr.AddrFormatError:"},{"line_number":955,"context_line":"                    LOG.warning(\u0027Invalid IP address: %s\u0027, out)"},{"line_number":956,"context_line":"                    continue"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"                # In case we get 0.0.0.0 on a valid channel, we need to keep"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_a88fab21","line":955,"in_reply_to":"5f2577a7_19b86174","updated":"2017-09-12 15:31:49.000000000","message":"Yep, I think it\u0027s good actually. I don\u0027t think we expect an empty string here..","commit_id":"d6ff5116f4a5586238d44a196ec89d844b151f9d"}]}