)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3808df1593e8cd4e544ed530c65cec926a34d5ad","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-09-14 07:06:08 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: unhardcode path to grub binaries"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic6a2bafdc87e33c4e1c4534fa355f995c824b945"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_2316fef2","line":8,"updated":"2017-09-14 13:11:30.000000000","message":"Closes-Bug: 1717255","commit_id":"60e77f430bfbd78c703f46cf00a0de6f52014938"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"45f600803fb4d902f4c03f912e136757fa231c49","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-22 17:42:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unhardcode path to grub binaries"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use PATH variable to find grub binaries."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f515b1d_0dbef964","line":7,"updated":"2017-09-22 17:53:18.000000000","message":"nit: If you make a new patch\n\nRemove hard-coded path to grub binaries","commit_id":"e3a7a067ab525e7728c726d57313cd0dfc1e30ab"}],"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5a9a0cc5c55bb4777f55735caa1557cecb6280cc","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # Install grub"},{"line_number":115,"context_line":"        utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"},{"line_number":116,"context_line":"                      \u0027\"%(bin)s-install %(dev)s\"\u0027 %"},{"line_number":117,"context_line":"                      {\u0027path\u0027: path, \u0027bin\u0027: binary_name, \u0027dev\u0027: device},"},{"line_number":118,"context_line":"                      shell\u003dTrue, env_variables\u003d{\u0027PATH\u0027: path_variable})"},{"line_number":119,"context_line":"        # Also run grub-install with --removable, this installs grub to the"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff5d4b2f_40af2794","line":116,"updated":"2017-09-19 13:16:25.000000000","message":"do we need to worry about the case where /usr/sbin is NOT in PATH env variable? Maybe, just to be safe, we should add it to path_variable?","commit_id":"a1d36197266ae268f109a9db9fa71147620866d2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ba65b46624d4a290b55a1b165a89d385972f3449","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # Install grub"},{"line_number":115,"context_line":"        utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"},{"line_number":116,"context_line":"                      \u0027\"%(bin)s-install %(dev)s\"\u0027 %"},{"line_number":117,"context_line":"                      {\u0027path\u0027: path, \u0027bin\u0027: binary_name, \u0027dev\u0027: device},"},{"line_number":118,"context_line":"                      shell\u003dTrue, env_variables\u003d{\u0027PATH\u0027: path_variable})"},{"line_number":119,"context_line":"        # Also run grub-install with --removable, this installs grub to the"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_8ed78d24","line":116,"in_reply_to":"ff5d4b2f_40af2794","updated":"2017-09-20 13:46:36.000000000","message":"If we were not explicitly adding /bin to the path on line 112 and not explicitly calling /usr/sbin, then I would say no, but we are doing both, and I think we should assume that someone is going to possibly hand us a broken path that would have worked before. I think we should just go ahead and explicitly add it.","commit_id":"a1d36197266ae268f109a9db9fa71147620866d2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3c2150c32293e0340aa899b28c8996bd05710e4f","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # Install grub"},{"line_number":115,"context_line":"        utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"},{"line_number":116,"context_line":"                      \u0027\"%(bin)s-install %(dev)s\"\u0027 %"},{"line_number":117,"context_line":"                      {\u0027path\u0027: path, \u0027bin\u0027: binary_name, \u0027dev\u0027: device},"},{"line_number":118,"context_line":"                      shell\u003dTrue, env_variables\u003d{\u0027PATH\u0027: path_variable})"},{"line_number":119,"context_line":"        # Also run grub-install with --removable, this installs grub to the"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f5c4f37_f8c5a65c","line":116,"in_reply_to":"ff5d4b2f_40af2794","updated":"2017-09-21 14:52:01.000000000","message":"good catch Ruby!","commit_id":"a1d36197266ae268f109a9db9fa71147620866d2"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"45f600803fb4d902f4c03f912e136757fa231c49","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        if os.path.exists(os.path.join(path, \u0027usr/sbin/grub2-install\u0027)):"},{"line_number":107,"context_line":"            binary_name \u003d \"grub2\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        # Add /bin to PATH variable as grub requires it to find efibootmgr"},{"line_number":110,"context_line":"        # when running in uefi boot mode."},{"line_number":111,"context_line":"        path_variable \u003d os.environ.get(\u0027PATH\u0027, \u0027\u0027)"},{"line_number":112,"context_line":"        path_variable \u003d \u0027%s:/bin:/usr/sbin\u0027 % path_variable"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_cd458172","line":109,"updated":"2017-09-22 17:53:18.000000000","message":"Can you update this comment too.","commit_id":"e3a7a067ab525e7728c726d57313cd0dfc1e30ab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b5f2e2a79955233a5abb8fcd1155cc5e1a48d4b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Add /bin to PATH variable as grub requires it to find efibootmgr"},{"line_number":110,"context_line":"        # when running in uefi boot mode."},{"line_number":111,"context_line":"        # Add /usr/sbin to PATH variable to ensure it is there as we do"},{"line_number":112,"context_line":"        # not use full path to grub binary anymore."},{"line_number":113,"context_line":"        path_variable \u003d os.environ.get(\u0027PATH\u0027, \u0027\u0027)"},{"line_number":114,"context_line":"        path_variable \u003d \u0027%s:/bin:/usr/sbin\u0027 % path_variable"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_75461652","line":112,"updated":"2017-09-26 08:02:00.000000000","message":"+1, but I agree that these are nits","commit_id":"db5272cfea9fa894675690d54b7d042cb3d01df3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"582458bc6831107f2408ed409b6eb343a95a259e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        # Add /bin to PATH variable as grub requires it to find efibootmgr"},{"line_number":110,"context_line":"        # when running in uefi boot mode."},{"line_number":111,"context_line":"        # Add /usr/sbin to PATH variable to ensure it is there as we do"},{"line_number":112,"context_line":"        # not use full path to grub binary anymore."},{"line_number":113,"context_line":"        path_variable \u003d os.environ.get(\u0027PATH\u0027, \u0027\u0027)"},{"line_number":114,"context_line":"        path_variable \u003d \u0027%s:/bin:/usr/sbin\u0027 % path_variable"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_5787be10","line":112,"updated":"2017-09-25 14:10:33.000000000","message":"nit. maybe s/grub binary anymore/grub binary/\n\nbecause only if people know that we had used the full path before, would the \u0027anymore\u0027 make sense. For someone just reading/looking at the code for the first time, they will be wondering what the \u0027anymore\u0027 meant.\n\nI guess it could also be something like \u0027Add /usr/sbin to PATH variable to ensure it is there, because we assume this is the default location for the grub binary.\u0027 ?\n\n(The above are just nits, me thinking out loud.)","commit_id":"db5272cfea9fa894675690d54b7d042cb3d01df3"}],"releasenotes/notes/fix-hardcoded-path-to-grub-7006f29a9ef72e75.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5a9a0cc5c55bb4777f55735caa1557cecb6280cc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Use PATH variable to check for grub binaries, allows to"},{"line_number":4,"context_line":"    install grub on partitioned image with grub located in"},{"line_number":5,"context_line":"    any of folders from PATH."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff5d4b2f_40eba7af","line":5,"updated":"2017-09-19 13:16:25.000000000","message":"maybe \n\nUses the PATH environment variable to get the grub (or grub2) binary instead of assuming it is in /usr/sbin. This provides flexibilty for grub to be installed in any PATH directory, on a partitioned image.","commit_id":"a1d36197266ae268f109a9db9fa71147620866d2"}]}