)]}'
{"id":"openstack%2Fironic-python-agent~506735","triplet_id":"openstack%2Fironic-python-agent~master~I98aa484dc5414ee49c281dfd40e44b3c613d53e0","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"I98aa484dc5414ee49c281dfd40e44b3c613d53e0","subject":"flake8: Enable some off-by-default checks","status":"MERGED","created":"2017-09-22 17:48:57.000000000","updated":"2017-09-25 15:50:35.000000000","submitted":"2017-09-25 15:50:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"506735-1506354635518-ca8e402b","meta_rev_id":"4a8b43f969ef60adcfdb418a8693ec08cb74b505","_number":506735,"virtual_id_number":506735,"owner":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-09-25 15:50:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-09-25 14:27:55.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2017-09-25 14:43:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":1,"date":"2017-09-25 14:43:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-25 14:27:55.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2017-09-25 14:43:27.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-09-25 15:50:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d614b3cff85e0f36a2872de65c5da5fece826d2b","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-09-22 17:48:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a37510de14d3bdcbfdd853b109f9ecc7fe66b46d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-22 19:40:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/35/506735/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/fa6d6e6//doc/build/html/ : SUCCESS in 3m 49s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/a763bba/ : SUCCESS in 4m 04s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/d8ac9d0/ : SUCCESS in 4m 19s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/35/506735/1/check/gate-ironic-python-agent-python35/233c645/ : SUCCESS in 3m 35s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/35/506735/1/check/gate-ironic-python-agent-requirements/4410415/ : SUCCESS in 2m 54s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/35/506735/1/check/gate-ironic-python-agent-releasenotes/6126c92//releasenotes/build/html/ : SUCCESS in 3m 27s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/22d7df7/ : SUCCESS in 3m 51s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-coreos-src-ubuntu-xenial/403d0af/ : SUCCESS in 51m 28s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-coreos-src-ubuntu-xenial/2ff8f34/ : SUCCESS in 51m 28s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial/46bdeef/ : SUCCESS in 59m 50s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial/f96718d/ : SUCCESS in 57m 03s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial/b8ae04d/ : SUCCESS in 55m 43s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial/fcf9ef0/ : SUCCESS in 55m 49s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-coreos-src-ubuntu-xenial/4abc3f2/ : SUCCESS in 51m 52s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-coreos-src-ubuntu-xenial/6715383/ : SUCCESS in 55m 14s\n- gate-tempest-dsvm-ironic-inspector-src-ubuntu-xenial-nv http://logs.openstack.org/35/506735/1/check/gate-tempest-dsvm-ironic-inspector-src-ubuntu-xenial-nv/8448c5f/ : SUCCESS in 1h 06m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"149f04068674c3de9b45407b589059e8cbc75183","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-09-23 18:28:57.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b52de1b89796c95c4510cca38d485f35cbfaeb61","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-09-23 19:28:26.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a8b3ee4b594aef52605e1611150381768f805269","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-23 20:41:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/35/506735/2/check/gate-ironic-python-agent-docs-ubuntu-xenial/2d2076b//doc/build/html/ : SUCCESS in 3m 58s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-ironic-python-agent-pep8-ubuntu-xenial/ac0b7d7/ : SUCCESS in 3m 53s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-ironic-python-agent-python27-ubuntu-xenial/4b38ca4/ : SUCCESS in 4m 15s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/35/506735/2/check/gate-ironic-python-agent-python35/771c169/ : SUCCESS in 2m 58s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/35/506735/2/check/gate-ironic-python-agent-requirements/5fc4133/ : SUCCESS in 2m 41s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/35/506735/2/check/gate-ironic-python-agent-releasenotes/035322f//releasenotes/build/html/ : SUCCESS in 2m 48s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/cc30316/ : SUCCESS in 3m 24s (non-voting)\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-coreos-src-ubuntu-xenial/99c1047/ : SUCCESS in 58m 37s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-coreos-src-ubuntu-xenial/5114ef6/ : SUCCESS in 57m 05s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial/9c8abc1/ : SUCCESS in 53m 18s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial/692306f/ : SUCCESS in 52m 52s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial/787f24d/ : SUCCESS in 52m 41s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial/28a74e7/ : SUCCESS in 52m 16s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-coreos-src-ubuntu-xenial/a56299e/ : SUCCESS in 1h 02m 33s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-coreos-src-ubuntu-xenial/7a60783/ : SUCCESS in 1h 02m 29s\n- gate-tempest-dsvm-ironic-inspector-src-ubuntu-xenial-nv http://logs.openstack.org/35/506735/2/check/gate-tempest-dsvm-ironic-inspector-src-ubuntu-xenial-nv/0bc0215/ : SUCCESS in 1h 09m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d89a75cfd4d662157e206aec056c6a89574c0d18","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-09-25 14:27:55.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"63435bee9d74974433e42a7a1254f57aee0643bd","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-09-25 14:43:27.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"05af74b63df1669b526949404554d56a2c0ba74a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-25 14:43:48.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"970680dc5cdfd8fef0c9603d19d3e577a842ba20","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-25 15:50:35.000000000","message":"Change has been successfully merged by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"4a8b43f969ef60adcfdb418a8693ec08cb74b505","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-25 15:50:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/35/506735/2/gate/gate-ironic-python-agent-docs-ubuntu-xenial/84ac7bb//doc/build/html/ : SUCCESS in 3m 46s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-ironic-python-agent-pep8-ubuntu-xenial/ea5cd6a/ : SUCCESS in 5m 08s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-ironic-python-agent-python27-ubuntu-xenial/fcfe521/ : SUCCESS in 4m 22s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/35/506735/2/gate/gate-ironic-python-agent-python35/851d5dd/ : SUCCESS in 5m 37s\n- gate-ironic-python-agent-requirements http://logs.openstack.org/35/506735/2/gate/gate-ironic-python-agent-requirements/9f20156/ : SUCCESS in 2m 37s\n- gate-ironic-python-agent-releasenotes http://docs-draft.openstack.org/35/506735/2/gate/gate-ironic-python-agent-releasenotes/feb13a9//releasenotes/build/html/ : SUCCESS in 4m 59s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-coreos-src-ubuntu-xenial/8da0690/ : SUCCESS in 51m 58s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial/23e927b/ : SUCCESS in 48m 25s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-coreos-src-ubuntu-xenial/c723149/ : SUCCESS in 49m 44s\n- gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial/5d5f684/ : SUCCESS in 57m 31s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-tinyipa-src-ubuntu-xenial/515842f/ : SUCCESS in 55m 08s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-coreos-src-ubuntu-xenial/f32df81/ : SUCCESS in 1h 03m 34s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-coreos-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-coreos-src-ubuntu-xenial/be487ed/ : SUCCESS in 1h 03m 03s\n- gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial http://logs.openstack.org/35/506735/2/gate/gate-tempest-dsvm-ironic-ipa-partition-bios-agent_ipmitool-tinyipa-src-ubuntu-xenial/cad98b0/ : SUCCESS in 1h 06m 05s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b67f9c12989c4c411f9416a22e360e9df74231b2","revisions":{"5ca5b33acab72ccca2d735be154381a9f88df501":{"kind":"REWORK","_number":1,"created":"2017-09-22 17:48:57.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/35/506735/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/35/506735/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/1"}}},"commit":{"parents":[{"commit":"9ed2677c9d06eaa4e8b4348011b28bef9fe7b62d","subject":"Fix wrong link about Hardware Managers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9ed2677c9d06eaa4e8b4348011b28bef9fe7b62d"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-09-22 17:47:14.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-09-22 17:48:38.000000000","tz":-420},"subject":"flake8: Enable some off-by-default checks","message":"flake8: Enable some off-by-default checks\n\nEnable the following off-by-default checks:\n    * [H204] Use assert(Not)Equal to check for equality.\n    * [H205] Use assert(Greater|Less)(Equal) for comparison.\n    * [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in\n\t     mock.patch/mock.patch.object calls\n\nIncrease the version of hacking in test-requirements so that can use new\noff-by-default checks.\n\nNo changes to code were required.\n\nChange-Id: I98aa484dc5414ee49c281dfd40e44b3c613d53e0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5ca5b33acab72ccca2d735be154381a9f88df501"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5ca5b33acab72ccca2d735be154381a9f88df501"}]},"branch":"refs/heads/master"},"b67f9c12989c4c411f9416a22e360e9df74231b2":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-09-23 19:28:26.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/35/506735/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/35/506735/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/35/506735/2"}}},"commit":{"parents":[{"commit":"9ed2677c9d06eaa4e8b4348011b28bef9fe7b62d","subject":"Fix wrong link about Hardware Managers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/9ed2677c9d06eaa4e8b4348011b28bef9fe7b62d"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-09-22 17:47:14.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-09-23 19:28:14.000000000","tz":-420},"subject":"flake8: Enable some off-by-default checks","message":"flake8: Enable some off-by-default checks\n\nEnable the following off-by-default checks:\n    * [H204] Use assert(Not)Equal to check for equality.\n    * [H205] Use assert(Greater|Less)(Equal) for comparison.\n    * [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in\n             mock.patch/mock.patch.object calls\n\nIncrease the version of hacking in test-requirements so that can use new\noff-by-default checks.\n\nNo changes to code were required.\n\nChange-Id: I98aa484dc5414ee49c281dfd40e44b3c613d53e0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b67f9c12989c4c411f9416a22e360e9df74231b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b67f9c12989c4c411f9416a22e360e9df74231b2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
