)]}'
{"id":"openstack%2Fironic-python-agent~507267","triplet_id":"openstack%2Fironic-python-agent~master~Idf67c27212559935425da0a32a6e22054b6e88ff","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"Idf67c27212559935425da0a32a6e22054b6e88ff","subject":"WIP/DNM: Some mock cleanup for the future","status":"ABANDONED","created":"2017-09-25 20:54:04.000000000","updated":"2023-03-09 18:50:05.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"60201007b3201c272da53cd188447e89db27bc39","_number":507267,"virtual_id_number":507267,"owner":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"29ca27979eb544b858a8ab6437c002505054398a","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-09-25 20:54:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d22af00fd241a8945dc0e02a6b6ae0e825f198f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-25 21:00:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/67/507267/1/check/gate-ironic-python-agent-docs-ubuntu-xenial/31db435//doc/build/html/ : SUCCESS in 3m 10s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/67/507267/1/check/gate-ironic-python-agent-pep8-ubuntu-xenial/aac3309/ : SUCCESS in 3m 52s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/67/507267/1/check/gate-ironic-python-agent-python27-ubuntu-xenial/a31d1b9/ : SUCCESS in 3m 09s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/67/507267/1/check/gate-ironic-python-agent-python35/3af41a4/ : SUCCESS in 3m 44s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/67/507267/1/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/9dab972/ : SUCCESS in 3m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2b10c4ea7313e8eb54e46d571d3376191bff63cd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-09-26 09:42:48.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"ddbdece6291657fb20bf8ef90fa39d5fa9a394a3","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 02:13:53.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":1},{"id":"60201007b3201c272da53cd188447e89db27bc39","tag":"autogenerated:gerrit:abandon","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2023-03-09 18:50:05.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e2bfbf3e858395b7d4f07f6eeedbe2c858350f4a","revisions":{"e2bfbf3e858395b7d4f07f6eeedbe2c858350f4a":{"kind":"REWORK","_number":1,"created":"2017-09-25 20:54:04.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/67/507267/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/67/507267/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/67/507267/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/67/507267/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/67/507267/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/67/507267/1"}}},"commit":{"parents":[{"commit":"b67f9c12989c4c411f9416a22e360e9df74231b2","subject":"flake8: Enable some off-by-default checks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b67f9c12989c4c411f9416a22e360e9df74231b2"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-09-25 20:39:45.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-09-25 20:53:16.000000000","tz":-420},"subject":"WIP/DNM: Some mock cleanup for the future","message":"WIP/DNM: Some mock cleanup for the future\n\nNot 100% sure about this. Maybe I will get back to this.\n\nUse lambda when appropriate for mock.patch \u0027new\u0027\n\nWhen appropriate use a lambda for the mock.patch / mock.patch.object\n\u0027new\u0027[1].\n\nRough guidelines for when appropriate:\n  * Only the \u0027return_value\u0027 is set for the mock\n  * No assertions are checked on the mock\n  * The \u0027return_value\u0027 is a static value\n  * The \u0027return_value\u0027 is not too large. Roughly more than 1-2 lines.\n\nThis is not an exhaustive patch and there could be candidates for\nchanging that were missed.\n\nThe reason for doing this is that it cleans up the test function\nargument list. Less arguments to keep track of. And is cleaner code,\nin my opinion.\n\n[1] https://docs.python.org/3.5/library/unittest.mock.html#the-patchers\n\nChange-Id: Idf67c27212559935425da0a32a6e22054b6e88ff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e2bfbf3e858395b7d4f07f6eeedbe2c858350f4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e2bfbf3e858395b7d4f07f6eeedbe2c858350f4a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}