)]}'
{"ironic_python_agent/extensions/image.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"aeb32f667ba0f9fc541f8b8a624dff6edf17a4e7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # Add /usr/sbin to PATH variable to ensure it is there as we do"},{"line_number":112,"context_line":"        # not use full path to grub binary anymore."},{"line_number":113,"context_line":"        path_variable \u003d os.environ.get(\u0027PATH\u0027, \u0027\u0027)"},{"line_number":114,"context_line":"        path_variable \u003d \u0027%s:/bin:/usr/sbin\u0027 % path_variable"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Install grub"},{"line_number":117,"context_line":"        utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_e35aa54e","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":59},"updated":"2017-10-03 21:07:43.000000000","message":"nit: alternative implementation for your consideration:\n\n    search_path \u003d path_variable.split(os.path.pathsep)\n    for path_to_add in (\u0027/bin\u0027, \u0027/usr/sbin\u0027):\n      if path_to_add not in search_path:\n        search_path.append(path_to_add)\n    path_variable \u003d os.path.pathsep.join(search_path)\n\nmainly to avoid dups in $PATH and not to assume path separator sentinel?","commit_id":"f05702e9f2157259fd9e8c7d927ea13da98f7f9d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8a22ded3fe82fcc0240f02807140260bc0b7b876","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # Add /usr/sbin to PATH variable to ensure it is there as we do"},{"line_number":112,"context_line":"        # not use full path to grub binary anymore."},{"line_number":113,"context_line":"        path_variable \u003d os.environ.get(\u0027PATH\u0027, \u0027\u0027)"},{"line_number":114,"context_line":"        path_variable \u003d \u0027%s:/bin:/usr/sbin\u0027 % path_variable"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Install grub"},{"line_number":117,"context_line":"        utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_b4a4d7ba","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":59},"in_reply_to":"7f515b1d_e35aa54e","updated":"2017-10-04 10:41:31.000000000","message":"adding duplicate folders to patch won\u0027t harm, may be improved in future.","commit_id":"f05702e9f2157259fd9e8c7d927ea13da98f7f9d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4fdb19253254a7b653989233e6aefc806df9151c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        # Add /usr/sbin to PATH variable to ensure it is there as we do"},{"line_number":112,"context_line":"        # not use full path to grub binary anymore."},{"line_number":113,"context_line":"        path_variable \u003d os.environ.get(\u0027PATH\u0027, \u0027\u0027)"},{"line_number":114,"context_line":"        path_variable \u003d \u0027%s:/bin:/usr/sbin\u0027 % path_variable"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # Install grub"},{"line_number":117,"context_line":"        utils.execute(\u0027chroot %(path)s /bin/sh -c \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_46a3c701","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":59},"in_reply_to":"7f515b1d_e35aa54e","updated":"2017-10-03 21:14:55.000000000","message":"true, but this is a cherry-pick. If we change it, we need to change it in master branch first, then backport. And I don\u0027t think making this change falls under the guidelines for backports.","commit_id":"f05702e9f2157259fd9e8c7d927ea13da98f7f9d"}]}