)]}'
{"id":"openstack%2Fironic-python-agent~511066","triplet_id":"openstack%2Fironic-python-agent~master~Ic2abdb685093785dab9625996f984dbd6520a8f9","project":"openstack/ironic-python-agent","branch":"master","attention_set":{},"removed_from_attention_set":{"10342":{"account":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"last_update":"2023-08-30 18:13:02.000000000","reason":"Change was abandoned"},"14760":{"account":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"last_update":"2023-08-30 18:13:02.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ic2abdb685093785dab9625996f984dbd6520a8f9","subject":"Detect when log messages are mis-formatted","status":"ABANDONED","created":"2017-10-10 22:22:08.000000000","updated":"2023-08-30 18:13:02.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9e09b71a7d28fe6fa8563de9206cb4a3321a2646","_number":511066,"virtual_id_number":511066,"owner":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-06-25 23:21:38.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2023-06-26 04:33:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-12 22:59:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-10-27 16:28:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-25 21:42:21.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"state":"CC"},{"updated":"2023-06-26 04:34:08.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"CC"}],"messages":[{"id":"d68a6ad63d9851e32361a31d62d4018794748a9f","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-10 22:22:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e87eb5814e5c7bd891529da4e6dad7e9fd5ef279","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-10 23:04:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"05b40c491eb27164ebda07197d2182e6580a8b34","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-10 23:36:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a4ba54a5756c9c6c98780104fccd7335ae7c7de5","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-10 23:39:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"8d4820db84c784a39189d1f9c2a30b7f6eb7f709","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 01:20:55.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-docs-ubuntu-xenial/53cd326/ : FAILURE in 1m 30s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-pep8-ubuntu-xenial/a984437/ : SUCCESS in 3m 36s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python27-ubuntu-xenial/abc1d34/ : SUCCESS in 3m 46s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python35/1da4ffd/ : SUCCESS in 3m 29s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/1c3a272/ : FAILURE in 1m 04s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"b16d0bd6b619f80968b89f7b9a76af3685ff375d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-11 06:25:34.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed.\n\n- openstack-tox-pep8 http://logs.openstack.org/66/511066/4/check/openstack-tox-pep8/500b421/ : SUCCESS in 3m 26s\n- openstack-tox-py27 http://logs.openstack.org/66/511066/4/check/openstack-tox-py27/4559e73/ : SUCCESS in 3m 59s\n- openstack-tox-py35 http://logs.openstack.org/66/511066/4/check/openstack-tox-py35/6b2a844/ : RETRY_LIMIT in 1m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/511066/4/check/build-openstack-sphinx-docs/2559004/ : RETRY_LIMIT in 1m 39s\n- legacy-ironic-python-agent-tox-func http://logs.openstack.org/66/511066/4/check/legacy-ironic-python-agent-tox-func/d483b5c/ : FAILURE in 2m 00s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"3dcb908d749219946b23df4ab57daf3b4ab85b1c","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-11 13:49:47.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"89f558bbbb7b3b49d53cb50b548bdf3a883ba391","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 16:46:45.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/66/511066/4/check/gate-ironic-python-agent-docs-ubuntu-xenial/463afb2//doc/build/html/ : SUCCESS in 3m 17s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-pep8-ubuntu-xenial/b53526f/ : FAILURE in 1m 43s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python27-ubuntu-xenial/5acdb78/ : FAILURE in 56s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python35/dea8e51/ : FAILURE in 1m 27s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/c0ccd69/ : SUCCESS in 3m 24s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"50b4c4cd11f8359860983ff2f0f755986af641e6","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-11 23:03:57.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"909471f661e98407cdc4d4d30323cd01aa7a0f48","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-11 23:32:17.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-docs-ubuntu-xenial/424217b/ : POST_FAILURE in 4m 23s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-pep8-ubuntu-xenial/b7da332/ : FAILURE in 2m 08s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python27-ubuntu-xenial/22f0d59/ : SUCCESS in 7m 07s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python35/2ba71df/ : FAILURE in 1m 00s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/8d23eba/ : FAILURE in 3m 12s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"de6acc7c5cbccf7fda77fdd7dc4a5ab4287e3f04","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-12 01:48:59.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- openstack-tox-pep8 http://logs.openstack.org/66/511066/4/check/openstack-tox-pep8/a3bccb7/ : SUCCESS in 3m 53s\n- openstack-tox-py27 http://logs.openstack.org/66/511066/4/check/openstack-tox-py27/618c6ba/ : SUCCESS in 4m 19s\n- openstack-tox-py35 http://logs.openstack.org/66/511066/4/check/openstack-tox-py35/6f64a35/ : SUCCESS in 4m 02s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/511066/4/check/build-openstack-sphinx-docs/57dad39/html/ : SUCCESS in 3m 45s\n- legacy-ironic-python-agent-tox-func http://logs.openstack.org/66/511066/4/check/legacy-ironic-python-agent-tox-func/d898bb4/ : FAILURE in 1m 54s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"ac406a253bb04dc98a5d6b7e0aed60dbf8d078fc","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-12 22:50:28.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"92cf51a65b22ca19de8cf8d3ee0be143fce56e7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-12 22:59:30.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-ironic-python-agent-docs-ubuntu-xenial http://docs-draft.openstack.org/66/511066/4/check/gate-ironic-python-agent-docs-ubuntu-xenial/c8d5667//doc/build/html/ : SUCCESS in 3m 14s\n- gate-ironic-python-agent-pep8-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-pep8-ubuntu-xenial/6591881/ : SUCCESS in 3m 45s\n- gate-ironic-python-agent-python27-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python27-ubuntu-xenial/63b2da6/ : SUCCESS in 4m 04s\n- gate-ironic-python-agent-python35 http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-python35/5912474/ : SUCCESS in 4m 04s\n- gate-ironic-python-agent-tox-func-ubuntu-xenial http://logs.openstack.org/66/511066/4/check/gate-ironic-python-agent-tox-func-ubuntu-xenial/92b8fbb/ : SUCCESS in 5m 14s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"7ab57148ed10fb2a8e9c4b4518821a5d53557289","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-17 23:04:44.000000000","message":"Patch Set 4: Code-Review-2\n\nI want to wait until the ironic version of this patch gets merged before this gets merged.","accounts_in_message":[],"_revision_number":4},{"id":"bd428758680e1abca19d75d7234073340eae1d33","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-17 23:10:11.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"8f95f0f68e172444f6efc217ace7b20a46e509c7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-17 23:45:59.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded.\n\n- openstack-tox-pep8 http://logs.openstack.org/66/511066/5/check/openstack-tox-pep8/0e89baa/ : SUCCESS in 2m 18s\n- openstack-tox-py27 http://logs.openstack.org/66/511066/5/check/openstack-tox-py27/02a49d5/ : SUCCESS in 3m 42s\n- openstack-tox-py35 http://logs.openstack.org/66/511066/5/check/openstack-tox-py35/70f7518/ : SUCCESS in 2m 26s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/511066/5/check/build-openstack-sphinx-docs/020742a/html/ : SUCCESS in 2m 47s\n- legacy-ironic-python-agent-tox-func http://logs.openstack.org/66/511066/5/check/legacy-ironic-python-agent-tox-func/f114f43/ : SUCCESS in 2m 31s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"3f34841ee7b2082c22dba419a480fb888779fcd5","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-27 15:50:24.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"e72d4c90020a7eee6ecbaa084f963088f24a5fe2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-27 16:09:04.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/66/511066/6/check/openstack-tox-pep8/e3ae590/ : SUCCESS in 3m 28s\n- openstack-tox-py27 http://logs.openstack.org/66/511066/6/check/openstack-tox-py27/6c02ce6/ : FAILURE in 3m 48s\n- openstack-tox-py35 http://logs.openstack.org/66/511066/6/check/openstack-tox-py35/52e0031/ : FAILURE in 3m 53s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/511066/6/check/build-openstack-sphinx-docs/d968278/html/ : SUCCESS in 4m 18s\n- ironic-python-agent-tox-func http://logs.openstack.org/66/511066/6/check/ironic-python-agent-tox-func/6dc5cb3/ : SUCCESS in 5m 56s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"8046a2e057abe1e1963a39732dd981633df81c94","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-27 16:18:26.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"1f163f45c07af4c78f29b73c6421a06ffba1dbe1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-27 16:28:23.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/66/511066/7/check/openstack-tox-pep8/eca5388/ : SUCCESS in 3m 04s\n- openstack-tox-py27 http://logs.openstack.org/66/511066/7/check/openstack-tox-py27/9ec0c21/ : SUCCESS in 3m 21s\n- openstack-tox-py35 http://logs.openstack.org/66/511066/7/check/openstack-tox-py35/ec7b251/ : SUCCESS in 4m 09s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/511066/7/check/build-openstack-sphinx-docs/91019e9/html/ : SUCCESS in 3m 56s\n- ironic-python-agent-tox-func http://logs.openstack.org/66/511066/7/check/ironic-python-agent-tox-func/65775d5/ : SUCCESS in 3m 23s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"c7b14d0fc5014d2ef1b7595a9328c182697f17ff","tag":"autogenerated:gerrit:abandon","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2023-03-09 18:50:15.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":7},{"id":"db2bd3eeea0c00061e0eebe6bec859d57718c2e9","tag":"autogenerated:gerrit:restore","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-06-25 21:30:38.000000000","message":"Restored","accounts_in_message":[],"_revision_number":7},{"id":"f89a958cdc7b6402b836e940980c90a4142afcf0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-25 21:30:53.000000000","message":"Patch Set 7: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.\nWarning:\n  Error merging gerrit/openstack/ironic-python-agent for 511066,7","accounts_in_message":[],"_revision_number":7},{"id":"2e83ed217f2232b7ef613adac3de787619c4ebdb","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-25 21:30:54.000000000","message":"Patch Set 7:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.\nWarning:\n  Error merging gerrit/openstack/ironic-python-agent for 511066,7","accounts_in_message":[],"_revision_number":7},{"id":"5ae1172e83c6f8678f2a57322f84ebd880213faa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-06-25 21:41:35.000000000","message":"Uploaded patch set 8.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":8},{"id":"9f03c2d3664256fded359b2e3310c644bc5838ac","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-06-25 21:42:21.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"71692b1cc10079b1de4cb29c9bca3e5dff4cef93","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-25 21:46:38.000000000","message":"Patch Set 8:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6df6636bc54c42f4a272e78d32dbe096\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/12596775bd64454eabee3221e854a4db : SUCCESS in 4m 01s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/fee6b2b9d1794929b1c8066487a3e825 : SUCCESS in 4m 16s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/a95b5e1445244ec683a609810bf9416c : SUCCESS in 4m 06s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"d8bd18cf7a557d3bafc7863147ae6271718ea0f3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-25 23:21:38.000000000","message":"Patch Set 8: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/aec690fb13ab4a7abda6c2ec13352e66\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/981c3222d67e457689187dfd0dfea1e2 : SUCCESS in 3m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0b16aa773dea4bc4ae3df80e471a19c1 : FAILURE in 3m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/435579b11b494cd386d05b93cde82f7a : SUCCESS in 3m 35s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6291f063312349ddaf8fa1c8193b09f7 : SUCCESS in 3m 31s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/8685fcfa69e04298a5c6a6be284e68b4 : SUCCESS in 3m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/af639167f8e54e4b991118cb752d9e0d : SUCCESS in 5m 15s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/8716f0a549df416ba8deff54ee0c7c86 : SUCCESS in 3m 31s\n- metalsmith-integration-ipa-src-uefi https://zuul.opendev.org/t/openstack/build/a3844750d3994a21be7b46689b466cd8 : SUCCESS in 1h 33m 08s\n- metalsmith-integration-ipa-src-legacy https://zuul.opendev.org/t/openstack/build/c7d615edadfc4eaab79b2f547698087f : SUCCESS in 1h 28m 52s\n- ironic-standalone-ipa-src https://zuul.opendev.org/t/openstack/build/86ef613a80c84ca89de667a1a6a792eb : SUCCESS in 1h 06m 16s\n- ironic-python-agent-check-image-tinyipa https://zuul.opendev.org/t/openstack/build/a5ca5b13bade49e796be8649a5e2a27f : SUCCESS in 21m 24s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/804af2ccd3094e98b2985c78efefaa0d : SUCCESS in 6m 47s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"fd57580971964b1d94cfb0391012a07f9036dd6f","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2023-06-26 04:33:40.000000000","message":"Removed Code-Review-2 by \u003cGERRIT_ACCOUNT_14760\u003e\n","accounts_in_message":[{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"}],"_revision_number":8},{"id":"abdac8cc8001c561e55519fb38c93a7ab9dd401a","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2023-06-26 04:34:08.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"9e09b71a7d28fe6fa8563de9206cb4a3321a2646","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-08-30 18:13:02.000000000","message":"Abandoned\n\nthis needs more than a rebase, and I don\u0027t have time to attack it","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"f35ffccde7c169f5bd3025d211bc84d3fa40c174","revisions":{"5a633e5d000fc74ba012b8793b7a23e9fd590717":{"kind":"REWORK","_number":1,"created":"2017-10-10 22:22:08.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/66/511066/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/1"}}},"commit":{"parents":[{"commit":"6d84d9642a11ea576e5eb46e405049f1441880f8","subject":"Fix a mis-formatted log message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d84d9642a11ea576e5eb46e405049f1441880f8"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5a633e5d000fc74ba012b8793b7a23e9fd590717"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/5a633e5d000fc74ba012b8793b7a23e9fd590717"}]},"branch":"refs/heads/master"},"ae9cf304587be81fa5c0aea172f8b1d16fa44793":{"kind":"REWORK","_number":2,"created":"2017-10-10 23:04:16.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/66/511066/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/2"}}},"commit":{"parents":[{"commit":"6d84d9642a11ea576e5eb46e405049f1441880f8","subject":"Fix a mis-formatted log message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d84d9642a11ea576e5eb46e405049f1441880f8"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 23:04:09.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ae9cf304587be81fa5c0aea172f8b1d16fa44793"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ae9cf304587be81fa5c0aea172f8b1d16fa44793"}]},"branch":"refs/heads/master"},"fbe583e0478e2ef5dbe9a817a2064e5f879e9c43":{"kind":"REWORK","_number":3,"created":"2017-10-10 23:36:23.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/66/511066/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/3"}}},"commit":{"parents":[{"commit":"6d84d9642a11ea576e5eb46e405049f1441880f8","subject":"Fix a mis-formatted log message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d84d9642a11ea576e5eb46e405049f1441880f8"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 23:36:17.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fbe583e0478e2ef5dbe9a817a2064e5f879e9c43"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fbe583e0478e2ef5dbe9a817a2064e5f879e9c43"}]},"branch":"refs/heads/master"},"582d7b1fcc9a455b78be68def26ed0cb0a368168":{"kind":"REWORK","_number":4,"created":"2017-10-10 23:39:56.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/66/511066/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/4"}}},"commit":{"parents":[{"commit":"6d84d9642a11ea576e5eb46e405049f1441880f8","subject":"Fix a mis-formatted log message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/6d84d9642a11ea576e5eb46e405049f1441880f8"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 23:39:48.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/582d7b1fcc9a455b78be68def26ed0cb0a368168"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/582d7b1fcc9a455b78be68def26ed0cb0a368168"}]},"branch":"refs/heads/master"},"a10ab84bbebf8e52f08799dbc3e23af47592b5b7":{"kind":"REWORK","_number":5,"created":"2017-10-17 23:10:11.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/66/511066/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/5"}}},"commit":{"parents":[{"commit":"ce32efc82b8a34455749407ebf0703bf41cb3a36","subject":"Merge \"Fix waiting for target disk to appear\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ce32efc82b8a34455749407ebf0703bf41cb3a36"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-17 23:09:26.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nNote: This will not catch errors in log messages if 1) The call to the\nlogger is mocked out, or 2) The unit test never exercises the logging\ncall.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a10ab84bbebf8e52f08799dbc3e23af47592b5b7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a10ab84bbebf8e52f08799dbc3e23af47592b5b7"}]},"branch":"refs/heads/master"},"7c70dff26d24700eb5fea1b6a1f121affd02ec3d":{"kind":"REWORK","_number":6,"created":"2017-10-27 15:50:24.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/66/511066/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/6"}}},"commit":{"parents":[{"commit":"c96d7d32aa7b51a07a8ddb14c09b80a60d7ec736","subject":"Fix post upload images task","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c96d7d32aa7b51a07a8ddb14c09b80a60d7ec736"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-27 15:50:11.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nNote: This will not catch errors in log messages if 1) The call to the\nlogger is mocked out, or 2) The unit test never exercises the logging\ncall.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7c70dff26d24700eb5fea1b6a1f121affd02ec3d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/7c70dff26d24700eb5fea1b6a1f121affd02ec3d"}]},"branch":"refs/heads/master"},"8cfbe314d0fca9fdc18692332ae4abf1817f0e8f":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2017-10-27 16:18:26.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/66/511066/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/7"}}},"commit":{"parents":[{"commit":"c3acbde396501996bca0373bb2e55c11a88b2651","subject":"Fix a mis-formatted log message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c3acbde396501996bca0373bb2e55c11a88b2651"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-27 16:17:02.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nNote: This will not catch errors in log messages if 1) The call to the\nlogger is mocked out, or 2) The unit test never exercises the logging\ncall.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8cfbe314d0fca9fdc18692332ae4abf1817f0e8f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/8cfbe314d0fca9fdc18692332ae4abf1817f0e8f"}]},"branch":"refs/heads/master"},"f35ffccde7c169f5bd3025d211bc84d3fa40c174":{"kind":"REWORK","_number":8,"created":"2023-06-25 21:41:35.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/66/511066/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/66/511066/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/66/511066/8"}}},"commit":{"parents":[{"commit":"4845fd04bab71fa393c374d932185dde16d020af","subject":"Merge \"Follow-up Add documentation for MellanoxDeviceHardwareManager\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/4845fd04bab71fa393c374d932185dde16d020af"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-10-10 22:20:11.000000000","tz":-420},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2023-06-25 21:41:34.000000000","tz":-420},"subject":"Detect when log messages are mis-formatted","message":"Detect when log messages are mis-formatted\n\nThis is a cross-port of part of the fixtures.py file from Nova as\nironic_fixtures.py.\n\nThere are a number of things we want to handle with logging in tests:\n\n* Redirect the logging to somewhere that we can test or dump it later.\n\n* Ensure that as many DEBUG messages as possible are actually\n   executed, to ensure they are actually syntactically valid (they\n   often have not been).\n\n* Ensure that we create useful output for tests that doesn\u0027t\n  overwhelm the testing system (which means we can\u0027t capture the\n  100 MB of debug logging on every run).\n\nTo do this we create a logger fixture at the root level, which\ndefaults to INFO and create a Null Logger at DEBUG which lets\nus execute log messages at DEBUG but not keep the output.\n\nTo support local debugging OS_DEBUG\u003dTrue can be set in the\nenvironment, which will print out the full debug logging.\n\nThere are also a set of overrides for particularly verbose\nmodules to be even less than INFO.\n\nNote: This will not catch errors in log messages if 1) The call to the\nlogger is mocked out, or 2) The unit test never exercises the logging\ncall.\n\nChange-Id: Ic2abdb685093785dab9625996f984dbd6520a8f9\nCloses-Bug: #1503086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f35ffccde7c169f5bd3025d211bc84d3fa40c174"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/f35ffccde7c169f5bd3025d211bc84d3fa40c174"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}