)]}'
{"id":"openstack%2Fironic-python-agent~513071","triplet_id":"openstack%2Fironic-python-agent~master~Id9e0dd1614703760b2fe143b2029f9bf6067420a","project":"openstack/ironic-python-agent","branch":"master","topic":"fix-unit-test","hashtags":[],"change_id":"Id9e0dd1614703760b2fe143b2029f9bf6067420a","subject":"Unit test has incorrect mock order","status":"MERGED","created":"2017-10-18 15:34:19.000000000","updated":"2017-10-20 10:11:15.000000000","submitted":"2017-10-20 10:11:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"513071-1508494275433-81eb01e3","meta_rev_id":"7c9b39d9aa4e5d3cc785e62fffc2c2d84f00b562","_number":513071,"virtual_id_number":513071,"owner":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2017-10-20 10:11:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"date":"2017-10-18 17:51:36.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-10-20 10:02:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2017-10-18 15:36:09.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":1,"date":"2017-10-18 16:03:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2017-10-20 10:02:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-18 15:36:09.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2017-10-18 16:03:57.000000000","updated_by":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"reviewer":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"state":"REVIEWER"},{"updated":"2017-10-20 10:02:14.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-10-20 10:11:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"80929cf7cb7d42b4ae602514a70a27f5736692bb","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-10-18 15:34:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"90598916315e0aea852dfbe163542417d74b3cbf","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-10-18 15:36:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"aaf1154fdac0a300f9d58989f5457f910542995d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-18 15:43:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- openstack-tox-pep8 http://logs.openstack.org/71/513071/1/check/openstack-tox-pep8/e5290da/ : SUCCESS in 2m 37s\n- openstack-tox-py27 http://logs.openstack.org/71/513071/1/check/openstack-tox-py27/6e0eef5/ : SUCCESS in 2m 49s\n- openstack-tox-py35 http://logs.openstack.org/71/513071/1/check/openstack-tox-py35/89fafef/ : SUCCESS in 2m 40s\n- build-openstack-sphinx-docs http://logs.openstack.org/71/513071/1/check/build-openstack-sphinx-docs/1917ba3/html/ : SUCCESS in 2m 44s\n- legacy-ironic-python-agent-tox-func http://logs.openstack.org/71/513071/1/check/legacy-ironic-python-agent-tox-func/58df934/ : SUCCESS in 2m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c107125c7a628d3ed0d98acb6f682492ce9197f0","author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"date":"2017-10-18 16:03:57.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM though it begs the question how good this test actually is :)","accounts_in_message":[],"_revision_number":1},{"id":"55f75410714b54a6972ad753679370170d8b0ca7","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-10-18 17:51:36.000000000","message":"Patch Set 1:\n\n\u003e LGTM though it begs the question how good this test actually is :)\n\nheh, the goal was to mock the stuff, so that was done. I guess the only other thing that could have been done, was to do more explicit asserting that the mocks were called with e.g. expected parameters. But at this point, I guess I should be happy that we even have unit tests :)","accounts_in_message":[],"_revision_number":1},{"id":"ff57f4ce35c47e37e166570d3d958f20f6fd5370","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-10-20 10:02:14.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"94f0d734fe3d0a006b5551a7bb78e5d0ef25e47d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-20 10:02:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f95670484e446b5c900b1feca65087361d375020","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-20 10:11:15.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"0db9e92cafbd6c6b6f1ece52bc90758ec9bfdb95","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-20 10:11:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/71/513071/1/gate/openstack-tox-pep8/1380c0c/ : SUCCESS in 2m 42s\n- openstack-tox-py27 http://logs.openstack.org/71/513071/1/gate/openstack-tox-py27/30877f8/ : SUCCESS in 4m 32s\n- openstack-tox-py35 http://logs.openstack.org/71/513071/1/gate/openstack-tox-py35/8c69a83/ : SUCCESS in 3m 21s\n- build-openstack-sphinx-docs http://logs.openstack.org/71/513071/1/gate/build-openstack-sphinx-docs/2310f3e/html/ : SUCCESS in 3m 38s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b433fb07ea3df19b4b1004db701bd1578391f005","revisions":{"b433fb07ea3df19b4b1004db701bd1578391f005":{"kind":"REWORK","_number":1,"created":"2017-10-18 15:34:19.000000000","uploader":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"ref":"refs/changes/71/513071/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/71/513071/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/513071/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/513071/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/513071/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/71/513071/1"}}},"commit":{"parents":[{"commit":"ce32efc82b8a34455749407ebf0703bf41cb3a36","subject":"Merge \"Fix waiting for target disk to appear\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ce32efc82b8a34455749407ebf0703bf41cb3a36"}]}],"author":{"name":"Ruby Loo","email":"ruby.loo@intel.com","date":"2017-10-18 15:32:23.000000000","tz":-240},"committer":{"name":"Ruby Loo","email":"ruby.loo@intel.com","date":"2017-10-18 15:32:23.000000000","tz":-240},"subject":"Unit test has incorrect mock order","message":"Unit test has incorrect mock order\n\nMinor change to a unit test; the names of the mock arguments to the\nunit test method are not consistent with the actual ordering of the\nmock decorators. This fixes it.\n\nChange-Id: Id9e0dd1614703760b2fe143b2029f9bf6067420a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b433fb07ea3df19b4b1004db701bd1578391f005"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/b433fb07ea3df19b4b1004db701bd1578391f005"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"ce32efc82b8a34455749407ebf0703bf41cb3a36","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}