)]}'
{"ironic_python_agent/hardware.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b79815755ae9100fbbac43db7570153477061cc4","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                break"},{"line_number":407,"context_line":"        else:"},{"line_number":408,"context_line":"            LOG.warning(\u0027The root device was not detected in %d seconds\u0027,"},{"line_number":409,"context_line":"                        CONF.disk_wait_delay * (CONF.disk_wait_attempts - 1))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def list_hardware_info(self):"},{"line_number":412,"context_line":"        \"\"\"Return full hardware inventory as a serializable dict."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_4a2d17fc","line":409,"updated":"2017-11-08 11:04:30.000000000","message":"with disk_wait_attempts\u003d\u003d1, this will result in \"The root device was not detected in 0 seconds\". This may be fine, but was it your intention?","commit_id":"0287e37383e19ed70fef50100e24182e36fec310"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9844ce3cc9ecc1525452d2aa9dccae34af736723","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                break"},{"line_number":407,"context_line":"        else:"},{"line_number":408,"context_line":"            LOG.warning(\u0027The root device was not detected in %d seconds\u0027,"},{"line_number":409,"context_line":"                        CONF.disk_wait_delay * (CONF.disk_wait_attempts - 1))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def list_hardware_info(self):"},{"line_number":412,"context_line":"        \"\"\"Return full hardware inventory as a serializable dict."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_0f6cc834","line":409,"in_reply_to":"1f485f77_ac1702ee","updated":"2017-11-09 15:44:20.000000000","message":"Done","commit_id":"0287e37383e19ed70fef50100e24182e36fec310"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6b26ce7e6b7552a8b061579ce627503206bb4896","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                break"},{"line_number":407,"context_line":"        else:"},{"line_number":408,"context_line":"            LOG.warning(\u0027The root device was not detected in %d seconds\u0027,"},{"line_number":409,"context_line":"                        CONF.disk_wait_delay * (CONF.disk_wait_attempts - 1))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def list_hardware_info(self):"},{"line_number":412,"context_line":"        \"\"\"Return full hardware inventory as a serializable dict."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_592deffb","line":409,"in_reply_to":"3f4b6375_199bf766","updated":"2017-11-08 15:21:52.000000000","message":"yeah, I\u0027d have two messages, to be honest.","commit_id":"0287e37383e19ed70fef50100e24182e36fec310"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"212cc698df86f193fd89e9478914cd6193c45bc9","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                break"},{"line_number":407,"context_line":"        else:"},{"line_number":408,"context_line":"            LOG.warning(\u0027The root device was not detected in %d seconds\u0027,"},{"line_number":409,"context_line":"                        CONF.disk_wait_delay * (CONF.disk_wait_attempts - 1))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def list_hardware_info(self):"},{"line_number":412,"context_line":"        \"\"\"Return full hardware inventory as a serializable dict."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_199bf766","line":409,"in_reply_to":"3f4b6375_4a2d17fc","updated":"2017-11-08 15:17:45.000000000","message":"Yes. It is odd, but I couldn\u0027t think of anything else to do, unless we don\u0027t want to log anything, or change the msg, cuz basically it didn\u0027t wait... \u0027The root device was not detected\u0027 ?","commit_id":"0287e37383e19ed70fef50100e24182e36fec310"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4956212bd8d64150f8a042ac30ed94587ef0dd44","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                break"},{"line_number":407,"context_line":"        else:"},{"line_number":408,"context_line":"            LOG.warning(\u0027The root device was not detected in %d seconds\u0027,"},{"line_number":409,"context_line":"                        CONF.disk_wait_delay * (CONF.disk_wait_attempts - 1))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def list_hardware_info(self):"},{"line_number":412,"context_line":"        \"\"\"Return full hardware inventory as a serializable dict."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_8b766e0c","line":409,"in_reply_to":"3f4b6375_592deffb","updated":"2017-11-08 15:59:10.000000000","message":"Not sure it is worth the coding effort but sure. What do you want the message to say if \u003d\u003d 1? Just \"The root device was not detected\"? Or \"The root device was not detected, but did not wait and retry\"? Or ?","commit_id":"0287e37383e19ed70fef50100e24182e36fec310"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1c0ff0bc5863468aa02fe7815f6240b516bc6742","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                break"},{"line_number":407,"context_line":"        else:"},{"line_number":408,"context_line":"            LOG.warning(\u0027The root device was not detected in %d seconds\u0027,"},{"line_number":409,"context_line":"                        CONF.disk_wait_delay * (CONF.disk_wait_attempts - 1))"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def list_hardware_info(self):"},{"line_number":412,"context_line":"        \"\"\"Return full hardware inventory as a serializable dict."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_ac1702ee","line":409,"in_reply_to":"3f4b6375_8b766e0c","updated":"2017-11-09 14:32:21.000000000","message":"I\u0027d leave \"The root device was not detected\"","commit_id":"0287e37383e19ed70fef50100e24182e36fec310"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"13c17d1fa32e2d8f1c8db6f64ca1d354d3b20f71","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if not CONF.disk_wait_attempts:"},{"line_number":393,"context_line":"            return"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        max_waits \u003d CONF.disk_wait_attempts - 1"},{"line_number":396,"context_line":"        for attempt in range(CONF.disk_wait_attempts):"},{"line_number":397,"context_line":"            try:"},{"line_number":398,"context_line":"                self.get_os_install_device()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_67cc6e89","line":395,"updated":"2017-11-10 21:22:40.000000000","message":"So what happens if CONF.disk_wait_attempts is 0?\n\nWhich appears to be allowed.","commit_id":"6da0268ebe9e69b891409236a88b8721ce2236eb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"7d496cf38130b0816cf09da31087a84c4cb542a3","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if not CONF.disk_wait_attempts:"},{"line_number":393,"context_line":"            return"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        max_waits \u003d CONF.disk_wait_attempts - 1"},{"line_number":396,"context_line":"        for attempt in range(CONF.disk_wait_attempts):"},{"line_number":397,"context_line":"            try:"},{"line_number":398,"context_line":"                self.get_os_install_device()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_2e774fd7","line":395,"in_reply_to":"1f485f77_4145dab2","updated":"2017-11-13 15:27:58.000000000","message":"Just a reminder, the goal of this patch was to fix the off-by-one error :)\n\nIf the config wasn\u0027t set up properly I\u0027ll... #$!@# I just looked and it isn\u0027t. In fact, a quick look shows that we aren\u0027t setting min (or max) for quite a few Int configs :-(  Ok, I opened a low-hanging-fruit bug: https://bugs.launchpad.net/ironic-python-agent/+bug/1731950","commit_id":"6da0268ebe9e69b891409236a88b8721ce2236eb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c54ab1b79d7536fe6853a5e6a683f51c0e864902","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if not CONF.disk_wait_attempts:"},{"line_number":393,"context_line":"            return"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        max_waits \u003d CONF.disk_wait_attempts - 1"},{"line_number":396,"context_line":"        for attempt in range(CONF.disk_wait_attempts):"},{"line_number":397,"context_line":"            try:"},{"line_number":398,"context_line":"                self.get_os_install_device()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_81c87255","line":395,"in_reply_to":"1f485f77_67cc6e89","updated":"2017-11-11 20:50:33.000000000","message":"It\u0027s handled on line 392","commit_id":"6da0268ebe9e69b891409236a88b8721ce2236eb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0c26df7bd91e6c36cafee2bccad0dddeec412339","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        if not CONF.disk_wait_attempts:"},{"line_number":393,"context_line":"            return"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        max_waits \u003d CONF.disk_wait_attempts - 1"},{"line_number":396,"context_line":"        for attempt in range(CONF.disk_wait_attempts):"},{"line_number":397,"context_line":"            try:"},{"line_number":398,"context_line":"                self.get_os_install_device()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_4145dab2","line":395,"in_reply_to":"1f485f77_81c87255","updated":"2017-11-11 21:28:52.000000000","message":"Okay, but what about -1 :) ?","commit_id":"6da0268ebe9e69b891409236a88b8721ce2236eb"}]}