)]}'
{"etc/ironic_python_agent/ironic_python_agent.conf.sample":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# The IP address to listen on. Can be supplied as \"ipa-listen-"},{"line_number":14,"context_line":"# host\" kernel parameter. (string value)"},{"line_number":15,"context_line":"# Deprecated group/name - [DEFAULT]/listen_host"},{"line_number":16,"context_line":"#listen_host \u003d ::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The port to listen on. Can be supplied as \"ipa-listen-port\""},{"line_number":19,"context_line":"# kernel parameter. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1f485f77_9422cda3","line":16,"updated":"2017-11-13 20:34:27.000000000","message":"huh? The .sample should have been updated already. Le Sigh.","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# The IP address to listen on. Can be supplied as \"ipa-listen-"},{"line_number":14,"context_line":"# host\" kernel parameter. (string value)"},{"line_number":15,"context_line":"# Deprecated group/name - [DEFAULT]/listen_host"},{"line_number":16,"context_line":"#listen_host \u003d ::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The port to listen on. Can be supplied as \"ipa-listen-port\""},{"line_number":19,"context_line":"# kernel parameter. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1f485f77_63aac7d2","line":16,"in_reply_to":"1f485f77_74a2b14d","updated":"2017-11-15 10:15:56.000000000","message":"np, I did update separately and patch was merged.","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"af35b7db3c77adf334592e6b898d7d7951983490","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# The IP address to listen on. Can be supplied as \"ipa-listen-"},{"line_number":14,"context_line":"# host\" kernel parameter. (string value)"},{"line_number":15,"context_line":"# Deprecated group/name - [DEFAULT]/listen_host"},{"line_number":16,"context_line":"#listen_host \u003d ::"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The port to listen on. Can be supplied as \"ipa-listen-port\""},{"line_number":19,"context_line":"# kernel parameter. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1f485f77_74a2b14d","line":16,"in_reply_to":"1f485f77_9422cda3","updated":"2017-11-13 20:35:46.000000000","message":"to clarify, i\u0027m not asking you to update in a separate patch (unless you want to), i\u0027m just conveying my disappointment that it hadn\u0027t been done in the patch that modified the config.","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"}],"ironic_python_agent/config.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e4950c57721dd2258dbb2ea9ba90f53b3bc7d291","unresolved":false,"context_lines":[{"line_number":205,"context_line":"               min\u003d0,"},{"line_number":206,"context_line":"               default\u003d60,"},{"line_number":207,"context_line":"               help\u003d\u0027Timeout value that will be set to all calls made via \u0027"},{"line_number":208,"context_line":"                    \u0027requests library which doesn\\\u0027t have default timeout and \u0027"},{"line_number":209,"context_line":"                    \u0027request may hang indefinitely. This is session \u0027"},{"line_number":210,"context_line":"                    \u0027initiation timeout and do not limit entire response to \u0027"},{"line_number":211,"context_line":"                    \u0027download.\u0027)"},{"line_number":212,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_2804f114","line":209,"range":{"start_line":208,"start_character":74,"end_line":209,"end_character":51},"updated":"2017-11-13 06:50:28.000000000","message":"This gives impression that this config can cause hang. May be we can do away with this part.","commit_id":"527f4f203265752c4404f8d0e7d243d8c304b2e4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bd50f9e4c075d491d0b3ba946ef7f2cd7127bc10","unresolved":false,"context_lines":[{"line_number":205,"context_line":"               min\u003d0,"},{"line_number":206,"context_line":"               default\u003d60,"},{"line_number":207,"context_line":"               help\u003d\u0027Timeout value that will be set to all calls made via \u0027"},{"line_number":208,"context_line":"                    \u0027requests library which doesn\\\u0027t have default timeout and \u0027"},{"line_number":209,"context_line":"                    \u0027request may hang indefinitely. This is session \u0027"},{"line_number":210,"context_line":"                    \u0027initiation timeout and do not limit entire response to \u0027"},{"line_number":211,"context_line":"                    \u0027download.\u0027)"},{"line_number":212,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_7319ba77","line":209,"range":{"start_line":208,"start_character":74,"end_line":209,"end_character":51},"in_reply_to":"1f485f77_2804f114","updated":"2017-11-13 08:09:03.000000000","message":"Done","commit_id":"527f4f203265752c4404f8d0e7d243d8c304b2e4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                    \u0027Must be provided together with \"certfile\" option. \u0027"},{"line_number":202,"context_line":"                    \u0027Default is to not present any client certificates to \u0027"},{"line_number":203,"context_line":"                    \u0027the server.\u0027),"},{"line_number":204,"context_line":"    cfg.IntOpt(\u0027requests_timeout\u0027,"},{"line_number":205,"context_line":"               min\u003d0,"},{"line_number":206,"context_line":"               default\u003d60,"},{"line_number":207,"context_line":"               help\u003d\u0027Timeout value that will be set to all calls made via \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_f4eea1b2","line":204,"updated":"2017-11-13 20:34:27.000000000","message":"it looks like the timeout value for requests can be a float. We want it to be an int, cuz it probably doesn\u0027t matter/make sense to have it so precise?","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                    \u0027Must be provided together with \"certfile\" option. \u0027"},{"line_number":202,"context_line":"                    \u0027Default is to not present any client certificates to \u0027"},{"line_number":203,"context_line":"                    \u0027the server.\u0027),"},{"line_number":204,"context_line":"    cfg.IntOpt(\u0027requests_timeout\u0027,"},{"line_number":205,"context_line":"               min\u003d0,"},{"line_number":206,"context_line":"               default\u003d60,"},{"line_number":207,"context_line":"               help\u003d\u0027Timeout value that will be set to all calls made via \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_03d31362","line":204,"in_reply_to":"1f485f77_f4eea1b2","updated":"2017-11-15 10:15:56.000000000","message":"there is no need have it so precise, int is more than enough.","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":206,"context_line":"               default\u003d60,"},{"line_number":207,"context_line":"               help\u003d\u0027Timeout value that will be set to all calls made via \u0027"},{"line_number":208,"context_line":"                    \u0027requests library. This is session initiation timeout \u0027"},{"line_number":209,"context_line":"                    \u0027and do not limit entire response to download.\u0027)"},{"line_number":210,"context_line":"]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"CONF.register_cli_opts(cli_opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_749cf15c","line":209,"updated":"2017-11-13 20:34:27.000000000","message":"I\u0027m not that familiar with IPA, but presumably, all HTTP requests are done via the \u0027requests\u0027 library. If so, I think it would be good to generalize this so it isn\u0027t specific to the \u0027requests\u0027 library -- or can we assume that folks know what this library does?\n\nE.g. something like\n\nThe amount of time (secs) to wait after an HTTP request is issued, for (the start of) a response to that request.\n\nDo we want to mention what happens if it times out? (What happens anyway?)","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"118e9b6629583552c3d10cec7d0a0c6a26f9fce6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"               default\u003d60,"},{"line_number":207,"context_line":"               help\u003d\u0027Timeout value that will be set to all calls made via \u0027"},{"line_number":208,"context_line":"                    \u0027requests library. This is session initiation timeout \u0027"},{"line_number":209,"context_line":"                    \u0027and do not limit entire response to download.\u0027)"},{"line_number":210,"context_line":"]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"CONF.register_cli_opts(cli_opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_d968431e","line":209,"in_reply_to":"1f485f77_23e04f96","updated":"2017-11-15 14:03:17.000000000","message":"Let\u0027s drop mentioning of the requests library, that\u0027s probably useless for most operators. Even though we drop it, I think it is ok to call it \u0027requests_timeout\u0027, unless someone can think of a better term. \u0027httprequests_timeout\u0027 seems too long :)\n\nwrt the exception, in ironic, we don\u0027t/shouldn\u0027t raise non-ironic exceptions to the user. I don\u0027t know what/if there is a general rule about this in ipa. Having said that, it would seem to me that it might be useful to know where the timeout happened, eg. when downloading some file or whatever. Although I see you\u0027ve commented on this elsewhere :)","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":206,"context_line":"               default\u003d60,"},{"line_number":207,"context_line":"               help\u003d\u0027Timeout value that will be set to all calls made via \u0027"},{"line_number":208,"context_line":"                    \u0027requests library. This is session initiation timeout \u0027"},{"line_number":209,"context_line":"                    \u0027and do not limit entire response to download.\u0027)"},{"line_number":210,"context_line":"]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"CONF.register_cli_opts(cli_opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_23e04f96","line":209,"in_reply_to":"1f485f77_749cf15c","updated":"2017-11-15 10:15:56.000000000","message":"I don\u0027t think we use any other lib when connecting to HTTP in ironic, in all requirements we have only \u0027requests\u0027 requirement. I don\u0027t if infra/api group force us to use only requests library, but mostly all projects use only requests.\n\nI even think we can drop mention about requests library as we do not use any other library when do HTTP requests in the code.\n\nWhen it happens it will raise Timeout exception, the exception will contain all needed data so user may distinguish what exactly happened. Or do you think we need to catch it and provide some suitable message in each case?","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"}],"ironic_python_agent/extensions/standby.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        verify, cert \u003d utils.get_ssl_client_options(CONF)"},{"line_number":225,"context_line":"        resp \u003d requests.get(url, stream\u003dTrue, proxies\u003dproxies,"},{"line_number":226,"context_line":"                            verify\u003dverify, cert\u003dcert,"},{"line_number":227,"context_line":"                            timeout\u003dCONF.requests_timeout)"},{"line_number":228,"context_line":"        if resp.status_code !\u003d 200:"},{"line_number":229,"context_line":"            msg \u003d (\u0027Received status code {} from {}, expected 200. Response \u0027"},{"line_number":230,"context_line":"                   \u0027body: {}\u0027).format(resp.status_code, url, resp.text)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_b41709a4","line":227,"updated":"2017-11-13 20:34:27.000000000","message":"if it times out, it looks like requests raises a requests.exceptions.Timeout. Should we catch it and raise eg errors.ImageDownloadError?","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        verify, cert \u003d utils.get_ssl_client_options(CONF)"},{"line_number":225,"context_line":"        resp \u003d requests.get(url, stream\u003dTrue, proxies\u003dproxies,"},{"line_number":226,"context_line":"                            verify\u003dverify, cert\u003dcert,"},{"line_number":227,"context_line":"                            timeout\u003dCONF.requests_timeout)"},{"line_number":228,"context_line":"        if resp.status_code !\u003d 200:"},{"line_number":229,"context_line":"            msg \u003d (\u0027Received status code {} from {}, expected 200. Response \u0027"},{"line_number":230,"context_line":"                   \u0027body: {}\u0027).format(resp.status_code, url, resp.text)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_de982e1c","line":227,"in_reply_to":"1f485f77_b41709a4","updated":"2017-11-15 10:15:56.000000000","message":"Done","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"}],"releasenotes/notes/add-timeout-to-request-2ee45351affc2389.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2b47977a404b2255f054dabc4948d6134a58af09","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":4,"context_line":"    set to 60 sec, to avoid having stuck sessions."},{"line_number":5,"context_line":"    `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4b6375_26d10424","line":5,"updated":"2017-11-07 18:23:32.000000000","message":"If we add a config, is it a fixes or a feature or both?","commit_id":"505d25657a96cec3d0eeec37c0bd78115bb95326"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e4950c57721dd2258dbb2ea9ba90f53b3bc7d291","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Is used in all requests made via requests library."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    set to `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f485f77_88b8852a","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"updated":"2017-11-13 06:50:28.000000000","message":"Should it be \u0027using\u0027?\ns/ \u0027set to\u0027 / \u0027using\u0027 /","commit_id":"527f4f203265752c4404f8d0e7d243d8c304b2e4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bd50f9e4c075d491d0b3ba946ef7f2cd7127bc10","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Is used in all requests made via requests library."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    set to `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f485f77_b3c29284","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"in_reply_to":"1f485f77_88b8852a","updated":"2017-11-13 08:09:03.000000000","message":"Done","commit_id":"527f4f203265752c4404f8d0e7d243d8c304b2e4"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e4950c57721dd2258dbb2ea9ba90f53b3bc7d291","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    set to `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f485f77_4884cd5e","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":5},"updated":"2017-11-13 06:50:28.000000000","message":"See `bug 1730618 ...\u003e`_.","commit_id":"527f4f203265752c4404f8d0e7d243d8c304b2e4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bd50f9e4c075d491d0b3ba946ef7f2cd7127bc10","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    set to `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f485f77_d3c50e90","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":5},"in_reply_to":"1f485f77_4884cd5e","updated":"2017-11-13 08:09:03.000000000","message":"Done","commit_id":"527f4f203265752c4404f8d0e7d243d8c304b2e4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add new config option `requests_timeout` which is 60 sec by default."},{"line_number":4,"context_line":"    Is used in all requests made via requests library."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_b47ca9eb","line":3,"updated":"2017-11-13 20:34:27.000000000","message":"nit s/Add/Adds/\n\nnit s/config option/configuration option/ (no abbreviations if we can avoid it)","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add new config option `requests_timeout` which is 60 sec by default."},{"line_number":4,"context_line":"    Is used in all requests made via requests library."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_beb8d275","line":3,"in_reply_to":"1f485f77_b47ca9eb","updated":"2017-11-15 10:15:56.000000000","message":"Done","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add new config option `requests_timeout` which is 60 sec by default."},{"line_number":4,"context_line":"    Is used in all requests made via requests library."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    using `requests_timeout` config option, which is 60 sec by default,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_f4dfc1d3","line":4,"updated":"2017-11-13 20:34:27.000000000","message":"How about\n\nInstead of waiting indefinitely, HTTP requests will time out if a response is not received after a certain amount of time. The default time out is 60 seconds and is configurable via the new configuration option ``[DEFAULT]/requests_timeout``.","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add new config option `requests_timeout` which is 60 sec by default."},{"line_number":4,"context_line":"    Is used in all requests made via requests library."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    using `requests_timeout` config option, which is 60 sec by default,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_9ebbd670","line":4,"in_reply_to":"1f485f77_f4dfc1d3","updated":"2017-11-15 10:15:56.000000000","message":"Done","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    using `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    See `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_d4f0456a","line":8,"updated":"2017-11-13 20:34:27.000000000","message":"maybe use some of my suggestion above, here...","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    using `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    See `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_7eb25a96","line":8,"in_reply_to":"1f485f77_d4f0456a","updated":"2017-11-15 10:15:56.000000000","message":"Done","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9292b0279b89bde4f47ae60cb3bd07fc6a234268","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    using `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    See `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_74ed118a","line":9,"updated":"2017-11-13 20:34:27.000000000","message":"missing period at the end. Maybe add \u0027for details.\u0027","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"88900a1979e6defdaa16a530b447d69f82c1bce8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Adds timeout to all HTTP requests made via requests library"},{"line_number":7,"context_line":"    using `requests_timeout` config option, which is 60 sec by default,"},{"line_number":8,"context_line":"    to avoid having hang sessions."},{"line_number":9,"context_line":"    See `bug 1730618 \u003chttps://bugs.launchpad.net/ironic/+bug/1730618\u003e`_"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_3eace232","line":9,"in_reply_to":"1f485f77_74ed118a","updated":"2017-11-15 10:15:56.000000000","message":"Done","commit_id":"2eeab2fa7c87c406737018cffd892080ee54a7e5"}]}