)]}'
{"id":"openstack%2Fironic-python-agent~523341","triplet_id":"openstack%2Fironic-python-agent~master~I695aca42b76dfad1b74418c05a48c5cba3b7d71e","project":"openstack/ironic-python-agent","branch":"master","topic":"app.wsgi","hashtags":[],"change_id":"I695aca42b76dfad1b74418c05a48c5cba3b7d71e","subject":"Remove /ironic-python-agent/api/app.wsgi","status":"MERGED","created":"2017-11-28 08:29:29.000000000","updated":"2017-12-19 23:41:11.000000000","submitted":"2017-12-19 23:41:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"523341-1513726871896-82265747","meta_rev_id":"7d38c9d47b25fbeb0493a5c2fc1b708869491251","_number":523341,"virtual_id_number":523341,"owner":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2017-12-14 07:39:33.000000000","_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2017-12-19 23:41:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},{"value":0,"date":"2017-12-14 10:41:30.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"date":"2017-12-15 06:07:30.000000000","_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"all":[{"value":0,"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},{"value":2,"date":"2017-12-19 22:43:20.000000000","_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":2,"date":"2017-12-19 22:34:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2017-12-14 15:18:16.000000000","_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"date":"2017-12-19 15:45:55.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"all":[{"value":0,"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},{"value":1,"date":"2017-12-19 22:43:20.000000000","_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},{"value":0,"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"value":0,"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-14 06:18:07.000000000","updated_by":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"reviewer":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"state":"REVIEWER"},{"updated":"2017-12-14 06:18:07.000000000","updated_by":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"reviewer":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"state":"REVIEWER"},{"updated":"2017-12-14 06:18:07.000000000","updated_by":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"reviewer":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"state":"REVIEWER"},{"updated":"2017-12-14 07:39:33.000000000","updated_by":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"reviewer":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"state":"REVIEWER"},{"updated":"2017-12-14 10:41:30.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-12-14 15:18:16.000000000","updated_by":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"reviewer":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"state":"REVIEWER"},{"updated":"2017-12-19 15:45:55.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2017-12-19 22:34:05.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2017-12-19 22:43:20.000000000","updated_by":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"reviewer":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"state":"REVIEWER"},{"updated":"2017-12-19 23:41:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c8d789d8fb169cb1418eeacb0b19e4775ea980ef","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-11-28 08:29:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b66995254869c1353a1e7055b69fae4b66d1b8d0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-28 08:43:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/41/523341/1/check/openstack-tox-pep8/6b44b41/ : SUCCESS in 2m 28s\n- openstack-tox-py27 http://logs.openstack.org/41/523341/1/check/openstack-tox-py27/08a917e/ : SUCCESS in 2m 21s\n- openstack-tox-py35 http://logs.openstack.org/41/523341/1/check/openstack-tox-py35/c4df5ee/ : SUCCESS in 4m 23s\n- build-openstack-sphinx-docs http://logs.openstack.org/41/523341/1/check/build-openstack-sphinx-docs/cea7741/html/ : SUCCESS in 2m 54s\n- ironic-python-agent-tox-func http://logs.openstack.org/41/523341/1/check/ironic-python-agent-tox-func/661d246/ : SUCCESS in 2m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7694ff6f3baee64e5b3fc2b65ca73e1e6e6d1d39","author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"date":"2017-12-14 06:17:47.000000000","message":"Patch Set 1: Code-Review+1\n\nit should be gotten attention from core-reviewers.","accounts_in_message":[],"_revision_number":1},{"id":"d850ba09338e1d8040f9d5041387ad6ef795a437","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-12-14 07:07:19.000000000","message":"Patch Set 1: Code-Review-2\n\napp.wsgi in an empty file. Why do we need to pep8 it?\n\nWe probably should delete it.","accounts_in_message":[],"_revision_number":1},{"id":"7c3d2896cf44c8129d172db66c001cc3ffba0399","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-12-14 07:10:24.000000000","message":"Patch Set 1:\n\nNam,\n\nI see you added all the core reviewers to this patch.\n\nI\u0027m not sure what others think. But I personally don\u0027t think we should just add all core reviewers to a patch because we want to. Others may disagree with me though. If there is a specific reviewer that a patch is relevant to, then I can see doing that. But just doing a shotgun approach and adding everybody I don\u0027t agree with.","accounts_in_message":[],"_revision_number":1},{"id":"dc6d8784e5e045dbb47d84ac4901a8a31e613ac9","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-12-14 07:28:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3add77961bbcbedae2f04aa0efc47f3f5340cf0f","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-12-14 07:32:30.000000000","message":"Patch Set 2:\n\nHi John L. Villalovos,\nI just want to make sure for whatever changes in the future, it should pass pep8 checks, like [1], [2], [3].\nAnyway, the patch set has just been updated as your recommendation.\nThank you very much.\n[1] https://review.openstack.org/#/c/523333/\n[2] https://review.openstack.org/#/c/523334/\n[3] https://review.openstack.org/#/c/521244/","accounts_in_message":[],"_revision_number":2},{"id":"ae61f6aa9bb891e0b918f6ccc985b9502028dcd1","author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"date":"2017-12-14 07:39:33.000000000","message":"Patch Set 2:\n\n@John L. Villalovos\n\nHi John, I am sorry about that.","accounts_in_message":[],"_revision_number":2},{"id":"0be0b457eb3f9a6daeec9992a77b4d49fd71e18e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-14 09:06:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/41/523341/2/check/openstack-tox-pep8/5513947/ : SUCCESS in 4m 16s\n- openstack-tox-py27 http://logs.openstack.org/41/523341/2/check/openstack-tox-py27/500b6db/ : SUCCESS in 3m 48s\n- openstack-tox-py35 http://logs.openstack.org/41/523341/2/check/openstack-tox-py35/38a110a/ : SUCCESS in 2m 27s\n- build-openstack-sphinx-docs http://logs.openstack.org/41/523341/2/check/build-openstack-sphinx-docs/9c40a2f/html/ : SUCCESS in 3m 47s\n- ipa-tempest-dsvm-partition-bios-agent_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-partition-bios-agent_ipmitool-coreos-src/1a47b24/ : SUCCESS in 57m 45s\n- ipa-tempest-dsvm-partition-bios-agent_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-partition-bios-agent_ipmitool-tinyipa-src/ff05d1b/ : SUCCESS in 44m 22s\n- ipa-tempest-dsvm-partition-bios-pxe_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-partition-bios-pxe_ipmitool-coreos-src/28b139a/ : SUCCESS in 52m 55s\n- ipa-tempest-dsvm-partition-bios-pxe_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-partition-bios-pxe_ipmitool-tinyipa-src/91a8850/ : SUCCESS in 45m 50s\n- ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-coreos-src/c1ba390/ : SUCCESS in 53m 41s\n- ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-tinyipa-src/9051980/ : SUCCESS in 43m 05s\n- ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-coreos-src/ec6da83/ : SUCCESS in 56m 39s\n- ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-tinyipa-src/27e752a/ : SUCCESS in 1h 05m 32s\n- ipa-tempest-dsvm-ironic-inspector-src http://logs.openstack.org/41/523341/2/check/ipa-tempest-dsvm-ironic-inspector-src/f2dbc79/ : SUCCESS in 1h 35m 16s (non-voting)\n- ironic-python-agent-tox-func http://logs.openstack.org/41/523341/2/check/ironic-python-agent-tox-func/14ec97d/ : SUCCESS in 2m 30s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f8ea8ebecfd4649a545383a3ef9142dfe4eb5f1b","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-12-14 10:41:30.000000000","message":"Patch Set 2:\n\n\u003e I personally don\u0027t think we should just add all core reviewers to a patch because we want to\n\n+1","accounts_in_message":[],"_revision_number":2},{"id":"acdc34ba645341e5b27187b33ad6cc5d05f4d21c","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-12-14 15:17:53.000000000","message":"Patch Set 2: -Code-Review","accounts_in_message":[],"_revision_number":2},{"id":"83b3809057bf2c6b6dcf14e9cefee3cabec6d6a9","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-12-14 15:18:16.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a9de458484a06a3609dc0c119d58e207673d7c1e","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-12-14 16:05:55.000000000","message":"Patch Set 2:\n\nHi\n\n\u003e I just want to make sure for whatever changes in the future, it should\n\u003e pass pep8 checks\n\nEVERYONE that submits a patch, needs cores to actually approve and get the patch merged. This isn\u0027t any different from the other patches that are submitted; please do not explicitly add the cores as reviewers.","accounts_in_message":[],"_revision_number":2},{"id":"8fbdf4262d1ac642ddc31bd109bc108da0e949d6","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-12-14 16:15:15.000000000","message":"Patch Set 2: Code-Review-1\n\nHi,\n\n\u003e I just want to make sure for whatever changes in the future, it should\n\u003e pass pep8 checks\n\nI actually had a question about this wsgi stuff in [1] and I didn\u0027t get an answer. Maybe no one saw my comment. I\u0027m -1\u0027ing this cuz I\u0027m curious still and would like an answer, even though this patch isn\u0027t doing that any more.\n\npep8 works on our python files even though we didn\u0027t explicitly specify those files. However, we do have a list of files to exclude. HOW do you know that .wsgi was not being pep8\u0027d? It seems odd to me to have both a \u0027exclude \u003d\u0027 and a \u0027filename \u003d \u0027...\n\n[1] https://review.openstack.org/#/c/523337/","accounts_in_message":[],"_revision_number":2},{"id":"a7abe0a82d25ba8dece7a2e25feb3a9cbbbc63cb","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-12-15 03:56:23.000000000","message":"Patch Set 2:\n\nHi Ruby,\nHave a nice day.\nSorry because I missed the email notification for your question.\nUnfortunately, I don\u0027t have the answer, either.\nHOW do I know that .wsgi was not being pep8\u0027d?\n\u003d\u003e Well, I just tried to edit that file in a way which violates pep8 on purpose and noticed that all the tests for pep8 still passed.\nAfter adding filename in tox, pep8 tests failed as expected.\nHopefully we could have the answer from someone, maybe other core reviewers.","accounts_in_message":[],"_revision_number":2},{"id":"02e1b309a37e4810c1adc68e7576998ff3fe0a37","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-12-15 05:31:26.000000000","message":"Patch Set 2:\n\n\u003e Hi,\n \u003e \n \u003e \u003e I just want to make sure for whatever changes in the future, it\n \u003e should\n \u003e \u003e pass pep8 checks\n \u003e \n \u003e I actually had a question about this wsgi stuff in [1] and I didn\u0027t\n \u003e get an answer. Maybe no one saw my comment. I\u0027m -1\u0027ing this cuz I\u0027m\n \u003e curious still and would like an answer, even though this patch\n \u003e isn\u0027t doing that any more.\n \u003e \n \u003e pep8 works on our python files even though we didn\u0027t explicitly\n \u003e specify those files. However, we do have a list of files to\n \u003e exclude. HOW do you know that .wsgi was not being pep8\u0027d? It seems\n \u003e odd to me to have both a \u0027exclude \u003d\u0027 and a \u0027filename \u003d \u0027...\n \u003e \n \u003e [1] https://review.openstack.org/#/c/523337/\n\nIt is because of \u0027flake8\u0027\n\nhttp://flake8.pycqa.org/en/latest/user/options.html\n\nLook for \u0027--filename\u0027\n\nDefault is \u0027*.py\u0027","accounts_in_message":[],"_revision_number":2},{"id":"1fcb2f8f5d94edde51c621649fcaa2be2ca903db","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-12-15 06:07:30.000000000","message":"Patch Set 2:\n\nHi John L. Villalovos,\nThanks a lot for your explanation :)","accounts_in_message":[],"_revision_number":2},{"id":"f1d896c23f07f90390d693406c509d5c1133c179","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2017-12-19 15:45:55.000000000","message":"Patch Set 2: -Code-Review\n\nThanks John, for explaining.","accounts_in_message":[],"_revision_number":2},{"id":"2bd20a92b42a5b085fb44ad915740efcaaf98b6f","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2017-12-19 22:34:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2ae0d2aca6cf7ff2ea7f26333042baeba284ef26","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2017-12-19 22:35:27.000000000","message":"Patch Set 2:\n\nIPA is intended to be an embedded service, and as such I feel we shouldn\u0027t have this file presentl.","accounts_in_message":[],"_revision_number":2},{"id":"f23c4dde0877bf446b1541fa26004a2de9a1db7c","author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"date":"2017-12-19 22:43:20.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ea5bd701fbbb5a438fcfb05658a1be31d53af0bb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-19 22:43:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"87cf561025a3d2e87004bd4cd373528e9fbe3a4a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-19 23:41:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/41/523341/2/gate/openstack-tox-pep8/957ab98/ : SUCCESS in 2m 44s\n- openstack-tox-py27 http://logs.openstack.org/41/523341/2/gate/openstack-tox-py27/f9c9993/ : SUCCESS in 2m 51s\n- openstack-tox-py35 http://logs.openstack.org/41/523341/2/gate/openstack-tox-py35/c1dfdff/ : SUCCESS in 4m 10s\n- build-openstack-sphinx-docs http://logs.openstack.org/41/523341/2/gate/build-openstack-sphinx-docs/5236737/html/ : SUCCESS in 3m 18s\n- ipa-tempest-dsvm-partition-bios-agent_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-partition-bios-agent_ipmitool-coreos-src/82a9fb2/ : SUCCESS in 50m 25s\n- ipa-tempest-dsvm-partition-bios-agent_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-partition-bios-agent_ipmitool-tinyipa-src/27a48ae/ : SUCCESS in 47m 24s\n- ipa-tempest-dsvm-partition-bios-pxe_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-partition-bios-pxe_ipmitool-coreos-src/e7ea552/ : SUCCESS in 49m 33s\n- ipa-tempest-dsvm-partition-bios-pxe_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-partition-bios-pxe_ipmitool-tinyipa-src/763f282/ : SUCCESS in 44m 22s\n- ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-coreos-src/5fb6095/ : SUCCESS in 49m 50s\n- ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-tinyipa-src/fd7fd23/ : SUCCESS in 44m 06s\n- ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-coreos-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-coreos-src/44a7199/ : SUCCESS in 48m 50s\n- ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-tinyipa-src http://logs.openstack.org/41/523341/2/gate/ipa-tempest-dsvm-wholedisk-bios-pxe_ipmitool-tinyipa-src/902b8d1/ : SUCCESS in 43m 42s","accounts_in_message":[],"_revision_number":2},{"id":"c09e6d29792e3c22b7d704174b2e32d12dd521cb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-19 23:41:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e6033e733ee700978c0f40a47b464ac7129f5a36","revisions":{"a184af9e1e7a77cae9398d147a8ecced8fde3e3a":{"kind":"REWORK","_number":1,"created":"2017-11-28 08:29:29.000000000","uploader":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"ref":"refs/changes/41/523341/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/41/523341/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/1"}}},"commit":{"parents":[{"commit":"831576c906c74519babb2751a19673e30736a9af","subject":"Merge \"Ignore IPv6 link local addresses\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/831576c906c74519babb2751a19673e30736a9af"}]}],"author":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-28 08:29:36.000000000","tz":420},"committer":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-28 08:29:36.000000000","tz":420},"subject":"Apply pep8 check to app.wsgi","message":"Apply pep8 check to app.wsgi\n\nBecause app.wsgi should meet pep8 standards,\nthis patch apply pep8 check to app.wsgi.\n\nChange-Id: I695aca42b76dfad1b74418c05a48c5cba3b7d71e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a184af9e1e7a77cae9398d147a8ecced8fde3e3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/a184af9e1e7a77cae9398d147a8ecced8fde3e3a"}]},"branch":"refs/heads/master"},"e6033e733ee700978c0f40a47b464ac7129f5a36":{"kind":"REWORK","_number":2,"created":"2017-12-14 07:28:20.000000000","uploader":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"ref":"refs/changes/41/523341/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/41/523341/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/41/523341/2"}}},"commit":{"parents":[{"commit":"e55d68f11efdc51595822981a3391ee5337dce79","subject":"Merge \"Include IPA Version during heartbeat\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e55d68f11efdc51595822981a3391ee5337dce79"}]}],"author":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-28 08:29:36.000000000","tz":420},"committer":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-12-14 07:20:14.000000000","tz":420},"subject":"Remove /ironic-python-agent/api/app.wsgi","message":"Remove /ironic-python-agent/api/app.wsgi\n\n/ironic-python-agent/api/app.wsgi is an empty file.\nAs suggestion from John L. Villalovos, we probably should delete it.\n\nChange-Id: I695aca42b76dfad1b74418c05a48c5cba3b7d71e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e6033e733ee700978c0f40a47b464ac7129f5a36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/e6033e733ee700978c0f40a47b464ac7129f5a36"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}