)]}'
{"id":"openstack%2Fironic-python-agent~524312","triplet_id":"openstack%2Fironic-python-agent~master~Ia116b355e7adb3cbfb8ae34f4d59bf527f2889bb","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"Ia116b355e7adb3cbfb8ae34f4d59bf527f2889bb","subject":"Fix issue with double mocking of utils.execute functions","status":"MERGED","created":"2017-11-30 18:36:59.000000000","updated":"2017-12-08 22:19:06.000000000","submitted":"2017-12-08 22:19:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"524312-1512771546538-b5c247cf","meta_rev_id":"b9d83e251a2688b3bef053bf79acb43ba6dbe37d","_number":524312,"virtual_id_number":524312,"owner":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2017-12-08 22:19:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2017-12-08 22:06:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-12-08 16:20:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2017-12-08 22:06:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-08 16:20:29.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-12-08 22:06:11.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2017-12-08 22:19:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"49b7ead07e592292bfc074af95f8fd62218109e4","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-11-30 18:36:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b2daaecb9dd4852d5a85ad3535d53a1be99b4102","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-30 18:43:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/12/524312/1/check/openstack-tox-pep8/13471e9/ : FAILURE in 2m 30s\n- openstack-tox-py27 http://logs.openstack.org/12/524312/1/check/openstack-tox-py27/659f7de/ : SUCCESS in 2m 37s\n- openstack-tox-py35 http://logs.openstack.org/12/524312/1/check/openstack-tox-py35/113df06/ : SUCCESS in 4m 43s\n- build-openstack-sphinx-docs http://logs.openstack.org/12/524312/1/check/build-openstack-sphinx-docs/b4d5fd1/html/ : SUCCESS in 4m 15s\n- ironic-python-agent-tox-func http://logs.openstack.org/12/524312/1/check/ironic-python-agent-tox-func/aa969e2/ : SUCCESS in 4m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a8136b211c5ed57334c0f958c8e8b310e7a95beb","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-11-30 18:52:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"305cfc01336506566bc43d817ff7cbe99557a844","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-30 19:06:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/12/524312/2/check/openstack-tox-pep8/e5aea18/ : SUCCESS in 2m 40s\n- openstack-tox-py27 http://logs.openstack.org/12/524312/2/check/openstack-tox-py27/01f1af7/ : SUCCESS in 3m 30s\n- openstack-tox-py35 http://logs.openstack.org/12/524312/2/check/openstack-tox-py35/f5a8b22/ : SUCCESS in 2m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/12/524312/2/check/build-openstack-sphinx-docs/5582059/html/ : SUCCESS in 2m 59s\n- ironic-python-agent-tox-func http://logs.openstack.org/12/524312/2/check/ironic-python-agent-tox-func/355003a/ : SUCCESS in 4m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e3d7563283d18e1539f7a3f5453720bc2f0882e7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-12-01 09:27:56.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c4fd82a9af4a71f33b490e9861e4ecc6bc9efe2f","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2017-12-01 15:42:57.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"29f699779bf1dc9ff4b4e781fd109f7a9b4e75cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-01 15:52:21.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/12/524312/3/check/openstack-tox-pep8/8c48fa8/ : SUCCESS in 2m 22s\n- openstack-tox-py27 http://logs.openstack.org/12/524312/3/check/openstack-tox-py27/1a9bea9/ : SUCCESS in 3m 31s\n- openstack-tox-py35 http://logs.openstack.org/12/524312/3/check/openstack-tox-py35/bd7e339/ : SUCCESS in 2m 51s\n- build-openstack-sphinx-docs http://logs.openstack.org/12/524312/3/check/build-openstack-sphinx-docs/4f00b45/html/ : SUCCESS in 4m 06s\n- ironic-python-agent-tox-func http://logs.openstack.org/12/524312/3/check/ironic-python-agent-tox-func/2d35857/ : SUCCESS in 2m 41s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"c7e25ebae4e76e8abfb87be2c4a0f79fd13966bc","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-12-08 16:20:29.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"025b3787f09971c0a51829f5677fd8c44fe34eeb","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2017-12-08 22:06:11.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"30098863d798575a072730b231f790da00998957","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-08 22:06:23.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"64c5ea82d9924806c0bd21d045e7a469eebf1e8f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-08 22:19:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"b9d83e251a2688b3bef053bf79acb43ba6dbe37d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-08 22:19:06.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/12/524312/3/gate/openstack-tox-pep8/c01af06/ : SUCCESS in 3m 12s\n- openstack-tox-py27 http://logs.openstack.org/12/524312/3/gate/openstack-tox-py27/4bb008c/ : SUCCESS in 3m 53s\n- openstack-tox-py35 http://logs.openstack.org/12/524312/3/gate/openstack-tox-py35/2597343/ : SUCCESS in 3m 47s\n- build-openstack-sphinx-docs http://logs.openstack.org/12/524312/3/gate/build-openstack-sphinx-docs/d76f405/html/ : SUCCESS in 4m 53s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"fc3de874693edb8205b4fc14a60b55e140434d94","revisions":{"854e138104bf86a25f6b58d7d53bcae1b5c7fe4c":{"kind":"REWORK","_number":1,"created":"2017-11-30 18:36:59.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/12/524312/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/12/524312/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/1"}}},"commit":{"parents":[{"commit":"831576c906c74519babb2751a19673e30736a9af","subject":"Merge \"Ignore IPv6 link local addresses\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/831576c906c74519babb2751a19673e30736a9af"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-11-30 18:16:51.000000000","tz":-480},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-11-30 18:34:20.000000000","tz":-480},"subject":"Fix issue with double mocking of utils.execute functions","message":"Fix issue with double mocking of utils.execute functions\n\nAn issue was discovered if we mock an already mock-ed function. This\nwas happening in our execute() detection code. Change it to not use a\nmock and instead a function.\n\nChange-Id: Ia116b355e7adb3cbfb8ae34f4d59bf527f2889bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/854e138104bf86a25f6b58d7d53bcae1b5c7fe4c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/854e138104bf86a25f6b58d7d53bcae1b5c7fe4c"}]},"branch":"refs/heads/master"},"182e67c939c326ae807af325a119d3d1397e2e90":{"kind":"REWORK","_number":2,"created":"2017-11-30 18:52:59.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/12/524312/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/12/524312/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/2"}}},"commit":{"parents":[{"commit":"831576c906c74519babb2751a19673e30736a9af","subject":"Merge \"Ignore IPv6 link local addresses\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/831576c906c74519babb2751a19673e30736a9af"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-11-30 18:16:51.000000000","tz":-480},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-11-30 18:50:23.000000000","tz":-480},"subject":"Fix issue with double mocking of utils.execute functions","message":"Fix issue with double mocking of utils.execute functions\n\nAn issue was discovered if we mock an already mock-ed function. This\nwas happening in our execute() detection code. Change it to not use a\nmock and instead a function.\n\nChange-Id: Ia116b355e7adb3cbfb8ae34f4d59bf527f2889bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/182e67c939c326ae807af325a119d3d1397e2e90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/182e67c939c326ae807af325a119d3d1397e2e90"}]},"branch":"refs/heads/master"},"fc3de874693edb8205b4fc14a60b55e140434d94":{"kind":"REWORK","_number":3,"created":"2017-12-01 15:42:57.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/12/524312/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/12/524312/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/12/524312/3"}}},"commit":{"parents":[{"commit":"831576c906c74519babb2751a19673e30736a9af","subject":"Merge \"Ignore IPv6 link local addresses\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/831576c906c74519babb2751a19673e30736a9af"}]}],"author":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-11-30 18:16:51.000000000","tz":-480},"committer":{"name":"John L. Villalovos","email":"john.l.villalovos@intel.com","date":"2017-12-01 15:42:02.000000000","tz":-480},"subject":"Fix issue with double mocking of utils.execute functions","message":"Fix issue with double mocking of utils.execute functions\n\nAn issue was discovered if we mock an already mock-ed function. This\nwas happening in our execute() detection code. Change it to not use a\nmock and instead a function.\n\nAdd unit tests to show it works as intended.\n\nChange-Id: Ia116b355e7adb3cbfb8ae34f4d59bf527f2889bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fc3de874693edb8205b4fc14a60b55e140434d94"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/fc3de874693edb8205b4fc14a60b55e140434d94"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}