)]}'
{"id":"openstack%2Fironic-python-agent~560562","triplet_id":"openstack%2Fironic-python-agent~master~I1025f21a57837e97280f82baba50fdd823a190cc","project":"openstack/ironic-python-agent","branch":"master","hashtags":[],"change_id":"I1025f21a57837e97280f82baba50fdd823a190cc","subject":"flake8: Add W503 to ignore list as invalid","status":"MERGED","created":"2018-04-11 16:35:38.000000000","updated":"2018-05-28 08:36:07.000000000","submitted":"2018-04-11 18:47:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"560562-1523472452592-90740a10","meta_rev_id":"afadb38b5883e0f33a425586af069db484a69782","_number":560562,"virtual_id_number":560562,"owner":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":2,"date":"2018-04-11 18:47:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":2,"date":"2018-04-11 16:37:47.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":2,"date":"2018-04-11 17:24:37.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"all":[{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":1,"date":"2018-04-11 17:24:37.000000000","_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-04-11 16:37:47.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2018-04-11 17:24:37.000000000","updated_by":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"reviewer":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"state":"REVIEWER"},{"updated":"2018-04-11 18:47:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a7eab775be167c70d10e5305a2d336b28a3ae128","author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"date":"2018-04-11 16:35:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a384998d1b81a1641d9339f916e3854f5cbde2d7","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2018-04-11 16:37:47.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a413adb309849a9fe5e30712854d728e345ea3bf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-11 17:14:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/62/560562/1/check/openstack-tox-pep8/3c0b624/ : SUCCESS in 3m 31s\n- openstack-tox-py27 http://logs.openstack.org/62/560562/1/check/openstack-tox-py27/12c94b1/ : SUCCESS in 3m 54s\n- openstack-tox-py35 http://logs.openstack.org/62/560562/1/check/openstack-tox-py35/bbbeb9c/ : SUCCESS in 4m 07s\n- build-openstack-sphinx-docs http://logs.openstack.org/62/560562/1/check/build-openstack-sphinx-docs/946d4c0/html/ : SUCCESS in 3m 25s\n- openstack-tox-functional http://logs.openstack.org/62/560562/1/check/openstack-tox-functional/f4858e1/ : SUCCESS in 3m 40s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/62/560562/1/check/openstack-tox-lower-constraints/56abbfa/ : SUCCESS in 3m 14s","accounts_in_message":[],"_revision_number":1},{"id":"33b575bbc096b6443b6b176206cbf2599ade97e9","author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"date":"2018-04-11 17:24:37.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"22aea69381d005fd276bc920f078b91e256a04e4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-11 17:28:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fdef64bc9761b04c56b7ba3beda35bf2e1b861f9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-11 18:47:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/62/560562/1/gate/openstack-tox-pep8/0d4e01d/ : SUCCESS in 3m 05s\n- openstack-tox-py27 http://logs.openstack.org/62/560562/1/gate/openstack-tox-py27/66b2e46/ : SUCCESS in 3m 47s\n- openstack-tox-py35 http://logs.openstack.org/62/560562/1/gate/openstack-tox-py35/2f307a4/ : SUCCESS in 3m 15s\n- build-openstack-sphinx-docs http://logs.openstack.org/62/560562/1/gate/build-openstack-sphinx-docs/1e65803/html/ : SUCCESS in 3m 57s\n- openstack-tox-lower-constraints http://logs.openstack.org/62/560562/1/gate/openstack-tox-lower-constraints/d9b3e32/ : SUCCESS in 3m 07s","accounts_in_message":[],"_revision_number":1},{"id":"4e6043b8adb2c0d0ead1294abdd1ebcd0aee8288","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-11 18:47:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"afadb38b5883e0f33a425586af069db484a69782","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2018-05-28 08:36:07.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit 4edda4842392abebc0531f79e838047c6b97be16","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c09634ad80988e960af2bcaca737be3e87ba7592","revisions":{"c09634ad80988e960af2bcaca737be3e87ba7592":{"kind":"REWORK","_number":1,"created":"2018-04-11 16:35:38.000000000","uploader":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"ref":"refs/changes/62/560562/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ironic-python-agent","ref":"refs/changes/62/560562/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/560562/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/560562/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/560562/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ironic-python-agent refs/changes/62/560562/1"}}},"commit":{"parents":[{"commit":"ae0544cc1a119de5548c429d095fae4add55de34","subject":"Merge \"GenericHardwareManager: get mac address using netifaces\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/ae0544cc1a119de5548c429d095fae4add55de34"}]}],"author":{"name":"John L. Villalovos","email":"openstack.org@sodarock.com","date":"2018-04-11 16:33:45.000000000","tz":-420},"committer":{"name":"John L. Villalovos","email":"openstack.org@sodarock.com","date":"2018-04-11 16:33:45.000000000","tz":-420},"subject":"flake8: Add W503 to ignore list as invalid","message":"flake8: Add W503 to ignore list as invalid\n\nW503 according to the [1] pycodestyle docs is not supposed to be\nenabled. But it is.\n\nW503 is something we will likely never enable as it is a personal\nstyle decision and can change depending on the code. There is no one\nright answer. Interestingly there is also a W504 which is the opposite\ncheck.\n\n[1] http://pycodestyle.pycqa.org/en/latest/intro.html#error-codes\n\nChange-Id: I1025f21a57837e97280f82baba50fdd823a190cc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c09634ad80988e960af2bcaca737be3e87ba7592"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ironic-python-agent/commit/c09634ad80988e960af2bcaca737be3e87ba7592"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}