)]}'
{"imagebuild/coreos/full_trusty_build.sh":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"73d5152a17f7f10ee4ed9b993bdc3f604e08d924","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    # https://github.com/docker/docker/issues/9745"},{"line_number":15,"context_line":"    # netbase is required as it carries things like /etc/protocols"},{"line_number":16,"context_line":"    # which python sockets requires."},{"line_number":17,"context_line":"    sudo -E apt-get install -y docker.io apparmor cgroup-lite netbase"},{"line_number":18,"context_line":"elif [ -x \"/usr/bin/dnf\" ]; then"},{"line_number":19,"context_line":"    sudo -E dnf install -y $REDHAT_PACKAGES"},{"line_number":20,"context_line":"elif [ -x \"/usr/bin/yum\" ]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"5f7c97a3_124d7899","line":17,"updated":"2018-05-09 15:49:13.000000000","message":"We don\u0027t need netbase on the system building the ramdisk, do we? Just in the ramdisk image itself?","commit_id":"13287be2933bad63bd1411b7b6c9f072e6c5f55a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d18b740b801f4ffa67c165b70cad988a823cc290","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    # https://github.com/docker/docker/issues/9745"},{"line_number":15,"context_line":"    # netbase is required as it carries things like /etc/protocols"},{"line_number":16,"context_line":"    # which python sockets requires."},{"line_number":17,"context_line":"    sudo -E apt-get install -y docker.io apparmor cgroup-lite netbase"},{"line_number":18,"context_line":"elif [ -x \"/usr/bin/dnf\" ]; then"},{"line_number":19,"context_line":"    sudo -E dnf install -y $REDHAT_PACKAGES"},{"line_number":20,"context_line":"elif [ -x \"/usr/bin/yum\" ]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"5f7c97a3_f581c64b","line":17,"in_reply_to":"5f7c97a3_124d7899","updated":"2018-05-09 15:56:52.000000000","message":"No, I guess in one of the rebases I lost the removal  of it.","commit_id":"13287be2933bad63bd1411b7b6c9f072e6c5f55a"}],"ironic_python_agent/config.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"73d5152a17f7f10ee4ed9b993bdc3f604e08d924","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027api_url\u0027,"},{"line_number":27,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-api-url\u0027),"},{"line_number":28,"context_line":"               deprecated_name\u003d\u0027api-url\u0027,"},{"line_number":29,"context_line":"               regex\u003d\u0027^http(s?):\\\\/\\\\/.+\u0027,"},{"line_number":30,"context_line":"               help\u003d\u0027URL of the Ironic API. \u0027"},{"line_number":31,"context_line":"                    \u0027Can be supplied as \"ipa-api-url\" kernel parameter.\u0027"},{"line_number":32,"context_line":"                    \u0027The value must start with either http:// or https://.\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_525a104f","line":29,"updated":"2018-05-09 15:49:13.000000000","message":"Where did this come from? Seems correct, but unrelated, and I wonder how things work today.","commit_id":"13287be2933bad63bd1411b7b6c9f072e6c5f55a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3829fcd7ac9cc384f9f82fdf9397760985d6cb18","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027api_url\u0027,"},{"line_number":27,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-api-url\u0027),"},{"line_number":28,"context_line":"               deprecated_name\u003d\u0027api-url\u0027,"},{"line_number":29,"context_line":"               regex\u003d\u0027^http(s?):\\\\/\\\\/.+\u0027,"},{"line_number":30,"context_line":"               help\u003d\u0027URL of the Ironic API. \u0027"},{"line_number":31,"context_line":"                    \u0027Can be supplied as \"ipa-api-url\" kernel parameter.\u0027"},{"line_number":32,"context_line":"                    \u0027The value must start with either http:// or https://.\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_d5228aa4","line":29,"in_reply_to":"5f7c97a3_525a104f","updated":"2018-05-09 15:50:48.000000000","message":"\u0027\\/\u0027 is not quite correct, it\u0027s an invalid escape sequence, but happens to work. it has to be r\u0027\\/\u0027 or \u0027\\\\/\u0027","commit_id":"13287be2933bad63bd1411b7b6c9f072e6c5f55a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d18b740b801f4ffa67c165b70cad988a823cc290","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027api_url\u0027,"},{"line_number":27,"context_line":"               default\u003dAPARAMS.get(\u0027ipa-api-url\u0027),"},{"line_number":28,"context_line":"               deprecated_name\u003d\u0027api-url\u0027,"},{"line_number":29,"context_line":"               regex\u003d\u0027^http(s?):\\\\/\\\\/.+\u0027,"},{"line_number":30,"context_line":"               help\u003d\u0027URL of the Ironic API. \u0027"},{"line_number":31,"context_line":"                    \u0027Can be supplied as \"ipa-api-url\" kernel parameter.\u0027"},{"line_number":32,"context_line":"                    \u0027The value must start with either http:// or https://.\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_55e75a41","line":29,"in_reply_to":"5f7c97a3_d5228aa4","updated":"2018-05-09 15:56:52.000000000","message":"What dmitry said :)","commit_id":"13287be2933bad63bd1411b7b6c9f072e6c5f55a"}],"playbooks/legacy/ipa-tempest-dsvm-partition-bios-agent_ipmitool-coreos-src/run.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"73d5152a17f7f10ee4ed9b993bdc3f604e08d924","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - shell:"},{"line_number":28,"context_line":"        cmd: |"},{"line_number":29,"context_line":"          cat \u003c\u003c \u0027EOF\u0027 \u003e\u003e ironic-extra-vars"},{"line_number":30,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2048\""},{"line_number":31,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_RAMDISK_TYPE\u003dcoreos\""},{"line_number":32,"context_line":"          EOF"},{"line_number":33,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5f7c97a3_722aac90","line":30,"updated":"2018-05-09 15:49:13.000000000","message":"I feel like we\u0027re going to need this change in ironic before we land this patch, or we\u0027ll break the ironic gate once the image build is published.","commit_id":"13287be2933bad63bd1411b7b6c9f072e6c5f55a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3829fcd7ac9cc384f9f82fdf9397760985d6cb18","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - shell:"},{"line_number":28,"context_line":"        cmd: |"},{"line_number":29,"context_line":"          cat \u003c\u003c \u0027EOF\u0027 \u003e\u003e ironic-extra-vars"},{"line_number":30,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2048\""},{"line_number":31,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_RAMDISK_TYPE\u003dcoreos\""},{"line_number":32,"context_line":"          EOF"},{"line_number":33,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5f7c97a3_b537cee3","line":30,"in_reply_to":"5f7c97a3_722aac90","updated":"2018-05-09 15:50:48.000000000","message":"coreos builds are not used in the ironic ci","commit_id":"13287be2933bad63bd1411b7b6c9f072e6c5f55a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"603f9dd22ad3e422fb7cc284f2e4052696186d9e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          cat \u003c\u003c \u0027EOF\u0027 \u003e\u003e ironic-extra-vars"},{"line_number":30,"context_line":"            export DEVSTACK_GATE_OS_TEST_TIMEOUT\u003d2400"},{"line_number":31,"context_line":"            export DEVSTACK_GATE_TEMPEST_BAREMETAL_BUILD_TIMEOUT\u003d1200"},{"line_number":32,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_CPU\u003d2\""},{"line_number":33,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2048\""},{"line_number":34,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_RAMDISK_TYPE\u003dcoreos\""},{"line_number":35,"context_line":"          EOF"},{"line_number":36,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_66b64141","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":73},"updated":"2018-05-11 10:26:59.000000000","message":"OMG, this really approaches a CentOS-based DIB build..","commit_id":"3164053f08c4cd40f9634d7ef9e06e4be9565cc5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"854d9ebb5352ee0cb8e71b0cd0b380affe236a37","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          cat \u003c\u003c \u0027EOF\u0027 \u003e\u003e ironic-extra-vars"},{"line_number":30,"context_line":"            export DEVSTACK_GATE_OS_TEST_TIMEOUT\u003d2400"},{"line_number":31,"context_line":"            export DEVSTACK_GATE_TEMPEST_BAREMETAL_BUILD_TIMEOUT\u003d1200"},{"line_number":32,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_CPU\u003d2\""},{"line_number":33,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2048\""},{"line_number":34,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_RAMDISK_TYPE\u003dcoreos\""},{"line_number":35,"context_line":"          EOF"},{"line_number":36,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_4cd323d6","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":73},"in_reply_to":"5f7c97a3_66b64141","updated":"2018-05-11 14:14:42.000000000","message":"Indeed :(","commit_id":"3164053f08c4cd40f9634d7ef9e06e4be9565cc5"}],"playbooks/legacy/ipa-tempest-dsvm-partition-bios-pxe_ipmitool-coreos-src/run.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0d1af5a9abfe53b39c7886cb5df714484befec35","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - shell:"},{"line_number":28,"context_line":"        cmd: |"},{"line_number":29,"context_line":"          cat \u003c\u003c \u0027EOF\u0027 \u003e\u003e ironic-extra-vars"},{"line_number":30,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2048\""},{"line_number":31,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_RAMDISK_TYPE\u003dcoreos\""},{"line_number":32,"context_line":"          EOF"},{"line_number":33,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_96e1b89d","line":30,"updated":"2018-05-07 08:56:12.000000000","message":"OH. Now we have parity with the DIB-built image :( Time to switch?","commit_id":"ec1c083b07a32e38fa774fcf2dfc83cd2b540bb2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"22e2f4cc296267db0a5672cd217cf38882365b15","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - shell:"},{"line_number":28,"context_line":"        cmd: |"},{"line_number":29,"context_line":"          cat \u003c\u003c \u0027EOF\u0027 \u003e\u003e ironic-extra-vars"},{"line_number":30,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2048\""},{"line_number":31,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_RAMDISK_TYPE\u003dcoreos\""},{"line_number":32,"context_line":"          EOF"},{"line_number":33,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_061491f4","line":30,"in_reply_to":"5f7c97a3_96e1b89d","updated":"2018-05-07 13:29:34.000000000","message":"Likely :\\ But this kind of works and is also a verified toolchain since the keys get stored/tracked. :\\\n\nI still need to figure out why coreos doesn\u0027t know what tcp is... I know i\u0027ve seen that error too...","commit_id":"ec1c083b07a32e38fa774fcf2dfc83cd2b540bb2"}],"playbooks/legacy/ipa-tempest-dsvm-wholedisk-bios-agent_ipmitool-coreos-src/run.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b297dc28ef849d4befa952aad93ccb040611e626","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - shell:"},{"line_number":28,"context_line":"        cmd: |"},{"line_number":29,"context_line":"          cat \u003c\u003c \u0027EOF\u0027 \u003e\u003e ironic-extra-vars"},{"line_number":30,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2\""},{"line_number":31,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_VM_SPECS_RAM\u003d2048\""},{"line_number":32,"context_line":"            export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"IRONIC_RAMDISK_TYPE\u003dcoreos\""},{"line_number":33,"context_line":"          EOF"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"5f7c97a3_3c91474f","line":30,"updated":"2018-05-10 20:44:39.000000000","message":"s/RAM/CPU :)","commit_id":"8cf8b8ed6ca5dafb7a353267f97f1bc672847f85"}]}